)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"560ac3db94a049c0b2212708d7b3514ecc40f5b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-17 18:21:01 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes tests so that it passes when run in a macbook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5afc83afd2aa2d7c0dbe98b545fe1b9f90308429"},{"line_number":10,"context_line":"Closes-Bug: #1309256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAXH%2F%2FsIY%3D","line":7,"updated":"2014-04-18 07:43:00.000000000","message":"Fixes tests so that it passes when run on OS X","commit_id":"a39597b0722c1fdcfd0e4e851c2152b2bf023f1e"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"da48627d52a042987ad13c42ce6da72f94dd89b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-17 18:21:01 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes tests so that it passes when run in a macbook"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5afc83afd2aa2d7c0dbe98b545fe1b9f90308429"},{"line_number":10,"context_line":"Closes-Bug: #1309256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAXH%2F%2FobU%3D","line":7,"in_reply_to":"AAAAXH%2F%2FsIY%3D","updated":"2014-04-18 17:17:52.000000000","message":"Yeah that is a little more correct.","commit_id":"a39597b0722c1fdcfd0e4e851c2152b2bf023f1e"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"592aa4469a7797ae0d8e46c5ecb3037026253c53","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-22 08:09:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes tests so that they pass when run on OS X"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5afc83afd2aa2d7c0dbe98b545fe1b9f90308429"},{"line_number":10,"context_line":"Closes-Bug: #1309256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAXH%2F%2FR4M%3D","line":7,"updated":"2014-04-22 19:34:32.000000000","message":"commit message body doesn\u0027t describes what this patch actually changing","commit_id":"af5e6499913aba4dde81f45a16ef4c6cc1fe58d0"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"068d33c90c4083fa07668895b346b0cfbdce75af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-22 08:09:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes tests so that they pass when run on OS X"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5afc83afd2aa2d7c0dbe98b545fe1b9f90308429"},{"line_number":10,"context_line":"Closes-Bug: #1309256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAXH%2F%2FJT0%3D","line":7,"in_reply_to":"AAAAXH%2F%2FQb8%3D","updated":"2014-04-23 17:46:17.000000000","message":"yeah I think it\u0027s pretty clear.","commit_id":"af5e6499913aba4dde81f45a16ef4c6cc1fe58d0"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"daf682ddf8099d5d8f1aaa57bae1ae4405e83f7d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-22 08:09:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes tests so that they pass when run on OS X"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5afc83afd2aa2d7c0dbe98b545fe1b9f90308429"},{"line_number":10,"context_line":"Closes-Bug: #1309256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAXH%2F%2FRpM%3D","line":7,"in_reply_to":"AAAAXH%2F%2FR4M%3D","updated":"2014-04-22 20:01:34.000000000","message":"commit message should contain straight answer why is it being done?\n\nRequired sections:\n\n1. Reasons:\n2. Chagens:","commit_id":"af5e6499913aba4dde81f45a16ef4c6cc1fe58d0"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"36cf5e3f177a97d5a3a1d55e5aff7256a3b7bebb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-22 08:09:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes tests so that they pass when run on OS X"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5afc83afd2aa2d7c0dbe98b545fe1b9f90308429"},{"line_number":10,"context_line":"Closes-Bug: #1309256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAXH%2F%2FQb8%3D","line":7,"in_reply_to":"AAAAXH%2F%2FRpM%3D","updated":"2014-04-22 23:49:27.000000000","message":"Deniz i think from the commit message, it is clear what i am trying to do. If the commit message wasnt clear enough, you can see the bug details.\n\nAs per your comment.\n1- Reasons: Make the tests pass in OS X\n2- Changes: Look at the diff.\n\nI am not sure what else is needed.","commit_id":"af5e6499913aba4dde81f45a16ef4c6cc1fe58d0"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"fabfbe1a331858fdb2918dc3aeee42f0e626c921","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   - Mock operating_system.get_ip_address() to return a dummy IP"},{"line_number":17,"context_line":"     so that it does not uses the UNIX internals sockets"},{"line_number":18,"context_line":"   - Mock the file.open so that it returns instead of looking and"},{"line_number":19,"context_line":"     opening /etc/fstab"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I5afc83afd2aa2d7c0dbe98b545fe1b9f90308429"},{"line_number":22,"context_line":"Closes-Bug: #1309256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAXX%2F%2F%2FeY%3D","line":19,"updated":"2014-04-24 19:48:21.000000000","message":"nice comments steve!","commit_id":"a30070d834b2c36d2f03e0b0264837f2291be8d3"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"53c2606b7bdfab76ab39a4d45a1a57e2e52e41b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-24 12:56:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes test so that it passes when run on OS X"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Reasons:"},{"line_number":10,"context_line":"   - The write_to_fstab() method doesn\u0027t work on OS X because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAXX%2F%2F%2FUo%3D","line":7,"updated":"2014-04-24 20:01:13.000000000","message":"rather than saying \"fixes to run on OSX\" lets say what the change acutally is, like \"mocks out file.open to not rely on os dependent files\". And do we really need that reason/changes stuff below?","commit_id":"dc2a5bb1a5026d01bdc28c30b34786c314e6a94f"},{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"7f1fc5bc963fc7ffc44edadb2c9153632db835c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-24 12:56:45 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes test so that it passes when run on OS X"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Reasons:"},{"line_number":10,"context_line":"   - The write_to_fstab() method doesn\u0027t work on OS X because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAXX%2F%2F%2FFY%3D","line":7,"in_reply_to":"AAAAXX%2F%2F%2FUo%3D","updated":"2014-04-24 20:29:54.000000000","message":"Michael, I suggested to Steve that he provide some more detail on what and why was changed (not necessarily the format below).  He added this because Denis suggested more detail.  Somehow, we need to find a way to get everyone on the same page so we don\u0027t spend so much time on stuff like this :)","commit_id":"dc2a5bb1a5026d01bdc28c30b34786c314e6a94f"}],"trove/tests/unittests/guestagent/test_mongodb_manager.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"a1216cf7fca9bca8e2e243794a54a57eead4b315","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        mock_app.start_db \u003d MagicMock(return_value\u003dNone)"},{"line_number":82,"context_line":"        mock_app.clear_storage \u003d MagicMock(return_value\u003dNone)"},{"line_number":83,"context_line":"        os.path.exists \u003d MagicMock(return_value\u003dis_db_installed)"},{"line_number":84,"context_line":"        operating_system.get_ip_address \u003d MagicMock(return_value\u003d\u0027127.0.0.1\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # invocation"},{"line_number":87,"context_line":"        self.manager.prepare(context\u003dself.context, databases\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FYUs%3D","line":84,"updated":"2014-04-22 07:51:10.000000000","message":"If you only need to patch operating_system.get_ip_address, for the duration of this call, it might be cleaner to use patch with a context manager instead. That way, you don\u0027t need to worry about saving / restoring the original operating_system.get_ip_address.","commit_id":"f53c5253fe08ac0c295c53d5535de4f2ecae1fe6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"ebd700a713a440fa09958a2c8e2c9830c8b6add6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                 memory_mb\u003d\u00272048\u0027, users\u003dNone,"},{"line_number":88,"context_line":"                                 device_path\u003ddevice_path,"},{"line_number":89,"context_line":"                                 mount_point\u003d\u0027/var/lib/mongodb\u0027,"},{"line_number":90,"context_line":"                                 backup_info\u003dbackup_info)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        # verification/assertion"},{"line_number":93,"context_line":"        mock_status.begin_install.assert_any_call()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXX%2F%2F%2FjI%3D","line":90,"updated":"2014-04-24 19:36:07.000000000","message":"Mat Lowery has a review in flight to remove this call from the MongoDB manager.  As such, is this change still necessary? (https://review.openstack.org/#/c/90194/ )","commit_id":"a30070d834b2c36d2f03e0b0264837f2291be8d3"}],"trove/tests/unittests/guestagent/test_volume.py":[{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"fabfbe1a331858fdb2918dc3aeee42f0e626c921","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        origin_execute \u003d utils.execute"},{"line_number":175,"context_line":"        utils.execute \u003d Mock()"},{"line_number":176,"context_line":"        m \u003d mock_open()"},{"line_number":177,"context_line":"        with patch(\u0027%s.open\u0027 % volume.__name__, m, create\u003dTrue):"},{"line_number":178,"context_line":"            self.volumeMountPoint.write_to_fstab()"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        self.assertEqual(2, utils.execute.call_count)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXX%2F%2F%2Fec%3D","line":177,"updated":"2014-04-24 19:48:21.000000000","message":"nice enhancement","commit_id":"a30070d834b2c36d2f03e0b0264837f2291be8d3"}]}
