)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2c7c059527bd21add8937f4adb3b1cd514522380","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86781505_1d49938a","updated":"2023-06-28 09:00:18.000000000","message":"Hi, Bo Tran, hungnt1, Hirotaka Wakabayashi,  I wonder which database versions do you use most? currently, I only focus on mysql:5.7.29, Is there any other version do you use? I propose to add mysql:8.0 tests to our zuul system. but not sure about the explicit version of mysql:8.0?\nmaybe 8.0.29? or 8.0.42? the same as `mariadb` and `postgresql`, which version do you use? I will add those version to our zuul test. welcome any feedback from you.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"1fa6044d3887ccbc4307591615b119f396257089","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31f74ab2_f72066a3","updated":"2023-06-28 01:24:03.000000000","message":"I think simple and default config should be set to \"image\" \u003crequired\u003e and change descriptions about this config backup_docker_image instead by as current","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":30941,"name":"Hung, Nguyen Trong","display_name":"hungnt1","email":"sudo.nguyenhung@gmail.com","username":"hungnt1"},"change_message_id":"3a3247f668d81c56e0f4c08d590c0b8e9ac70d24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"497c66a2_f1f36803","updated":"2023-06-27 09:27:54.000000000","message":"I think we must add document to build backup image since we not maintain docker image.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":30941,"name":"Hung, Nguyen Trong","display_name":"hungnt1","email":"sudo.nguyenhung@gmail.com","username":"hungnt1"},"change_message_id":"0c9b14f837a500f05ec38b090d4a9ff7f67a487e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4440c550_2c7849bd","updated":"2023-06-28 01:14:51.000000000","message":"So why not make only one image for all database. Trove have device mapping help spare database store.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"334ae5397c61cd2cd6f3f5a6bbe3818b474c92e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c1b2434f_e297952c","updated":"2023-06-29 08:13:06.000000000","message":"please fix the pep8 first. you can also run tox -e pep8 in you local machine in you project root directory.\nI not sure that should we remove these settings[1] from devstack?\nhttps://github.com/openstack/trove/blob/master/devstack/settings#L100-L103","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1826406f41de2e9da65c2b6a6525a3ff80035137","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fdd7747_ddd77190","in_reply_to":"25301318_050163f9","updated":"2023-06-29 03:57:41.000000000","message":"yes, you are right, i would consider to how to refactor the multiple backup images.  currently, only mysql supports multiple images.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2c7c059527bd21add8937f4adb3b1cd514522380","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d73e581_5f3f85e5","in_reply_to":"31f74ab2_f72066a3","updated":"2023-06-28 09:00:18.000000000","message":"In some test scenario, we may not need to test backup, in these case, image opt should be allowed to set to empty.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"fabbfbfd69cf8b4c2b91cf9eb1dea729d017ddd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"600bd05a_c5c57fd9","in_reply_to":"38144634_6dba68f3","updated":"2023-06-30 06:59:11.000000000","message":"yup. I agree with you","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"925894edde62de4298f7bfb43e8f0a2650676a12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf867297_fee8ed57","in_reply_to":"497c66a2_f1f36803","updated":"2023-06-27 23:47:23.000000000","message":"Hi! Thanks for the comment! I will make the docs. The outline of the document will be:\n1. Prepares `Dockerfile`\n2. Runs `docker build/tag/push` to a docker registry on a control node.\n\n```\nDATABASE_BACKUP_VERSION\u003d1.1.2\nNIC_NAME\u003d$(ip -f inet route | grep default  | awk \u0027{print $5}\u0027)\nHOST_IP\u003d$(ip -f inet addr show ${NIC_NAME}|grep inet|awk \u0027{print $2}\u0027|perl -pe \"s|(/.*)||g\")\n\ncd ~/trove/backup\nvi Dockerfile\ndocker build -t testuser/db-backup-postgresql:${DATABASE_BACKUP_VERSION} .\ndocker tag testuser/db-backup-postgresql:${DATABASE_BACKUP_VERSION} ${HOST_IP}:5000/testuser/db-backup-postgresql:${DATABASE_BACKUP_VERSION}\n```","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2c7c059527bd21add8937f4adb3b1cd514522380","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d0b6e69c_dead4f13","in_reply_to":"4ca91cf5_25f80f64","updated":"2023-06-28 09:00:18.000000000","message":"Hi, hungnt1, we build the backup and datastore image everyday in our CI. Per[1]: the packages `trove-datastore-registry-master.tar.gz` is a packaged docker registry which used by registry:2 image, currently, we use this file in our CI by run a local registry, these code can be found at [2], IMO, Deploying a private registry is more reasonable in production. [3] is the playbook we used to build image.\n[1]:https://tarballs.opendev.org/openstack/trove/images/\n[2]:https://github.com/openstack/trove/blob/master/devstack/plugin.sh#L508\n[3]:https://github.com/openstack/trove/blob/master/playbooks/image-build/docker-registry.yaml","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"8f6856fbbfde5d9e67d68e03dbc2c4f8ea53a58d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"25301318_050163f9","in_reply_to":"86781505_1d49938a","updated":"2023-06-29 01:40:54.000000000","message":"I using various version of database engines such as:\nMongoDB: 4.4.7, 5.0.16, 6.0.5\nMariaDB: 10.3, 10.4\nPostgres: 13.10, 14.6, 15.2\nRedis: 5.0.4\n\nI doing add new other versions for above database engine and add new database engine. So, I think I will be person understand about problems will meet with trove in maintain, use, development process. Current, we doing very good and should change something about working when receive some feedback from story. we need to sum up problems and think about develop proccess to make it eseasy to dev, use and maintain.\n\nSo, if you want support multiple version of database engine, you need to do seperate docker image database, docker image backup/restore for each version like as my commit.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":30941,"name":"Hung, Nguyen Trong","display_name":"hungnt1","email":"sudo.nguyenhung@gmail.com","username":"hungnt1"},"change_message_id":"0c9b14f837a500f05ec38b090d4a9ff7f67a487e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ca91cf5_25f80f64","in_reply_to":"bf867297_fee8ed57","updated":"2023-06-28 01:14:51.000000000","message":"So why not make only one image for all database. Trove have device mapping help spare database store.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"83804b6dff0bc80bdc8da608ef70b6ecc358a112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8fb5a490_ef0383b0","in_reply_to":"c1b2434f_e297952c","updated":"2023-06-29 23:50:45.000000000","message":"Hi Wu, Thanks for the comment! I will fix the pep8 issue. \n\n\u003e I not sure that should we remove these settings[1] from devstack?\n\u003e https://github.com/openstack/trove/blob/master/devstack/settings#L100-L103\n\nThanks, I think we should basically remove the devstack settings because we do not maintain the images. Let\u0027s make Trove on devstack use the local registry now! :)","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"01bd82e927d6dce69684d61ce91c57abc72bfb96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38144634_6dba68f3","in_reply_to":"c27654bf_7389421b","updated":"2023-06-30 06:06:32.000000000","message":"Hi, Bo, this is what we are doing now, however,  I found an issue that the CI tests can\u0027t cover the changing of the backup code. because we always import the docker_image.tar from the website[0]. In this case, commit that hasn\u0027t merged can\u0027t get tested. \n\nto test the backup code. I will build these images during the installation of devstack instead of importing docker_image.tar. \n\n[0]:https://tarballs.opendev.org/openstack/trove/images/","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3dfc3554d91151701e741eadb6212ddf94c531a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce09eb40_3684caf6","in_reply_to":"c6280949_c2a6be4e","updated":"2023-06-30 04:06:26.000000000","message":"yes, i also used to use: ${my-host-ip-here}:5000, In devstack, you just need to set: TROVE_ENABLE_LOCAL_REGISTRY\u003dTrue in local.conf, then trove will setup a docker registry and pull the datastore and it\u0027s backup images to this registry, then configure the trove.conf to use this registry properly. maybe i should add this setting to devstack docs.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"3c9f6032233e4ed4e51c99e81e6105fb5c980998","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c27654bf_7389421b","in_reply_to":"ce09eb40_3684caf6","updated":"2023-06-30 04:16:04.000000000","message":"in devstack environment, I think we don\u0027t need make like that. I just simple think that we should add a script to download docker_image.tar from anywhere or push/ local build a backup/restore image and import it when build new glance image.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"829b14d9b4d5fd3d5d31bd60fd73ab52a360b291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c6280949_c2a6be4e","in_reply_to":"d0b6e69c_dead4f13","updated":"2023-06-30 03:58:27.000000000","message":"One prerequisite for Trove is a Docker registry. For some users who do not have a docker registry, I propose the following docs so that users can start their own local registry for free. off course, users can select a commercial docker registry service.\nhttps://docs.docker.com/registry/\n\nAssuming users have fulfilled the prerequisite, I suggest the IP and port of the registry would be `${my-host-ip-here}:5000`, which I usually use it when I test Trove on devstack for testing purpose.:)","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"01bd82e927d6dce69684d61ce91c57abc72bfb96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f6a3a71d_f6cf2288","updated":"2023-06-30 06:06:32.000000000","message":"Hi, hirotaka, please also add a docs about  importing docker_image.tar.\nthe docker_image.tar can be found at : https://tarballs.opendev.org/openstack/trove/images/\n\nthanks.","commit_id":"05f258afbdb1c55ff1bfc851d100d697e8d78259"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"d65f81f5c10b940136865915d2a2244898715743","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1c54b72c_6e77d4dc","updated":"2023-08-04 11:56:26.000000000","message":"Hello guys, could you please check this?","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"cb843f6ff12760c9fed6e0be5e6ee775b806522d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c8755803_c8b211ff","updated":"2023-08-16 06:13:41.000000000","message":"also need to fix CI.","commit_id":"b434fd82111d9f9f24f877e28e3e235a310919c9"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"14bfa3b38f3483d2394a41a4255dcf369b5328c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8c110dc5_44db4d32","updated":"2023-08-24 12:27:14.000000000","message":"LGTM","commit_id":"16256dd183c490412c661f1891df585958e22c6c"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"25d3903ba746a9940f4acb35dd1817061e99da8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9861b6fa_bd26841d","updated":"2023-08-24 16:10:37.000000000","message":"Sorry, I uploaded patches on local caches. LGTM :)","commit_id":"f2d927162cc0855edb265d1c48c160e7e39b9c51"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fb75834d905d538a1bdc397d0abb24e6f69ff89e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"01c2d845_034ead88","updated":"2023-10-07 08:26:32.000000000","message":"Hi, hirotaka, LGMT, thanks.","commit_id":"2ad7e9773e78b74ccb0f2fb2488ab64fed59ae10"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"f8bfcd03a74feae6b0dd3358054a68b2c5fab2fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"6be7db5c_8e9f1553","updated":"2024-01-08 03:22:06.000000000","message":"I will update this patch.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"260ff8ac4248007c95428f0076960ad082f82b7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"34189428_444fadc2","updated":"2024-01-11 06:31:11.000000000","message":"hi, Hirotaka, could you help to review this patch? as there is a user needs this guide.","commit_id":"67e13892214197ecce1a79c7c695fd3718eb442c"}],"doc/source/admin/building_guest_images.rst":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"36c01075152a177b6a499e7fffe8ba3631b3a5be","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"-------------------"},{"line_number":218,"context_line":"Build Docker images"},{"line_number":219,"context_line":"-------------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"This document shows you the steps to build the docker container images. Before"},{"line_number":222,"context_line":"you start building the images, please prepare your docker registry. See the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"698ec736_8e5ac122","line":219,"updated":"2023-06-30 05:52:44.000000000","message":"5000 may be  listened by keystone, what about we listen on 4000 port?","commit_id":"05f258afbdb1c55ff1bfc851d100d697e8d78259"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"3be844b8f6e446d0028a5260d3e7cd913240f37c","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"-------------------"},{"line_number":218,"context_line":"Build Docker images"},{"line_number":219,"context_line":"-------------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"This document shows you the steps to build the docker container images. Before"},{"line_number":222,"context_line":"you start building the images, please prepare your docker registry. See the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"6e5ca3e9_a9b5ce7a","line":219,"in_reply_to":"698ec736_8e5ac122","updated":"2023-08-04 11:53:56.000000000","message":"Done","commit_id":"05f258afbdb1c55ff1bfc851d100d697e8d78259"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"36c01075152a177b6a499e7fffe8ba3631b3a5be","unresolved":true,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"This document shows you the steps to build the docker container images. Before"},{"line_number":222,"context_line":"you start building the images, please prepare your docker registry. See the"},{"line_number":223,"context_line":"`Docker Registry Overview`_ on docs.docker.com if you would like to start your"},{"line_number":224,"context_line":"own docker registry. In this document, we assume our local dokcer registry that"},{"line_number":225,"context_line":"runs on ``${my-host-ip-here}:5000``."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":".. _`Docker Registry Overview`: https://docs.docker.com/registry/"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"a75cd20b_38e9766b","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":36},"updated":"2023-06-30 05:52:44.000000000","message":"i prefer to give an example here directly. like this: https://docs.openstack.org/kolla-ansible/latest/user/multinode.html#deploy-a-registry\nand i also prefer to listen on 0.0.0.0, So that we can push the image directly without needing to login or set insecure registries first.\n\nif we listen on 0.0.0.0, we just need to change the tag to 127.0.0.1/xxx/image. As 127.0.0.1 is already in docker insecure Registries list.","commit_id":"05f258afbdb1c55ff1bfc851d100d697e8d78259"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"e39d1c90947c21d74c360515aba3d01caef89c5a","unresolved":true,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"This document shows you the steps to build the docker container images. Before"},{"line_number":222,"context_line":"you start building the images, please prepare your docker registry. See the"},{"line_number":223,"context_line":"`Docker Registry Overview`_ on docs.docker.com if you would like to start your"},{"line_number":224,"context_line":"own docker registry. In this document, we assume our local dokcer registry that"},{"line_number":225,"context_line":"runs on ``${my-host-ip-here}:5000``."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":".. _`Docker Registry Overview`: https://docs.docker.com/registry/"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dc878b36_76f4aaf7","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":36},"in_reply_to":"a75cd20b_38e9766b","updated":"2023-06-30 06:12:16.000000000","message":"Also introduce how to import the docker_image.tar to a local registry here? thanks","commit_id":"05f258afbdb1c55ff1bfc851d100d697e8d78259"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"3be844b8f6e446d0028a5260d3e7cd913240f37c","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"This document shows you the steps to build the docker container images. Before"},{"line_number":222,"context_line":"you start building the images, please prepare your docker registry. See the"},{"line_number":223,"context_line":"`Docker Registry Overview`_ on docs.docker.com if you would like to start your"},{"line_number":224,"context_line":"own docker registry. In this document, we assume our local dokcer registry that"},{"line_number":225,"context_line":"runs on ``${my-host-ip-here}:5000``."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":".. _`Docker Registry Overview`: https://docs.docker.com/registry/"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"f4ae2bae_8020eed7","line":225,"range":{"start_line":223,"start_character":0,"end_line":225,"end_character":36},"in_reply_to":"dc878b36_76f4aaf7","updated":"2023-08-04 11:53:56.000000000","message":"Done","commit_id":"05f258afbdb1c55ff1bfc851d100d697e8d78259"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"36c01075152a177b6a499e7fffe8ba3631b3a5be","unresolved":true,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":".. code-block:: console"},{"line_number":279,"context_line":"    $ DATABASE_NAME\u003dpostgres"},{"line_number":280,"context_line":"    $ DABASE_VERSION\u003d12.14"},{"line_number":281,"context_line":"    $ NIC_NAME\u003d$(ip -f inet route | grep default  | awk \u0027{print $5}\u0027)"},{"line_number":282,"context_line":"    $ HOST_IP\u003d$(ip -f inet addr show ${NIC_NAME}|grep inet|awk \u0027{print $2}\u0027|perl -pe \"s|(/.*)||g\")"},{"line_number":283,"context_line":"    $ REGISTRY_REPO\u003dtestuser"}],"source_content_type":"text/x-rst","patch_set":3,"id":"765afa64_661d2440","line":280,"range":{"start_line":280,"start_character":6,"end_line":280,"end_character":20},"updated":"2023-06-30 05:52:44.000000000","message":"nit: s/dabase/database/","commit_id":"05f258afbdb1c55ff1bfc851d100d697e8d78259"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"3be844b8f6e446d0028a5260d3e7cd913240f37c","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":".. code-block:: console"},{"line_number":279,"context_line":"    $ DATABASE_NAME\u003dpostgres"},{"line_number":280,"context_line":"    $ DABASE_VERSION\u003d12.14"},{"line_number":281,"context_line":"    $ NIC_NAME\u003d$(ip -f inet route | grep default  | awk \u0027{print $5}\u0027)"},{"line_number":282,"context_line":"    $ HOST_IP\u003d$(ip -f inet addr show ${NIC_NAME}|grep inet|awk \u0027{print $2}\u0027|perl -pe \"s|(/.*)||g\")"},{"line_number":283,"context_line":"    $ REGISTRY_REPO\u003dtestuser"}],"source_content_type":"text/x-rst","patch_set":3,"id":"42c1f84f_ac037944","line":280,"range":{"start_line":280,"start_character":6,"end_line":280,"end_character":20},"in_reply_to":"765afa64_661d2440","updated":"2023-08-04 11:53:56.000000000","message":"Done","commit_id":"05f258afbdb1c55ff1bfc851d100d697e8d78259"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"70cbd2be474efcb1d14b720b45af20008fc6ec2b","unresolved":true,"context_lines":[{"line_number":62,"context_line":"the related options for container images are:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. code-block:: ini"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   [mysql]"},{"line_number":67,"context_line":"   docker_image"},{"line_number":68,"context_line":"   backup_docker_image"}],"source_content_type":"text/x-rst","patch_set":6,"id":"e6b87121_d6d47951","line":65,"updated":"2023-08-07 03:47:16.000000000","message":"Add docker_insecure_registries here?","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"ac6bf4f8f037b62f70b8fe790963d0a541862f01","unresolved":false,"context_lines":[{"line_number":62,"context_line":"the related options for container images are:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. code-block:: ini"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   [mysql]"},{"line_number":67,"context_line":"   docker_image"},{"line_number":68,"context_line":"   backup_docker_image"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9b412710_787cf18b","line":65,"in_reply_to":"e6b87121_d6d47951","updated":"2023-08-16 01:08:32.000000000","message":"Thanks for the comment! I think the \"docker_insecure_registries\" directive should not be added here because this section describes the new feature of Docker introduction, not how to use Docker in special cases.","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"70cbd2be474efcb1d14b720b45af20008fc6ec2b","unresolved":true,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":".. code-block:: console"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.0"},{"line_number":281,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":282,"context_line":"    $ DATABASE_BACKUP_IMAGE\u003d${REGISTRY_REPO_PATH}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${DATABASE_BACKUP_VERSION}"},{"line_number":283,"context_line":"    $ git clone https://opendev.org/openstack/trove"}],"source_content_type":"text/x-rst","patch_set":6,"id":"cbd90da7_c58c5409","line":280,"updated":"2023-08-07 03:47:16.000000000","message":"we may switch these tag to DATABASE_VERSION to support multiple datastore_version for each datastore. as that commit hasn\u0027t merged yet. Do you think we should merged that first?","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"ac6bf4f8f037b62f70b8fe790963d0a541862f01","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":".. code-block:: console"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.0"},{"line_number":281,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":282,"context_line":"    $ DATABASE_BACKUP_IMAGE\u003d${REGISTRY_REPO_PATH}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${DATABASE_BACKUP_VERSION}"},{"line_number":283,"context_line":"    $ git clone https://opendev.org/openstack/trove"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a8c787b4_df505b52","line":280,"in_reply_to":"cbd90da7_c58c5409","updated":"2023-08-16 01:08:32.000000000","message":"Thanks for the comment, I think improvements should be merged soon after the review is completed.","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"70cbd2be474efcb1d14b720b45af20008fc6ec2b","unresolved":true,"context_lines":[{"line_number":280,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.0"},{"line_number":281,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":282,"context_line":"    $ DATABASE_BACKUP_IMAGE\u003d${REGISTRY_REPO_PATH}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${DATABASE_BACKUP_VERSION}"},{"line_number":283,"context_line":"    $ git clone https://opendev.org/openstack/trove"},{"line_number":284,"context_line":"    $ cd ~/trove/backup"},{"line_number":285,"context_line":"    $ vi Dockerfile"},{"line_number":286,"context_line":"    $ docker build -t ${DATABASE_BACKUP_IMAGE} ."},{"line_number":287,"context_line":"    $ docker tag ${DATABASE_BACKUP_IMAGE} ${REGISTRY_HTTP_ADDR}${DATABASE_BACKUP_IMAGE}"},{"line_number":288,"context_line":"    $ docker push ${REGISTRY_HTTP_ADDR}${DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6541ed5e_b178dc08","line":285,"range":{"start_line":283,"start_character":0,"end_line":285,"end_character":19},"updated":"2023-08-07 03:47:16.000000000","message":"we don\u0027t need to \"vi Dockerfile\" here, use: docker build -t ${DATABASE_BACKUP_IMAGE} --build-arg DATASTORE\u003dmysql5.7 .","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"ac6bf4f8f037b62f70b8fe790963d0a541862f01","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.0"},{"line_number":281,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":282,"context_line":"    $ DATABASE_BACKUP_IMAGE\u003d${REGISTRY_REPO_PATH}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${DATABASE_BACKUP_VERSION}"},{"line_number":283,"context_line":"    $ git clone https://opendev.org/openstack/trove"},{"line_number":284,"context_line":"    $ cd ~/trove/backup"},{"line_number":285,"context_line":"    $ vi Dockerfile"},{"line_number":286,"context_line":"    $ docker build -t ${DATABASE_BACKUP_IMAGE} ."},{"line_number":287,"context_line":"    $ docker tag ${DATABASE_BACKUP_IMAGE} ${REGISTRY_HTTP_ADDR}${DATABASE_BACKUP_IMAGE}"},{"line_number":288,"context_line":"    $ docker push ${REGISTRY_HTTP_ADDR}${DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d4d79670_62c9c4b7","line":285,"range":{"start_line":283,"start_character":0,"end_line":285,"end_character":19},"in_reply_to":"6541ed5e_b178dc08","updated":"2023-08-16 01:08:32.000000000","message":"Thanks for the comment, updated!","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"70cbd2be474efcb1d14b720b45af20008fc6ec2b","unresolved":true,"context_lines":[{"line_number":305,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.2.0"},{"line_number":306,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":307,"context_line":"    $ DATABASE_BACKUP_IMAGE\u003d${REGISTRY_REPO_PATH}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${DATABASE_BACKUP_VERSION}"},{"line_number":308,"context_line":"    $ git clone https://opendev.org/openstack/trove"},{"line_number":309,"context_line":"    $ cd ~/trove/backup"},{"line_number":310,"context_line":"    $ vi Dockerfile"},{"line_number":311,"context_line":"    $ docker build -t ${DATABASE_BACKUP_IMAGE} ."}],"source_content_type":"text/x-rst","patch_set":6,"id":"0c88c974_a5bcfe48","line":308,"updated":"2023-08-07 03:47:16.000000000","message":"already cloned  above?","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"ac6bf4f8f037b62f70b8fe790963d0a541862f01","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.2.0"},{"line_number":306,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":307,"context_line":"    $ DATABASE_BACKUP_IMAGE\u003d${REGISTRY_REPO_PATH}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${DATABASE_BACKUP_VERSION}"},{"line_number":308,"context_line":"    $ git clone https://opendev.org/openstack/trove"},{"line_number":309,"context_line":"    $ cd ~/trove/backup"},{"line_number":310,"context_line":"    $ vi Dockerfile"},{"line_number":311,"context_line":"    $ docker build -t ${DATABASE_BACKUP_IMAGE} ."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5c27ce2a_31c795eb","line":308,"in_reply_to":"0c88c974_a5bcfe48","updated":"2023-08-16 01:08:32.000000000","message":"Thanks for the comment. I updated the docs.","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"70cbd2be474efcb1d14b720b45af20008fc6ec2b","unresolved":true,"context_lines":[{"line_number":329,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.2"},{"line_number":330,"context_line":"    $ ALT_DATABASE_NAME\u003dpostgresql"},{"line_number":331,"context_line":"    $ DATABASE_BACKUP_IMAGE\u003d${REGISTRY_REPO_PATH}/db-backup-${ALT_DATABASE_NAME}:${DATABASE_BACKUP_VERSION}"},{"line_number":332,"context_line":"    $ git clone https://opendev.org/openstack/trove"},{"line_number":333,"context_line":"    $ cd ~/trove/backup"},{"line_number":334,"context_line":"    $ vi Dockerfile"},{"line_number":335,"context_line":"    $ docker build -t ${DATABASE_BACKUP_IMAGE} ."},{"line_number":336,"context_line":"    $ docker tag ${DATABASE_BACKUP_IMAGE} ${REGISTRY_HTTP_ADDR}${DATABASE_BACKUP_IMAGE}"},{"line_number":337,"context_line":"    $ docker push ${REGISTRY_HTTP_ADDR}${DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa0de8b4_2ea03285","line":334,"range":{"start_line":332,"start_character":0,"end_line":334,"end_character":19},"updated":"2023-08-07 03:47:16.000000000","message":"ditto.","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"ac6bf4f8f037b62f70b8fe790963d0a541862f01","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.2"},{"line_number":330,"context_line":"    $ ALT_DATABASE_NAME\u003dpostgresql"},{"line_number":331,"context_line":"    $ DATABASE_BACKUP_IMAGE\u003d${REGISTRY_REPO_PATH}/db-backup-${ALT_DATABASE_NAME}:${DATABASE_BACKUP_VERSION}"},{"line_number":332,"context_line":"    $ git clone https://opendev.org/openstack/trove"},{"line_number":333,"context_line":"    $ cd ~/trove/backup"},{"line_number":334,"context_line":"    $ vi Dockerfile"},{"line_number":335,"context_line":"    $ docker build -t ${DATABASE_BACKUP_IMAGE} ."},{"line_number":336,"context_line":"    $ docker tag ${DATABASE_BACKUP_IMAGE} ${REGISTRY_HTTP_ADDR}${DATABASE_BACKUP_IMAGE}"},{"line_number":337,"context_line":"    $ docker push ${REGISTRY_HTTP_ADDR}${DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":6,"id":"65a9fd30_28f10d75","line":334,"range":{"start_line":332,"start_character":0,"end_line":334,"end_character":19},"in_reply_to":"fa0de8b4_2ea03285","updated":"2023-08-16 01:08:32.000000000","message":"ditto.","commit_id":"0e26a9f14b4ba287fba768fa33905be1b638de53"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"cb843f6ff12760c9fed6e0be5e6ee775b806522d","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"--------------------------"},{"line_number":218,"context_line":"Use your own Docker Images"},{"line_number":219,"context_line":"--------------------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"You can pull and push your own images when you use a private Docker registry."},{"line_number":222,"context_line":"For Docker registry, please see `Docker Registry Overview`_ on docs.docker.com"}],"source_content_type":"text/x-rst","patch_set":12,"id":"2e88a8c6_d569e959","line":219,"updated":"2023-08-16 06:13:41.000000000","message":"Hi, why we removed the docs section about running registry and importing the trove-imagexxx.tar.gz?","commit_id":"b434fd82111d9f9f24f877e28e3e235a310919c9"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"a3e976bbea8805e14cdbfc7c69201ad4eebf9229","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"--------------------------"},{"line_number":218,"context_line":"Use your own Docker Images"},{"line_number":219,"context_line":"--------------------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"You can pull and push your own images when you use a private Docker registry."},{"line_number":222,"context_line":"For Docker registry, please see `Docker Registry Overview`_ on docs.docker.com"}],"source_content_type":"text/x-rst","patch_set":12,"id":"39180ec2_e246a485","line":219,"in_reply_to":"2e88a8c6_d569e959","updated":"2023-08-16 15:46:26.000000000","message":"We should instruct users here how to build docker images and use them in Trove. \n\nWe can add the docs about running docker registry in detail here, however I basically think we should focus only on our specialized area as we can only control them. Our documents should be independent of how to run docker registry service. Instead, we can place the hyperlink to docker registry service for users to avoid search how to run registry service. \n\nI think we can omit how to import trove-datastore-registry-master.tar.gz here, because the purpose of this chapter is to build users\u0027 own image.","commit_id":"b434fd82111d9f9f24f877e28e3e235a310919c9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    $ git clone https://opendev.org/openstack/trove"},{"line_number":232,"context_line":"    $ YOUR_TROVE_SRC_DIR\u003d${PWD}/trove"},{"line_number":233,"context_line":"    $ YOUR_TROVE_HOST_GATEWAY_IP\u003d10.x.y.z"},{"line_number":234,"context_line":"    $ YOUR_REGISTRY_PORT\u003d4000"},{"line_number":235,"context_line":"    $ YOUR_REGISTRY_HTTP_ADDR\u003d${YOUR_TROVE_HOST_GATEWAY_IP}:${YOUR_REGISTRY_PORT}"},{"line_number":236,"context_line":"    $ YOUR_REGISTRY_REPO_NAME\u003dtrove-datastores"}],"source_content_type":"text/x-rst","patch_set":22,"id":"d13d9d76_d1fe37e3","line":233,"range":{"start_line":233,"start_character":6,"end_line":233,"end_character":32},"updated":"2023-11-13 02:30:20.000000000","message":"YOUR_REGISTRY_ADDRESS?  what\u0027s the meaning of trove_host_gateway_ip here?","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":240,"context_line":".. code-block:: console"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    $ DATABASE_NAME\u003dmysql"},{"line_number":243,"context_line":"    $ DATABASE_VERSION\u003d5.7.29"},{"line_number":244,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":245,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":246,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"f3ec4cd4_4504202c","line":243,"range":{"start_line":243,"start_character":23,"end_line":243,"end_character":29},"updated":"2023-11-13 02:30:20.000000000","message":"s/5.7.29/5.7. we can\u0027t build backup image against exact mysql version 5.7.29, thus I recommend to use 5.7 instead of 5.7.59. as I have already tested mysql 5.7 in zuul so it\u0027s fine.\nanother reason for using mysql 5.7 is that we have supported multiple datastore versions feature, If we use 5.7.29, then we need to build a backup image with 5.7.29 tag, however,  In our backup script, It only supports mysql 5.7 and 8.0.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"58b6979df687a4c33ef292acbb82877b4f23f5f6","unresolved":true,"context_lines":[{"line_number":240,"context_line":".. code-block:: console"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    $ DATABASE_NAME\u003dmysql"},{"line_number":243,"context_line":"    $ DATABASE_VERSION\u003d5.7.29"},{"line_number":244,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":245,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":246,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"80d27e79_b53caf08","line":243,"range":{"start_line":243,"start_character":23,"end_line":243,"end_character":29},"in_reply_to":"5a069c9a_303590d4","updated":"2023-12-21 06:27:17.000000000","message":"Hi, Bo, thanks for your explanation, Got it.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"7f03b7dcb8255882ab791ec58705ac286b0cda31","unresolved":true,"context_lines":[{"line_number":240,"context_line":".. code-block:: console"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    $ DATABASE_NAME\u003dmysql"},{"line_number":243,"context_line":"    $ DATABASE_VERSION\u003d5.7.29"},{"line_number":244,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":245,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":246,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a069c9a_303590d4","line":243,"range":{"start_line":243,"start_character":23,"end_line":243,"end_character":29},"in_reply_to":"6dcb0a55_661fde88","updated":"2023-12-20 10:35:26.000000000","message":"The exact version being depended by OS version. \nSo, I think we shouldn\u0027t focus to this problem.\n\nWe just have big different between 2 version (not minor version). Such as: MySQL 5.7 and 8.0 are different but 5.7.39 and 5.7.42 are same.\n\nYou don\u0027t need worry about this.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"805d4b57bcec46aff8d6d4f7a2c7c522c4781d13","unresolved":true,"context_lines":[{"line_number":240,"context_line":".. code-block:: console"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    $ DATABASE_NAME\u003dmysql"},{"line_number":243,"context_line":"    $ DATABASE_VERSION\u003d5.7.29"},{"line_number":244,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":245,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":246,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"6dcb0a55_661fde88","line":243,"range":{"start_line":243,"start_character":23,"end_line":243,"end_character":29},"in_reply_to":"d7088be5_309f8c75","updated":"2023-12-20 10:21:56.000000000","message":"I think we don\u0027t need to maintain deb packages，we just need to download the corresponding version from the repository. \n\nCurrently, though the user have the guide, The trove backup image build script  still isn\u0027t capable of building a image against a exact version.\nfor example:  5.7.29 and 5.7.41 are using a same backup images. which may cause mysql backup failing.\n\nI am not sure what\u0027s the different between 5.7.29 and 5.7.41, and whether the backup image can work on both them.\n\nfor the reason of stabilization,  i think we would better to fix a version for a release, and test it in our CI.\n\nhow do you think Bo?","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"963cde3341257576dcf82984eb03fd3e6754e4f6","unresolved":true,"context_lines":[{"line_number":240,"context_line":".. code-block:: console"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    $ DATABASE_NAME\u003dmysql"},{"line_number":243,"context_line":"    $ DATABASE_VERSION\u003d5.7.29"},{"line_number":244,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":245,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":246,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"d7088be5_309f8c75","line":243,"range":{"start_line":243,"start_character":23,"end_line":243,"end_character":29},"in_reply_to":"e551995f_b42e1ed9","updated":"2023-12-20 10:02:02.000000000","message":"To resolve this problem, we need maintain some deb packages.\nI think we should write some tutorials to guide user can build a docker image by self.\n\nTrove just is open source software, it can\u0027t be fit with all cases","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"469279b0fba2a16870c59c82317b25d88e99be5f","unresolved":true,"context_lines":[{"line_number":240,"context_line":".. code-block:: console"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    $ DATABASE_NAME\u003dmysql"},{"line_number":243,"context_line":"    $ DATABASE_VERSION\u003d5.7.29"},{"line_number":244,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":245,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":246,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"fd880ff9_57029181","line":243,"range":{"start_line":243,"start_character":23,"end_line":243,"end_character":29},"in_reply_to":"f3ec4cd4_4504202c","updated":"2023-11-13 02:38:21.000000000","message":"I doing work as a cloud provider - I agree with wu.chunyang.\nWe don\u0027t need define exact of version. I provide 6 versions are:\n- 5.7.38, 5.7.39, 5.7.42, 5.7.43\n- 8.0.34, 8.1.0\nI just need build 2 docker image for mysql 5.x and 8.x and set tag for other versions.\nI doing use this my patch: https://review.opendev.org/c/openstack/trove/+/884165","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"41668b6d68b72811759b16e8a46707c4964f6e3f","unresolved":true,"context_lines":[{"line_number":240,"context_line":".. code-block:: console"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    $ DATABASE_NAME\u003dmysql"},{"line_number":243,"context_line":"    $ DATABASE_VERSION\u003d5.7.29"},{"line_number":244,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":245,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":246,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"e551995f_b42e1ed9","line":243,"range":{"start_line":243,"start_character":23,"end_line":243,"end_character":29},"in_reply_to":"fd880ff9_57029181","updated":"2023-12-20 07:58:08.000000000","message":"I am currently considering whether we should fix the micro(patch) version for each release. because the backup build script always download the latest package. for example: In Bobcat, the mysql:5.7 image links to mysql:5.7.41, and we build backup image by downloading latest binary package in the Docker file.   however, the next time in the future we build this backup image again. the built image may download 5.7.46 or newer version package. which perhaps not work with old trove code. In this case, fixing the backup image version and the mysql image version for trove stable branch may be more reasonable.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":251,"context_line":".. code-block:: console"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    $ cd ${YOUR_TROVE_SRC_DIR}/backup"},{"line_number":254,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":255,"context_line":"    $ TROVE_DATABASE_BACKUP_VERSION\u003d1.1.0"},{"line_number":256,"context_line":"    $ TROVE_DATABASE_BACKUP_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${TROVE_DATABASE_BACKUP_VERSION}"},{"line_number":257,"context_line":"    $ docker build -t ${TROVE_DATABASE_BACKUP_IMAGE} --build-arg DATASTORE\u003d${DATABASE_NAME}${DATABASE_MINOR_VERSION} --build-arg DATASTORE_VERSION\u003d${DATABASE_VERSION} ."}],"source_content_type":"text/x-rst","patch_set":22,"id":"700365a7_4c3f0ad2","line":254,"updated":"2023-11-13 02:30:20.000000000","message":"Don\u0027t need this variable any more.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    $ cd ${YOUR_TROVE_SRC_DIR}/backup"},{"line_number":254,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":255,"context_line":"    $ TROVE_DATABASE_BACKUP_VERSION\u003d1.1.0"},{"line_number":256,"context_line":"    $ TROVE_DATABASE_BACKUP_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${TROVE_DATABASE_BACKUP_VERSION}"},{"line_number":257,"context_line":"    $ docker build -t ${TROVE_DATABASE_BACKUP_IMAGE} --build-arg DATASTORE\u003d${DATABASE_NAME}${DATABASE_MINOR_VERSION} --build-arg DATASTORE_VERSION\u003d${DATABASE_VERSION} ."},{"line_number":258,"context_line":"    $ docker tag ${TROVE_DATABASE_BACKUP_IMAGE} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7f2e2e08_28e05360","line":255,"range":{"start_line":255,"start_character":36,"end_line":255,"end_character":41},"updated":"2023-11-13 02:30:20.000000000","message":"here let\u0027s use $DATABASE_VERSION.  1.1.0 currently is only used for compatibility, we suggest to use the same tag with the datastore version for support multiple datastore.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":253,"context_line":"    $ cd ${YOUR_TROVE_SRC_DIR}/backup"},{"line_number":254,"context_line":"    $ DATABASE_MINOR_VERSION\u003d$(echo ${DATABASE_VERSION}|awk -F. \u0027{print $1\".\"$2}\u0027)"},{"line_number":255,"context_line":"    $ TROVE_DATABASE_BACKUP_VERSION\u003d1.1.0"},{"line_number":256,"context_line":"    $ TROVE_DATABASE_BACKUP_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/db-backup-${DATABASE_NAME}${DATABASE_MINOR_VERSION}:${TROVE_DATABASE_BACKUP_VERSION}"},{"line_number":257,"context_line":"    $ docker build -t ${TROVE_DATABASE_BACKUP_IMAGE} --build-arg DATASTORE\u003d${DATABASE_NAME}${DATABASE_MINOR_VERSION} --build-arg DATASTORE_VERSION\u003d${DATABASE_VERSION} ."},{"line_number":258,"context_line":"    $ docker tag ${TROVE_DATABASE_BACKUP_IMAGE} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_BACKUP_IMAGE}"},{"line_number":259,"context_line":"    $ docker push ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"384f3b3d_15e2dc60","line":256,"range":{"start_line":256,"start_character":61,"end_line":256,"end_character":145},"updated":"2023-11-13 02:30:20.000000000","message":"Let\u0027s use db-backup-${DATABASE_NAME}:${DATABASE_VERSION} instead.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":264,"context_line":".. code-block:: console"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    $ DATABASE_NAME\u003dmariadb"},{"line_number":267,"context_line":"    $ DATABASE_VERSION\u003d10.4.31"},{"line_number":268,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":269,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":270,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"df1e0f9f_ef413c22","line":267,"range":{"start_line":267,"start_character":23,"end_line":267,"end_character":30},"updated":"2023-11-13 02:30:20.000000000","message":"using 10.4 instead?  I am not sure that we should concern about the minor version in docker hub. refer to Postgres doc, it alway recommends user to use the latest minor version for each major version, so I infer this should be the same as other datastores.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":275,"context_line":".. code-block:: console"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    $ cd ${YOUR_TROVE_SRC_DIR}/backup"},{"line_number":278,"context_line":"    $ TROVE_DATABASE_BACKUP_VERSION\u003d1.2.0"},{"line_number":279,"context_line":"    $ TROVE_DATABASE_BACKUP_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/db-backup-${DATABASE_NAME}:${TROVE_DATABASE_BACKUP_VERSION}"},{"line_number":280,"context_line":"    $ docker build -t ${TROVE_DATABASE_BACKUP_IMAGE} --build-arg DATASTORE\u003d${DATABASE_NAME} --build-arg DATASTORE_VERSION\u003d${DATABASE_VERSION} ."},{"line_number":281,"context_line":"    $ docker tag ${TROVE_DATABASE_BACKUP_IMAGE} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"f7e4845f_178edbca","line":278,"range":{"start_line":278,"start_character":36,"end_line":278,"end_character":41},"updated":"2023-11-13 02:30:20.000000000","message":"$DATABASE_VERSION  for supporting multiple datastore version.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":287,"context_line":".. code-block:: console"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    $ DATABASE_NAME\u003dpostgres"},{"line_number":290,"context_line":"    $ DATABASE_VERSION\u003d12.14"},{"line_number":291,"context_line":"    $ TROVE_DATABASE_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":292,"context_line":"    $ docker pull ${DATABASE_NAME}:${DATABASE_VERSION}"},{"line_number":293,"context_line":"    $ docker tag ${DATABASE_NAME}:${DATABASE_VERSION} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"62b745f0_18672ba3","line":290,"updated":"2023-11-13 02:30:20.000000000","message":"Using 12 here? because  postgres:12 always links to the latest minor version(12.17), \nand our previous CI tested postgre base on postgre:12 image. however Both 12 and 12.14 are suppose to work fine here.\n\nrefer to: https://www.postgresql.org/support/versioning/","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":299,"context_line":".. code-block:: console"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    $ cd ${YOUR_TROVE_SRC_DIR}/backup"},{"line_number":302,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.2"},{"line_number":303,"context_line":"    $ ALT_DATABASE_NAME\u003dpostgresql"},{"line_number":304,"context_line":"    $ TROVE_DATABASE_BACKUP_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/db-backup-${ALT_DATABASE_NAME}:${DATABASE_BACKUP_VERSION}"},{"line_number":305,"context_line":"    $ docker build -t ${TROVE_DATABASE_BACKUP_IMAGE} --build-arg DATASTORE\u003d${ALT_DATABASE_NAME} --build-arg DATASTORE_VERSION\u003d${DATABASE_VERSION} ."}],"source_content_type":"text/x-rst","patch_set":22,"id":"d88ebdb9_aaad702e","line":302,"range":{"start_line":302,"start_character":30,"end_line":302,"end_character":35},"updated":"2023-11-13 02:30:20.000000000","message":"remove this variable as the following command already used ${DATABASE_VERSION}. see line 305","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    $ cd ${YOUR_TROVE_SRC_DIR}/backup"},{"line_number":302,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.2"},{"line_number":303,"context_line":"    $ ALT_DATABASE_NAME\u003dpostgresql"},{"line_number":304,"context_line":"    $ TROVE_DATABASE_BACKUP_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/db-backup-${ALT_DATABASE_NAME}:${DATABASE_BACKUP_VERSION}"},{"line_number":305,"context_line":"    $ docker build -t ${TROVE_DATABASE_BACKUP_IMAGE} --build-arg DATASTORE\u003d${ALT_DATABASE_NAME} --build-arg DATASTORE_VERSION\u003d${DATABASE_VERSION} ."},{"line_number":306,"context_line":"    $ docker tag ${TROVE_DATABASE_BACKUP_IMAGE} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"72f0547a_e0f8e862","line":303,"updated":"2023-11-13 02:30:20.000000000","message":"what\u0027s the abrrevation for ALT?","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":301,"context_line":"    $ cd ${YOUR_TROVE_SRC_DIR}/backup"},{"line_number":302,"context_line":"    $ DATABASE_BACKUP_VERSION\u003d1.1.2"},{"line_number":303,"context_line":"    $ ALT_DATABASE_NAME\u003dpostgresql"},{"line_number":304,"context_line":"    $ TROVE_DATABASE_BACKUP_IMAGE\u003d${YOUR_REGISTRY_REPO_NAME}/db-backup-${ALT_DATABASE_NAME}:${DATABASE_BACKUP_VERSION}"},{"line_number":305,"context_line":"    $ docker build -t ${TROVE_DATABASE_BACKUP_IMAGE} --build-arg DATASTORE\u003d${ALT_DATABASE_NAME} --build-arg DATASTORE_VERSION\u003d${DATABASE_VERSION} ."},{"line_number":306,"context_line":"    $ docker tag ${TROVE_DATABASE_BACKUP_IMAGE} ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_BACKUP_IMAGE}"},{"line_number":307,"context_line":"    $ docker push ${YOUR_REGISTRY_HTTP_ADDR}/${TROVE_DATABASE_BACKUP_IMAGE}"}],"source_content_type":"text/x-rst","patch_set":22,"id":"4412ea62_523e511b","line":304,"updated":"2023-11-13 02:30:20.000000000","message":"Using  ${DATABASE_VERSION} instead","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":322,"context_line":""},{"line_number":323,"context_line":"      [mysql]"},{"line_number":324,"context_line":"      docker_image \u003d 10.x.y.z:4000/trove-datastores/mysql"},{"line_number":325,"context_line":"      backup_docker_image \u003d 10.x.y.z:4000/trove-datastores/db-backup-mysql:1.1.0"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"      [mariadb]"},{"line_number":328,"context_line":"      docker_image \u003d 10.x.y.z:4000/trove-datastores/mariadb"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3cf23404_a3af0ff2","line":325,"range":{"start_line":325,"start_character":74,"end_line":325,"end_character":80},"updated":"2023-11-13 02:30:20.000000000","message":"Don\u0027t configure 1.1.0 here, trove will use the datastore version as the  backup image tag by default. just configure it like this: 10.x.y.z:4000/trove-datastores/db-backup-mysql","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"      [mariadb]"},{"line_number":328,"context_line":"      docker_image \u003d 10.x.y.z:4000/trove-datastores/mariadb"},{"line_number":329,"context_line":"      backup_docker_image \u003d 10.x.y.z:4000/trove-datastores/db-backup-mariadb:1.2.0"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"      [postgres]"},{"line_number":332,"context_line":"      docker_image \u003d 10.x.y.z:4000/trove-datastores/postgres"}],"source_content_type":"text/x-rst","patch_set":22,"id":"24042eea_f777887a","line":329,"updated":"2023-11-13 02:30:20.000000000","message":"ditto","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"      [postgres]"},{"line_number":332,"context_line":"      docker_image \u003d 10.x.y.z:4000/trove-datastores/postgres"},{"line_number":333,"context_line":"      backup_docker_image \u003d 10.x.y.z:4000/trove-datastores/db-backup-postgresql:1.1.2"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"      [guest_agent]"},{"line_number":336,"context_line":"      container_registry \u003d 10.x.y.z:4000"}],"source_content_type":"text/x-rst","patch_set":22,"id":"c98492b6_f62e940f","line":333,"range":{"start_line":333,"start_character":80,"end_line":333,"end_character":85},"updated":"2023-11-13 02:30:20.000000000","message":"ditto","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b888bd30b57a5c881588956ee6720f5ad4c31663","unresolved":true,"context_lines":[{"line_number":333,"context_line":"      backup_docker_image \u003d 10.x.y.z:4000/trove-datastores/db-backup-postgresql:1.1.2"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"      [guest_agent]"},{"line_number":336,"context_line":"      container_registry \u003d 10.x.y.z:4000"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"e86b0aae_60f7da15","line":336,"updated":"2023-11-13 02:30:20.000000000","message":"if the operator hasn\u0027t configured the Docker registry with authentication, these configuration options can be omitted. If they did, then the operator also needs to configure container_registry_username and container_registry_password.","commit_id":"a28683cea3375011e57951354c08723554d8b7eb"}],"trove/common/cfg.py":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"334ae5397c61cd2cd6f3f5a6bbe3818b474c92e9","unresolved":true,"context_lines":[{"line_number":660,"context_line":"        help\u003d\u0027Database docker image.\u0027"},{"line_number":661,"context_line":"    ),"},{"line_number":662,"context_line":"    cfg.StrOpt("},{"line_number":663,"context_line":"        \u0027backup_docker_image\u0027, default\u003d\u0027your-registry/your-repo/db-backup-mysql:1.1.0\u0027,"},{"line_number":664,"context_line":"        help\u003d\u0027The docker image used for backup and restore. For mysql, \u0027"},{"line_number":665,"context_line":"             \u0027the minor version is added to the image name as a suffix before \u0027"},{"line_number":666,"context_line":"             \u0027creating container, e.g. your-registry/your-repo/db-backup-mysql5.7:1.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"f84e50c3_22186d69","line":663,"in_reply_to":"9e30ff8f_12741f12","updated":"2023-06-29 08:13:06.000000000","message":"\u003e pep8: E501 line too long (87 \u003e 79 characters)\n\nPlease fix.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"3be844b8f6e446d0028a5260d3e7cd913240f37c","unresolved":false,"context_lines":[{"line_number":660,"context_line":"        help\u003d\u0027Database docker image.\u0027"},{"line_number":661,"context_line":"    ),"},{"line_number":662,"context_line":"    cfg.StrOpt("},{"line_number":663,"context_line":"        \u0027backup_docker_image\u0027, default\u003d\u0027your-registry/your-repo/db-backup-mysql:1.1.0\u0027,"},{"line_number":664,"context_line":"        help\u003d\u0027The docker image used for backup and restore. For mysql, \u0027"},{"line_number":665,"context_line":"             \u0027the minor version is added to the image name as a suffix before \u0027"},{"line_number":666,"context_line":"             \u0027creating container, e.g. your-registry/your-repo/db-backup-mysql5.7:1.0.0\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd982310_22b4e530","line":663,"in_reply_to":"f84e50c3_22186d69","updated":"2023-08-04 11:53:56.000000000","message":"Done","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"3be844b8f6e446d0028a5260d3e7cd913240f37c","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        \u0027backup_docker_image\u0027, default\u003d\u0027your-registry/your-repo/db-backup-mysql:1.1.0\u0027,"},{"line_number":664,"context_line":"        help\u003d\u0027The docker image used for backup and restore. For mysql, \u0027"},{"line_number":665,"context_line":"             \u0027the minor version is added to the image name as a suffix before \u0027"},{"line_number":666,"context_line":"             \u0027creating container, e.g. your-registry/your-repo/db-backup-mysql5.7:1.0.0\u0027"},{"line_number":667,"context_line":"    ),"},{"line_number":668,"context_line":"]"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d1e402de_b5644672","line":666,"in_reply_to":"302b72f0_de834460","updated":"2023-08-04 11:53:56.000000000","message":"Done","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"334ae5397c61cd2cd6f3f5a6bbe3818b474c92e9","unresolved":true,"context_lines":[{"line_number":663,"context_line":"        \u0027backup_docker_image\u0027, default\u003d\u0027your-registry/your-repo/db-backup-mysql:1.1.0\u0027,"},{"line_number":664,"context_line":"        help\u003d\u0027The docker image used for backup and restore. For mysql, \u0027"},{"line_number":665,"context_line":"             \u0027the minor version is added to the image name as a suffix before \u0027"},{"line_number":666,"context_line":"             \u0027creating container, e.g. your-registry/your-repo/db-backup-mysql5.7:1.0.0\u0027"},{"line_number":667,"context_line":"    ),"},{"line_number":668,"context_line":"]"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"302b72f0_de834460","line":666,"in_reply_to":"704faa83_31e136d5","updated":"2023-06-29 08:13:06.000000000","message":"\u003e pep8: E501 line too long (88 \u003e 79 characters)\n\nPlease fix.","commit_id":"5de1e0ebc896366060f1a2399886b27f76bc5c1b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"cb843f6ff12760c9fed6e0be5e6ee775b806522d","unresolved":true,"context_lines":[{"line_number":661,"context_line":"    ),"},{"line_number":662,"context_line":"    cfg.StrOpt("},{"line_number":663,"context_line":"        \u0027backup_docker_image\u0027,"},{"line_number":664,"context_line":"        default\u003d\u0027your-registry/your-repo/db-backup-mysql:1.1.0\u0027,"},{"line_number":665,"context_line":"        help\u003d\u0027The docker image used for backup and restore. For mysql, \u0027"},{"line_number":666,"context_line":"             \u0027the minor version is added to the image name as a suffix before \u0027"},{"line_number":667,"context_line":"             \u0027creating container, e.g. \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"115cd169_88d51ee1","line":664,"updated":"2023-08-16 06:13:41.000000000","message":"this default value is still not correct here, I prefer to remove the default value, and add “required” parameters[0] here. Therefore, if this value is not configured by user, oslo.config will raise an exception.\n[0]: https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.Opt","commit_id":"b434fd82111d9f9f24f877e28e3e235a310919c9"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"a3e976bbea8805e14cdbfc7c69201ad4eebf9229","unresolved":false,"context_lines":[{"line_number":661,"context_line":"    ),"},{"line_number":662,"context_line":"    cfg.StrOpt("},{"line_number":663,"context_line":"        \u0027backup_docker_image\u0027,"},{"line_number":664,"context_line":"        default\u003d\u0027your-registry/your-repo/db-backup-mysql:1.1.0\u0027,"},{"line_number":665,"context_line":"        help\u003d\u0027The docker image used for backup and restore. For mysql, \u0027"},{"line_number":666,"context_line":"             \u0027the minor version is added to the image name as a suffix before \u0027"},{"line_number":667,"context_line":"             \u0027creating container, e.g. \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"1e162ab8_f1adc5c2","line":664,"in_reply_to":"115cd169_88d51ee1","updated":"2023-08-16 15:46:26.000000000","message":"Thanks for the comment! I removed \"default\" parameter and added \"sample_default\" parameter instead as \"sample_default\" parameter can lead users to configure \"backup_docker_image\" directive properly. I think \"required\" parameter is not suitable in some case. For example, \u0027backup_docker_image\u0027 directive in \"mysql\" option group is required for MySQL users, but not required for Postgres users.","commit_id":"b434fd82111d9f9f24f877e28e3e235a310919c9"}]}