)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"908c4539f19c1a94cff232fcbc0328ba9adebdb8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Leon \u003csteve.leon@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-22 18:34:51 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add datastore version to backups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icfec975b92cd9523e639ad6a2d6787ee4d4cb39d"},{"line_number":10,"context_line":"Implements: blueprint backup-metadata"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAXH%2F%2FC%2F0%3D","line":7,"updated":"2014-04-24 11:57:37.000000000","message":"Please write full sterling commit description:\n\n - Why is it required?\n - What has been changed?","commit_id":"86e541ceab386c73c12771f5f86214438b5d21d2"}],"trove/backup/models.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"21e2a256cacc9301078318fc1ac21df587c98b3c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                           \u0027backup_type\u0027: db_info.backup_type,"},{"line_number":110,"context_line":"                           \u0027checksum\u0027: db_info.checksum,"},{"line_number":111,"context_line":"                           \u0027parent\u0027: parent,"},{"line_number":112,"context_line":"                           \u0027datastore_version\u0027: ds_version.name,"},{"line_number":113,"context_line":"                           }"},{"line_number":114,"context_line":"            api.API(context).create_backup(backup_info, instance_id)"},{"line_number":115,"context_line":"            return db_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_d4323d5e","line":112,"updated":"2014-06-03 15:59:38.000000000","message":"Why not put the datastore version ID here?","commit_id":"d0a9149053ed2ec93a3897bf1e94697b32c606d2"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"141e9039862dc0dce210c4f5cd07eef511e00da8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                           \u0027backup_type\u0027: db_info.backup_type,"},{"line_number":110,"context_line":"                           \u0027checksum\u0027: db_info.checksum,"},{"line_number":111,"context_line":"                           \u0027parent\u0027: parent,"},{"line_number":112,"context_line":"                           \u0027datastore_version\u0027: ds_version.name,"},{"line_number":113,"context_line":"                           }"},{"line_number":114,"context_line":"            api.API(context).create_backup(backup_info, instance_id)"},{"line_number":115,"context_line":"            return db_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_43b11146","line":112,"in_reply_to":"1ae5cdf2_4df860c3","updated":"2014-06-03 18:42:23.000000000","message":"So I guess my issue then is this is not unique enough, We also need to have the datastore name here, because what if two datastore version\u0027s have the same name? I.e. you have MySQL and Maria datastores both with a datastore version that has the name 5.6.","commit_id":"d0a9149053ed2ec93a3897bf1e94697b32c606d2"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"cb7a67d6038b65351beec5b6db0f41e45927d02c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                           \u0027backup_type\u0027: db_info.backup_type,"},{"line_number":110,"context_line":"                           \u0027checksum\u0027: db_info.checksum,"},{"line_number":111,"context_line":"                           \u0027parent\u0027: parent,"},{"line_number":112,"context_line":"                           \u0027datastore_version\u0027: ds_version.name,"},{"line_number":113,"context_line":"                           }"},{"line_number":114,"context_line":"            api.API(context).create_backup(backup_info, instance_id)"},{"line_number":115,"context_line":"            return db_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_28806245","line":112,"in_reply_to":"1ae5cdf2_4df860c3","updated":"2014-06-03 18:44:10.000000000","message":"The datastore_version.name is not unique (even in the same region). To make the name unique you will need to pass the datastore.name with it. (I\u0027m making the assumption that when the backup lands in another region you would try to find the datastore_version by looking up by name in the trove database. If so, this could return more than one datastore_version)","commit_id":"d0a9149053ed2ec93a3897bf1e94697b32c606d2"},{"author":{"_account_id":11316,"name":"Steve Leon","email":"kokhang@gmail.com","username":"kokhang"},"change_message_id":"c847ab5d436d84cbf865c1e075ac093350b553e3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                           \u0027backup_type\u0027: db_info.backup_type,"},{"line_number":110,"context_line":"                           \u0027checksum\u0027: db_info.checksum,"},{"line_number":111,"context_line":"                           \u0027parent\u0027: parent,"},{"line_number":112,"context_line":"                           \u0027datastore_version\u0027: ds_version.name,"},{"line_number":113,"context_line":"                           }"},{"line_number":114,"context_line":"            api.API(context).create_backup(backup_info, instance_id)"},{"line_number":115,"context_line":"            return db_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_eab4b283","line":112,"in_reply_to":"1ae5cdf2_d4323d5e","updated":"2014-06-03 17:00:23.000000000","message":"This is actually not really needed for this feature. But it was added thinking ahead for the cross-region backup. The reason I added the name was because the ID is not unique among regions. So if a backup is created and copied to a different region, the datastore version can be obtained by the name and not by the ID.","commit_id":"d0a9149053ed2ec93a3897bf1e94697b32c606d2"},{"author":{"_account_id":11316,"name":"Steve Leon","email":"kokhang@gmail.com","username":"kokhang"},"change_message_id":"44727773312b80d092ec233e118f0f02f41ff19a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                           \u0027backup_type\u0027: db_info.backup_type,"},{"line_number":110,"context_line":"                           \u0027checksum\u0027: db_info.checksum,"},{"line_number":111,"context_line":"                           \u0027parent\u0027: parent,"},{"line_number":112,"context_line":"                           \u0027datastore_version\u0027: ds_version.name,"},{"line_number":113,"context_line":"                           }"},{"line_number":114,"context_line":"            api.API(context).create_backup(backup_info, instance_id)"},{"line_number":115,"context_line":"            return db_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_4df860c3","line":112,"in_reply_to":"1ae5cdf2_eab4b283","updated":"2014-06-03 17:17:47.000000000","message":"What i meant to say is that the ID is different between regions. But the name is the same across regions.","commit_id":"d0a9149053ed2ec93a3897bf1e94697b32c606d2"}],"trove/backup/service.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"763eb0af2155becd8b90c6126ff1702cc93185c9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        LOG.debug(\"Listing Backups for tenant \u0027%s\u0027\" % tenant_id)"},{"line_number":40,"context_line":"        filter_opts \u003d {}"},{"line_number":41,"context_line":"        filter_opts.update(req.GET)"},{"line_number":42,"context_line":"        datastore \u003d filter_opts.pop(\u0027datastore\u0027, None)"},{"line_number":43,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":44,"context_line":"        backups, marker \u003d Backup.list(context, datastore)"},{"line_number":45,"context_line":"        view \u003d views.BackupViews(backups)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_5f877d0f","line":42,"updated":"2014-05-22 05:02:14.000000000","message":"could you just do\n\n  datastore \u003d req.GET.get(\u0027datastore\u0027)","commit_id":"f57d93b12ecb81f6d48ef0bc35c5f48852873c68"}],"trove/backup/views.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"7c1a37d41d1227f1d6c277ee9fb3442319f8b87a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        if self.backup.datastore_version_id:"},{"line_number":38,"context_line":"            result[\u0027backup\u0027][\u0027datastore\u0027] \u003d {"},{"line_number":39,"context_line":"                \"type\": self.backup.datastore.name,"},{"line_number":40,"context_line":"                \"version\": self.backup.datastore_version.name"},{"line_number":41,"context_line":"            }"},{"line_number":42,"context_line":"        return result"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1ae5cdf2_c9634d40","line":40,"updated":"2014-06-04 23:22:18.000000000","message":"Please add the datastore_version.id here as well.","commit_id":"dab365d79186e6f7d88c234a72f4c7e4b74983ad"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"c1ce3f4ddfdf854aa7898ebcadebfa3f56c3f0e8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        if self.backup.datastore_version_id:"},{"line_number":38,"context_line":"            result[\u0027backup\u0027][\u0027datastore\u0027] \u003d {"},{"line_number":39,"context_line":"                \"type\": self.backup.datastore.name,"},{"line_number":40,"context_line":"                \"datastore\": self.backup.datastore.name,"},{"line_number":41,"context_line":"                \"version\": self.backup.datastore_version.name"},{"line_number":42,"context_line":"            }"},{"line_number":43,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":14,"id":"1ae5cdf2_6f6d3032","line":40,"updated":"2014-06-10 17:26:01.000000000","message":"Isn\u0027t this duplicating the \"type\"? \n\nAlso, where is the datastore_verision id?","commit_id":"8ffead111f07cd85987cbbd22fb0e749bfe08b48"}]}