)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"69c4b50ba09022b787655978b4b117571f538cc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf2dddde_514893a0","updated":"2024-01-10 06:26:53.000000000","message":"Hello Bo, could you help to review this patch?","commit_id":"9d31e46f00e5f07ef0f603469dbda98f0196aa14"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"33ba4497fe4a90abc2c57a758b27a64c63df9512","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5397c99_ef9397f6","updated":"2024-01-11 03:26:26.000000000","message":"as we already support cinder volume as instance root disk. so this patch should make the instance recovered from a evacuation quickly.","commit_id":"9d31e46f00e5f07ef0f603469dbda98f0196aa14"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"a5ca9fe5f05c190f0dc5a97d3dc2a90c3081f167","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c571d7d1_d9febf20","updated":"2024-01-19 01:04:18.000000000","message":"recheck","commit_id":"9d31e46f00e5f07ef0f603469dbda98f0196aa14"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"65def49cdc85c6e3245b5a5985d0c293eb4f5302","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b0ca2cc7_497d83b6","updated":"2024-01-09 02:48:18.000000000","message":"recheck swift error","commit_id":"9d31e46f00e5f07ef0f603469dbda98f0196aa14"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"c7570e5bd531a32f78b39613e6870bec744a19ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4a0fd41_ae4831ec","in_reply_to":"c5397c99_ef9397f6","updated":"2024-01-12 07:23:23.000000000","message":"yeah. I haven\u0027t more comment.","commit_id":"9d31e46f00e5f07ef0f603469dbda98f0196aa14"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"ad85316274a256fac3d0feb82c5c9fec92c18812","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0d51b9c9_b093fc56","in_reply_to":"cf2dddde_514893a0","updated":"2024-01-11 02:18:21.000000000","message":"I had run my code like this, it\u0027s ok.\n\nHowever, I also meet this problem (not permission) for data folders, other datastores and I don\u0027t think this is problem I need handle in my environment.\n\nSo, If we need handle this problem, I think we can do that in: https://github.com/openstack/trove/blob/master/trove/cmd/guest.py#L77 or maybe change socket path in config template to save socket in mount_point\u0027s folders.","commit_id":"9d31e46f00e5f07ef0f603469dbda98f0196aa14"}],"trove/common/constants.py":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"ad85316274a256fac3d0feb82c5c9fec92c18812","unresolved":true,"context_lines":[{"line_number":18,"context_line":"DOCKER_NETWORK_NAME \u003d \"database-network\""},{"line_number":19,"context_line":"DOCKER_HOST_NIC_MODE \u003d \"docker-hostnic\""},{"line_number":20,"context_line":"DOCKER_BRIDGE_MODE \u003d \"bridge\""},{"line_number":21,"context_line":"MYSQL_HOST_SOCKET_PATH \u003d \"/var/lib/mysqld\""}],"source_content_type":"text/x-python","patch_set":2,"id":"213f13d3_99095b92","line":21,"range":{"start_line":21,"start_character":26,"end_line":21,"end_character":41},"updated":"2024-01-11 02:18:21.000000000","message":"I think this path should/ can be \"\u003cmount_point\u003e/data\" or \"\u003cmount_point\u003e/run\".\nWe need just change config template.","commit_id":"9d31e46f00e5f07ef0f603469dbda98f0196aa14"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"edade7b94507fd45ac5a6710dda7aa06401029ea","unresolved":true,"context_lines":[{"line_number":18,"context_line":"DOCKER_NETWORK_NAME \u003d \"database-network\""},{"line_number":19,"context_line":"DOCKER_HOST_NIC_MODE \u003d \"docker-hostnic\""},{"line_number":20,"context_line":"DOCKER_BRIDGE_MODE \u003d \"bridge\""},{"line_number":21,"context_line":"MYSQL_HOST_SOCKET_PATH \u003d \"/var/lib/mysqld\""}],"source_content_type":"text/x-python","patch_set":2,"id":"a31789b6_d179e767","line":21,"range":{"start_line":21,"start_character":26,"end_line":21,"end_character":41},"in_reply_to":"213f13d3_99095b92","updated":"2024-01-11 03:20:46.000000000","message":"The config opt in config template controls the path inside the container（/var/run/mysqld）. however, this controls the mapped path in the host(/var/lib/mysqld).\nAs we use hard code here[0], so we should not allow user to change path in config template theoretically. \n\nI don\u0027t know why you don\u0027t need to handle this.\nAssuming that your host was shutdown by accident, the Cloud operator should evacuate all VMs on that host. if there is a trove instance on that host. then it should be evacuated to other host and rebooted by nova. in this case, the trove instance can\u0027t recover from the reboot. Cloud operator has to\nexecute \"openstack database instance reboot\" command one by one. \nthis is not what we expected.\n\nThis patch only handles mysql datastore. the postgresql will be done in another patch.\n\n[0]: https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/mysql_common/manager.py#L118","commit_id":"9d31e46f00e5f07ef0f603469dbda98f0196aa14"}]}