)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"26d5141bf2de242d4cee78c959e068df70c778a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a831bb36_6ee76b82","updated":"2024-03-20 01:30:23.000000000","message":"hello Takashi, could you help to review this patch? I add the commit action manually in this patch.","commit_id":"ab83ad7c8567dc33664f9bbcd521beda225a181a"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"f780e1196fcebd5af61ebaac07de3c122bd7b490","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"34e209da_986c1040","updated":"2024-03-20 05:29:16.000000000","message":"merge this one for RC1 release.","commit_id":"ab83ad7c8567dc33664f9bbcd521beda225a181a"}],"trove/db/sqlalchemy/session.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5fc233bc5e906d8408044b041a64bb91e21fed29","unresolved":true,"context_lines":[{"line_number":72,"context_line":"def _create_facade(options):"},{"line_number":73,"context_line":"    global _FACADE"},{"line_number":74,"context_line":"    if _FACADE is None:"},{"line_number":75,"context_line":"        _FACADE \u003d db_session.EngineFacade.from_config(options)"},{"line_number":76,"context_line":"    return _FACADE"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"925c42ae_7195ccfc","line":75,"range":{"start_line":75,"start_character":18,"end_line":75,"end_character":62},"updated":"2024-03-14 05:29:02.000000000","message":"IIUC to remove autocommit you have to make sure all update queries are executed within an explicit session (under with session.begin() )","commit_id":"e8b0f57bc0548be73cb2f6c711adf56e344b3584"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"f10174f3eb02604268298e54d8eb5c4ceeb6c7f3","unresolved":true,"context_lines":[{"line_number":72,"context_line":"def _create_facade(options):"},{"line_number":73,"context_line":"    global _FACADE"},{"line_number":74,"context_line":"    if _FACADE is None:"},{"line_number":75,"context_line":"        _FACADE \u003d db_session.EngineFacade.from_config(options)"},{"line_number":76,"context_line":"    return _FACADE"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f758f14e_1753405d","line":75,"range":{"start_line":75,"start_character":18,"end_line":75,"end_character":62},"in_reply_to":"925c42ae_7195ccfc","updated":"2024-03-14 07:21:58.000000000","message":"thanks for your help. i will check that.","commit_id":"e8b0f57bc0548be73cb2f6c711adf56e344b3584"}]}
