)]}'
{"trove/instance/models.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"f6d8a85e609c08910aad6384d00530634cf7b6ed","unresolved":false,"context_lines":[{"line_number":845,"context_line":"            LOG.debug(_(\"configuration being detached; \""},{"line_number":846,"context_line":"                        \"marking restart required\"))"},{"line_number":847,"context_line":"            self.update_db(task_status\u003dInstanceTasks.RESTART_REQUIRED)"},{"line_number":848,"context_line":"            # This wasn\u0027t changed to detach_configuration because that change"},{"line_number":849,"context_line":"            # would break backward compat of the task manager"},{"line_number":850,"context_line":"            task_api.API(self.context).unassign_configuration(self.id,"},{"line_number":851,"context_line":"                                                              flavor,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_2d013205","line":848,"updated":"2014-05-19 00:12:11.000000000","message":"Could you please say unassigned_configuration instead of This?(for clarity)","commit_id":"f10dad8ea2662cdf32e969f7662984b14b389b1d"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"479821d7cc78adc92a23876b22a28a745a29c97f","unresolved":false,"context_lines":[{"line_number":845,"context_line":"            LOG.debug(_(\"configuration being detached; \""},{"line_number":846,"context_line":"                        \"marking restart required\"))"},{"line_number":847,"context_line":"            self.update_db(task_status\u003dInstanceTasks.RESTART_REQUIRED)"},{"line_number":848,"context_line":"            # This wasn\u0027t changed to detach_configuration because that change"},{"line_number":849,"context_line":"            # would break backward compat of the task manager"},{"line_number":850,"context_line":"            task_api.API(self.context).unassign_configuration(self.id,"},{"line_number":851,"context_line":"                                                              flavor,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_0a7a6723","line":848,"updated":"2014-05-19 15:18:14.000000000","message":"Thanks for all the changes Doug! Sorry I guess I forgot to point out the comment here.","commit_id":"6bbd23fcfdc54263eaf6a9af1cf3cea7418c838e"}],"trove/taskmanager/api.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"f6d8a85e609c08910aad6384d00530634cf7b6ed","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                instance_id\u003dinstance_id,"},{"line_number":133,"context_line":"                                overrides\u003doverrides))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # This wasn\u0027t changed to detach_configuration because that change"},{"line_number":136,"context_line":"    # would break backward compat of the task manager"},{"line_number":137,"context_line":"    def unassign_configuration(self, instance_id, flavor, configuration_id):"},{"line_number":138,"context_line":"        LOG.debug(_(\"Making async call to detach configuration for \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_4d067e1e","line":135,"updated":"2014-05-19 00:12:11.000000000","message":"same here","commit_id":"f10dad8ea2662cdf32e969f7662984b14b389b1d"}],"trove/taskmanager/manager.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"f6d8a85e609c08910aad6384d00530634cf7b6ed","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def detach_configuration(self, context, instance_id, flavor,"},{"line_number":97,"context_line":"                             configuration_id):"},{"line_number":98,"context_line":"        instance_tasks \u003d models.BuiltInstanceTasks.load(context, instance_id)"},{"line_number":99,"context_line":"        # This wasn\u0027t changed to detach_configuration because that change"},{"line_number":100,"context_line":"        # would break backward compat of the task manager"},{"line_number":101,"context_line":"        instance_tasks.unassign_configuration(flavor, configuration_id)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_6d07ba18","line":99,"updated":"2014-05-19 00:12:11.000000000","message":"same here","commit_id":"f10dad8ea2662cdf32e969f7662984b14b389b1d"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"50069dc74ecd3fb95c05cad47cfebc85781083d9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        instance_tasks \u003d models.BuiltInstanceTasks.load(context, instance_id)"},{"line_number":94,"context_line":"        instance_tasks.update_overrides(overrides)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def detach_configuration(self, context, instance_id, flavor,"},{"line_number":97,"context_line":"                             configuration_id):"},{"line_number":98,"context_line":"        instance_tasks \u003d models.BuiltInstanceTasks.load(context, instance_id)"},{"line_number":99,"context_line":"        # unassign_configuration wasn\u0027t changed to detach_configuration because"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_6081184d","line":96,"updated":"2014-05-21 07:00:26.000000000","message":"This call forms part of the Taskmanager RPC API contract, and should NOT be renamed.","commit_id":"6bbd23fcfdc54263eaf6a9af1cf3cea7418c838e"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"50069dc74ecd3fb95c05cad47cfebc85781083d9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        instance_tasks \u003d models.BuiltInstanceTasks.load(context, instance_id)"},{"line_number":99,"context_line":"        # unassign_configuration wasn\u0027t changed to detach_configuration because"},{"line_number":100,"context_line":"        # that would break backward compat of the task manager"},{"line_number":101,"context_line":"        instance_tasks.unassign_configuration(flavor, configuration_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    if CONF.exists_notification_transformer:"},{"line_number":104,"context_line":"        @periodic_task.periodic_task("}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_e094488e","line":101,"updated":"2014-05-21 07:00:26.000000000","message":"unassign_configuration here can be safely changed to detach_configuration since this is an internal call to taskmanager.models.","commit_id":"6bbd23fcfdc54263eaf6a9af1cf3cea7418c838e"}],"trove/taskmanager/models.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"50069dc74ecd3fb95c05cad47cfebc85781083d9","unresolved":false,"context_lines":[{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    # unassign_configuration wasn\u0027t changed to detach_configuration because"},{"line_number":840,"context_line":"    # that would break backward compat of the task manager"},{"line_number":841,"context_line":"    def unassign_configuration(self, flavor, configuration_id):"},{"line_number":842,"context_line":"        LOG.debug(_(\u0027Detaching the configuration (id: %(config_id)s)\u0027"},{"line_number":843,"context_line":"                    \u0027 from the instance %(instance_id)s\u0027) %"},{"line_number":844,"context_line":"                  {\u0027config_id\u0027: self.configuration.id, \u0027instance_id\u0027: self.id})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_405edc13","line":841,"updated":"2014-05-21 07:00:26.000000000","message":"unassign_configuration here can be safely changed to detach_configuration since this is an internal call to taskmanager.models.","commit_id":"6bbd23fcfdc54263eaf6a9af1cf3cea7418c838e"}]}
