)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4c3f9df5a6ce4eb666b1eee93e9188ff4a3093b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"adding a description to the configuration datastore parameters"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"partially implements: add-descriptions-to-config-parameters-api"},{"line_number":12,"context_line":"Change-Id: Ibd8f9b00b557d168b11d239f81e64933b8b3b487"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_26900e95","line":11,"updated":"2014-04-30 15:06:30.000000000","message":"didnt link correctly","commit_id":"0bfdb2fdca35403f30d4f73e74c191b6e58b683a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b565f04b2fcd0e442a46f1b5e8f426a814bf713f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"adding a description to the configuration datastore parameters"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"partially implements: add-descriptions-to-config-parameters-api"},{"line_number":12,"context_line":"Change-Id: Ibd8f9b00b557d168b11d239f81e64933b8b3b487"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ae8d1ca_52d74723","line":11,"in_reply_to":"9ad9bd40_26900e95","updated":"2014-05-29 08:27:30.000000000","message":"You need bp / blueprint in the message for it to link correctly.","commit_id":"0bfdb2fdca35403f30d4f73e74c191b6e58b683a"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1d37f68a5fbf7b5b78fc19c72bb79bd55c5f4b45","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Craig Vyvial \u003ccp16net@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-20 05:22:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configuration datastore paramters description"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"adding a description to the configuration datastore parameters"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_9cfeb368","line":7,"updated":"2014-06-21 11:20:31.000000000","message":"parameters (sp?)","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"10b2761495edcfcf17ac86474d45e7f7a9a852d0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"adding a description to the configuration datastore parameters"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"partially implements blueprint add-descriptions-to-config-parameters-api"},{"line_number":12,"context_line":"Change-Id: Ibd8f9b00b557d168b11d239f81e64933b8b3b487"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_90d78622","line":11,"updated":"2014-06-20 16:25:53.000000000","message":"missing :  here","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1d37f68a5fbf7b5b78fc19c72bb79bd55c5f4b45","unresolved":false,"context_lines":[{"line_number":9,"context_line":"adding a description to the configuration datastore parameters"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"partially implements blueprint add-descriptions-to-config-parameters-api"},{"line_number":12,"context_line":"Change-Id: Ibd8f9b00b557d168b11d239f81e64933b8b3b487"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_7cfba77a","line":12,"updated":"2014-06-21 11:20:31.000000000","message":"stick a newline on this file please.","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"}],"trove/db/sqlalchemy/migrate_repo/versions/027_configuration_parameter_datastore_description.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1d37f68a5fbf7b5b78fc19c72bb79bd55c5f4b45","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    # add column:"},{"line_number":28,"context_line":"    backups \u003d Table(\u0027datastore_configuration_parameters\u0027, meta, autoload\u003dTrue)"},{"line_number":29,"context_line":"    backups.create_column(Column(\u0027description\u0027, String(255), nullable\u003dTrue))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_dcf3db9c","line":28,"updated":"2014-06-21 11:20:31.000000000","message":"I agree with doug, the name is confusing. I\u0027m suspecting that this is a copy and paste from a previous migration script ;)","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"026bbec030866c96d80fa33ac8ccaf46afcd4ada","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    # add column:"},{"line_number":28,"context_line":"    backups \u003d Table(\u0027datastore_configuration_parameters\u0027, meta, autoload\u003dTrue)"},{"line_number":29,"context_line":"    backups.create_column(Column(\u0027description\u0027, String(255), nullable\u003dTrue))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4d1c8e13","line":28,"updated":"2014-06-20 13:30:19.000000000","message":"minor point - Why is this called \u0027backups\u0027? Would something like ds_cfg_params be better?","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1d37f68a5fbf7b5b78fc19c72bb79bd55c5f4b45","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # drop column:"},{"line_number":37,"context_line":"    backups \u003d Table(\u0027datastore_configuration_parameters\u0027, meta, autoload\u003dTrue)"},{"line_number":38,"context_line":"    backups.drop_column(\u0027description\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_1ceaa39f","line":37,"updated":"2014-06-21 11:20:31.000000000","message":"same as above.","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"}],"trove/extensions/mgmt/configuration/service.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"10b2761495edcfcf17ac86474d45e7f7a9a852d0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if \u0027min_size\u0027 in parameter:"},{"line_number":88,"context_line":"            min_size \u003d int(parameter[\u0027min_size\u0027])"},{"line_number":89,"context_line":"        if \u0027description\u0027 in parameter:"},{"line_number":90,"context_line":"            min_size \u003d parameter[\u0027description\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        datastore_version \u003d ds_models.DatastoreVersion.load_by_uuid(version_id)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_0d08c12b","line":90,"updated":"2014-06-20 16:25:53.000000000","message":"Shouldnt this be a different variable name - like description?","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1d37f68a5fbf7b5b78fc19c72bb79bd55c5f4b45","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if \u0027min_size\u0027 in parameter:"},{"line_number":88,"context_line":"            min_size \u003d int(parameter[\u0027min_size\u0027])"},{"line_number":89,"context_line":"        if \u0027description\u0027 in parameter:"},{"line_number":90,"context_line":"            min_size \u003d parameter[\u0027description\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        datastore_version \u003d ds_models.DatastoreVersion.load_by_uuid(version_id)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7c32c75e","line":90,"updated":"2014-06-21 11:20:31.000000000","message":"actually, this is an error. I believe this is a copy of the previous line.","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"}],"trove/templates/mysql/validation-rules.json":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"026bbec030866c96d80fa33ac8ccaf46afcd4ada","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"max\": 1,"},{"line_number":7,"context_line":"            \"min\": 0,"},{"line_number":8,"context_line":"            \"type\": \"integer\","},{"line_number":9,"context_line":"            \"description\": \"innodb_file_per_table\""},{"line_number":10,"context_line":"        },"},{"line_number":11,"context_line":"        {"},{"line_number":12,"context_line":"            \"name\": \"autocommit\","}],"source_content_type":"application/json","patch_set":2,"id":"1ae5cdf2_0dde063e","line":9,"updated":"2014-06-20 13:30:19.000000000","message":"What is the expectation as to who is supposed to fill in the \"correct\" values for these descriptions?","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1d37f68a5fbf7b5b78fc19c72bb79bd55c5f4b45","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"max\": 1,"},{"line_number":15,"context_line":"            \"min\": 0,"},{"line_number":16,"context_line":"            \"type\": \"integer\","},{"line_number":17,"context_line":"            \"description\": \"autocommit\""},{"line_number":18,"context_line":"        },"},{"line_number":19,"context_line":"        {"},{"line_number":20,"context_line":"            \"name\": \"local_infile\","}],"source_content_type":"application/json","patch_set":2,"id":"1ae5cdf2_9c35d346","line":17,"updated":"2014-06-21 11:20:31.000000000","message":"As implemented here, the description is the same as the name. I would prefer to see this code simplified in such a way that the default value for the description is the name and eliminate this set of changes.","commit_id":"e5b0b5e18a07a63c7a54616cff5708388828a99c"}]}