)]}'
{"trove/datastore/models.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1a7bf23dcb6678220f96529330720e1aaa9114bb","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    def load_all(cls, only_active\u003dTrue):"},{"line_number":168,"context_line":"        if only_active:"},{"line_number":169,"context_line":"            return cls(DBDatastoreVersion.find_all(active\u003dTrue))"},{"line_number":170,"context_line":"        return cls(DBDatastoreVersion.find_all())"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def __iter__(self):"},{"line_number":173,"context_line":"        for item in self.db_info:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_db0e5434","line":170,"updated":"2014-05-30 15:39:43.000000000","message":"Couldn\u0027t the three previous lines be reduced to:\n\n    return cls(DBDatastoreVersion.find_all(active\u003donly_active))\n\nJust a thought ...","commit_id":"b0941e8d05420240ffa0002e8898f2afff92dd41"}],"trove/datastore/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a0d5676ddb5061e610ffc61f3871eb410202a63d","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def show(self, req, tenant_id, id):"},{"line_number":26,"context_line":"        datastore \u003d models.Datastore.load(id)"},{"line_number":27,"context_line":"        datastore_versions \u003d (models.DatastoreVersions.load(datastore.id))"},{"line_number":28,"context_line":"        return wsgi.Result(views."},{"line_number":29,"context_line":"                           DatastoreView(datastore, datastore_versions,"},{"line_number":30,"context_line":"                           req).data(), 200)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_80829d50","line":27,"range":{"start_line":27,"start_character":70,"end_line":27,"end_character":72},"updated":"2014-05-30 15:17:02.000000000","message":"do we need additional () ?","commit_id":"b0941e8d05420240ffa0002e8898f2afff92dd41"}],"trove/datastore/views.py":[{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"83701727694de2ee80a13cbd409f18a7a9525c76","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":29,"context_line":"        only_active \u003d True"},{"line_number":30,"context_line":"        if context.is_admin:"},{"line_number":31,"context_line":"            only_active \u003d False"},{"line_number":32,"context_line":"        self.datastore_versions \u003d models.DatastoreVersions.load(self.datastore.id,"},{"line_number":33,"context_line":"                                                                only_active)"},{"line_number":34,"context_line":"        self.req \u003d req"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_4547a31f","line":31,"updated":"2014-05-02 01:11:11.000000000","message":"A minor suggestion could be to just do this maybe?\n\nonly_active \u003d not context.is_admin","commit_id":"b8f3403ea6fbf89a3609b0dde7a4382d6c01ae68"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"ef23a6fc9e3272ecd22084a8e14d3f6572b811ea","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":29,"context_line":"        only_active \u003d True"},{"line_number":30,"context_line":"        if context.is_admin:"},{"line_number":31,"context_line":"            only_active \u003d False"},{"line_number":32,"context_line":"        self.datastore_versions \u003d models.DatastoreVersions.load(self.datastore.id,"},{"line_number":33,"context_line":"                                                                only_active)"},{"line_number":34,"context_line":"        self.req \u003d req"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_f626a115","line":31,"in_reply_to":"9ad9bd40_16e30506","updated":"2014-05-02 15:57:41.000000000","message":"Sure, yeah I can make this change.","commit_id":"b8f3403ea6fbf89a3609b0dde7a4382d6c01ae68"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"0ec4a04cfbaf4bae05853bdff7a8c3ca4f08209b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":29,"context_line":"        only_active \u003d True"},{"line_number":30,"context_line":"        if context.is_admin:"},{"line_number":31,"context_line":"            only_active \u003d False"},{"line_number":32,"context_line":"        self.datastore_versions \u003d models.DatastoreVersions.load(self.datastore.id,"},{"line_number":33,"context_line":"                                                                only_active)"},{"line_number":34,"context_line":"        self.req \u003d req"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_16e30506","line":31,"in_reply_to":"9ad9bd40_4547a31f","updated":"2014-05-02 15:50:28.000000000","message":"i thought about that as well but i was ok with this because its a little more clear because then you could say this as well.\n\n    self.datastore_versions \u003d models.DatastoreVersions.load(self.datastore.id, not context.admin)\n\nLeaving it the way it is or making the change would be fine. I think thats a personal choice.\n\nI am good with your suggestion Dan.","commit_id":"b8f3403ea6fbf89a3609b0dde7a4382d6c01ae68"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"83701727694de2ee80a13cbd409f18a7a9525c76","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        for datastore_version in self.datastore_versions:"},{"line_number":108,"context_line":"            data.append(self."},{"line_number":109,"context_line":"                        data_for_datastore_version(datastore_version,"},{"line_number":110,"context_line":"                                                   include_datastore_id))"},{"line_number":111,"context_line":"        return {\u0027versions\u0027: data}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def data_for_datastore_version(self, datastore_version, include_datastore_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_85ad2b34","line":110,"updated":"2014-05-02 01:11:11.000000000","message":"You could use a list comprehension here instead of building a new list the long way.","commit_id":"b8f3403ea6fbf89a3609b0dde7a4382d6c01ae68"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"0ec4a04cfbaf4bae05853bdff7a8c3ca4f08209b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        for datastore_version in self.datastore_versions:"},{"line_number":108,"context_line":"            data.append(self."},{"line_number":109,"context_line":"                        data_for_datastore_version(datastore_version,"},{"line_number":110,"context_line":"                                                   include_datastore_id))"},{"line_number":111,"context_line":"        return {\u0027versions\u0027: data}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def data_for_datastore_version(self, datastore_version, include_datastore_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_d69d1d5b","line":110,"in_reply_to":"9ad9bd40_85ad2b34","updated":"2014-05-02 15:50:28.000000000","message":"Yeah you could but i might make it look like a long one liner.","commit_id":"b8f3403ea6fbf89a3609b0dde7a4382d6c01ae68"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"ef23a6fc9e3272ecd22084a8e14d3f6572b811ea","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        for datastore_version in self.datastore_versions:"},{"line_number":108,"context_line":"            data.append(self."},{"line_number":109,"context_line":"                        data_for_datastore_version(datastore_version,"},{"line_number":110,"context_line":"                                                   include_datastore_id))"},{"line_number":111,"context_line":"        return {\u0027versions\u0027: data}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def data_for_datastore_version(self, datastore_version, include_datastore_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_564aedac","line":110,"in_reply_to":"9ad9bd40_d69d1d5b","updated":"2014-05-02 15:57:41.000000000","message":"Yeah I thought about the list comprehension and the variable and fn names are really long. This looks more readable. Any thoughts?","commit_id":"b8f3403ea6fbf89a3609b0dde7a4382d6c01ae68"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"dd7892df8f554e5cc2e92e5aa7f6c1627d5b4d1e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":29,"context_line":"        only_active \u003d not context.is_admin"},{"line_number":30,"context_line":"        self.datastore_versions \u003d (models.DatastoreVersions."},{"line_number":31,"context_line":"                                   load(self.datastore.id, only_active))"},{"line_number":32,"context_line":"        self.req \u003d req"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def data(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_5ff2289b","line":31,"updated":"2014-05-08 18:58:25.000000000","message":"It seems we\u0027re breaking MVC a bit here.  Instead of accessing the model directly from the View, this would be better if we passed in the datastore_versions to this view.","commit_id":"463f7d41ee9610ffd604f56645fec2dd7060fd79"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"3f9f365ac5003ca7156089d2129114d6caa6b306","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":29,"context_line":"        only_active \u003d not context.is_admin"},{"line_number":30,"context_line":"        self.datastore_versions \u003d (models.DatastoreVersions."},{"line_number":31,"context_line":"                                   load(self.datastore.id, only_active))"},{"line_number":32,"context_line":"        self.req \u003d req"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def data(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_96c49293","line":31,"in_reply_to":"7adec928_5ff2289b","updated":"2014-05-09 01:08:13.000000000","message":"agreed.","commit_id":"463f7d41ee9610ffd604f56645fec2dd7060fd79"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"f05dcc8fbb306f5ca506a1d6102a2ed8d1b8087a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":29,"context_line":"        only_active \u003d not context.is_admin"},{"line_number":30,"context_line":"        self.datastore_versions \u003d (models.DatastoreVersions."},{"line_number":31,"context_line":"                                   load(self.datastore.id, only_active))"},{"line_number":32,"context_line":"        self.req \u003d req"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def data(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_b62a602a","line":31,"in_reply_to":"7adec928_96c49293","updated":"2014-05-09 16:27:43.000000000","message":"Good point. Will do.","commit_id":"463f7d41ee9610ffd604f56645fec2dd7060fd79"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"62960a9a3676e0d0658015a888d403c122ce0a5d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        context \u003d req.environ[wsgi.CONTEXT_KEY]"},{"line_number":29,"context_line":"        only_active \u003d not context.is_admin"},{"line_number":30,"context_line":"        self.datastore_versions \u003d (models.DatastoreVersions."},{"line_number":31,"context_line":"                                   load(self.datastore.id, only_active))"},{"line_number":32,"context_line":"        self.req \u003d req"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def data(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_a06195aa","line":31,"in_reply_to":"7adec928_b62a602a","updated":"2014-05-19 14:51:15.000000000","message":"Hey so according to http://msdn.microsoft.com/en-us/library/ff649643.aspx it looks like it is ok for the view to access the models . Any thoughts?\n\nBut moved it out of here in the next patch anyways.","commit_id":"463f7d41ee9610ffd604f56645fec2dd7060fd79"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"d79bdb0cfdceda01bb0409333073efae0d14b1b9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        data \u003d []"},{"line_number":60,"context_line":"        for datastore in self.datastores:"},{"line_number":61,"context_line":"            datastore_versions \u003d (models.DatastoreVersions."},{"line_number":62,"context_line":"                                  load(datastore.id, self.only_active))"},{"line_number":63,"context_line":"            data.append(self.data_for_datastore(datastore, datastore_versions))"},{"line_number":64,"context_line":"        return {\u0027datastores\u0027: data}"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7adec928_d2a3a64d","line":62,"updated":"2014-05-21 06:02:18.000000000","message":"umm i think you did the same thing again that vipul mentioned here. breaking mvc.","commit_id":"a0f190ff5d5a826631b9df3edf8f69681eba689d"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"6205d4ec5bc6d6202cd2d28eee46c4b2c10082f9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        data \u003d []"},{"line_number":60,"context_line":"        for datastore in self.datastores:"},{"line_number":61,"context_line":"            datastore_versions \u003d (models.DatastoreVersions."},{"line_number":62,"context_line":"                                  load(datastore.id, self.only_active))"},{"line_number":63,"context_line":"            data.append(self.data_for_datastore(datastore, datastore_versions))"},{"line_number":64,"context_line":"        return {\u0027datastores\u0027: data}"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7adec928_2488c821","line":62,"in_reply_to":"7adec928_d2a3a64d","updated":"2014-05-22 20:16:37.000000000","message":"Yea this would ideally be another place where datastore_versions could be passed in.","commit_id":"a0f190ff5d5a826631b9df3edf8f69681eba689d"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"9d7ca720434740c8c14e75c545ce2864606287d2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.datastores \u003d datastores"},{"line_number":53,"context_line":"        self.datastores_versions \u003d datastores_versions"},{"line_number":54,"context_line":"        self.req \u003d req"},{"line_number":55,"context_line":"        context \u003d self.req.environ[wsgi.CONTEXT_KEY]"},{"line_number":56,"context_line":"        self.only_active \u003d not context.is_admin"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def data(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ae8d1ca_3eb1938f","line":55,"updated":"2014-05-29 18:44:31.000000000","message":"Why is req still defaulted to None if it\u0027s checked for an attribute here?","commit_id":"aec7d26afdf86e73de25ebe28ad06fa755e50f82"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"1e9b537baa4323f57295533397d009f94685e36b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.datastores \u003d datastores"},{"line_number":53,"context_line":"        self.datastores_versions \u003d datastores_versions"},{"line_number":54,"context_line":"        self.req \u003d req"},{"line_number":55,"context_line":"        context \u003d self.req.environ[wsgi.CONTEXT_KEY]"},{"line_number":56,"context_line":"        self.only_active \u003d not context.is_admin"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def data(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ae8d1ca_99680189","line":55,"in_reply_to":"3ae8d1ca_3eb1938f","updated":"2014-05-29 18:48:42.000000000","message":"good catch, This was done prior to changing the models patch. will remove it.","commit_id":"aec7d26afdf86e73de25ebe28ad06fa755e50f82"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a0d5676ddb5061e610ffc61f3871eb410202a63d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            \"links\": self._build_links(),"},{"line_number":35,"context_line":"        }"},{"line_number":36,"context_line":"        datastore_dict.update(DatastoreVersionsView(self.datastore_versions,"},{"line_number":37,"context_line":"                                                    self.req).data(False))"},{"line_number":38,"context_line":"        default_version \u003d self.datastore.default_version_id"},{"line_number":39,"context_line":"        if default_version:"},{"line_number":40,"context_line":"            datastore_dict[\"default_version\"] \u003d default_version"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_e0f8c1e7","line":37,"updated":"2014-05-30 15:17:02.000000000","message":"include_datastore_id\u003dFalse - would be more verbose","commit_id":"b0941e8d05420240ffa0002e8898f2afff92dd41"}]}