)]}'
{"trove/tests/api/instances.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"aa93e655b8054eef745c5ddb549baf4794ff1960","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"                result \u003d dbaas.instances.get(instance_info.id)"},{"line_number":1103,"context_line":"                assert_equal(200, dbaas.last_http_code)"},{"line_number":1104,"context_line":"                assert_equal(\"SHUTDOWN\", result.status)"},{"line_number":1105,"context_line":"                time.sleep(1)"},{"line_number":1106,"context_line":"        except exceptions.NotFound:"},{"line_number":1107,"context_line":"            pass"},{"line_number":1108,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_688cac36","line":1105,"updated":"2014-05-20 21:33:06.000000000","message":"Wouldn\u0027t it be cleaner to leave this sleep where it was and just remove the one before the while loop?  Just a thought ...","commit_id":"f997879cbe5e81951068faaaf0467b860affbcc8"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"266688bff29fab63893c3f79cb1327cb8c055ac7","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"                result \u003d dbaas.instances.get(instance_info.id)"},{"line_number":1103,"context_line":"                assert_equal(200, dbaas.last_http_code)"},{"line_number":1104,"context_line":"                assert_equal(\"SHUTDOWN\", result.status)"},{"line_number":1105,"context_line":"                time.sleep(1)"},{"line_number":1106,"context_line":"        except exceptions.NotFound:"},{"line_number":1107,"context_line":"            pass"},{"line_number":1108,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_72b572cf","line":1105,"in_reply_to":"7adec928_688cac36","updated":"2014-05-21 05:51:45.000000000","message":"need to get the instance at least once and sometimes it fails fast and we might not get the logs for the get instance so we should sleep at the end of the block instead of the beginning.","commit_id":"f997879cbe5e81951068faaaf0467b860affbcc8"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"0204b39e11a22a119269089da0308f28e9d8233a","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"                result \u003d dbaas.instances.get(instance_info.id)"},{"line_number":1103,"context_line":"                assert_equal(200, dbaas.last_http_code)"},{"line_number":1104,"context_line":"                assert_equal(\"SHUTDOWN\", result.status)"},{"line_number":1105,"context_line":"                time.sleep(1)"},{"line_number":1106,"context_line":"        except exceptions.NotFound:"},{"line_number":1107,"context_line":"            pass"},{"line_number":1108,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_a4d058f8","line":1105,"in_reply_to":"7adec928_72b572cf","updated":"2014-05-22 20:20:21.000000000","message":"Sounds reasonable ;)","commit_id":"f997879cbe5e81951068faaaf0467b860affbcc8"}],"trove/tests/util/event_simulator.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"aa93e655b8054eef745c5ddb549baf4794ff1960","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    global allowable_empty_sleeps"},{"line_number":70,"context_line":"    if len(pending_events) \u003d\u003d 0:"},{"line_number":71,"context_line":"        allowable_empty_sleeps -\u003d 1"},{"line_number":72,"context_line":"        if allowable_empty_sleeps \u003c 0:"},{"line_number":73,"context_line":"            fail(\"Trying to sleep when no events are pending.\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    global sleep_entrance_count"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_9bcea4b3","line":72,"updated":"2014-05-20 21:33:06.000000000","message":"From my read-through of the code, it appears that allowable_empty_sleeps is never greater than zero.  That would mean that after subtracting 1 it will always be less than zero, hence this \u0027if\u0027 will always evaluate to \u0027true.\u0027  Unless there\u0027s another way this variable gets set ...","commit_id":"f997879cbe5e81951068faaaf0467b860affbcc8"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"266688bff29fab63893c3f79cb1327cb8c055ac7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    global allowable_empty_sleeps"},{"line_number":70,"context_line":"    if len(pending_events) \u003d\u003d 0:"},{"line_number":71,"context_line":"        allowable_empty_sleeps -\u003d 1"},{"line_number":72,"context_line":"        if allowable_empty_sleeps \u003c 0:"},{"line_number":73,"context_line":"            fail(\"Trying to sleep when no events are pending.\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    global sleep_entrance_count"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_f23d022e","line":72,"in_reply_to":"7adec928_9bcea4b3","updated":"2014-05-21 05:51:45.000000000","message":"that looks like the point of this. if there are no pending_events then we should break out of here. Maybe this is some foresight into incrementing this but yeah i dont see any where it is incremented right now.","commit_id":"f997879cbe5e81951068faaaf0467b860affbcc8"}]}