)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"551529cf712199feec0ffdc6164db235c60c958e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ba78176_bea98180","updated":"2024-07-29 14:08:05.000000000","message":"\\o/ thanks for fixing tempest!","commit_id":"3b32e0611eccc3f6cfe7459486c7ba9f89c6433b"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"dfc1ada0b6aab6de08611bf057665554dd5799b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"639b428b_859c67bf","updated":"2024-07-17 13:04:32.000000000","message":"recheck","commit_id":"3b32e0611eccc3f6cfe7459486c7ba9f89c6433b"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"60a5d49e8835b0d46f2ed82f124428f834323f78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70eae72f_a017c003","updated":"2024-07-22 13:40:25.000000000","message":"recheck","commit_id":"3b32e0611eccc3f6cfe7459486c7ba9f89c6433b"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"717c8f9b60974b3779b9972bf6e6c643bf488f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe3f881c_b2a1abfa","updated":"2024-07-18 19:45:33.000000000","message":"recheck","commit_id":"3b32e0611eccc3f6cfe7459486c7ba9f89c6433b"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"9cfa250ff52bff5f587cc193eaa856f2c812dd3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95dc0964_92b8d044","updated":"2024-07-19 00:21:20.000000000","message":"¯\\_(ツ)_/¯ I think this is a tempest issue since this exact same patch passed CI a few days ago","commit_id":"3b32e0611eccc3f6cfe7459486c7ba9f89c6433b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"e4c8662689c9bcfc13be0af9f2c7b74a22a7c8a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b0c062db_710a4fad","in_reply_to":"7ba78176_bea98180","updated":"2024-07-30 15:11:22.000000000","message":"I will review this patch in this week！ Thanks for your work.","commit_id":"3b32e0611eccc3f6cfe7459486c7ba9f89c6433b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"f0b8b6b4756b61e756beb4b01eacd61d3e9991bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43369768_72fad5b7","in_reply_to":"95dc0964_92b8d044","updated":"2024-07-23 07:24:53.000000000","message":"yes， this seems to be a tempest issue. Let\u0027s fix it first.","commit_id":"3b32e0611eccc3f6cfe7459486c7ba9f89c6433b"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"35bfe631d043c101da7d9dc80537eb4ba55de922","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a1c0666_24faaa41","updated":"2024-08-09 05:49:36.000000000","message":"Hi, this change LGTM. by the way, Did you test this in your environment? and whether the data were lost after rebuild? \n\nalso, if possible, please add a release note for this feature.refer to: https://docs.openstack.org/trove/latest/contributor/release-notes.html","commit_id":"efc4b7e58231f0e0b2eaa69aa79bdf9a4fbf1613"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"244b9d60828e84f3985595d5108d6d5ab12756e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40b8a584_d78fd837","in_reply_to":"9a1c0666_24faaa41","updated":"2024-08-10 01:49:13.000000000","message":"Release note added.\n\nAs for testing: I\u0027m running guest images with this patch in production. We\u0027ve rebuilt 10 postgresql instances without data loss.","commit_id":"efc4b7e58231f0e0b2eaa69aa79bdf9a4fbf1613"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"c3db56fe42c5fd72204b769ac555043e07a987d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82fcb7a3_ba6048eb","updated":"2024-08-12 03:16:01.000000000","message":"As I commented in the story, can you help me clear about your problem?\nCurrently, I thinking we don\u0027t need rebuild a database instance.","commit_id":"ca39d9540f2a7a82291fc0088132e8765321c49f"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"f0c2d15c62322a2b88c933a1a8a041ff7bb403a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67e20ba4_4f04f593","updated":"2024-08-12 06:35:58.000000000","message":"recheck docker timeout","commit_id":"ca39d9540f2a7a82291fc0088132e8765321c49f"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"558375df61c3d2ca2597580c30133713b52b812a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db62159f_294c1625","in_reply_to":"82fcb7a3_ba6048eb","updated":"2024-08-12 06:28:31.000000000","message":"To replace old trove guest image with a new one.","commit_id":"ca39d9540f2a7a82291fc0088132e8765321c49f"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"7f8be6670a7fe1bb0f167558b430c708bbb33c8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0608a374_c8dd24a7","updated":"2024-08-12 07:02:23.000000000","message":"I think we shouldn\u0027t rebuild to upgrade code to latest. It will make downtime database. Just is upgrade code, we can do something such as scp code to old agent, prepare \u0026 install without downtime.\n\nThis way isn\u0027t good that DBaaS should remove.","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"4c2a92f5bb8a67b9d4336a8f4fdc0cd99c255018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cafef5ea_d14cb24c","updated":"2024-08-13 14:11:20.000000000","message":"recheck","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"e36b42ae1fa76b16ee95dfa4e7ebb021acb97437","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c73db0b_671cbf00","updated":"2024-08-13 01:52:46.000000000","message":"you can reference this patch to know why this function being error after run.\n\nhttps://review.opendev.org/c/openstack/trove/+/926042","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"0a1b9b4d9897b9f629207b904739727eee06bbab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f06b2f47_5121fd48","in_reply_to":"0608a374_c8dd24a7","updated":"2024-08-12 13:03:00.000000000","message":"this function has already implemented in mariadb and mariadb driver, so i think is ok for the postgres driver as well.\n\nfrom the doc, we use \"rebuild\" to upgrade instance rather than copy code to old agent\nhttps://docs.openstack.org/trove/latest/admin/upgrade.html","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"9629274e9b4de20096f3afe0a15e864b888f6129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a3bdeac8_ceb8019c","in_reply_to":"79fa0653_ae9d510e","updated":"2024-08-13 14:20:45.000000000","message":"I also note that \u0027rebuild\u0027 is in he existing API and client, so even if there are future plans to remove the feature it\u0027s valid to fix it in the meantime.","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"bd32a96c39c984120beeaf892a9e653a56ebc965","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a2cb274d_56c4fcf8","in_reply_to":"a3bdeac8_ceb8019c","updated":"2024-08-14 06:14:22.000000000","message":"ok. it being valid to fix it in the meantime. you can ignore my comment about this problem. but you should review other my comments.\n\nThe reset configuration will raise a bug make instance work not right","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"7926a6f857e7c6b3453eef312fb5c888d9628484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7671963_1c6cbdf1","in_reply_to":"bcc29d09_c9a15b53","updated":"2024-08-13 01:46:01.000000000","message":"if source code being depended by something in OS. we should create an empty database instance and do migrate by detach volumes and re-attach but this case is rare and we will control this progress.","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"93e28b3c266a268fe7e5cc1df904909a14cff0dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"79fa0653_ae9d510e","in_reply_to":"c7671963_1c6cbdf1","updated":"2024-08-13 14:11:09.000000000","message":"I think this rebuild option is important because it replaces the guest VM. We need to be able to replace that (for e.g. ubuntu security updates) regardless of the state of the container or db code.\n\nIt\u0027s also important for upgrading the guest agent in cases where the guest agent is broken in such a way that it can\u0027t upgrade itself.","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"9629274e9b4de20096f3afe0a15e864b888f6129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a64ffb2_f080afe3","in_reply_to":"cafef5ea_d14cb24c","updated":"2024-08-13 14:20:45.000000000","message":"oops, this was unneeded, someone beat me to it 😊","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"1d91d83b6707675669afd0379c801cf9a3b9303d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bcc29d09_c9a15b53","in_reply_to":"f06b2f47_5121fd48","updated":"2024-08-13 01:33:38.000000000","message":"Yup. That is document\u0027s problem. whether this is right in production? I think that is never.\nwhether you can agree tradeoff between downtime database/ applications and upgrade source code by rebuild while this isn\u0027t important?\n\nI had planned to remove this functions in the future.","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"6d5f15d7ced25f3974b8b4bfc4628f40b144c6c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d5470486_d242962c","updated":"2024-08-20 03:17:33.000000000","message":"I think the rebuild (or resize) maybe a bug of trove. As I commented in this patch: https://review.opendev.org/c/openstack/trove/+/926042. in the real, rebuild can be like resize, because it just change flavor and os. after rebuild, the os can be keep but just flavor was changed","commit_id":"b1c74bf6bff6be1402bf42648113e62f09ec2475"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"6ce71958d44201432a95b26820e412c6048f2bd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ac107a21_3e71a9fb","updated":"2024-08-21 18:55:57.000000000","message":"thanks all!","commit_id":"b1c74bf6bff6be1402bf42648113e62f09ec2475"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"658d39b7e4d3a36d51270eb3b2cc74825c215bee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6decbc01_493d04d1","in_reply_to":"ac107a21_3e71a9fb","updated":"2024-08-29 09:29:17.000000000","message":"you are welcome!!","commit_id":"b1c74bf6bff6be1402bf42648113e62f09ec2475"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"e04086a0369ee0f5ef033a8cd7926249cc943608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e0c883e1_b4103532","in_reply_to":"d5470486_d242962c","updated":"2024-08-21 02:20:40.000000000","message":"yes, this should be same behavior with the resize. Let\u0027s merge this patch to fix the \u0027Not implement\u0027 error. and fix the the losing of the configuration opts later.","commit_id":"b1c74bf6bff6be1402bf42648113e62f09ec2475"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"31b40a96f44d4523e068440818b2299134d9eda4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a408d9cc_6cef18e2","in_reply_to":"e0c883e1_b4103532","updated":"2024-08-21 04:47:45.000000000","message":"ok. author maybe accept the lose config. And i think this problem can be fix later","commit_id":"b1c74bf6bff6be1402bf42648113e62f09ec2475"}],"trove/guestagent/datastore/postgres/manager.py":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"e36b42ae1fa76b16ee95dfa4e7ebb021acb97437","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            # Prepare postgres configuration"},{"line_number":284,"context_line":"            LOG.debug(\u0027Preparing database configuration\u0027)"},{"line_number":285,"context_line":"            self.app.configuration_manager.reset_configuration(config_contents)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            # note that this is a different \u0027datadir\u0027 from the one above."},{"line_number":288,"context_line":"            # The actual postgres data is in the \u0027pgdata\u0027 subdir of the"}],"source_content_type":"text/x-python","patch_set":4,"id":"79d216e7_2f981ea4","line":285,"updated":"2024-08-13 01:52:46.000000000","message":"If we run this line. old config being deleted. Can we keep them?","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"6fd5442ea3b730552f2773e158b0572e8bbc6af9","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            # Prepare postgres configuration"},{"line_number":284,"context_line":"            LOG.debug(\u0027Preparing database configuration\u0027)"},{"line_number":285,"context_line":"            self.app.configuration_manager.reset_configuration(config_contents)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            # note that this is a different \u0027datadir\u0027 from the one above."},{"line_number":288,"context_line":"            # The actual postgres data is in the \u0027pgdata\u0027 subdir of the"}],"source_content_type":"text/x-python","patch_set":4,"id":"b0a91de6_0299df1c","line":285,"in_reply_to":"48d9436f_49e5fe73","updated":"2024-08-20 03:03:03.000000000","message":"This same reset (and the update_overrides, later) is present in the mariadb and mysql rebuilds.\n\nWhether this is right or wrong really depends on how we interpret the word \u0027rebuild\u0027. I think as a user I would prefer not to lose config... that said, I think we need to be consistent among the different db backends.\n\nWe could provide a future documented change to this behavior that\u0027s applied to all backends in a future patch.","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"ea8e8e36655a2cc83075536bccdebbd3d6b49c6f","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            # Prepare postgres configuration"},{"line_number":284,"context_line":"            LOG.debug(\u0027Preparing database configuration\u0027)"},{"line_number":285,"context_line":"            self.app.configuration_manager.reset_configuration(config_contents)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            # note that this is a different \u0027datadir\u0027 from the one above."},{"line_number":288,"context_line":"            # The actual postgres data is in the \u0027pgdata\u0027 subdir of the"}],"source_content_type":"text/x-python","patch_set":4,"id":"e88c362d_51217f80","line":285,"in_reply_to":"54fdc6d2_d6a9c25c","updated":"2024-08-20 14:14:48.000000000","message":"yes, for now the behavior seems acceptable.","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"547e5f50aa342d4e80b59ceb24ae51c99d592e60","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            # Prepare postgres configuration"},{"line_number":284,"context_line":"            LOG.debug(\u0027Preparing database configuration\u0027)"},{"line_number":285,"context_line":"            self.app.configuration_manager.reset_configuration(config_contents)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            # note that this is a different \u0027datadir\u0027 from the one above."},{"line_number":288,"context_line":"            # The actual postgres data is in the \u0027pgdata\u0027 subdir of the"}],"source_content_type":"text/x-python","patch_set":4,"id":"d96b1d46_bfed83e7","line":285,"in_reply_to":"79d216e7_2f981ea4","updated":"2024-08-17 06:09:01.000000000","message":"when this function was called, it means that the instance has already rebuilt by nova, all the data were lost, there is no old config anymore.","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"ae2d74dbe5d22a1d49a39252d8d9078afaae84b5","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            # Prepare postgres configuration"},{"line_number":284,"context_line":"            LOG.debug(\u0027Preparing database configuration\u0027)"},{"line_number":285,"context_line":"            self.app.configuration_manager.reset_configuration(config_contents)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            # note that this is a different \u0027datadir\u0027 from the one above."},{"line_number":288,"context_line":"            # The actual postgres data is in the \u0027pgdata\u0027 subdir of the"}],"source_content_type":"text/x-python","patch_set":4,"id":"54fdc6d2_d6a9c25c","line":285,"in_reply_to":"b0a91de6_0299df1c","updated":"2024-08-20 03:10:28.000000000","message":"Are you will accept the lose config?","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"adba1d314396a328e8f9f6344cc15ca121a69b41","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            # Prepare postgres configuration"},{"line_number":284,"context_line":"            LOG.debug(\u0027Preparing database configuration\u0027)"},{"line_number":285,"context_line":"            self.app.configuration_manager.reset_configuration(config_contents)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"            # note that this is a different \u0027datadir\u0027 from the one above."},{"line_number":288,"context_line":"            # The actual postgres data is in the \u0027pgdata\u0027 subdir of the"}],"source_content_type":"text/x-python","patch_set":4,"id":"48d9436f_49e5fe73","line":285,"in_reply_to":"d96b1d46_bfed83e7","updated":"2024-08-19 03:44:18.000000000","message":"Whether this is result that operator expected? Do rebuild and re-apply config by manual (or by some scripts)?\n\nin the suppose, we clients had config and apply them config. when we do rebuild, this config will lost?","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"e36b42ae1fa76b16ee95dfa4e7ebb021acb97437","unresolved":true,"context_lines":[{"line_number":288,"context_line":"            # The actual postgres data is in the \u0027pgdata\u0027 subdir of the"},{"line_number":289,"context_line":"            # volume mount."},{"line_number":290,"context_line":"            self.app.set_data_dir(self.app.datadir)"},{"line_number":291,"context_line":"            self.app.update_overrides(config_overrides)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"            # Start database service."},{"line_number":294,"context_line":"            command \u003d f\"postgres -c config_file\u003d{service.CONFIG_FILE}\""}],"source_content_type":"text/x-python","patch_set":4,"id":"c8d51012_9ac74cac","line":291,"updated":"2024-08-13 01:52:46.000000000","message":"ditto","commit_id":"a97d3b46b9432d862c9bb325561603742addf505"}]}