)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"245a82e614ce8634e9bd187cb6084b48bfc51809","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f72c7a4_29db0e83","updated":"2024-10-07 02:29:35.000000000","message":"@wu.chunyang can you help me review this patch?","commit_id":"45fee289ea903e9aad2b9254d06d95d371f2ae16"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"da1934b9c1ca4d599dbfb267ced6209bee788766","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"00d9f2d3_2c9b31cb","updated":"2024-09-20 01:37:28.000000000","message":"Hi I\u0027ve been looking at the same issue for support PostgreSQL versions after 12. See my comment.","commit_id":"45fee289ea903e9aad2b9254d06d95d371f2ae16"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5d429e46a2a2316c0cbedeb69da6d04ec1851c9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b020403f_6f62c6ce","updated":"2025-02-26 16:58:42.000000000","message":"so...\n\nI wrote my opinion in https://review.opendev.org/c/openstack/trove/+/942515\n\nI would really prefer adding conditions based on the DB versions to templates rather then try maintaining templates for each and every version separately.\n\nAs then in case of adding some new option - it would need huge amount of changes made by maintainer or any other user.\n\nSo if we can/do have version inside of the template - we can leverage jinja and compare versions to decide if some option is needed or not.\n\nAs, for example - this is already somehow dated, as there\u0027s a mysql 8.4 and postgres 17 available... So this approach would be super hard to keep up to date, imo.","commit_id":"45fee289ea903e9aad2b9254d06d95d371f2ae16"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"86dc1ce8a4c85c21fbe6fe6ed16ae5487f76ffb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c1a94d19_299a3753","in_reply_to":"2f72c7a4_29db0e83","updated":"2025-03-06 14:32:31.000000000","message":"hello, Bo, as i commented on the [commit], this approach is really harder to review, but it looks more explicit and concrete, let me know if you use these configure opts in the production. if it is, I\u0027d like to revert these configure opts to the template. \n\n[commit]: https://review.opendev.org/c/openstack/trove/+/929983","commit_id":"45fee289ea903e9aad2b9254d06d95d371f2ae16"}],"trove/templates/postgresql/13.10/config.template":[{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"da1934b9c1ca4d599dbfb267ced6209bee788766","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Currently unused"},{"line_number":2,"context_line":"# The recommended amount for \u0027shared_buffers\u0027 on a dedicated database server is 25% of RAM."},{"line_number":3,"context_line":"# Servers with less than 3GB of RAM require a more conservative value to save memory for other processes."},{"line_number":4,"context_line":"{% set shared_buffers_mb \u003d [(0.25 if flavor[\u0027ram\u0027] \u003e\u003d 3072 else 0.10) * flavor[\u0027ram\u0027]] %}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"cd7bab61_51a0a5cb","line":1,"updated":"2024-09-20 01:37:28.000000000","message":"Hi I have been looking into allow support for versions of PostGreSQL greater than 12.  \n\nI like your explicit approach, but I wanted to avoid making code changes each time we added a new version of PostgresSQL.  I\u0027ve submitted my change, with uses the datastore version in the template  for you to consider https://review.opendev.org/c/openstack/trove/+/929983","commit_id":"45fee289ea903e9aad2b9254d06d95d371f2ae16"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"781ccdeafe211c72716018563324eba3729d97f8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Currently unused"},{"line_number":2,"context_line":"# The recommended amount for \u0027shared_buffers\u0027 on a dedicated database server is 25% of RAM."},{"line_number":3,"context_line":"# Servers with less than 3GB of RAM require a more conservative value to save memory for other processes."},{"line_number":4,"context_line":"{% set shared_buffers_mb \u003d [(0.25 if flavor[\u0027ram\u0027] \u003e\u003d 3072 else 0.10) * flavor[\u0027ram\u0027]] %}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"d349117d_323a1535","line":1,"in_reply_to":"cd7bab61_51a0a5cb","updated":"2024-10-01 02:50:21.000000000","message":"what are difference between your \u0026 my patch?","commit_id":"45fee289ea903e9aad2b9254d06d95d371f2ae16"}]}