)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"5a2d89ef49d0eb520376aa6e0ebbf8176079a445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6bc10cb3_5588f093","updated":"2024-08-09 10:41:15.000000000","message":"i need you help, let\u0027s review this patch.","commit_id":"f04bf620f1fcab706eee21932e1e1a1f5d86c249"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"fa9cdb9dddb4ad5b7f3db964ec318172bdd70fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52bc10f3_71aa7fea","updated":"2025-01-22 11:09:13.000000000","message":"Hello, Bo!\nGenerating config from template looks like a very ugly solution. It obliges to test it against every version of every database manager in the future.\n\nBefore rebuilding old container we actually can fetch configuration from guest, store somewhere temporarly (if needed) and then apply it to a newly created guest.\nIt would be much cleaner solution, how do you think?","commit_id":"6f79cc3072b01a5206aeb9417b63e27b7986bbba"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"945646647a9ec2131f36382f41acc6c9abbf0c4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f7b904f_68b788fa","updated":"2024-08-21 02:21:53.000000000","message":"I\u0027ll review this later.","commit_id":"6f79cc3072b01a5206aeb9417b63e27b7986bbba"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"984f1fff2e0ef5ca9421df34f5b2302e63b91a6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8932a108_abd80d46","in_reply_to":"52bc10f3_71aa7fea","updated":"2025-02-12 02:51:28.000000000","message":"I think what that you want say, I will think about solutions for this problem","commit_id":"6f79cc3072b01a5206aeb9417b63e27b7986bbba"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"fa9cdb9dddb4ad5b7f3db964ec318172bdd70fd4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3f38cad_60f677d6","in_reply_to":"6f7b904f_68b788fa","updated":"2025-01-22 11:09:13.000000000","message":"I made an investigagion about the bug and I can see two different \"mecanics\" in current code:\n\nFirst - is \"new-style\" configuration manager (e.g. self.configuration_manager in guestagent/datastore/postgres/manager.py). It\u0027s a \"new-style\" because it is said so in  guestagent/datastore/manager.py:131.\n\nSecond - is the template based configuration generator, it\u0027s being called with new flavor on resize, e.g. in _start_datastore(self) method in taskmanager/models.py:2193.\n\nIf inside the compute instance all of the configuration files for ALL datastores are being stored in the dedicated volume and not within /etc directory then generation of the new config from template is redundant and erroneous as it may lead to the loss of essential data inside user\u0027s configuration files e.g. ACL for redis/keydb, master credentials for replicas, etc.\n\nI think second method is obsolete and we may remove the code for generating new config on flavor resize completely.\nAnd if we do so then the patchset is this thread is useless as it resolve problem caused by obsolete code.\n\nSo I propose to move all the configuration files to the data volume and not to regenerate them on flavor resize, and it will resolve the original bug.","commit_id":"6f79cc3072b01a5206aeb9417b63e27b7986bbba"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"0a8352dc20efe1798e829db442d97405502e98b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e469dfd0_c05efa07","in_reply_to":"8b7e1a5a_7f036511","updated":"2025-12-11 16:03:37.000000000","message":"Done","commit_id":"6f79cc3072b01a5206aeb9417b63e27b7986bbba"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"67bfdcd67b98060b92bbea16f05b48de9abb7bda","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b7e1a5a_7f036511","in_reply_to":"a3f38cad_60f677d6","updated":"2025-02-18 10:55:50.000000000","message":"This is a problem. We need to regenerate them on flavor resize - and this is important because some our config depend by ram \u0026 cpu.","commit_id":"6f79cc3072b01a5206aeb9417b63e27b7986bbba"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"79af2f4d87ac1e8e8dd4cb986dad22170247d73c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"610916bd_5ec13e38","updated":"2025-07-29 01:55:55.000000000","message":"Could not perform action: not Signed-off-by author/committer/uploader in message footer","commit_id":"81cc4a194e0e591a281d1fb3f028d7228348f99d"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"6a11544515e68dec1a7fc6bfa8ba0e86eea0c408","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2022fa90_6d176071","updated":"2025-07-28 03:50:35.000000000","message":"recheck","commit_id":"81cc4a194e0e591a281d1fb3f028d7228348f99d"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"d4d3f9d419edc08923f1385be7d5320e1ddf7ecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f06d596c_3e1a309d","updated":"2025-05-01 16:24:12.000000000","message":"recheck - no zuul results","commit_id":"81cc4a194e0e591a281d1fb3f028d7228348f99d"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"ce433217bf73515cec7d73766146c93b53d781b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"26afcc94_673f81c8","updated":"2025-12-05 11:10:27.000000000","message":"@adrian.r.jarvis@gmail.com Hello, please review this MR.","commit_id":"fabc77067a90f3c9d8537c830168d0ab668e6ee8"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"fffff24501f6b6f6fd3d72aeac0a06b4c1b2a82f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e308adb5_90994f81","updated":"2025-12-02 09:47:56.000000000","message":"LGTM","commit_id":"fabc77067a90f3c9d8537c830168d0ab668e6ee8"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"0a8352dc20efe1798e829db442d97405502e98b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9d1afc5e_f87ed033","in_reply_to":"26afcc94_673f81c8","updated":"2025-12-11 16:03:37.000000000","message":"Hello! Since officially supported versions for PostgreSQL: 12 (dropped in 2025.2), 16, 17, MySQL: 5.7 (dropped in 2025.2), 8.0, 8.4 and MariaDB: 10.4 (dropped in 2025.2), 11.4, 11.8, the choice of database versions in the patch looks weird and some ISP-specific.","commit_id":"fabc77067a90f3c9d8537c830168d0ab668e6ee8"}]}