)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"72565a95cc7834b6a53225eb364c06a734426bd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92d076fc_8b3aea83","updated":"2024-09-04 02:23:35.000000000","message":"this looks the same as `https://review.opendev.org/c/openstack/trove/+/912054`","commit_id":"823625406465d55ba609c1461b857be0227b63b2"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"809b0d6fd4abc6c9303fdb811c3e7b801232b691","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c56bf3eb_5a827979","in_reply_to":"92d076fc_8b3aea83","updated":"2024-09-10 12:40:23.000000000","message":"This changes from LegacyEngineFacade to the \"new\" transaction context in enginefacade.\n\nThe patch you listed doesn\u0027t, it uses oslo_db.sqlalchemy.session.EngineFacade which is an alias for oslo_db.sqlalchemy.enginefacade.LegacyEngineFacade – you want to call transaction_context() in oslo_db.sqlalchemy.enginefacade to get a transaction context and work with that.","commit_id":"823625406465d55ba609c1461b857be0227b63b2"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"18e04887ee9e4944fbb74fe19a13c32c2dfb2eea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0236b8cc_6dd7bd89","in_reply_to":"c56bf3eb_5a827979","updated":"2024-09-18 05:55:45.000000000","message":"thanks for the clarification. however, i am going to merge this patch at the beginning of the next cycle.","commit_id":"823625406465d55ba609c1461b857be0227b63b2"}],"trove/db/sqlalchemy/session.py":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"bb362e76ba785313df841ae00022a1c1922ef687","unresolved":true,"context_lines":[{"line_number":72,"context_line":"def _create_facade():"},{"line_number":73,"context_line":"    global _FACADE"},{"line_number":74,"context_line":"    if _FACADE is None:"},{"line_number":75,"context_line":"        ctx \u003d enginefacade.transaction_context()"},{"line_number":76,"context_line":"        _FACADE \u003d ctx.writer"},{"line_number":77,"context_line":"    return _FACADE"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"22260553_78064ce5","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":28},"updated":"2024-09-04 02:21:32.000000000","message":"Hi， what\u0027s the difference between `db_session.EngineFacade.from_config(options)` and `enginefacade.transaction_context()`.I remember we don\u0027t use `legacyenginefacade` in trove project.","commit_id":"823625406465d55ba609c1461b857be0227b63b2"}]}
