)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"7fba86f072dce17afc4b34c7ab3c2ea29bcb2313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e860482d_1b5d8cb5","updated":"2025-02-27 20:12:59.000000000","message":"Thanks for the comments... looking at my commit it is a bit hacky so I am currently rewriting it.  I hope to submit an update soon with a corrected commit message","commit_id":"16ec3fd466c6d84002f6341dc36a7db73996913a"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"f0abc7d80cbf067dd56ad9859b8cda1baed878f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2369d2c0_2ba34e71","updated":"2024-09-22 22:06:59.000000000","message":"This change set is a dynamic way of supporting postgres versions 13 or greater.","commit_id":"16ec3fd466c6d84002f6341dc36a7db73996913a"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"84b534fe05d82193f9abacbd48e879066449f6a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67286042_a6a356d4","updated":"2024-10-01 03:11:15.000000000","message":"as my comment in this: https://review.opendev.org/c/openstack/trove/+/925054\nI think your patch need make with common with any datastore versions.\nAnd seem your patch being duplicated with my above patch.\nDo you think about this?","commit_id":"16ec3fd466c6d84002f6341dc36a7db73996913a"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4376bcef59dc2b420f7e6b029e556cef0420fe26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3dfb299f_62977bf4","updated":"2024-09-26 06:27:37.000000000","message":"hi, thanks for the patch.\n\nPlease follow proper formatting for commit messages\nTitle of commit \u003c less then 50 characters \u003cCR\u003e \nDescription of commit (wrapped at 71 characters) may be mulltiline\nCloses-Bug: #X or TrivialFix or Implements:","commit_id":"16ec3fd466c6d84002f6341dc36a7db73996913a"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"15d1ae208932d4f7075d70a1fcdde91822aae40d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de85f072_446a1de8","updated":"2025-03-01 00:16:53.000000000","message":"I have just discovered that there is already a semantic-version library in the requirements so I will update my change to use that","commit_id":"48213e4fe870fe942efdcbce76726e83a4ed1259"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"88021ca26bcca4a05adffe16327a0659c8d9ae9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"27729af2_dba6d7d4","updated":"2025-02-28 16:36:10.000000000","message":"recheck","commit_id":"48213e4fe870fe942efdcbce76726e83a4ed1259"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7e4dc6dc43c153323f569dadb5b1672a33cd9f77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2f9f422f_39fc6628","updated":"2025-03-05 06:38:20.000000000","message":"Awesome, thanks for working on this one! This is exactly how I\u0027d imagine this to be done:)\n\nReally nits on reno formatting","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"9cc37036dd4a8f5edbc1f6eca4566c961a391c9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"569de498_09978233","updated":"2025-03-05 08:28:49.000000000","message":"It\u0027s good for some version.\n\nBut do you think about when have multiple changes in multi version? In production, we doing maintain from version 13.x.x to 17.x.x. If we doing maintain all in one file. It\u0027s so hard and make file too big and can\u0027t inject into server.\n\nLet\u0027s review above my patch in my comment.","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c20ba79d592abbfc69ec7fae7204d1d7bb22ba1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5490e00d_e62d2cd3","updated":"2025-03-18 16:06:34.000000000","message":"well, branching for 2025.1 has already happened. But also that is a proper bugfix which can be more the eligible for backporting as well, imo","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"be639b0c6ee3bf3c2508c9961ca43bbd76781cd7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"21c6c22c_6f31979e","in_reply_to":"1c8164c4_603fe0cd","updated":"2025-03-07 03:06:20.000000000","message":"Hi Bo,\n\nThanks for your review.\n\nI have been thinking over your comments and I have updated my patch so that when trove is looking for templates it searches more directories.  The reason I have implemented this is to avoid having to create templates for every version of a database.  \n\nFor example if the datastore version name is 8.0.5 for mysql then the code will look for the following template files:\nmysql/8.0.5/config.template\nmysql/8.0/config.template\nmysql/8/config.template\nmysql/config.template\n\nThis allows us to have a template for every major version if required and we can use the jinja2 templating for minor changes.\n\nIt also means that if an operator wants to create a new datastore version that is a patch they don\u0027t need to create another template.  For exmaple if there is a template file mysql/8.0/config.template, then if I want to add a datastore for mysql 8.0.7 I can do with needing to create (or duplicate) the template file.","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"8f547905404c43768c698663726ee0a0295a5026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b950f791_c3f5dc1d","in_reply_to":"1e839ed8_bedc0897","updated":"2025-03-27 13:09:04.000000000","message":"@wu.wenxiang@99cloud.net hello, I think we can merge it in master now.","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"be639b0c6ee3bf3c2508c9961ca43bbd76781cd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b08436be_c10242a2","in_reply_to":"2f9f422f_39fc6628","updated":"2025-03-07 03:06:20.000000000","message":"Thanks - I\u0027ve fix those.","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"b3e3f5d5b452bac4f4040cefeaa1804e1a629bdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1e839ed8_bedc0897","in_reply_to":"5490e00d_e62d2cd3","updated":"2025-03-20 01:40:27.000000000","message":"make sense.","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"d1e3c23a4cf7094af4337d838946d2cf5db409bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1c8164c4_603fe0cd","in_reply_to":"569de498_09978233","updated":"2025-03-06 14:25:32.000000000","message":"Hi, Bo, thanks for your review! As far as i known, these contents will be rendered first, and then pass the file to guest-agent, so we don\u0027t need to consider the size of this template.\nfurthermore, you may need to maintain many datastore versions in production. i think it\u0027s harder to maintain a config file for each version. so i prefer to use this solution.\nAs Trove already uses the `jinja2` to render template, and the `jinja2` is really a powerful tools and providers more flexibility . so i thinks it\u0027s reasonable to use `jinja2`.\n\nfinally, I also work for other openstack projects, it\u0027s really common to use `jinja2` to render a large template.","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"b7339b379e90596eeb0d4fbb91c040e8435ebee5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cf7b8261_0cd2752d","in_reply_to":"9c2dbddf_9319368c","updated":"2025-03-27 13:19:33.000000000","message":"Branching for 2025.1 has already happened, please check, we already do it.","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"549273b6a156e869a60535839425509d51f9f254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c2dbddf_9319368c","in_reply_to":"b950f791_c3f5dc1d","updated":"2025-03-27 13:14:14.000000000","message":"Hi, Ivan, I can\u0027t approve this commit now as we are in the feature freeze period for 2025.1. This patch won\u0027t be merged until the next development window is opened.","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"985bfbb3b834fdc82af39d1734898dcc2d543f5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"deca5c9f_edd9fe06","in_reply_to":"cf7b8261_0cd2752d","updated":"2025-03-27 13:47:04.000000000","message":"well， thanks for the reminder, from the release scheduler[0], the next development window should be opened after Apr 04 in principle. however the 2025.1 is already released. so we may don\u0027t need to wait until Apr 04. it should be fine to merge it now.\n[0]: https://releases.openstack.org/flamingo/schedule.html","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"1fa81046af75f98e69153c7d378e64062f6ac244","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5a99666f_1363744d","updated":"2025-03-11 00:08:50.000000000","message":"Sorry for the number of patches.  This should be the last one.  It adds allowing the DatastoreVersion.version field to override the name field when parsing the semantic version.","commit_id":"bec522f27db58f7a056b310327fee10cb2554e5f"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"9938c4e828d00d34aa2a72643b4c155f78bdf414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e78ec57e_486027c7","updated":"2025-03-15 15:43:51.000000000","message":"@wchy1001@gmail.com hello, please review it, I think it\u0027s time to accept these changes.","commit_id":"c641e52411c1619db6c4aaba08c1f34e5482c71a"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"a62f7c8ee7c6728b287fd52dd0521f53fcebd4ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c38901f9_84b2eeb6","updated":"2025-03-15 13:05:09.000000000","message":"recheck   the new added test was failed.","commit_id":"c641e52411c1619db6c4aaba08c1f34e5482c71a"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"d15bd8399ab2396321d691d1500e3f7f5132d50d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"568a9492_7dcd4fd6","in_reply_to":"a788c862_bc0d1ed8","updated":"2025-03-17 07:50:59.000000000","message":"thanks for the information. This feature only affects the new datastore version. so we can  merge it in next cycle together with CI tests.","commit_id":"c641e52411c1619db6c4aaba08c1f34e5482c71a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c02684bdb6f122343a3c0385ed73dcfaefc1780","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a788c862_bc0d1ed8","in_reply_to":"e78ec57e_486027c7","updated":"2025-03-16 05:39:17.000000000","message":"I\u0027m not a core in Trove so I really have no idea why I\u0027m invited to this change... However we already entered the feature freeze period for 2025.1 and we expect RC1 quite soon, so this may not be merged for 2025.1 and you may have to wait until development for 2025.2 is opened.","commit_id":"c641e52411c1619db6c4aaba08c1f34e5482c71a"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"42a8a3d08c22cdd7263b76002b72883f80713306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"83c0c832_770a3981","updated":"2025-03-27 02:11:19.000000000","message":"LGTM","commit_id":"9ae2392d5a3b660529d35e1d8e84744d00088727"}],"releasenotes/notes/fix-support-postgresql-v13-and-above-90ba30c4ab62df3d.yaml":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7e4dc6dc43c153323f569dadb5b1672a33cd9f77","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes support for PostgreSQL v13 and above."},{"line_number":5,"context_line":"    Sets the `wal_keep_size` or `wal_keep_segments` in the instance "},{"line_number":6,"context_line":"    configuration file depending on the version in the data store version name."},{"line_number":7,"context_line":"    The version number is parsed from the Datastore Version name and is exposed"},{"line_number":8,"context_line":"    to the database instance configuration templates to allow the the use of "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c9272493_46f0711c","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":68},"updated":"2025-03-05 06:38:20.000000000","message":"trailing whitespace","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"be639b0c6ee3bf3c2508c9961ca43bbd76781cd7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes support for PostgreSQL v13 and above."},{"line_number":5,"context_line":"    Sets the `wal_keep_size` or `wal_keep_segments` in the instance "},{"line_number":6,"context_line":"    configuration file depending on the version in the data store version name."},{"line_number":7,"context_line":"    The version number is parsed from the Datastore Version name and is exposed"},{"line_number":8,"context_line":"    to the database instance configuration templates to allow the the use of "}],"source_content_type":"text/x-yaml","patch_set":6,"id":"97f02b5a_a265e196","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":68},"in_reply_to":"c9272493_46f0711c","updated":"2025-03-07 03:06:20.000000000","message":"Done","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7e4dc6dc43c153323f569dadb5b1672a33cd9f77","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    Sets the `wal_keep_size` or `wal_keep_segments` in the instance "},{"line_number":6,"context_line":"    configuration file depending on the version in the data store version name."},{"line_number":7,"context_line":"    The version number is parsed from the Datastore Version name and is exposed"},{"line_number":8,"context_line":"    to the database instance configuration templates to allow the the use of "},{"line_number":9,"context_line":"    conditional based on the version."},{"line_number":10,"context_line":"    `Story 2008285 \u003chttps://storyboard.openstack.org/#!/story/2008285\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"14e571b6_6dee5f06","line":8,"range":{"start_line":8,"start_character":76,"end_line":8,"end_character":77},"updated":"2025-03-05 06:38:20.000000000","message":"ditto","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"be639b0c6ee3bf3c2508c9961ca43bbd76781cd7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Sets the `wal_keep_size` or `wal_keep_segments` in the instance "},{"line_number":6,"context_line":"    configuration file depending on the version in the data store version name."},{"line_number":7,"context_line":"    The version number is parsed from the Datastore Version name and is exposed"},{"line_number":8,"context_line":"    to the database instance configuration templates to allow the the use of "},{"line_number":9,"context_line":"    conditional based on the version."},{"line_number":10,"context_line":"    `Story 2008285 \u003chttps://storyboard.openstack.org/#!/story/2008285\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"457e3100_c08b87ae","line":8,"range":{"start_line":8,"start_character":76,"end_line":8,"end_character":77},"in_reply_to":"14e571b6_6dee5f06","updated":"2025-03-07 03:06:20.000000000","message":"Done","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7e4dc6dc43c153323f569dadb5b1672a33cd9f77","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    The version number is parsed from the Datastore Version name and is exposed"},{"line_number":8,"context_line":"    to the database instance configuration templates to allow the the use of "},{"line_number":9,"context_line":"    conditional based on the version."},{"line_number":10,"context_line":"    `Story 2008285 \u003chttps://storyboard.openstack.org/#!/story/2008285\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"41e9cb27_1a0f08b3","line":10,"updated":"2025-03-05 06:38:20.000000000","message":"please, add a new line here","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"be639b0c6ee3bf3c2508c9961ca43bbd76781cd7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    The version number is parsed from the Datastore Version name and is exposed"},{"line_number":8,"context_line":"    to the database instance configuration templates to allow the the use of "},{"line_number":9,"context_line":"    conditional based on the version."},{"line_number":10,"context_line":"    `Story 2008285 \u003chttps://storyboard.openstack.org/#!/story/2008285\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0504c29e_39910460","line":10,"in_reply_to":"41e9cb27_1a0f08b3","updated":"2025-03-07 03:06:20.000000000","message":"Done","commit_id":"8e5daaa0cb0d750f7847ccea04b21f1c75c0eef1"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"c20ba79d592abbfc69ec7fae7204d1d7bb22ba1f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    The version number is parsed from the Datastore Version name and is exposed"},{"line_number":8,"context_line":"    to the database instance configuration templates to allow the the use of"},{"line_number":9,"context_line":"    conditional based on the version."},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    `Story 2008285 \u003chttps://storyboard.openstack.org/#!/story/2008285\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4aaf5fbd_134670e2","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2025-03-18 16:06:34.000000000","message":"trailing whitespace","commit_id":"c641e52411c1619db6c4aaba08c1f34e5482c71a"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"747e342b5a57c40b45bd936e25ba32bbde1c18ec","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    The version number is parsed from the Datastore Version name and is exposed"},{"line_number":8,"context_line":"    to the database instance configuration templates to allow the the use of"},{"line_number":9,"context_line":"    conditional based on the version."},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    `Story 2008285 \u003chttps://storyboard.openstack.org/#!/story/2008285\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d074964f_22225045","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"in_reply_to":"4aaf5fbd_134670e2","updated":"2025-03-19 02:22:21.000000000","message":"Done","commit_id":"c641e52411c1619db6c4aaba08c1f34e5482c71a"}],"trove/templates/mysql/replica_source.config.template":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c3866339732752fcb0292d6c9931acfab1364e27","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mysqld]"},{"line_number":2,"context_line":"log_bin \u003d /var/lib/mysql/data/mysql-bin.log"},{"line_number":3,"context_line":"{% if datastore.semantic_version.major \u003e\u003d 8 %}"},{"line_number":4,"context_line":"binlog_format \u003d MIXED"},{"line_number":5,"context_line":"enforce_gtid_consistency \u003d ON"},{"line_number":6,"context_line":"gtid_mode \u003d ON"},{"line_number":7,"context_line":"log_slave_updates \u003d ON"},{"line_number":8,"context_line":"{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bb7786ac_e095a35f","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":11},"updated":"2025-03-11 12:53:21.000000000","message":"Hello, are these opts exclusive to MySQL 8.x?","commit_id":"bec522f27db58f7a056b310327fee10cb2554e5f"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"c17554f67de58678589509f3689fa30dbab0563a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[mysqld]"},{"line_number":2,"context_line":"log_bin \u003d /var/lib/mysql/data/mysql-bin.log"},{"line_number":3,"context_line":"{% if datastore.semantic_version.major \u003e\u003d 8 %}"},{"line_number":4,"context_line":"binlog_format \u003d MIXED"},{"line_number":5,"context_line":"enforce_gtid_consistency \u003d ON"},{"line_number":6,"context_line":"gtid_mode \u003d ON"},{"line_number":7,"context_line":"log_slave_updates \u003d ON"},{"line_number":8,"context_line":"{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"cfe108f6_78d50d7b","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":11},"in_reply_to":"45d86292_33f8f955","updated":"2025-03-12 01:34:27.000000000","message":"Done","commit_id":"bec522f27db58f7a056b310327fee10cb2554e5f"},{"author":{"_account_id":35986,"name":"Adrian Jarvis","email":"adrian.r.jarvis@gmail.com","username":"adrian_jarvis"},"change_message_id":"3d0510eb02b1efb23e7d7f5577e396501714904e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mysqld]"},{"line_number":2,"context_line":"log_bin \u003d /var/lib/mysql/data/mysql-bin.log"},{"line_number":3,"context_line":"{% if datastore.semantic_version.major \u003e\u003d 8 %}"},{"line_number":4,"context_line":"binlog_format \u003d MIXED"},{"line_number":5,"context_line":"enforce_gtid_consistency \u003d ON"},{"line_number":6,"context_line":"gtid_mode \u003d ON"},{"line_number":7,"context_line":"log_slave_updates \u003d ON"},{"line_number":8,"context_line":"{% endif %}"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"45d86292_33f8f955","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":11},"in_reply_to":"bb7786ac_e095a35f","updated":"2025-03-12 01:33:40.000000000","message":"I thought they were part of an earlier commit for support MySQL8.0 but you are right they are applicable to earlier versions of MySQL.  I have removed those changes from my change.","commit_id":"bec522f27db58f7a056b310327fee10cb2554e5f"}]}