)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c43cac19302537570f7b37588235d0b914039854","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error commit: Add Datastore Version Registry Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run upgrade version of trove, we can\u0027t migrate database"},{"line_number":10,"context_line":"of trove and we can\u0027t run cmd to list datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch will help us fix above error"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"76c164ad_70f37e5d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"updated":"2024-10-31 14:36:22.000000000","message":"When upgrading Trove, the trove-manage script fails to upgrade the database when the DBDatastoreVersion table is not empty.\n\nAlso i can\u0027t reproduce the `list datastore version` issue","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"8d456eb5f7dfac21f0a8c92d0b22d62a092c3821","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error commit: Add Datastore Version Registry Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run upgrade version of trove, we can\u0027t migrate database"},{"line_number":10,"context_line":"of trove and we can\u0027t run cmd to list datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch will help us fix above error"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"40377b83_3f98dd7c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"1bef10f3_ca70d2e7","updated":"2024-11-05 02:54:01.000000000","message":"I don\u0027t know why, but in other my system, I had this error and I was trace in code and I saw DBDatastoreVersion database model hasn\u0027t `registry_ext` \u0026 `repl_strategy` attr - this isn\u0027t my expected.\nAnd api return 500 and raise [here](https://opendev.org/openstack/trove/src/commit/3ff639047eea34c416872014639258d9ecdf067b/trove/datastore/views.py#L94)","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"946f6a992f1ce0cc0b6f807cb05ad9608e72d41c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error commit: Add Datastore Version Registry Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run upgrade version of trove, we can\u0027t migrate database"},{"line_number":10,"context_line":"of trove and we can\u0027t run cmd to list datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch will help us fix above error"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8df17f53_5d7d13dc","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"40377b83_3f98dd7c","updated":"2024-11-05 06:01:38.000000000","message":"Hi, The error you encountered when executing `openstack datastore list` is due the failure of the db migration.","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"5f08960e6363a8a81be31c7f4ecd674ded2321ec","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error commit: Add Datastore Version Registry Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run upgrade version of trove, we can\u0027t migrate database"},{"line_number":10,"context_line":"of trove and we can\u0027t run cmd to list datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch will help us fix above error"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b6f38f9a_b2e48191","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"72ecf8f4_9486fcfb","updated":"2024-11-08 07:07:36.000000000","message":"ok, thanks for the clarification. this is what you fixed in `trove/datastore/models.py` file?","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"efcfd0df5107338c1c877744cff8cb0010f46077","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error commit: Add Datastore Version Registry Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run upgrade version of trove, we can\u0027t migrate database"},{"line_number":10,"context_line":"of trove and we can\u0027t run cmd to list datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch will help us fix above error"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"88490078_55fd5b90","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"76c164ad_70f37e5d","updated":"2024-10-31 15:24:08.000000000","message":"1. When i use command: `openstack datastore list` \u003d\u003e It\u0027s raise error because datastores haven\u0027t above attributes\n2. when I install trove with [upper-contrainst](https://github.com/openstack/requirements/blob/stable/2024.2/upper-constraints.txt) and run command `trove-manager db_sync`. It\u0027s can\u0027t be done and apply new migrate version because this code not work.","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"db5649ba2aef1211216e14045d9bdce27b857a20","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error commit: Add Datastore Version Registry Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run upgrade version of trove, we can\u0027t migrate database"},{"line_number":10,"context_line":"of trove and we can\u0027t run cmd to list datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch will help us fix above error"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1bef10f3_ca70d2e7","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"88490078_55fd5b90","updated":"2024-11-01 08:28:39.000000000","message":"thanks for the patch. as you updated the datastore version field. the api response also be changed. maybe we need to update api document too?  document is here: https://docs.openstack.org/api-ref/database/#id8\nbut the actual response is \n```\n{\n  \"active\": true,\n  \"datastore\": \"3423e828-3355-48ef-9c16-5c41e7c196fb\",\n  \"id\": \"800774c4-0505-4ae7-8cf9-aae131e065ae\",\n  \"image\": null,\n  \"image_tags\": [\n    \"trove\"\n  ],\n  \"name\": \"5.7\",\n  \"packages\": \"\",\n  \"registry_ext\": \"trove.guestagent.datastore.mysql.manager.Manager\",\n  \"repl_strategy\": \"trove.guestagent.strategies.replication.mysql_gtid.MysqlGTIDReplication\",\n  \"version\": \"5.7\"\n}\n```","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"0c015af2520848c0aef897aa99e83d267d681509","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error commit: Add Datastore Version Registry Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run upgrade version of trove, we can\u0027t migrate database"},{"line_number":10,"context_line":"of trove and we can\u0027t run cmd to list datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch will help us fix above error"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"72ecf8f4_9486fcfb","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"8df17f53_5d7d13dc","updated":"2024-11-06 16:35:03.000000000","message":"`due the failure of the db migration` - no. this patch was helped me migrate database success. but when i run above command. it is raise above error","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"8ec17d5a42bd8c5151176ddd2866b10ff798f946","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix error commit: Add Datastore Version Registry Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we run upgrade version of trove, we can\u0027t migrate database"},{"line_number":10,"context_line":"of trove and we can\u0027t run cmd to list datastore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch will help us fix above error"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"78b5a765_948ded8d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"b6f38f9a_b2e48191","updated":"2024-11-14 08:27:58.000000000","message":"yup.","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"1b7d00101fa5ee44dcb51d8559fcbe787775ea2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e1282882_a2c5ffb9","updated":"2024-10-31 10:41:56.000000000","message":"@wchy1001@gmail.com let help me review this patch","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"341dc995c2dde6c153cf658695696407bab61647","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58a20e07_e4cfe0e9","updated":"2024-10-31 13:52:08.000000000","message":"how can i reproduce this issue? I tested it in my dev environment, and I can execute \u0027 openstack datastore version list  mysql\u0027","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"c43cac19302537570f7b37588235d0b914039854","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f9a9cd59_1d558d1b","updated":"2024-10-31 14:36:22.000000000","message":"well, i reproduced it and this patch works properly. do you think a release note is needed ?","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"6193cd47f69314650480686383429989297422ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c149c275_89b27cf7","in_reply_to":"e1282882_a2c5ffb9","updated":"2024-10-31 13:43:26.000000000","message":"ok, i will take a review soon","commit_id":"55e43402e18089e33678536cc384d14900c5b5b9"}],"api-ref/source/samples/datastore-version-show-response.json":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"d8e40b5e27748de183b07ddc95756b74703dcf89","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      \"image_tags\": ["},{"line_number":23,"context_line":"        \"trove\""},{"line_number":24,"context_line":"      ]"},{"line_number":25,"context_line":"    }"},{"line_number":26,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"405825de_31d6f83f","line":25,"updated":"2024-11-05 06:36:39.000000000","message":"Hi @Bo, please help me confirm this response json.","commit_id":"596134e3ad3b96deca937b1dcb7b79dd80f3c32d"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"0c015af2520848c0aef897aa99e83d267d681509","unresolved":true,"context_lines":[{"line_number":22,"context_line":"      \"image_tags\": ["},{"line_number":23,"context_line":"        \"trove\""},{"line_number":24,"context_line":"      ]"},{"line_number":25,"context_line":"    }"},{"line_number":26,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"9ff564cc_a91cee53","line":25,"in_reply_to":"405825de_31d6f83f","updated":"2024-11-06 16:35:03.000000000","message":"this response is correct like my expected","commit_id":"596134e3ad3b96deca937b1dcb7b79dd80f3c32d"}]}