)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"677b27aa4efbbf069f6ee822a6132489786a98f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Updates RPC API to use oslo.messaging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibd886f3cb4a45250c7c434b3af711abee266671c"},{"line_number":10,"context_line":"Implements: blueprint rpc-versioning"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ae5cdf2_d994008e","line":10,"updated":"2014-06-27 10:09:52.000000000","message":"it should also mention: oslo-messaging","commit_id":"63a33fbb8864077eb61bf60deb6ecc08728e9a65"}],"etc/trove/trove-conductor.conf.sample":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"f5e8d4a8fac00dca14cc8ece2ad5576036818b86","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# The RabbitMQ virtual host. (string value)"},{"line_number":29,"context_line":"#rabbit_virtual_host\u003d/"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"rpc_backend \u003d trove.openstack.common.rpc.impl_kombu"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# The manager class to use for conductor. (string value)"},{"line_number":34,"context_line":"conductor_manager \u003d trove.conductor.manager.Manager"}],"source_content_type":"application/octet-stream","patch_set":36,"id":"fa98f980_eb0a8d1e","line":31,"updated":"2014-09-15 14:37:40.000000000","message":"I still have to change all rpc related configuration parameters.","commit_id":"e78b84db053303c448d6f2527334d29a99baf77d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#rabbit_virtual_host\u003d/"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# RabbitMQ topic used for OpenStack notifications. (list value)"},{"line_number":32,"context_line":"#rabbit_notification_topic \u003d [\u0027notifications\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"rpc_backend \u003d trove.openstack.common.rpc.impl_kombu"},{"line_number":35,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"5a890539_79cad2a2","side":"PARENT","line":32,"updated":"2014-11-10 17:29:50.000000000","message":"unclear why you are removing this commented line.","commit_id":"38aaa60b6c148c32600e057087aca804611433c8"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#rabbit_virtual_host\u003d/"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# RabbitMQ topic used for OpenStack notifications. (list value)"},{"line_number":32,"context_line":"#rabbit_notification_topic \u003d [\u0027notifications\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"rpc_backend \u003d trove.openstack.common.rpc.impl_kombu"},{"line_number":35,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"5a890539_4931aeeb","side":"PARENT","line":32,"in_reply_to":"5a890539_79cad2a2","updated":"2014-11-12 09:07:53.000000000","message":"This is unused parameter.","commit_id":"38aaa60b6c148c32600e057087aca804611433c8"}],"etc/trove/trove-guestagent.conf.sample":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# The RabbitMQ virtual host. (string value)"},{"line_number":26,"context_line":"# rabbit_virtual_host\u003d/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# RabbitMQ topic used for OpenStack notifications. (list value)"},{"line_number":29,"context_line":"# rabbit_notification_topic \u003d [\u0027notifications\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"5a890539_99cf7eb0","side":"PARENT","line":28,"updated":"2014-11-10 17:29:50.000000000","message":"same question as conductor sample.","commit_id":"38aaa60b6c148c32600e057087aca804611433c8"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# The RabbitMQ virtual host. (string value)"},{"line_number":26,"context_line":"# rabbit_virtual_host\u003d/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# RabbitMQ topic used for OpenStack notifications. (list value)"},{"line_number":29,"context_line":"# rabbit_notification_topic \u003d [\u0027notifications\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":43,"id":"5a890539_a920529c","side":"PARENT","line":28,"in_reply_to":"5a890539_99cf7eb0","updated":"2014-11-12 09:07:53.000000000","message":"This is unused parameter.","commit_id":"38aaa60b6c148c32600e057087aca804611433c8"}],"requirements.txt":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f5d05c12756991c4f7fe2f8d5a76cad00b61a0e0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Babel\u003e\u003d1.3"},{"line_number":30,"context_line":"six\u003e\u003d1.7.0"},{"line_number":31,"context_line":"stevedore\u003e\u003d0.14"},{"line_number":32,"context_line":"oslo.messaging\u003e\u003d1.3.0"}],"source_content_type":"text/plain","patch_set":33,"id":"fa98f980_dec114e5","line":32,"updated":"2014-09-15 08:43:26.000000000","message":"Version should matchi the one in global-requirements. \n\nhttps://git.openstack.org/cgit/openstack/requirements/tree/global-requirements.txt#n59","commit_id":"89ba1067c1fd42746b877067e45f563a564c2ea1"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"38538118bfd65ad536f47d5460f70caf0d74db74","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Babel\u003e\u003d1.3"},{"line_number":33,"context_line":"six\u003e\u003d1.7.0"},{"line_number":34,"context_line":"stevedore\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":35,"context_line":"oslo.messaging\u003e\u003d1.4.0.0a3"},{"line_number":36,"context_line":""}],"source_content_type":"text/plain","patch_set":40,"id":"baa201ad_91576fc9","line":35,"updated":"2014-10-08 16:35:27.000000000","message":"Requirement oslo.messaging\u003e\u003d1.4.0.0a3 does not match openstack/requirements value oslo.messaging\u003e\u003d1.4.0\n\nfrom gate job","commit_id":"4007e3b876678f2aa622de5efbfeec370f53a8b4"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"042d5f91d40f0ece5aa6f6f1f1bdb28a0c0e93c0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Babel\u003e\u003d1.3"},{"line_number":33,"context_line":"six\u003e\u003d1.7.0"},{"line_number":34,"context_line":"stevedore\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":35,"context_line":"oslo.messaging\u003e\u003d1.4.0.0a3"},{"line_number":36,"context_line":""}],"source_content_type":"text/plain","patch_set":40,"id":"baa201ad_7f62a617","line":35,"in_reply_to":"baa201ad_91576fc9","updated":"2014-10-10 08:17:10.000000000","message":"I didn\u0027t publish new rebase yet. Thanks for this comment.","commit_id":"4007e3b876678f2aa622de5efbfeec370f53a8b4"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9587e40d0f675cde99e75ea8bf1f79332ea5db6b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"six\u003e\u003d1.7.0"},{"line_number":34,"context_line":"stevedore\u003e\u003d1.1.0  # Apache-2.0"},{"line_number":35,"context_line":"ordereddict"},{"line_number":36,"context_line":"oslo.messaging\u003e\u003d1.4.0"},{"line_number":37,"context_line":""}],"source_content_type":"text/plain","patch_set":50,"id":"3a961159_4bcefa5b","line":36,"updated":"2014-12-08 21:15:08.000000000","message":"oslo.messaging\u003e\u003d1.4.0,!\u003d1.5.0","commit_id":"c082e99df400071fb372b312c8d9b2214cc9407e"}],"trove/cmd/guest.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":39,"context_line":"CONF.register_opts([openstack_cfg.StrOpt(\u0027guest_id\u0027, default\u003dNone,"},{"line_number":40,"context_line":"                                         help\u003d\"ID of the Guest Instance.\")])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO(sgotliv): find common place to retrieve rpc api version"},{"line_number":43,"context_line":"# based on configured release version"},{"line_number":44,"context_line":"RPC_API_VERSION \u003d \"3.0\""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_9dd59845","line":42,"updated":"2014-11-10 17:29:50.000000000","message":"Is this something that should be done before commit?\n\nIt should be easy enough to put it into trove/common/something.py, no?","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d3a3e97713784b5876327675bb278d5fc2b3f74a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"CONF.register_opts([openstack_cfg.StrOpt(\u0027guest_id\u0027, default\u003dNone,"},{"line_number":40,"context_line":"                                         help\u003d\"ID of the Guest Instance.\")])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO(sgotliv): find common place to retrieve rpc api version"},{"line_number":43,"context_line":"# based on configured release version"},{"line_number":44,"context_line":"RPC_API_VERSION \u003d \"3.0\""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_729397a3","line":42,"in_reply_to":"5a890539_9dd59845","updated":"2014-11-11 23:13:49.000000000","message":"I\u0027d say that we should keep version in cfg.py to be able to lauch different guests with different versions for example.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"CONF.register_opts([openstack_cfg.StrOpt(\u0027guest_id\u0027, default\u003dNone,"},{"line_number":40,"context_line":"                                         help\u003d\"ID of the Guest Instance.\")])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO(sgotliv): find common place to retrieve rpc api version"},{"line_number":43,"context_line":"# based on configured release version"},{"line_number":44,"context_line":"RPC_API_VERSION \u003d \"3.0\""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_8979d695","line":42,"in_reply_to":"5a890539_9dd59845","updated":"2014-11-12 09:07:53.000000000","message":"I\u0027ll move it to trove/common/rpc/version.py","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0b3ebcdbd0818d4bd24c0a85b9b95ed918ee69e2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from oslo.config import cfg as openstack_cfg"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from trove.common import cfg"},{"line_number":30,"context_line":"from trove.common import debug_utils"},{"line_number":31,"context_line":"from trove.openstack.common import log as logging"},{"line_number":32,"context_line":"from trove.openstack.common import service as openstack_service"}],"source_content_type":"text/x-python","patch_set":54,"id":"3a961159_43464f50","line":29,"updated":"2014-12-12 11:30:06.000000000","message":"your problem with the guest agent is here.\n\nThe `trove.common.cfg` module is importing rpc, which is importing oslo.messaging and setting the localcontext before everything is monkeypatched.","commit_id":"fbffd9208e5dab199653851272ec9bb2447a03c3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"6386d481d44b99c0f79ec08ef561b565201cc182","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from oslo.config import cfg as openstack_cfg"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from trove.common import cfg"},{"line_number":30,"context_line":"from trove.common import debug_utils"},{"line_number":31,"context_line":"from trove.openstack.common import log as logging"},{"line_number":32,"context_line":"from trove.openstack.common import service as openstack_service"}],"source_content_type":"text/x-python","patch_set":54,"id":"3a961159_9eaecc7f","line":29,"in_reply_to":"3a961159_43464f50","updated":"2014-12-12 12:25:37.000000000","message":"Thanks! Unfortunately, chasing after imports is not a good solution in the long term.\nSo we decided to remove remote debugging functionality which created a need to postpone monkeypatching of the thread module in the first place.","commit_id":"fbffd9208e5dab199653851272ec9bb2447a03c3"}],"trove/common/cfg.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.config import cfg"},{"line_number":19,"context_line":"from trove.openstack.common import log as logging"},{"line_number":20,"context_line":"from trove import rpc"},{"line_number":21,"context_line":"import os.path"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"UNKNOWN_SERVICE_ID \u003d \u0027unknown-service-id-error\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_8b598f5c","line":20,"updated":"2014-08-20 08:40:56.000000000","message":"please organize imports in correct order","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"030771804a67ea6b933aa75d77ee031c66a6d6d7","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.config import cfg"},{"line_number":19,"context_line":"from trove.openstack.common import log as logging"},{"line_number":20,"context_line":"from trove import rpc"},{"line_number":21,"context_line":"import os.path"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"UNKNOWN_SERVICE_ID \u003d \u0027unknown-service-id-error\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_9765b81f","line":20,"in_reply_to":"1abeadc6_8b598f5c","updated":"2014-09-14 20:22:26.000000000","message":"Done","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"}],"trove/common/rpc/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"bdeab7a3db3d3f739120806605c54958a5627e8e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.host \u003d host or CONF.host"},{"line_number":45,"context_line":"        self.binary \u003d binary or os.path.basename(inspect.stack()[-1][1])"},{"line_number":46,"context_line":"        self.topic \u003d topic or self.binary.rpartition(\u0027trove-\u0027)[2]"},{"line_number":47,"context_line":"        self.manager_impl \u003d importutils.import_object(manager)"},{"line_number":48,"context_line":"        self.report_interval \u003d CONF.report_interval"},{"line_number":49,"context_line":"        self.rpc_api_version \u003d rpc_api_version or \\"},{"line_number":50,"context_line":"            self.manager_impl.RPC_API_VERSION"}],"source_content_type":"text/x-python","patch_set":44,"id":"5a890539_11a43056","line":47,"updated":"2014-11-19 12:59:13.000000000","message":"The only thing that i\u0027m not quite sure about is that if manager would appear to be \u0027None\u0027 RPC service would fail to start with a bit weired message to user \"ImportError\", shouldn\u0027t we do wrapping for this case?\n\nAlso, i\u0027d say that we should expect set of managers instead of only one, because RPCServer of oslo.messaging allows to have service that runs with single RPC API version but multiple managers (in terms of oslo.messaging - multiple endpoints).","commit_id":"44fa17827b7d9f54b936cfb428d7037b0792c12b"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"0dd5b782a7a211d45908127d523b968dfe46108c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.host \u003d host or CONF.host"},{"line_number":45,"context_line":"        self.binary \u003d binary or os.path.basename(inspect.stack()[-1][1])"},{"line_number":46,"context_line":"        self.topic \u003d topic or self.binary.rpartition(\u0027trove-\u0027)[2]"},{"line_number":47,"context_line":"        self.manager_impl \u003d importutils.import_object(manager)"},{"line_number":48,"context_line":"        self.report_interval \u003d CONF.report_interval"},{"line_number":49,"context_line":"        self.rpc_api_version \u003d rpc_api_version or \\"},{"line_number":50,"context_line":"            self.manager_impl.RPC_API_VERSION"}],"source_content_type":"text/x-python","patch_set":44,"id":"5a890539_f4b8fb12","line":47,"in_reply_to":"5a890539_11a43056","updated":"2014-11-23 14:24:08.000000000","message":"Denis,\n\nI agree with both comments but since they are not related to what I am trying to do here I will address them in another patch right after this one is merged.\n\nI\u0027ll open a launchpad bug so we can follow after the progress.","commit_id":"44fa17827b7d9f54b936cfb428d7037b0792c12b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"bdeab7a3db3d3f739120806605c54958a5627e8e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if not hasattr(self.manager_impl, \u0027target\u0027):"},{"line_number":59,"context_line":"            self.manager_impl.target \u003d target"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        endpoints \u003d [self.manager_impl]"},{"line_number":62,"context_line":"        self.rpcserver \u003d rpc.get_server(target, endpoints)"},{"line_number":63,"context_line":"        self.rpcserver.start()"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"5a890539_14cfbeb1","line":61,"updated":"2014-11-19 12:59:13.000000000","message":"that\u0027s why i\u0027m talking about, what if some want\u0027s to launch another instance of additional endpoint? there\u0027s no way, could you please address this?","commit_id":"44fa17827b7d9f54b936cfb428d7037b0792c12b"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"0dd5b782a7a211d45908127d523b968dfe46108c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if not hasattr(self.manager_impl, \u0027target\u0027):"},{"line_number":59,"context_line":"            self.manager_impl.target \u003d target"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        endpoints \u003d [self.manager_impl]"},{"line_number":62,"context_line":"        self.rpcserver \u003d rpc.get_server(target, endpoints)"},{"line_number":63,"context_line":"        self.rpcserver.start()"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"5a890539_74440b1b","line":61,"in_reply_to":"5a890539_14cfbeb1","updated":"2014-11-23 14:24:08.000000000","message":"I agree and will address it in another patch.","commit_id":"44fa17827b7d9f54b936cfb428d7037b0792c12b"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8c483685a96953beff926be16cb5cb0ea17e8041","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            self.manager_impl.RPC_API_VERSION"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def start(self):"},{"line_number":50,"context_line":"        LOG.debug(_(\"Creating RPC server for service %s\") % self.topic)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        target \u003d messaging.Target(topic\u003dself.topic, server\u003dself.host,"},{"line_number":53,"context_line":"                                  version\u003dself.rpc_api_version)"}],"source_content_type":"text/x-python","patch_set":45,"id":"5a890539_cfa8af8e","line":50,"updated":"2014-11-24 17:09:06.000000000","message":"Debug messages shouldn\u0027t be internationalized","commit_id":"93b7c7d5648784772873280a370b853601ac3400"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"a1624b11b0af62eeccb93649c7bfc83f31256553","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            self.manager_impl.RPC_API_VERSION"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def start(self):"},{"line_number":50,"context_line":"        LOG.debug(_(\"Creating RPC server for service %s\") % self.topic)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        target \u003d messaging.Target(topic\u003dself.topic, server\u003dself.host,"},{"line_number":53,"context_line":"                                  version\u003dself.rpc_api_version)"}],"source_content_type":"text/x-python","patch_set":45,"id":"5a890539_a4c0e250","line":50,"in_reply_to":"5a890539_cfa8af8e","updated":"2014-11-24 21:10:18.000000000","message":"Done","commit_id":"93b7c7d5648784772873280a370b853601ac3400"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8c483685a96953beff926be16cb5cb0ea17e8041","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # errors, go ahead and ignore them.. as we\u0027re shutting down anyway"},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.rpcserver.stop()"},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            pass"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        super(RpcService, self).stop()"}],"source_content_type":"text/x-python","patch_set":45,"id":"5a890539_8fb787d7","line":75,"updated":"2014-11-24 17:09:06.000000000","message":"I agree that we can ignore this, but should we at least log it first?","commit_id":"93b7c7d5648784772873280a370b853601ac3400"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"a1624b11b0af62eeccb93649c7bfc83f31256553","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        # errors, go ahead and ignore them.. as we\u0027re shutting down anyway"},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            self.rpcserver.stop()"},{"line_number":75,"context_line":"        except Exception:"},{"line_number":76,"context_line":"            pass"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        super(RpcService, self).stop()"}],"source_content_type":"text/x-python","patch_set":45,"id":"5a890539_04cff67f","line":75,"in_reply_to":"5a890539_8fb787d7","updated":"2014-11-24 21:10:18.000000000","message":"Done","commit_id":"93b7c7d5648784772873280a370b853601ac3400"}],"trove/common/rpc/version.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8c483685a96953beff926be16cb5cb0ea17e8041","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":45,"id":"5a890539_6fd5fbe3","line":1,"updated":"2014-11-24 17:09:06.000000000","message":"This should be \u0027(c) 2011, 2014\u0027 if you\u0027re going to change it, but I think adding a line for RedHat with 2014 would probably be more appropriate","commit_id":"93b7c7d5648784772873280a370b853601ac3400"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"a1624b11b0af62eeccb93649c7bfc83f31256553","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":45,"id":"5a890539_c4a88e8e","line":1,"in_reply_to":"5a890539_6fd5fbe3","updated":"2014-11-24 21:10:18.000000000","message":"I didn\u0027t mean to change it.","commit_id":"93b7c7d5648784772873280a370b853601ac3400"}],"trove/conductor/api.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        LOG.debug(\"Making async call to cast heartbeat for instance: %s\""},{"line_number":58,"context_line":"                  % instance_id)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00273.0\u0027)"},{"line_number":61,"context_line":"        cctxt.cast(self.context, \"heartbeat\","},{"line_number":62,"context_line":"                   instance_id\u003dinstance_id,"},{"line_number":63,"context_line":"                   sent\u003dsent,"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_e6d4fa48","line":60,"updated":"2014-08-20 08:40:56.000000000","message":"version should be retrieved from VERSION_ALIASES according to configuration parameter\n\nsee https://review.openstack.org/#/c/94484/18/trove/common/cfg.py,cm\n\nsee https://review.openstack.org/#/c/94484/18/trove/guestagent/api.py,cm","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        LOG.debug(\"Making async call to cast update_backup for instance: %s\""},{"line_number":69,"context_line":"                  % instance_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00273.0\u0027)"},{"line_number":72,"context_line":"        cctxt.cast(self.context, \"update_backup\","},{"line_number":73,"context_line":"                   instance_id\u003dinstance_id,"},{"line_number":74,"context_line":"                   backup_id\u003dbackup_id,"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_e63b1a9a","line":71,"updated":"2014-08-20 08:40:56.000000000","message":"same","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_9d091898","line":1,"updated":"2014-11-10 17:29:50.000000000","message":"why update this, you are weakening the copyright","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_34f91ac9","line":1,"in_reply_to":"5a890539_9d091898","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":"RPC_API_VERSION \u003d \"3.0\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class API(object):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_5d69708a","line":23,"updated":"2014-11-10 17:29:50.000000000","message":"this manifest constant in many places is asking for trouble, IMHO","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d cfg.CONF"},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":"RPC_API_VERSION \u003d \"3.0\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class API(object):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_699bcac9","line":23,"in_reply_to":"5a890539_5d69708a","updated":"2014-11-12 09:07:53.000000000","message":"Agree. I will move it to trove/common/rpc.py.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"}],"trove/conductor/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from trove.openstack.common import log as logging"},{"line_number":22,"context_line":"from trove.openstack.common import periodic_task"},{"line_number":23,"context_line":"from trove.openstack.common.gettextutils import _"},{"line_number":24,"context_line":"from oslo import messaging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_a65122da","line":24,"updated":"2014-08-20 08:40:56.000000000","message":"please organize imports in correct order","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"030771804a67ea6b933aa75d77ee031c66a6d6d7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from trove.openstack.common import log as logging"},{"line_number":22,"context_line":"from trove.openstack.common import periodic_task"},{"line_number":23,"context_line":"from trove.openstack.common.gettextutils import _"},{"line_number":24,"context_line":"from oslo import messaging"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_77a3f442","line":24,"in_reply_to":"1abeadc6_a65122da","updated":"2014-09-14 20:22:26.000000000","message":"Done","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"}],"trove/extensions/mgmt/instances/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from trove.common import remote"},{"line_number":18,"context_line":"from trove.common import utils"},{"line_number":19,"context_line":"from trove.openstack.common import log as logging"},{"line_number":20,"context_line":"from trove import rpc"},{"line_number":21,"context_line":"from trove.instance import models as imodels"},{"line_number":22,"context_line":"from trove.instance.models import load_instance, InstanceServiceStatus"},{"line_number":23,"context_line":"from trove.instance import models as instance_models"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_860426c1","line":20,"updated":"2014-08-20 08:40:56.000000000","message":"please organize imports","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"030771804a67ea6b933aa75d77ee031c66a6d6d7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from trove.common import remote"},{"line_number":18,"context_line":"from trove.common import utils"},{"line_number":19,"context_line":"from trove.openstack.common import log as logging"},{"line_number":20,"context_line":"from trove import rpc"},{"line_number":21,"context_line":"from trove.instance import models as imodels"},{"line_number":22,"context_line":"from trove.instance.models import load_instance, InstanceServiceStatus"},{"line_number":23,"context_line":"from trove.instance import models as instance_models"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_f76e04ff","line":20,"in_reply_to":"1abeadc6_860426c1","updated":"2014-09-14 20:22:26.000000000","message":"Done","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"}],"trove/guestagent/api.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"437a161be65500c41a759d3f9e2fadd3006a102e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_4f1074a8","line":1,"updated":"2014-06-10 17:27:55.000000000","message":"Header shoul not be changed.","commit_id":"72c9bc9d833974bbc7dab156847cb043d2170b0b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"437a161be65500c41a759d3f9e2fadd3006a102e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        \"\"\"Make an asynchronous call to change the passwords of one or more"},{"line_number":146,"context_line":"           users."},{"line_number":147,"context_line":"        \"\"\""},{"line_number":148,"context_line":"        LOG.debug(_(\"Changing passwords for users on Instance %s\"), self.id)"},{"line_number":149,"context_line":"        self._cast(\"change_passwords\", \u00273.0\u0027, users\u003dusers)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def update_attributes(self, username, hostname, user_attrs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_cf72c410","line":148,"updated":"2014-06-10 17:27:55.000000000","message":"debug messages should not be coverd with translations.","commit_id":"72c9bc9d833974bbc7dab156847cb043d2170b0b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from trove import rpc"},{"line_number":27,"context_line":"from trove.openstack.common import log as logging"},{"line_number":28,"context_line":"from trove.openstack.common.gettextutils import _"},{"line_number":29,"context_line":"from trove.guestagent import models as agent_models"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_06281633","line":29,"updated":"2014-08-20 08:40:56.000000000","message":"please organize imports in correct order","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"030771804a67ea6b933aa75d77ee031c66a6d6d7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from trove import rpc"},{"line_number":27,"context_line":"from trove.openstack.common import log as logging"},{"line_number":28,"context_line":"from trove.openstack.common.gettextutils import _"},{"line_number":29,"context_line":"from trove.guestagent import models as agent_models"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d cfg.CONF"},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_577fd0aa","line":29,"in_reply_to":"1abeadc6_06281633","updated":"2014-09-14 20:22:26.000000000","message":"Done","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        return self._call(\"list_access\", AGENT_LOW_TIMEOUT,"},{"line_number":137,"context_line":"                          username\u003dusername, hostname\u003dhostname)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def grant_access(self, username, hostname, databases):"},{"line_number":140,"context_line":"        \"\"\"Grant a user permission to use a given database.\"\"\""},{"line_number":141,"context_line":"        return self._call(\"grant_access\", AGENT_LOW_TIMEOUT,"},{"line_number":142,"context_line":"                          username\u003dusername, hostname\u003dhostname,"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_fde69c15","side":"PARENT","line":139,"updated":"2014-11-10 17:29:50.000000000","message":"no log.debug here?","commit_id":"38aaa60b6c148c32600e057087aca804611433c8"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        return self._call(\"list_access\", AGENT_LOW_TIMEOUT,"},{"line_number":137,"context_line":"                          username\u003dusername, hostname\u003dhostname)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def grant_access(self, username, hostname, databases):"},{"line_number":140,"context_line":"        \"\"\"Grant a user permission to use a given database.\"\"\""},{"line_number":141,"context_line":"        return self._call(\"grant_access\", AGENT_LOW_TIMEOUT,"},{"line_number":142,"context_line":"                          username\u003dusername, hostname\u003dhostname,"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_ab1da1bf","side":"PARENT","line":139,"in_reply_to":"5a890539_fde69c15","updated":"2014-11-12 09:07:53.000000000","message":"Will do in another patch.","commit_id":"38aaa60b6c148c32600e057087aca804611433c8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                          username\u003dusername, hostname\u003dhostname,"},{"line_number":143,"context_line":"                          databases\u003ddatabases)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def revoke_access(self, username, hostname, database):"},{"line_number":146,"context_line":"        \"\"\"Remove a user\u0027s permission to use a given database.\"\"\""},{"line_number":147,"context_line":"        return self._call(\"revoke_access\", AGENT_LOW_TIMEOUT,"},{"line_number":148,"context_line":"                          username\u003dusername, hostname\u003dhostname,"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_1de4480c","side":"PARENT","line":145,"updated":"2014-11-10 17:29:50.000000000","message":"no log debug here?","commit_id":"38aaa60b6c148c32600e057087aca804611433c8"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                          username\u003dusername, hostname\u003dhostname,"},{"line_number":143,"context_line":"                          databases\u003ddatabases)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def revoke_access(self, username, hostname, database):"},{"line_number":146,"context_line":"        \"\"\"Remove a user\u0027s permission to use a given database.\"\"\""},{"line_number":147,"context_line":"        return self._call(\"revoke_access\", AGENT_LOW_TIMEOUT,"},{"line_number":148,"context_line":"                          username\u003dusername, hostname\u003dhostname,"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_ab74c1fd","side":"PARENT","line":145,"in_reply_to":"5a890539_1de4480c","updated":"2014-11-12 09:07:53.000000000","message":"Will add in another patch.","commit_id":"38aaa60b6c148c32600e057087aca804611433c8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_1dce085b","line":1,"updated":"2014-11-10 17:29:50.000000000","message":"why are you updating this? in effect you are weakening the copyright.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_290382b9","line":1,"in_reply_to":"5a890539_1dce085b","updated":"2014-11-12 09:07:53.000000000","message":"I don\u0027t know :-), just decided to experiment with the copyright. Will revert this change.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            LOG.debug(\"Result is %s.\" % result)"},{"line_number":75,"context_line":"            return result"},{"line_number":76,"context_line":"        except RemoteError as r:"},{"line_number":77,"context_line":"            LOG.error(r)"},{"line_number":78,"context_line":"            raise exception.GuestError(original_message\u003dr.value)"},{"line_number":79,"context_line":"        except Exception as e:"},{"line_number":80,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_fdf85cc6","line":77,"updated":"2014-11-10 17:29:50.000000000","message":"shouldn\u0027t you log.exception?","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            LOG.debug(\"Result is %s.\" % result)"},{"line_number":75,"context_line":"            return result"},{"line_number":76,"context_line":"        except RemoteError as r:"},{"line_number":77,"context_line":"            LOG.error(r)"},{"line_number":78,"context_line":"            raise exception.GuestError(original_message\u003dr.value)"},{"line_number":79,"context_line":"        except Exception as e:"},{"line_number":80,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_4077bcd4","line":77,"in_reply_to":"5a890539_fdf85cc6","updated":"2014-11-12 09:07:53.000000000","message":"Actually, I should avoid doing unrelated changes :-).","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            cctxt \u003d self.client.prepare(version\u003dversion)"},{"line_number":89,"context_line":"            cctxt.cast(self.context, method_name, **kwargs)"},{"line_number":90,"context_line":"        except RemoteError as r:"},{"line_number":91,"context_line":"            LOG.error(r)"},{"line_number":92,"context_line":"            raise exception.GuestError(original_message\u003dr.value)"},{"line_number":93,"context_line":"        except Exception as e:"},{"line_number":94,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_1df608d8","line":91,"updated":"2014-11-10 17:29:50.000000000","message":"log exception?","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            cctxt \u003d self.client.prepare(version\u003dversion)"},{"line_number":89,"context_line":"            cctxt.cast(self.context, method_name, **kwargs)"},{"line_number":90,"context_line":"        except RemoteError as r:"},{"line_number":91,"context_line":"            LOG.error(r)"},{"line_number":92,"context_line":"            raise exception.GuestError(original_message\u003dr.value)"},{"line_number":93,"context_line":"        except Exception as e:"},{"line_number":94,"context_line":"            LOG.exception(_(\"Error calling %s\") % method_name)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_09e4060c","line":91,"in_reply_to":"5a890539_1df608d8","updated":"2014-11-12 09:07:53.000000000","message":"Remove unrelated change.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"\"\"Make an asynchronous call to change the passwords of one or more"},{"line_number":103,"context_line":"           users."},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        LOG.debug(_(\"Changing passwords for users on Instance %s\"), self.id)"},{"line_number":106,"context_line":"        self._cast(\"change_passwords\", self.version_cap, users\u003dusers)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_attributes(self, username, hostname, user_attrs):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_3d03c4b9","line":105,"updated":"2014-11-10 17:29:50.000000000","message":"don\u0027t i18n a .debug message","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d3a3e97713784b5876327675bb278d5fc2b3f74a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"\"\"Make an asynchronous call to change the passwords of one or more"},{"line_number":103,"context_line":"           users."},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        LOG.debug(_(\"Changing passwords for users on Instance %s\"), self.id)"},{"line_number":106,"context_line":"        self._cast(\"change_passwords\", self.version_cap, users\u003dusers)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_attributes(self, username, hostname, user_attrs):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_12f413f1","line":105,"in_reply_to":"5a890539_3d03c4b9","updated":"2014-11-11 23:13:49.000000000","message":"+1 to all concerns about debug stuff.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"\"\"Make an asynchronous call to change the passwords of one or more"},{"line_number":103,"context_line":"           users."},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        LOG.debug(_(\"Changing passwords for users on Instance %s\"), self.id)"},{"line_number":106,"context_line":"        self._cast(\"change_passwords\", self.version_cap, users\u003dusers)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_attributes(self, username, hostname, user_attrs):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_a055c01e","line":105,"in_reply_to":"5a890539_3d03c4b9","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_attributes(self, username, hostname, user_attrs):"},{"line_number":109,"context_line":"        \"\"\"Update user attributes.\"\"\""},{"line_number":110,"context_line":"        LOG.debug(_(\"Changing user attributes on Instance %s\"), self.id)"},{"line_number":111,"context_line":"        self._cast(\"update_attributes\", self.version_cap,"},{"line_number":112,"context_line":"                   username\u003dusername, hostname\u003dhostname, user_attrs\u003duser_attrs)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_7d2c6c4b","line":110,"updated":"2014-11-10 17:29:50.000000000","message":"no i18n on debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def update_attributes(self, username, hostname, user_attrs):"},{"line_number":109,"context_line":"        \"\"\"Update user attributes.\"\"\""},{"line_number":110,"context_line":"        LOG.debug(_(\"Changing user attributes on Instance %s\"), self.id)"},{"line_number":111,"context_line":"        self._cast(\"update_attributes\", self.version_cap,"},{"line_number":112,"context_line":"                   username\u003dusername, hostname\u003dhostname, user_attrs\u003duser_attrs)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_c031ec0c","line":110,"in_reply_to":"5a890539_7d2c6c4b","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def create_user(self, users):"},{"line_number":115,"context_line":"        \"\"\"Make an asynchronous call to create a new database user\"\"\""},{"line_number":116,"context_line":"        LOG.debug(_(\"Creating Users for Instance %s\"), self.id)"},{"line_number":117,"context_line":"        self._cast(\"create_user\", self.version_cap, users\u003dusers)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def get_user(self, username, hostname):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_fd1f7c07","line":116,"updated":"2014-11-10 17:29:50.000000000","message":"no i18n on debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def create_user(self, users):"},{"line_number":115,"context_line":"        \"\"\"Make an asynchronous call to create a new database user\"\"\""},{"line_number":116,"context_line":"        LOG.debug(_(\"Creating Users for Instance %s\"), self.id)"},{"line_number":117,"context_line":"        self._cast(\"create_user\", self.version_cap, users\u003dusers)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def get_user(self, username, hostname):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_003cd4e1","line":116,"in_reply_to":"5a890539_fd1f7c07","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def get_user(self, username, hostname):"},{"line_number":120,"context_line":"        \"\"\"Make an asynchronous call to get a single database user.\"\"\""},{"line_number":121,"context_line":"        LOG.debug(\"Getting a user on Instance %s\", self.id)"},{"line_number":122,"context_line":"        LOG.debug(\"User name is %s\" % username)"},{"line_number":123,"context_line":"        return self._call(\"get_user\", AGENT_LOW_TIMEOUT, self.version_cap,"},{"line_number":124,"context_line":"                          username\u003dusername, hostname\u003dhostname)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_3d1ae417","line":121,"updated":"2014-11-10 17:29:50.000000000","message":"can you make this one log call?","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def get_user(self, username, hostname):"},{"line_number":120,"context_line":"        \"\"\"Make an asynchronous call to get a single database user.\"\"\""},{"line_number":121,"context_line":"        LOG.debug(\"Getting a user on Instance %s\", self.id)"},{"line_number":122,"context_line":"        LOG.debug(\"User name is %s\" % username)"},{"line_number":123,"context_line":"        return self._call(\"get_user\", AGENT_LOW_TIMEOUT, self.version_cap,"},{"line_number":124,"context_line":"                          username\u003dusername, hostname\u003dhostname)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_cb882d25","line":121,"in_reply_to":"5a890539_3d1ae417","updated":"2014-11-12 09:07:53.000000000","message":"I\u0027ll return a dot. I\u0027ll send another patch for one log call and other log improvements you\u0027ve proposed here.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def list_access(self, username, hostname):"},{"line_number":127,"context_line":"        \"\"\"Show all the databases to which a user has more than USAGE.\"\"\""},{"line_number":128,"context_line":"        LOG.debug(\"Showing user grants on Instance %s\", self.id)"},{"line_number":129,"context_line":"        LOG.debug(\"User name is %s\" % username)"},{"line_number":130,"context_line":"        return self._call(\"list_access\", AGENT_LOW_TIMEOUT, self.version_cap,"},{"line_number":131,"context_line":"                          username\u003dusername, hostname\u003dhostname)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_9dd83855","line":128,"updated":"2014-11-10 17:29:50.000000000","message":"similarly, make it one call?","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def list_access(self, username, hostname):"},{"line_number":127,"context_line":"        \"\"\"Show all the databases to which a user has more than USAGE.\"\"\""},{"line_number":128,"context_line":"        LOG.debug(\"Showing user grants on Instance %s\", self.id)"},{"line_number":129,"context_line":"        LOG.debug(\"User name is %s\" % username)"},{"line_number":130,"context_line":"        return self._call(\"list_access\", AGENT_LOW_TIMEOUT, self.version_cap,"},{"line_number":131,"context_line":"                          username\u003dusername, hostname\u003dhostname)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_eb8de932","line":128,"in_reply_to":"5a890539_9dd83855","updated":"2014-11-12 09:07:53.000000000","message":"Same as above.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        \"\"\"Make an asynchronous call to create a new database"},{"line_number":160,"context_line":"           within the specified container"},{"line_number":161,"context_line":"        \"\"\""},{"line_number":162,"context_line":"        LOG.debug(_(\"Creating databases for Instance %s\"), self.id)"},{"line_number":163,"context_line":"        self._cast(\"create_database\", self.version_cap, databases\u003ddatabases)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def list_databases(self, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_3df104ce","line":162,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        \"\"\"Make an asynchronous call to create a new database"},{"line_number":160,"context_line":"           within the specified container"},{"line_number":161,"context_line":"        \"\"\""},{"line_number":162,"context_line":"        LOG.debug(_(\"Creating databases for Instance %s\"), self.id)"},{"line_number":163,"context_line":"        self._cast(\"create_database\", self.version_cap, databases\u003ddatabases)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def list_databases(self, limit\u003dNone, marker\u003dNone, include_marker\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_cba10dab","line":162,"in_reply_to":"5a890539_3df104ce","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        \"\"\"Make an asynchronous call to delete an existing database"},{"line_number":174,"context_line":"           within the specified container"},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        LOG.debug(_(\"Deleting database %(database)s for \""},{"line_number":177,"context_line":"                    \"Instance %(instance_id)s\") % {\u0027database\u0027: database,"},{"line_number":178,"context_line":"                                                   \u0027instance_id\u0027: self.id})"},{"line_number":179,"context_line":"        self._cast(\"delete_database\", self.version_cap, database\u003ddatabase)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_fdcdbc87","line":176,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log.debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        \"\"\"Make an asynchronous call to delete an existing database"},{"line_number":174,"context_line":"           within the specified container"},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        LOG.debug(_(\"Deleting database %(database)s for \""},{"line_number":177,"context_line":"                    \"Instance %(instance_id)s\") % {\u0027database\u0027: database,"},{"line_number":178,"context_line":"                                                   \u0027instance_id\u0027: self.id})"},{"line_number":179,"context_line":"        self._cast(\"delete_database\", self.version_cap, database\u003ddatabase)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_4be7dd12","line":176,"in_reply_to":"5a890539_fdcdbc87","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        \"\"\"Make a synchronous call to enable the root user for"},{"line_number":183,"context_line":"           access from anywhere"},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        LOG.debug(_(\"Enable root user for Instance %s\"), self.id)"},{"line_number":186,"context_line":"        return self._call(\"enable_root\", AGENT_HIGH_TIMEOUT, self.version_cap)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def disable_root(self):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_3dc82474","line":185,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        \"\"\"Make a synchronous call to enable the root user for"},{"line_number":183,"context_line":"           access from anywhere"},{"line_number":184,"context_line":"        \"\"\""},{"line_number":185,"context_line":"        LOG.debug(_(\"Enable root user for Instance %s\"), self.id)"},{"line_number":186,"context_line":"        return self._call(\"enable_root\", AGENT_HIGH_TIMEOUT, self.version_cap)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def disable_root(self):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_6be4990d","line":185,"in_reply_to":"5a890539_3dc82474","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        \"\"\"Make a synchronous call to disable the root user for"},{"line_number":190,"context_line":"           access from anywhere"},{"line_number":191,"context_line":"        \"\"\""},{"line_number":192,"context_line":"        LOG.debug(_(\"Disable root user for Instance %s\"), self.id)"},{"line_number":193,"context_line":"        return self._call(\"disable_root\", AGENT_LOW_TIMEOUT, self.version_cap)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def is_root_enabled(self):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_5dc5f059","line":192,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        \"\"\"Make a synchronous call to disable the root user for"},{"line_number":190,"context_line":"           access from anywhere"},{"line_number":191,"context_line":"        \"\"\""},{"line_number":192,"context_line":"        LOG.debug(_(\"Disable root user for Instance %s\"), self.id)"},{"line_number":193,"context_line":"        return self._call(\"disable_root\", AGENT_LOW_TIMEOUT, self.version_cap)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def is_root_enabled(self):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_8bf1c5cf","line":192,"in_reply_to":"5a890539_5dc5f059","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        \"\"\"Make a synchronous call to check if root access is"},{"line_number":197,"context_line":"           available for the container"},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        LOG.debug(_(\"Check root access for Instance %s\"), self.id)"},{"line_number":200,"context_line":"        return self._call(\"is_root_enabled\", AGENT_LOW_TIMEOUT,"},{"line_number":201,"context_line":"                          self.version_cap)"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_7da1cca8","line":199,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        \"\"\"Make a synchronous call to check if root access is"},{"line_number":197,"context_line":"           available for the container"},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        LOG.debug(_(\"Check root access for Instance %s\"), self.id)"},{"line_number":200,"context_line":"        return self._call(\"is_root_enabled\", AGENT_LOW_TIMEOUT,"},{"line_number":201,"context_line":"                          self.version_cap)"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_2be37108","line":199,"in_reply_to":"5a890539_7da1cca8","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def get_hwinfo(self):"},{"line_number":204,"context_line":"        \"\"\"Make a synchronous call to get hardware info for the container\"\"\""},{"line_number":205,"context_line":"        LOG.debug(_(\"Check hwinfo on Instance %s\"), self.id)"},{"line_number":206,"context_line":"        return self._call(\"get_hwinfo\", AGENT_LOW_TIMEOUT, self.version_cap)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_diagnostics(self):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_bdab3488","line":205,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log.debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def get_hwinfo(self):"},{"line_number":204,"context_line":"        \"\"\"Make a synchronous call to get hardware info for the container\"\"\""},{"line_number":205,"context_line":"        LOG.debug(_(\"Check hwinfo on Instance %s\"), self.id)"},{"line_number":206,"context_line":"        return self._call(\"get_hwinfo\", AGENT_LOW_TIMEOUT, self.version_cap)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_diagnostics(self):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_ebd88955","line":205,"in_reply_to":"5a890539_bdab3488","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_diagnostics(self):"},{"line_number":209,"context_line":"        \"\"\"Make a synchronous call to get diagnostics for the container\"\"\""},{"line_number":210,"context_line":"        LOG.debug(_(\"Check diagnostics on Instance %s\"), self.id)"},{"line_number":211,"context_line":"        return self._call(\"get_diagnostics\", AGENT_LOW_TIMEOUT,"},{"line_number":212,"context_line":"                          self.version_cap)"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_ddb000f7","line":210,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log.debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_diagnostics(self):"},{"line_number":209,"context_line":"        \"\"\"Make a synchronous call to get diagnostics for the container\"\"\""},{"line_number":210,"context_line":"        LOG.debug(_(\"Check diagnostics on Instance %s\"), self.id)"},{"line_number":211,"context_line":"        return self._call(\"get_diagnostics\", AGENT_LOW_TIMEOUT,"},{"line_number":212,"context_line":"                          self.version_cap)"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_0bdeb53f","line":210,"in_reply_to":"5a890539_ddb000f7","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def restart(self):"},{"line_number":256,"context_line":"        \"\"\"Restart the MySQL server.\"\"\""},{"line_number":257,"context_line":"        LOG.debug(_(\"Sending the call to restart MySQL on the Guest.\"))"},{"line_number":258,"context_line":"        self._call(\"restart\", AGENT_HIGH_TIMEOUT, self.version_cap)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def start_db_with_conf_changes(self, config_contents):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_fd94dc45","line":257,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log.debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def restart(self):"},{"line_number":256,"context_line":"        \"\"\"Restart the MySQL server.\"\"\""},{"line_number":257,"context_line":"        LOG.debug(_(\"Sending the call to restart MySQL on the Guest.\"))"},{"line_number":258,"context_line":"        self._call(\"restart\", AGENT_HIGH_TIMEOUT, self.version_cap)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def start_db_with_conf_changes(self, config_contents):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_2b1531f1","line":257,"in_reply_to":"5a890539_fd94dc45","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def start_db_with_conf_changes(self, config_contents):"},{"line_number":261,"context_line":"        \"\"\"Start the MySQL server.\"\"\""},{"line_number":262,"context_line":"        LOG.debug(_(\"Sending the call to start MySQL on the Guest with \""},{"line_number":263,"context_line":"                    \"a timeout of %s.\") % AGENT_HIGH_TIMEOUT)"},{"line_number":264,"context_line":"        self._call(\"start_db_with_conf_changes\", AGENT_HIGH_TIMEOUT,"},{"line_number":265,"context_line":"                   self.version_cap, config_contents\u003dconfig_contents)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_1d928857","line":262,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log.debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def start_db_with_conf_changes(self, config_contents):"},{"line_number":261,"context_line":"        \"\"\"Start the MySQL server.\"\"\""},{"line_number":262,"context_line":"        LOG.debug(_(\"Sending the call to start MySQL on the Guest with \""},{"line_number":263,"context_line":"                    \"a timeout of %s.\") % AGENT_HIGH_TIMEOUT)"},{"line_number":264,"context_line":"        self._call(\"start_db_with_conf_changes\", AGENT_HIGH_TIMEOUT,"},{"line_number":265,"context_line":"                   self.version_cap, config_contents\u003dconfig_contents)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_4bf99dc7","line":262,"in_reply_to":"5a890539_1d928857","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        \"\"\"Ignore running state of MySQL, and just change the config file"},{"line_number":269,"context_line":"           to a new flavor."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        LOG.debug(_(\"Sending the call to change MySQL conf file on the Guest \""},{"line_number":272,"context_line":"                    \"with a timeout of %s.\") % AGENT_HIGH_TIMEOUT)"},{"line_number":273,"context_line":"        self._call(\"reset_configuration\", AGENT_HIGH_TIMEOUT, self.version_cap,"},{"line_number":274,"context_line":"                   configuration\u003dconfiguration)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_5d9c106a","line":271,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log.debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        \"\"\"Ignore running state of MySQL, and just change the config file"},{"line_number":269,"context_line":"           to a new flavor."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        LOG.debug(_(\"Sending the call to change MySQL conf file on the Guest \""},{"line_number":272,"context_line":"                    \"with a timeout of %s.\") % AGENT_HIGH_TIMEOUT)"},{"line_number":273,"context_line":"        self._call(\"reset_configuration\", AGENT_HIGH_TIMEOUT, self.version_cap,"},{"line_number":274,"context_line":"                   configuration\u003dconfiguration)"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_0b107500","line":271,"in_reply_to":"5a890539_5d9c106a","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def stop_db(self, do_not_start_on_reboot\u003dFalse):"},{"line_number":277,"context_line":"        \"\"\"Stop the MySQL server.\"\"\""},{"line_number":278,"context_line":"        LOG.debug(_(\"Sending the call to stop MySQL on the Guest.\"))"},{"line_number":279,"context_line":"        self._call(\"stop_db\", AGENT_HIGH_TIMEOUT, self.version_cap,"},{"line_number":280,"context_line":"                   do_not_start_on_reboot\u003ddo_not_start_on_reboot)"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_7d88ec22","line":278,"updated":"2014-11-10 17:29:50.000000000","message":"i18n on log.debug","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def stop_db(self, do_not_start_on_reboot\u003dFalse):"},{"line_number":277,"context_line":"        \"\"\"Stop the MySQL server.\"\"\""},{"line_number":278,"context_line":"        LOG.debug(_(\"Sending the call to stop MySQL on the Guest.\"))"},{"line_number":279,"context_line":"        self._call(\"stop_db\", AGENT_HIGH_TIMEOUT, self.version_cap,"},{"line_number":280,"context_line":"                   do_not_start_on_reboot\u003ddo_not_start_on_reboot)"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_ab69218d","line":278,"in_reply_to":"5a890539_7d88ec22","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def upgrade(self, instance_version, location, metadata\u003dNone):"},{"line_number":283,"context_line":"        \"\"\"Make an asynchronous call to self upgrade the guest agent.\"\"\""},{"line_number":284,"context_line":"        LOG.debug(\"Sending an upgrade call to nova-guest\")"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        self._cast(\"upgrade\", self.version_cap,"},{"line_number":287,"context_line":"                   instance_version\u003dinstance_version,"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_bd997470","line":284,"updated":"2014-11-10 17:29:50.000000000","message":"inconsistent use of \u0027.\u0027 at the end of messages. It would be good to do this consistently and we\u0027re using the convention of having a punctuation at the end of the message.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def upgrade(self, instance_version, location, metadata\u003dNone):"},{"line_number":283,"context_line":"        \"\"\"Make an asynchronous call to self upgrade the guest agent.\"\"\""},{"line_number":284,"context_line":"        LOG.debug(\"Sending an upgrade call to nova-guest\")"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        self._cast(\"upgrade\", self.version_cap,"},{"line_number":287,"context_line":"                   instance_version\u003dinstance_version,"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_69baeae2","line":284,"in_reply_to":"5a890539_bd997470","updated":"2014-11-12 09:07:53.000000000","message":"I\u0027ll revert this unrelated change.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    def update_overrides(self, overrides, remove\u003dFalse):"},{"line_number":330,"context_line":"        \"\"\"Update the overrides.\"\"\""},{"line_number":331,"context_line":"        LOG.debug(\"Updating overrides on Instance %s\", self.id)"},{"line_number":332,"context_line":"        LOG.debug(\"Updating overrides values %s\" % overrides)"},{"line_number":333,"context_line":"        self._cast(\"update_overrides\", self.version_cap, overrides\u003doverrides,"},{"line_number":334,"context_line":"                   remove\u003dremove)"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_9dbbd8c3","line":332,"updated":"2014-11-10 17:29:50.000000000","message":"why two messages, and would you use overrides as a parameter in the second case rather than forcing the string to be rendered.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    def update_overrides(self, overrides, remove\u003dFalse):"},{"line_number":330,"context_line":"        \"\"\"Update the overrides.\"\"\""},{"line_number":331,"context_line":"        LOG.debug(\"Updating overrides on Instance %s\", self.id)"},{"line_number":332,"context_line":"        LOG.debug(\"Updating overrides values %s\" % overrides)"},{"line_number":333,"context_line":"        self._cast(\"update_overrides\", self.version_cap, overrides\u003doverrides,"},{"line_number":334,"context_line":"                   remove\u003dremove)"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_6b6f3993","line":332,"in_reply_to":"5a890539_9dbbd8c3","updated":"2014-11-12 09:07:53.000000000","message":"I\u0027ll remove unrelated change. Let\u0027s handle it in the separate patch.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"}],"trove/openstack/common/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from trove.openstack.common import threadgroup"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# TODO(esp): We need to see what is in oslo for this class"},{"line_number":41,"context_line":"# rpc \u003d importutils.try_import(\u0027trove.openstack.common.rpc\u0027)"},{"line_number":42,"context_line":"CONF \u003d cfg.CONF"},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_26b992e9","line":41,"updated":"2014-08-20 08:40:56.000000000","message":"we can\u0027t modify anything under openstack/common","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"030771804a67ea6b933aa75d77ee031c66a6d6d7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from trove.openstack.common import threadgroup"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# TODO(esp): We need to see what is in oslo for this class"},{"line_number":41,"context_line":"# rpc \u003d importutils.try_import(\u0027trove.openstack.common.rpc\u0027)"},{"line_number":42,"context_line":"CONF \u003d cfg.CONF"},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_9733f812","line":41,"in_reply_to":"1abeadc6_26b992e9","updated":"2014-09-14 20:22:26.000000000","message":"RPCService is responsible to close rpcserver and perform rpc cleanup therefore I am removing this code.","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"}],"trove/rpc.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_dd3ac035","line":1,"updated":"2014-11-10 17:29:50.000000000","message":"shouldn\u0027t this be 2014?","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d3a3e97713784b5876327675bb278d5fc2b3f74a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_72dab779","line":1,"in_reply_to":"5a890539_dd3ac035","updated":"2014-11-11 23:13:49.000000000","message":"it\u0027s up to Sergey.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"}],"trove/taskmanager/api.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"437a161be65500c41a759d3f9e2fadd3006a102e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_8fd6fcc1","line":1,"updated":"2014-06-10 17:27:55.000000000","message":"same","commit_id":"72c9bc9d833974bbc7dab156847cb043d2170b0b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        LOG.debug(\"Making async call to resize volume for instance: %s\""},{"line_number":82,"context_line":"                  % instance_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00273.0\u0027)"},{"line_number":85,"context_line":"        cctxt.cast(self.context, \"resize_volume\","},{"line_number":86,"context_line":"                   new_size\u003dnew_size,"},{"line_number":87,"context_line":"                   instance_id\u003dinstance_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_86c9867a","line":84,"updated":"2014-08-20 08:40:56.000000000","message":"same here, i\u0027ve got self.version_cap, use it instead of hardcoding.\n\ndo this for every call below\n\nsee https://review.openstack.org/#/c/94484/18/trove/guestagent/api.py,cm","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"030771804a67ea6b933aa75d77ee031c66a6d6d7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        LOG.debug(\"Making async call to resize volume for instance: %s\""},{"line_number":82,"context_line":"                  % instance_id)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00273.0\u0027)"},{"line_number":85,"context_line":"        cctxt.cast(self.context, \"resize_volume\","},{"line_number":86,"context_line":"                   new_size\u003dnew_size,"},{"line_number":87,"context_line":"                   instance_id\u003dinstance_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_37096c31","line":84,"in_reply_to":"1abeadc6_86c9867a","updated":"2014-09-14 20:22:26.000000000","message":"According to oslo.messaging documentation:\n\nprepare should be used to override client properties for an individual method\ninvocation, so in our case it seems to be redundant because client was initialized with \"version_cap\" in the first place...\n\nThoughts?","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"4299bd9d9b8714741f372b00eccea239a3cfbf75","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                   availability_zone\u003davailability_zone,"},{"line_number":164,"context_line":"                   root_password\u003droot_password,"},{"line_number":165,"context_line":"                   nics\u003dnics,"},{"line_number":166,"context_line":"                   overrides\u003doverrides)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def update_overrides(self, instance_id, overrides\u003dNone):"},{"line_number":169,"context_line":"        LOG.debug(\"Making async call to update datastore configurations for \""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa98f980_124dd672","line":166,"updated":"2014-09-09 20:40:38.000000000","message":"Looks like \"slave_of_id\" and \"cluster_config\" got knocked off here.","commit_id":"b2991e963bd886bbd2c53226a345405302d258aa"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_dd11e0ad","line":1,"updated":"2014-11-10 17:29:50.000000000","message":"why update this, you are weakening the copyright.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_71f1f4cc","line":1,"in_reply_to":"5a890539_dd11e0ad","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"RPC_API_VERSION \u003d \"3.0\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class API(object):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_1d236806","line":31,"updated":"2014-11-10 17:29:50.000000000","message":"should find a way to get this from a common place.","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"RPC_API_VERSION \u003d \"3.0\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class API(object):"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_11ba70de","line":31,"in_reply_to":"5a890539_1d236806","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"}],"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a2f94d1913fd58eb2306735326360a28970aa354","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from trove.openstack.common.gettextutils import _"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"#from trove.openstack.common.notifier import api as notifier"},{"line_number":56,"context_line":"from trove import rpc"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"from trove.openstack.common import timeutils"},{"line_number":59,"context_line":"import trove.common.remote as remote"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_0684960a","line":56,"updated":"2014-08-20 08:40:56.000000000","message":"re-organize imports","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"030771804a67ea6b933aa75d77ee031c66a6d6d7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from trove.openstack.common.gettextutils import _"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"#from trove.openstack.common.notifier import api as notifier"},{"line_number":56,"context_line":"from trove import rpc"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"from trove.openstack.common import timeutils"},{"line_number":59,"context_line":"import trove.common.remote as remote"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa98f980_020b4424","line":56,"in_reply_to":"1abeadc6_0684960a","updated":"2014-09-14 20:22:26.000000000","message":"Done","commit_id":"fe407227814837375ab1e14765eef22ca2a41ede"}],"trove/tests/fakes/taskmanager.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f5d05c12756991c4f7fe2f8d5a76cad00b61a0e0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        eventlet.spawn_after(0.1, func)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _get_tm_method(self, method_name):"},{"line_number":44,"context_line":"        manager \u003d Manager()"},{"line_number":45,"context_line":"        method \u003d getattr(Manager, method_name)"},{"line_number":46,"context_line":"        return manager, method"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"fa98f980_1e147c4b","line":44,"updated":"2014-09-15 08:43:26.000000000","message":"nitpick: you could probably keep 1 `Manager` instance per fake.","commit_id":"89ba1067c1fd42746b877067e45f563a564c2ea1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e4e7c276c77919fff0ce242196d22b3be8641b49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_1d6a881a","line":1,"updated":"2014-11-10 17:29:50.000000000","message":"You can\u0027t backdate a copyright ;) This change would effectively invalidate the copyright ...","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"4f5af7e921e7180a3a7eeb09479f749d4b30737a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":43,"id":"5a890539_51e4f80c","line":1,"in_reply_to":"5a890539_1d6a881a","updated":"2014-11-12 09:07:53.000000000","message":"Done","commit_id":"041c07c8f9b536ab4905b64376e8ffcb371e07d3"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8c483685a96953beff926be16cb5cb0ea17e8041","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":45,"id":"5a890539_721404e9","line":1,"updated":"2014-11-24 17:09:06.000000000","message":"No sure why this was changed","commit_id":"93b7c7d5648784772873280a370b853601ac3400"}],"trove/tests/unittests/guestagent/test_api.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"073bbfa6a5ff5de9e953cf0e2b077d38314d488c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def _mock_call_pwd_change(cmd, version\u003dNone, users\u003dNone):"},{"line_number":32,"context_line":"    if users \u003d\u003d \u0027dummy\u0027and version \u003d\u003d \u00271.0\u0027:"},{"line_number":33,"context_line":"        return True"},{"line_number":34,"context_line":"    else:"},{"line_number":35,"context_line":"        raise BaseException(\"Test Failed\")"}],"source_content_type":"text/x-python","patch_set":46,"id":"5a890539_ef8d4232","line":32,"updated":"2014-11-25 17:38:43.000000000","message":"Are we testing if this version is the same as RPC_API_VERSION? If not, what does version 1.0 represent? Thanks.","commit_id":"9ccc68f0b6dc37fc7fc785afbcb5028483e47c1a"}]}