)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"7d27d2337ea00bb90ac6b1a75722c53db40e86d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d94701ba_8d9a41ca","updated":"2025-05-01 15:33:31.000000000","message":"@noonedeadpunk@gmail.com\n\nincorrect path for release note file, right:\nreleasenotes/notes/mariadb-backup-1cd69e9f82e992fb.yaml\n\nneed remove: backup/","commit_id":"739c2b9202259302f01ffb065d8278f36e8fc5ad"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"6252529aef8c417ffc483f80d00212f30a93ae12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"872fd7a5_90abc623","updated":"2025-05-01 15:31:23.000000000","message":"LGTM","commit_id":"739c2b9202259302f01ffb065d8278f36e8fc5ad"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"1ccc142ac3eca4b44216b404d3f5cfa255304a48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55b09758_95c02119","in_reply_to":"744dd5e0_c1c81227","updated":"2025-05-01 16:26:07.000000000","message":"Done","commit_id":"739c2b9202259302f01ffb065d8278f36e8fc5ad"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"436d69c93e25d1822d2885a52ddc80f679584afb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"744dd5e0_c1c81227","in_reply_to":"d94701ba_8d9a41ca","updated":"2025-05-01 16:22:35.000000000","message":"Ah, good catch, I was just building backup images, so ran reno from the wrong place.","commit_id":"739c2b9202259302f01ffb065d8278f36e8fc5ad"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"977f1c4af9c7683d0323bdb23c9562a7a8bca47a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22194aa0_ce71a0ed","updated":"2025-05-06 01:12:18.000000000","message":"Hi, your code is look good to me but I think we should make compatible with old-versions.\n\nThanks","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cc9e05af965f90b18c7e7cbb2472932c8a4772f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8362437c_d32fd3f7","in_reply_to":"0eb7d16f_3ba50219","updated":"2025-05-15 16:35:55.000000000","message":"I proposed https://review.opendev.org/c/openstack/trove/+/949915 as alternative to this patch.\n\nI really can not come with a better solution here, unfortunately. But the problem stands, that MariaDB 11.4 backup is just broken right now.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"5876a65b483ddb7c4a196e7a0896d0d6635464c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"220f39e9_8c73f5f6","in_reply_to":"10a9b4bc_b540fd7c","updated":"2025-06-26 09:26:39.000000000","message":"1. the oldest version for MariaDB we supported is already mariadb 10.4, and The latest code in guest agent should not support such an old version.\n2. In this cycle, i will remove the 10.4 as it reaches it\u0027s EOL\n3. I didn\u0027t merged this patch because currently i am busy on fixing CI status.\n4. once the CI get fixed, i will merged this one, https://review.opendev.org/c/openstack/trove/+/948660","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"0becffd6f7ac10ab814360e086237225dbd32326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e079fa94_6a06e11d","in_reply_to":"220f39e9_8c73f5f6","updated":"2025-06-26 10:09:13.000000000","message":"Aha, ok, great, thanks for the info, sounds good 😊\n\n\nLet me know if I can help in any way.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5df1d270fea0723bd642f124cbf3ecb9ee5151c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84b92251_1b0289d6","in_reply_to":"22194aa0_ce71a0ed","updated":"2025-05-09 07:46:32.000000000","message":"How old are we talking about? As this is compatible back to the 10.4. The currently supported/available for download is 10.4.\n\nShould this be compatible with MariaDB 5.5?","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"bc44cbb58ece401931807f2bb218bcbdd7a435a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc186351_4be5c915","in_reply_to":"37857c06_61984c85","updated":"2025-05-12 07:05:22.000000000","message":"yup, I know that and what do you think about if we will handle this problem with following:\n\nif version \u003c 10.4:\n...\nelif 10.4 \u003c version \u003c 1.xxx\n...\nelse:\n...\n\nor some logic like above? I think the users (other system administrators) maybe not happy when them system being forced upgrade version.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4c4240afb8889eb1fbf0a332e639f32ca3a8785d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0eb7d16f_3ba50219","in_reply_to":"509fefea_73dacb2c","updated":"2025-05-15 15:14:46.000000000","message":"Btw, I assume you are aware that we\u0027re talking about the backup image right now, as there\u0027s no awareness of versions.\n\nSo the only way to implement such logic is to introduce another driver to the backup image and call it instead of old one by the agent.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"430170c67295cbcb5ac73da29a96e6c9556ef08e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a8ba8bf_b46bbc81","in_reply_to":"8362437c_d32fd3f7","updated":"2025-06-23 14:09:28.000000000","message":"@Dmitriy  hi, I apologized for my carelessness. i didn\u0027t review these comments before i merged the alternative patch. now, I have to declare that how do we maintain these outdated datastores. Trove keeps compatibility for these outdated datastores doesn\u0027t mean we should to support to create them in the latest trove code, as you said, we should not maintain these EOL datastores. but for these existed cloud platform, we should not break the present supported datastore versions.  for example: the new deployed users who uses the latest code to build image will not support the old datastores. but for the existed user, after they updated the trove code, they should still able to create the outdated datastores with previous guest-images, but if they build the new image with the latest code, the outdated datastore will be not supported. the current user can use different image tag to achieve this goal. the operator just need to ensure that the old datastore version uses old image, and the new datastore version uses the latest built image.\nTo achieve this, we need to keep a fairly stable trove guest api, this doesn\u0027t mean we need add a lot of compatible codes in guest-agent.\nFinally, in this cycle. i will remove the support of mysql5.7,mariadb10.4 and postgresql12 and add the support of latest LTS version.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"20b91eea9211df2d1442b2c2fe6d856e37912176","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37857c06_61984c85","in_reply_to":"84b92251_1b0289d6","updated":"2025-05-09 07:51:37.000000000","message":"Just for the context - current LTS release is 11.4. 11.8 - next LTS, is already in RC so will be released in next couple of month.\n\n11.8 does not have mariabackup at all.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"9f6eb1523aa4bebca985ef830523bdd4a572db94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"10a9b4bc_b540fd7c","in_reply_to":"922a37d1_c25cf79b","updated":"2025-06-26 09:01:42.000000000","message":"@wchy1001@gmail.com also, talking about backup images, I found this to be an extremely useful patch to avoid problems with spawning a new backup image for the same \"major\" version of MariaDB specifically:\nhttps://review.opendev.org/c/openstack/trove/+/948660\n\nSo would be appreciated if you could provide some feedback on it as well.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"980c28fcf395f654b218c1befa17a9a98e3c28af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"922a37d1_c25cf79b","in_reply_to":"9a8ba8bf_b46bbc81","updated":"2025-06-26 08:58:45.000000000","message":"Ok, thanks for the explanation.\n\nI see you\u0027ve restored the patch recently, but I somehow already got lost in this topic a little bit.\n\nI also see the revert of alternative patch at the same time: https://review.opendev.org/c/openstack/trove/+/952537\n\nSo I\u0027m not sure at this point what is expectation with this patch, as it has a CR-1. I\u0027m totally fine if you folks adopt/change it to your taste to have that said.\n\nBecause indeed, with this patch backup images built from this code will be incompatible with older versions, but again - it does not prevent from building older backup images from older trove versions and tag them accordingly. Which is quite in line with what you are saying if I\u0027m reading it right.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"99aba235df78ef33e7c03f681c7fd981d6fd1257","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"509fefea_73dacb2c","in_reply_to":"dc186351_4be5c915","updated":"2025-05-15 07:56:40.000000000","message":"Yeah, sure, I will look into implementing the logic. It\u0027s not argue if it\u0027s possible or not possible to do, it\u0027s more about trying to understand where project is heading.\n\nI\u0027m just not convinced that it is bearable for trove project with maintenance level I see as of today to try keeping maintaining database versions forever, even what the database engine maintainer gave up maintaining them.\n\nI also think it is an unreasonable expectation to be able to deploy/use an unmaintained version of the database once it reaches EOL.\n\nSo I believe that users must be running relevant versions of software and do upgrades of their engine versions.\n\nAs for me it\u0027s kind of important that Trove, as a project, was supporting modern engines rather then focusing on maintenance of EOL ones.\n\nBut sure, I will check on how to implement the logic you are asking for.","commit_id":"3c69781fdc0e463200a3a621d67ab720afcd2e00"}]}