)]}'
{"backup/install.sh":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"3a9ce8aab31322b2214ccca4b19bf6feb9c32787","unresolved":true,"context_lines":[{"line_number":69,"context_line":"\tdpkg -i percona-release.deb"},{"line_number":70,"context_line":"\tpercona-release enable-only tools release"},{"line_number":71,"context_line":"\tapt-get update"},{"line_number":72,"context_line":"\tif [ \"${OPT_DATASTORE_VERSION}\" \u003d \"8.0\" ]; then"},{"line_number":73,"context_line":"\t\tapt-get install ${APTOPTS} percona-xtrabackup-80"},{"line_number":74,"context_line":"\telif [ \"${OPT_DATASTORE_VERSION}\" \u003d \"8.4\" ]; then"},{"line_number":75,"context_line":"\t\tapt-get install ${APTOPTS} percona-xtrabackup-84"},{"line_number":76,"context_line":"\telse"},{"line_number":77,"context_line":"\t\techo \"Unsupported MySQL version: ${OPT_DATASTORE_VERSION}\""},{"line_number":78,"context_line":"\t\texit 1"},{"line_number":79,"context_line":"\tfi"},{"line_number":80,"context_line":"\trm -f percona-release.deb"},{"line_number":81,"context_line":"elif [ \"${OPT_DATASTORE}\" \u003d \"mariadb\" ]; then"},{"line_number":82,"context_line":"\t# See the url below about the supported version."}],"source_content_type":"text/x-sh","patch_set":2,"id":"96716b08_708a2899","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":3},"updated":"2025-07-11 07:31:29.000000000","message":"I wonder if we can do smth like this instead:\n\n`apt-get install ${APTOPTS} percona-xtrabackup-${OPT_DATASTORE_VERSION//./}`?\n\nThis should avoid us having to adjust this for each release.\n\nBut I wonder if `OPT_DATASTORE_VERSION` can be like `8.4.4`. As I think it can?","commit_id":"4f1f1bbc1d9840bb2d84b63228e0248883dcafd1"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"7954f74fd4211f7b561a97e7f9a2a956fb39a828","unresolved":true,"context_lines":[{"line_number":69,"context_line":"\tdpkg -i percona-release.deb"},{"line_number":70,"context_line":"\tpercona-release enable-only tools release"},{"line_number":71,"context_line":"\tapt-get update"},{"line_number":72,"context_line":"\tif [ \"${OPT_DATASTORE_VERSION}\" \u003d \"8.0\" ]; then"},{"line_number":73,"context_line":"\t\tapt-get install ${APTOPTS} percona-xtrabackup-80"},{"line_number":74,"context_line":"\telif [ \"${OPT_DATASTORE_VERSION}\" \u003d \"8.4\" ]; then"},{"line_number":75,"context_line":"\t\tapt-get install ${APTOPTS} percona-xtrabackup-84"},{"line_number":76,"context_line":"\telse"},{"line_number":77,"context_line":"\t\techo \"Unsupported MySQL version: ${OPT_DATASTORE_VERSION}\""},{"line_number":78,"context_line":"\t\texit 1"},{"line_number":79,"context_line":"\tfi"},{"line_number":80,"context_line":"\trm -f percona-release.deb"},{"line_number":81,"context_line":"elif [ \"${OPT_DATASTORE}\" \u003d \"mariadb\" ]; then"},{"line_number":82,"context_line":"\t# See the url below about the supported version."}],"source_content_type":"text/x-sh","patch_set":2,"id":"e5d431dc_65ca057c","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":3},"in_reply_to":"96716b08_708a2899","updated":"2025-07-14 04:32:10.000000000","message":"I think we add environments to define list package to install instead of hardcode versions. such as:\nOTP_DATABASE_PACKAGES: package1, package2, ...\nmake it more flexibility","commit_id":"4f1f1bbc1d9840bb2d84b63228e0248883dcafd1"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"389de1694276c595e64b8eeb97c73e5e4739d30a","unresolved":true,"context_lines":[{"line_number":69,"context_line":"\tdpkg -i percona-release.deb"},{"line_number":70,"context_line":"\tpercona-release enable-only tools release"},{"line_number":71,"context_line":"\tapt-get update"},{"line_number":72,"context_line":"\tif [ \"${OPT_DATASTORE_VERSION}\" \u003d \"8.0\" ]; then"},{"line_number":73,"context_line":"\t\tapt-get install ${APTOPTS} percona-xtrabackup-80"},{"line_number":74,"context_line":"\telif [ \"${OPT_DATASTORE_VERSION}\" \u003d \"8.4\" ]; then"},{"line_number":75,"context_line":"\t\tapt-get install ${APTOPTS} percona-xtrabackup-84"},{"line_number":76,"context_line":"\telse"},{"line_number":77,"context_line":"\t\techo \"Unsupported MySQL version: ${OPT_DATASTORE_VERSION}\""},{"line_number":78,"context_line":"\t\texit 1"},{"line_number":79,"context_line":"\tfi"},{"line_number":80,"context_line":"\trm -f percona-release.deb"},{"line_number":81,"context_line":"elif [ \"${OPT_DATASTORE}\" \u003d \"mariadb\" ]; then"},{"line_number":82,"context_line":"\t# See the url below about the supported version."}],"source_content_type":"text/x-sh","patch_set":2,"id":"21597a15_a1b50de8","line":79,"range":{"start_line":72,"start_character":0,"end_line":79,"end_character":3},"in_reply_to":"e5d431dc_65ca057c","updated":"2025-07-15 02:04:22.000000000","message":"hello，@Dmitriy Rabotyagov，we are not sure whether Percona will follow this naming schema. For example, MySQL 5.7 corresponds to: percona-xtrabackup-24.\n\nHi Bo: the package name is really hard to remember, so i don\u0027t think this is a good idea.","commit_id":"4f1f1bbc1d9840bb2d84b63228e0248883dcafd1"}],"releasenotes/notes/add-support-mysql8.4-2490b5c87f885b01.yaml":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"7143b3d2ba78a20a1e6cf0aac838db35d7eb176c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support of mysql 8.4, currently, the supported versions"},{"line_number":5,"context_line":"    are mysql 8.0 \u0026 8.4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9d4a10e5_046932fc","line":4,"updated":"2025-07-08 11:11:34.000000000","message":"```suggestion\n    Add support of MySQL 8.4, currently, the supported versions\n```","commit_id":"5ae9fecc18d42e3108d5b83130cfaae5593ad53c"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"029564b516e419dfb99ae8d91fdac25cadb557b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support of mysql 8.4, currently, the supported versions"},{"line_number":5,"context_line":"    are mysql 8.0 \u0026 8.4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b26864be_becaf027","line":4,"in_reply_to":"9d4a10e5_046932fc","updated":"2025-07-13 16:14:01.000000000","message":"Done","commit_id":"5ae9fecc18d42e3108d5b83130cfaae5593ad53c"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"7143b3d2ba78a20a1e6cf0aac838db35d7eb176c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support of mysql 8.4, currently, the supported versions"},{"line_number":5,"context_line":"    are mysql 8.0 \u0026 8.4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0d2d5efe_45b5f136","line":5,"updated":"2025-07-08 11:11:34.000000000","message":"```suggestion\n    are MySQL 8.0 and 8.4.\n```","commit_id":"5ae9fecc18d42e3108d5b83130cfaae5593ad53c"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"029564b516e419dfb99ae8d91fdac25cadb557b3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support of mysql 8.4, currently, the supported versions"},{"line_number":5,"context_line":"    are mysql 8.0 \u0026 8.4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"71a77c91_952d4353","line":5,"in_reply_to":"0d2d5efe_45b5f136","updated":"2025-07-13 16:14:01.000000000","message":"Done","commit_id":"5ae9fecc18d42e3108d5b83130cfaae5593ad53c"}],"trove/guestagent/utils/docker.py":[{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"8b98047e30a49f1e894573ccec52749582dd1867","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # One of staring, healthy, unhealthy, unknown"},{"line_number":234,"context_line":"        return container.health"},{"line_number":235,"context_line":"    except docker.errors.NotFound:"},{"line_number":236,"context_line":"        return \"shutdown\""},{"line_number":237,"context_line":"    except Exception:"},{"line_number":238,"context_line":"        return \"unknown\""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"41b40a51_cf3eec6b","line":236,"range":{"start_line":236,"start_character":16,"end_line":236,"end_character":24},"updated":"2025-07-09 01:24:24.000000000","message":"I think we should keep this original of status is \"not running\" because if \"shutdown\" meaning container existed","commit_id":"5ae9fecc18d42e3108d5b83130cfaae5593ad53c"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"ef11891d80be061f47a8b233dc35fc6518c62fe9","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # One of staring, healthy, unhealthy, unknown"},{"line_number":234,"context_line":"        return container.health"},{"line_number":235,"context_line":"    except docker.errors.NotFound:"},{"line_number":236,"context_line":"        return \"shutdown\""},{"line_number":237,"context_line":"    except Exception:"},{"line_number":238,"context_line":"        return \"unknown\""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"93c97f83_0444afac","line":236,"range":{"start_line":236,"start_character":16,"end_line":236,"end_character":24},"in_reply_to":"41b40a51_cf3eec6b","updated":"2025-07-09 01:48:46.000000000","message":"hello, the previous logic is here:\n```\n        elif status \u003d\u003d \"not running\":\n            return service_status.ServiceStatuses.SHUTDOWN\n```\nnot running is not a valid status in trove, so I mapped it to SHUTDOWN as the previous does.","commit_id":"5ae9fecc18d42e3108d5b83130cfaae5593ad53c"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"522620164e8c860f30eac8650cb147a858e90c71","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        # One of staring, healthy, unhealthy, unknown"},{"line_number":234,"context_line":"        return container.health"},{"line_number":235,"context_line":"    except docker.errors.NotFound:"},{"line_number":236,"context_line":"        return \"shutdown\""},{"line_number":237,"context_line":"    except Exception:"},{"line_number":238,"context_line":"        return \"unknown\""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"572a7306_e46c0099","line":236,"range":{"start_line":236,"start_character":16,"end_line":236,"end_character":24},"in_reply_to":"93c97f83_0444afac","updated":"2025-07-11 06:05:57.000000000","message":"Done","commit_id":"5ae9fecc18d42e3108d5b83130cfaae5593ad53c"}]}