)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"7d994e2db251b3406169297bcd868984b9a00032","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a091615f_9a8f23fc","updated":"2026-01-06 14:07:36.000000000","message":"LGTM\n\n@wchy1001@gmail.com hello, I think we can merge this trivial changes.","commit_id":"76808762c88055fd6ad3c06561f5557db00e0dc0"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"b458befe42bc117c3acb8dc390a956f91aa00824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8e66bfd7_5575d74b","updated":"2026-01-06 22:26:13.000000000","message":"Hello Eric, Thanks you for the update! LGTM:)","commit_id":"0ea55a7e516cd7388e7a285fc5bbadf7365e15ee"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"2d9d76879dc6acfba23b56811084caa0c15f31aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1cafb83a_abfc4528","updated":"2026-01-07 11:50:05.000000000","message":"It\u0027s weird that our CI tests didn\u0027t catch this issue. I\u0027m trying to figure it out.","commit_id":"0ea55a7e516cd7388e7a285fc5bbadf7365e15ee"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"d08c03e58e5d98e1b8946e1cc6ac887456ef7cad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"55b49882_62c5fda1","updated":"2026-01-08 05:55:26.000000000","message":"verified in test env. you need to update [here](https://opendev.org/openstack/trove/src/branch/master/trove/instance/models.py#L1317) as well","commit_id":"0ea55a7e516cd7388e7a285fc5bbadf7365e15ee"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"4ba5b0fa7eb928033278266180025b31551755dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b590d25c_12ad4606","in_reply_to":"1cafb83a_abfc4528","updated":"2026-01-07 11:55:52.000000000","message":"To reproduce this issue (without changes in the patchset), you need to completely disable Swift endpoint in your OS setup. Is it possible in CI tests?","commit_id":"0ea55a7e516cd7388e7a285fc5bbadf7365e15ee"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"21a2d20358ee4f041548fa8869e3e5487dfa6440","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a28e9446_0cbf8458","in_reply_to":"2ed55a95_d31378f7","updated":"2026-01-08 13:07:14.000000000","message":"Yes, currently we only support Swift for log upload storage, so that case doesn\u0027t need to be considered.","commit_id":"0ea55a7e516cd7388e7a285fc5bbadf7365e15ee"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"8c5c355faa874b60f7dda31167f5339055e64e47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2ed55a95_d31378f7","in_reply_to":"55b49882_62c5fda1","updated":"2026-01-08 11:19:44.000000000","message":"Oops, yes, I didn\u0027t copy the code carefully enough, we have that changes in our forked repo.\n\nRight now everything is in place, check it out please.\n\nThere are two places with ``verify_swift_auth_token`` calls left intact in the repo, but they are related to logs functionality. There are no ways to work with logs without swift yet, but hopefully we will try to implement this feature soon.","commit_id":"0ea55a7e516cd7388e7a285fc5bbadf7365e15ee"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"4c8016f6400086aa16df809b2d59f986f1d0d104","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"157bf3a6_30b844de","in_reply_to":"b590d25c_12ad4606","updated":"2026-01-07 12:16:27.000000000","message":"yes, please see this patch: https://review.opendev.org/c/openstack/trove/+/972460 \nI thought I had already disabled Swift installation in our CI jobs, however it isn\u0027t working now.\n\nI searched in the Trove project, and I guess you might have missed this part.\nhttps://opendev.org/openstack/trove/src/branch/master/trove/instance/models.py#L1317","commit_id":"0ea55a7e516cd7388e7a285fc5bbadf7365e15ee"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"a0eb70e96e0d24f1d077d072f52816c27d9b50f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dbc4b051_b0a8e1b4","updated":"2026-01-08 14:00:42.000000000","message":"recheck","commit_id":"8e030265635d4c79d17a69a18aed1235a89a70d8"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"6c664007b13f0c04fe8bdee57e6334c2db405443","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f6939f87_b4dfc366","updated":"2026-01-08 18:35:57.000000000","message":"recheck","commit_id":"8e030265635d4c79d17a69a18aed1235a89a70d8"}],"trove/instance/service.py":[{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"f6cdd095dca059b139da57442ef6e809519578de","unresolved":true,"context_lines":[{"line_number":378,"context_line":"            if locality:"},{"line_number":379,"context_line":"                msg \u003d \u0027Cannot specify locality when creating replicas.\u0027"},{"line_number":380,"context_line":"                raise exception.BadRequest(message\u003dmsg)"},{"line_number":381,"context_line":"            if CONF.storage_strategy not in [\"cinder\"]:"},{"line_number":382,"context_line":"                backup_model.verify_swift_auth_token(context)"},{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            if replica_count and replica_count \u003e 1:"}],"source_content_type":"text/x-python","patch_set":4,"id":"eee2e2d9_1549867c","line":381,"updated":"2026-01-06 14:44:16.000000000","message":"Hello Eric, thanks for the PR. I think `if CONF.storage_strategy in [\"swift\"]:` is clearer. What do you think?","commit_id":"76808762c88055fd6ad3c06561f5557db00e0dc0"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"d6d1d63be0371f18c5c0d13acf90ccf5abbb02ff","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if locality:"},{"line_number":379,"context_line":"                msg \u003d \u0027Cannot specify locality when creating replicas.\u0027"},{"line_number":380,"context_line":"                raise exception.BadRequest(message\u003dmsg)"},{"line_number":381,"context_line":"            if CONF.storage_strategy not in [\"cinder\"]:"},{"line_number":382,"context_line":"                backup_model.verify_swift_auth_token(context)"},{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            if replica_count and replica_count \u003e 1:"}],"source_content_type":"text/x-python","patch_set":4,"id":"4fa2dd0b_824b102c","line":381,"in_reply_to":"eee2e2d9_1549867c","updated":"2026-01-06 14:51:02.000000000","message":"Hello, thank you for the review. Yes, you\u0027re right. That would be a better way to check especially if other storage strategies will be added in the future, S3 for example.","commit_id":"76808762c88055fd6ad3c06561f5557db00e0dc0"}]}