)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"03d00a9043874883b02a4147e03a810b6a381d09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9d2373f_0d6254ad","updated":"2025-12-19 12:19:02.000000000","message":"I have revised Eric’s PR (#970600) to ensure it does not affect the behavior of existing users. Wu and Eric, could you please check this. Thanks in advance.\n\n\n-------\nHere are the test results from my local environment.\n\n**GuestAgent Configuration:**\n\nExpected shm_size: MySQL 64MB (Docker\u0027s default value[1]), PostgreSQL 1024MB (configured value)\n\n```\n[mysql]\ndocker_image \u003d 10.0.0.4:4000/trove-datastores/mysql\nbackup_docker_image \u003d 10.0.0.4:4000/trove-datastores/db-backup-mysql:1.2.0\n\n[mariadb]\ndocker_image \u003d 10.0.0.4:4000/trove-datastores/mariadb\nbackup_docker_image \u003d 10.0.0.4:4000/trove-datastores/db-backup-mariadb:1.2.0\n\n[postgresql]\ndocker_use_shm_size \u003d True\ndocker_shm_size_mb \u003d 1024\ndocker_image \u003d 10.0.0.4:4000/trove-datastores/postgres\nbackup_docker_image \u003d 10.0.0.4:4000/trove-datastores/db-backup-postgresql:1.2.0\n```\n\n**MySQL container verification (expected: 64MB):**\n```\nubuntu@mysql8042:~$ docker inspect f8a6572969ed --format \u0027{{.HostConfig.ShmSize}}\u0027\n67108864\nubuntu@mysql8042:~$ docker exec f8a6572969ed df -h /dev/shm\nFilesystem      Size  Used Avail Use% Mounted on\nshm              64M     0   64M   0% /dev/shm\n```\n\n**PostgreSQL container verification (expected: 1024MB):**\n```\nubuntu@postgresql1:~$ docker inspect 2d6de50f9cda --format \u0027{{.HostConfig.ShmSize}}\u0027\n1073741824\nubuntu@postgresql1:~$ docker exec 2d6de50f9cda df -h /dev/shm\nFilesystem      Size  Used Avail Use% Mounted on\nshm             1.0G  1.1M 1023M   1% /dev/shm\n```\n\nBoth results match the expected values, confirming that:\n- MySQL uses Docker\u0027s default 64MB when `docker_use_shm_size` is not set\n- PostgreSQL correctly applies the configured 1024MB when `docker_use_shm_size\u003dTrue`\n\n---\n[1] https://github.com/moby/moby/blob/master/daemon/config/config.go#L42","commit_id":"9a5b5898ea7245b8c3efe776a3a77313235123cd"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"1fd06da467fcb30ed9496e8992480e2070176c0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a74325a4_9d48e900","in_reply_to":"b9d2373f_0d6254ad","updated":"2025-12-19 15:20:59.000000000","message":"Hello, please take a look at my comment on the original patch.","commit_id":"9a5b5898ea7245b8c3efe776a3a77313235123cd"}],"trove/taskmanager/models.py":[{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"9eb4505c39c15e9b45566543ea719d5cf5757e0c","unresolved":true,"context_lines":[{"line_number":663,"context_line":"        # check if use shm-size or not when starting docker container."},{"line_number":664,"context_line":"        use_shm, shm_mb \u003d self._get_container_shm_config(datastore_manager)"},{"line_number":665,"context_line":"        guest_memory_mb \u003d int(shm_mb) if use_shm else flavor[\u0027ram\u0027]"},{"line_number":666,"context_line":"        self._guest_prepare(guest_memory_mb, volume_info,"},{"line_number":667,"context_line":"                            packages, databases, users, backup_info,"},{"line_number":668,"context_line":"                            config.config_contents, root_password,"},{"line_number":669,"context_line":"                            overrides,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e6b82a01_b07d24ec","line":666,"updated":"2025-12-20 10:32:43.000000000","message":"I can see a problem here - memory_mb is not being used inside `do_prepare` method in guest at all. The same is for memory_mb for rebuild and upgrade.\n\nAlso getting `docker_use_shm_size` and `docker_use_shm_size` inside taskmanager and later in guest\u0027s Manager means that administrator should set them in both trove.conf and trove-guestagent.conf, as for me, quite non-obvious.\n\nSo passing `docker_shm_size_mb` by RPC seems kind of redundant as long as we fetch them from trove-guestagent.conf.\n\nBut IMO it\u0027s better to solve the issue within the original patchset.","commit_id":"06ecde32227117a152a79e0e44f8d02272727a00"}]}