)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"28496c7fee6ecba3d2d1e283da0ead28addeee3e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"01134483_f31e7c0e","updated":"2026-03-17 19:19:19.000000000","message":"Hi Eric, thank you very much for the patch! I think this change currently bundles at least three separate concerns:\n\n1. Fixing the upgrade call to pass datastore_version.version instead of name\n2. Adding/implementing PostgreSQL guest manager upgrade behavior\n3. Changing the upgrade logic to allow same-version upgrades\n\nFrom a review and maintenance perspective, we would like to split this into separate reviews (one concern per patch)? It would be great to start with (1) as a focused bug fix, then propose (2) and (3) as follow-up reviews with their own rationale and tests.\n\nAs a side note for context: PostgreSQL support in Trove’s containerized (Docker-based) guest path was introduced later than some other datastores, so there may still be functional gaps.\nThat said, I think it would be better to address PostgreSQL upgrade support in a dedicated follow-up review, separate from the main fix in this patch.\n\nThanks!","commit_id":"f3861f5d8f631bb6eed9d66a9236fe811a8cc07a"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"f6da4eb9480596180f0cd1aa6f92ea1f4f6623c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed1a02e5_4ae6bf25","updated":"2026-03-17 09:02:02.000000000","message":"recheck","commit_id":"f3861f5d8f631bb6eed9d66a9236fe811a8cc07a"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"11992a950087a73fd2d01b334a217c3fb1f6ce30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"299a04a8_1d58e032","in_reply_to":"01134483_f31e7c0e","updated":"2026-03-18 13:51:02.000000000","message":"Hello, Hirotaka! Thank you for the review.\n\nHere we go:\n  1. (this patchset updated)\n  2. https://review.opendev.org/c/openstack/trove/+/981109\n  3. https://review.opendev.org/c/openstack/trove/+/981115\n\nTo test all three patches properly, I will create a separate [DNM] patch because upgrade tests are not included and require special job definitions.\nPlus, I plan to create a patchset in trove-tempest-plugin with an improved upgrade tests proposal.","commit_id":"f3861f5d8f631bb6eed9d66a9236fe811a8cc07a"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"34f0b9926d14dfd6771f1a9bba9ed6b8b104f2f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf3ae23e_39e234b9","updated":"2026-06-15 07:54:15.000000000","message":"Hello Eric, Thank you for the patch, and sorry for the delayed review. My understanding of the changes is that it\u0027s easier to use \"version\" rather than \"name\" when creating scenario tests, even though they hold the same value. Wu has kindly merged #981109 and #981115. I\u0027ll rebase this on my end, and if there are no issues, I\u0027d like to merge it.\n\nThanks a lot!","commit_id":"08c1909da10261f3f28acb080b4f1ac5c1e77e76"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"34f0b9926d14dfd6771f1a9bba9ed6b8b104f2f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"67a434b2_50105fe7","updated":"2026-06-15 07:54:15.000000000","message":"Hi Eric,\n\nThank you for the patch, and sorry for the delayed review. In this context, I think \"version\" makes more sense than \"name\", even though they hold the same value. Wu has already merged #981109 and #981115. I\u0027ll rebase this on my end, and if there are no issues, I\u0027d like to merge it.\n\nThanks a lot!","commit_id":"08c1909da10261f3f28acb080b4f1ac5c1e77e76"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"11e843def9562c3c3cf4aba29024553f878f154a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1e21cbc5_dd52bb48","in_reply_to":"bf3ae23e_39e234b9","updated":"2026-06-15 08:01:12.000000000","message":"Great, np, thank you for the review 🙂","commit_id":"08c1909da10261f3f28acb080b4f1ac5c1e77e76"},{"author":{"_account_id":31737,"name":"Hirotaka Wakabayashi","email":"hiwkby@yahoo.com","username":"hiwkby"},"change_message_id":"32efea58bbaf11a88d08706cabb8e9ed20646de7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6198a4df_22f06ef4","updated":"2026-06-15 10:41:04.000000000","message":"Approved!","commit_id":"0ace89987de2b2e0530cf5ccc2372d0f9c5d8479"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"ff36e68b2b5326cec52867a69391f728e383dd4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d98700f4_5d8dc830","updated":"2026-06-15 15:58:46.000000000","message":"recheck","commit_id":"0ace89987de2b2e0530cf5ccc2372d0f9c5d8479"}]}