)]}'
{"trove/templates/mysql/validation-rules.json":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        {"},{"line_number":21,"context_line":"            \"name\": \"long_query_time\","},{"line_number":22,"context_line":"            \"restart_required\": true,"},{"line_number":23,"context_line":"            \"max\": 65535,"},{"line_number":24,"context_line":"            \"min\": 10,"},{"line_number":25,"context_line":"            \"type\": \"integer\""},{"line_number":26,"context_line":"        },"}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_93269e65","line":23,"updated":"2014-06-22 01:24:34.000000000","message":"why max 65535? is that some particular number of hours or minutes?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":21,"context_line":"            \"name\": \"long_query_time\","},{"line_number":22,"context_line":"            \"restart_required\": true,"},{"line_number":23,"context_line":"            \"max\": 65535,"},{"line_number":24,"context_line":"            \"min\": 10,"},{"line_number":25,"context_line":"            \"type\": \"integer\""},{"line_number":26,"context_line":"        },"},{"line_number":27,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_7323d257","line":24,"updated":"2014-06-22 01:24:34.000000000","message":"why is the min 10? MySQL allows 0 for a min and that\u0027s actually very useful in some cases.","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"}],"trove/templates/percona/validation-rules.json":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"configuration-parameters\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"name\": \"general_log_file\","},{"line_number":5,"context_line":"            \"restart_required\": true,"},{"line_number":6,"context_line":"            \"type\": \"string\""},{"line_number":7,"context_line":"        },"},{"line_number":8,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_d3e2e6ff","line":5,"updated":"2014-06-22 01:24:34.000000000","message":"why is a restart required?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        },"},{"line_number":8,"context_line":"        {"},{"line_number":9,"context_line":"            \"name\": \"general_log\","},{"line_number":10,"context_line":"            \"restart_required\": true,"},{"line_number":11,"context_line":"            \"max\": 1,"},{"line_number":12,"context_line":"            \"min\": 0,"},{"line_number":13,"context_line":"            \"type\": \"integer\""}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_f3ed22f1","line":10,"updated":"2014-06-22 01:24:34.000000000","message":"why is a restart required?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        },"},{"line_number":15,"context_line":"        {"},{"line_number":16,"context_line":"            \"name\": \"log_slow_queries\","},{"line_number":17,"context_line":"            \"restart_required\": true,"},{"line_number":18,"context_line":"            \"type\": \"string\""},{"line_number":19,"context_line":"        },"},{"line_number":20,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_13e9aee2","line":17,"updated":"2014-06-22 01:24:34.000000000","message":"why is a restart required?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        },"},{"line_number":20,"context_line":"        {"},{"line_number":21,"context_line":"            \"name\": \"long_query_time\","},{"line_number":22,"context_line":"            \"restart_required\": true,"},{"line_number":23,"context_line":"            \"max\": 65535,"},{"line_number":24,"context_line":"            \"min\": 10,"},{"line_number":25,"context_line":"            \"type\": \"integer\""}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_33bb0ae6","line":22,"updated":"2014-06-22 01:24:34.000000000","message":"why is a restart required?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":21,"context_line":"            \"name\": \"long_query_time\","},{"line_number":22,"context_line":"            \"restart_required\": true,"},{"line_number":23,"context_line":"            \"max\": 65535,"},{"line_number":24,"context_line":"            \"min\": 10,"},{"line_number":25,"context_line":"            \"type\": \"integer\""},{"line_number":26,"context_line":"        },"},{"line_number":27,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_13128efc","line":24,"updated":"2014-06-22 01:24:34.000000000","message":"same comments as mysql.","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        },"},{"line_number":27,"context_line":"        {"},{"line_number":28,"context_line":"            \"name\": \"log_error\","},{"line_number":29,"context_line":"            \"restart_required\": true,"},{"line_number":30,"context_line":"            \"type\": \"string\""},{"line_number":31,"context_line":"        },"},{"line_number":32,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_73b11200","line":29,"updated":"2014-06-22 01:24:34.000000000","message":"why is a restart required?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        },"},{"line_number":32,"context_line":"        {"},{"line_number":33,"context_line":"            \"name\": \"bin_log\","},{"line_number":34,"context_line":"            \"restart_required\": true,"},{"line_number":35,"context_line":"            \"type\": \"string\""},{"line_number":36,"context_line":"        },"},{"line_number":37,"context_line":"        {"}],"source_content_type":"application/json","patch_set":1,"id":"1ae5cdf2_93b4def1","line":34,"updated":"2014-06-22 01:24:34.000000000","message":"why is a restart required?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"}],"trove/tests/api/configurations.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        # test being able to update and insert new parameter name and values"},{"line_number":228,"context_line":"        # to an existing configuration"},{"line_number":229,"context_line":"        values \u003d (\u0027{\"join_buffer_size\": 1048576, \"connect_timeout\": 60,\u0027"},{"line_number":230,"context_line":"                  \u0027\"general_log_file\": \"/var/log/mysql/general.log\",\u0027"},{"line_number":231,"context_line":"                  \u0027\"general_log\":1, \"long_query_time\":11, \u0027"},{"line_number":232,"context_line":"                  \u0027\"bin_log\": \"/var/log/mysql/bin.log\"}\u0027)"},{"line_number":233,"context_line":"        instance_info.dbaas.configurations.edit(configuration_info.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b3ce3a81","line":230,"updated":"2014-06-22 01:24:34.000000000","message":"what about the other parameters?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3ab92bf8add6ca0d88c6d2e01b28dc31656a0ccb","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        values \u003d (\u0027{\"join_buffer_size\": 1048576, \"connect_timeout\": 60,\u0027"},{"line_number":230,"context_line":"                  \u0027\"general_log_file\": \"/var/log/mysql/general.log\",\u0027"},{"line_number":231,"context_line":"                  \u0027\"general_log\":1, \"long_query_time\":11, \u0027"},{"line_number":232,"context_line":"                  \u0027\"bin_log\": \"/var/log/mysql/bin.log\"}\u0027)"},{"line_number":233,"context_line":"        instance_info.dbaas.configurations.edit(configuration_info.id,"},{"line_number":234,"context_line":"                                                values)"},{"line_number":235,"context_line":"        resp, body \u003d instance_info.dbaas.client.last_response"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_00dd9614","line":232,"updated":"2014-06-09 15:06:29.000000000","message":"You added 6 new parameters, but are only testing 4 here.  Plus I don\u0027t see any code to verify that the values were updated successfully/correctly.","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"3ab92bf8add6ca0d88c6d2e01b28dc31656a0ccb","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        ssh_server \u003d ServerSSHConnection(configuration_instance.id)"},{"line_number":506,"context_line":"        result \u003d ssh_server.execute(ssh_cmd)"},{"line_number":507,"context_line":"        assert_true(result is not None)"},{"line_number":508,"context_line":"        assert_true(\"bin.log\" in result)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"@test(runs_after\u003d[WaitForConfigurationInstanceToFinish], groups\u003d[GROUP])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e09b4a70","line":508,"updated":"2014-06-09 15:06:29.000000000","message":"Shouldn\u0027t we test that all the configuration you changed has taken effect, not just one?","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d36ef201b905dbe9f905e26d6511854e0f4f8332","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        ssh_server \u003d ServerSSHConnection(configuration_instance.id)"},{"line_number":506,"context_line":"        result \u003d ssh_server.execute(ssh_cmd)"},{"line_number":507,"context_line":"        assert_true(result is not None)"},{"line_number":508,"context_line":"        assert_true(\"bin.log\" in result)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"@test(runs_after\u003d[WaitForConfigurationInstanceToFinish], groups\u003d[GROUP])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_93821efd","line":508,"in_reply_to":"1ae5cdf2_e09b4a70","updated":"2014-06-22 01:24:34.000000000","message":"Yes, that should be done ...","commit_id":"48b0d71ca0fcf343e0a9dff518cdced73828d726"}]}