)]}'
{"trove/tests/api/users.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"18e2dbe46d3139fc50179184978e07325a762ca3","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        users \u003d []"},{"line_number":317,"context_line":"        username \u003d \"testuser_nochg\""},{"line_number":318,"context_line":"        hostname \u003d \"192.168.0.1\""},{"line_number":319,"context_line":"        users.append({\"name\": username, \"password\": \"password\","},{"line_number":320,"context_line":"                      \"host\": hostname, \"databases\": []})"},{"line_number":321,"context_line":"        self.dbaas.users.create(instance_info.id, users)"},{"line_number":322,"context_line":"        user_new \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_3c457bb3","line":319,"updated":"2014-06-07 10:57:37.000000000","message":"no need to define users explicitly,\nyou just need to do:\nusers \u003d [...]","commit_id":"fd6e78898ca9ba1d1893e83061b45fea642f1559"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cab79ce9c9c5b61f96614a7255a6bb3be30e589c","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        users \u003d []"},{"line_number":317,"context_line":"        username \u003d \"testuser_nochg\""},{"line_number":318,"context_line":"        hostname \u003d \"192.168.0.1\""},{"line_number":319,"context_line":"        users.append({\"name\": username, \"password\": \"password\","},{"line_number":320,"context_line":"                      \"host\": hostname, \"databases\": []})"},{"line_number":321,"context_line":"        self.dbaas.users.create(instance_info.id, users)"},{"line_number":322,"context_line":"        user_new \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0bee978b","line":319,"in_reply_to":"1ae5cdf2_3c457bb3","updated":"2014-06-09 15:34:00.000000000","message":"Sure, but then my test would be different from the other ones in this file.  If you think that should be the way the tests are written, submit a bug and change them all.","commit_id":"fd6e78898ca9ba1d1893e83061b45fea642f1559"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"18e2dbe46d3139fc50179184978e07325a762ca3","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        users.append({\"name\": username, \"password\": \"password\","},{"line_number":320,"context_line":"                      \"host\": hostname, \"databases\": []})"},{"line_number":321,"context_line":"        self.dbaas.users.create(instance_info.id, users)"},{"line_number":322,"context_line":"        user_new \u003d {}"},{"line_number":323,"context_line":"        assert_raises(Exception,"},{"line_number":324,"context_line":"                      self.dbaas.users.update_attributes, instance_info.id,"},{"line_number":325,"context_line":"                      username, user_new, hostname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7c1623a9","line":322,"updated":"2014-06-07 10:57:37.000000000","message":"same here, you just need to pass {} instead of defining another attribute","commit_id":"fd6e78898ca9ba1d1893e83061b45fea642f1559"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cab79ce9c9c5b61f96614a7255a6bb3be30e589c","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        users.append({\"name\": username, \"password\": \"password\","},{"line_number":320,"context_line":"                      \"host\": hostname, \"databases\": []})"},{"line_number":321,"context_line":"        self.dbaas.users.create(instance_info.id, users)"},{"line_number":322,"context_line":"        user_new \u003d {}"},{"line_number":323,"context_line":"        assert_raises(Exception,"},{"line_number":324,"context_line":"                      self.dbaas.users.update_attributes, instance_info.id,"},{"line_number":325,"context_line":"                      username, user_new, hostname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_8b01c73b","line":322,"in_reply_to":"1ae5cdf2_7c1623a9","updated":"2014-06-09 15:34:00.000000000","message":"ditto","commit_id":"fd6e78898ca9ba1d1893e83061b45fea642f1559"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"18e2dbe46d3139fc50179184978e07325a762ca3","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                      self.dbaas.users.update_attributes, instance_info.id,"},{"line_number":325,"context_line":"                      username, user_new, hostname)"},{"line_number":326,"context_line":"        # The last_http_code will actually have worked, since the exception"},{"line_number":327,"context_line":"        # is thrown before the actual http request"},{"line_number":328,"context_line":"        assert_equal(202, self.dbaas.last_http_code)"},{"line_number":329,"context_line":"        self.dbaas.users.delete(instance_info.id, username, hostname\u003dhostname)"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5c1167ae","line":327,"updated":"2014-06-07 10:57:37.000000000","message":"It seems that last http code should not be 202 because exception happend, it should be fixed","commit_id":"fd6e78898ca9ba1d1893e83061b45fea642f1559"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cab79ce9c9c5b61f96614a7255a6bb3be30e589c","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                      self.dbaas.users.update_attributes, instance_info.id,"},{"line_number":325,"context_line":"                      username, user_new, hostname)"},{"line_number":326,"context_line":"        # The last_http_code will actually have worked, since the exception"},{"line_number":327,"context_line":"        # is thrown before the actual http request"},{"line_number":328,"context_line":"        assert_equal(202, self.dbaas.last_http_code)"},{"line_number":329,"context_line":"        self.dbaas.users.delete(instance_info.id, username, hostname\u003dhostname)"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4b125f63","line":327,"in_reply_to":"1ae5cdf2_5c1167ae","updated":"2014-06-09 15:34:00.000000000","message":"If you look at the code it\u0027s testing, it\u0027s obvious that the exception gets thrown before the http request gets executed, hence this is checking the *previous* request, which should have worked.  I agree this is a bit confusing, so I\u0027ll remove the check (once again was trying to be consistent).","commit_id":"fd6e78898ca9ba1d1893e83061b45fea642f1559"}]}