)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"369c02a70b8b1da202b5cdc5da70c8cbe160e81a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7254781c_4974010f","updated":"2026-05-24 07:00:25.000000000","message":"recheck","commit_id":"0aea42100c9fbbedb1c45a3cd2f034aabf17c788"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"ab366ac1b0a645cfb0e8ec0d4e008166c27af14d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"364f9d82_7d1998bb","updated":"2026-05-25 09:42:14.000000000","message":"can i push support redis support path before this path? because, i think redis should be based for your path.\n\nanw, if i can\u0027t, i think you should review about backup for keydb/ valkey again? whether we need do snapshot before snapshot?","commit_id":"26f182f09dd22401bd04886da8de789278198eab"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"226dde952cab04bae06e2874e4eb454c9a7e2335","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0d171c70_1ca369bd","in_reply_to":"364f9d82_7d1998bb","updated":"2026-05-25 10:16:37.000000000","message":"Hello, Bo! Nice to hear from you.\n\nUnfortunately, we can\u0027t support vanilla Redis anymore due to licensing issues.\nSo the only option is to use forks: Valkey - looks more like a vanilla Redis 7.2.4, and KeyDB - focused on performance and multi-threading.\n\nActually, with the provided code, it\u0027s very easy to implement a \"Redis\" datastore using RedisCommon as a base class, and sell \"Redis\" DBaaS, if you can overcome licensing issues.\n\nI can\u0027t clearly get a point about backup and snapshots. Is there something wrong with the current implementation?","commit_id":"26f182f09dd22401bd04886da8de789278198eab"},{"author":{"_account_id":28691,"name":"Bo Tran","email":"ministry.96.nd@gmail.com","username":"ministry"},"change_message_id":"d4ffeef94cfa0471ddcfda1b7083d56a2aa665db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b09c787a_91e1dc3f","updated":"2026-05-26 06:55:15.000000000","message":"I think you should do save to disk before snapshot.","commit_id":"a2cf0f7133235faa5007390b3553c37dda97f7af"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"04538ba29be3c472d0a727311a2409cf6aabea5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f9468560_a1f111ba","updated":"2026-05-25 14:35:35.000000000","message":"recheck","commit_id":"a2cf0f7133235faa5007390b3553c37dda97f7af"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"d625272c400c2369096e135b96a23fc5f4df3c80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"00a3dcc1_e6d1256d","in_reply_to":"b09c787a_91e1dc3f","updated":"2026-05-26 09:01:02.000000000","message":"Ah, yes, right. We do it for [cinder backups](https://review.opendev.org/c/openstack/trove/+/989856/10/trove/guestagent/datastore/redis_common/manager.py#188), and for [swift backups](https://review.opendev.org/c/openstack/trove/+/989856/10/trove/guestagent/datastore/redis_common/manager.py#120) too.\nReplication snapshots utilize this code too.\nOr maybe I\u0027m missing something?","commit_id":"a2cf0f7133235faa5007390b3553c37dda97f7af"}]}