)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"3d423b8988d87a7807e265ae4be5b3a8c4410ee3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"75bb00a1_69c30871","updated":"2026-07-05 14:25:31.000000000","message":"This doesn’t quite make sense to me. Development images shouldn’t run in production at all.\nOur production images don\u0027t need to install anything on startup. For dev environments, we frequently add new packages during development. Instead of rebuilding images repeatedly, I prefer installing these extra packages when the guest agent service starts.","commit_id":"3e2c0d87bcb115a5f6259389c9d35d25ec34651a"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"3ce229092e5c6bf6edada7116c6e9c9d1d923737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc38c18d_d9b0a5c1","updated":"2026-06-09 08:53:14.000000000","message":"recheck","commit_id":"3e2c0d87bcb115a5f6259389c9d35d25ec34651a"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"6fc84062632e47265f06ba8b89741a4700005d86","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a244c14_f62b76c8","in_reply_to":"75bb00a1_69c30871","updated":"2026-07-07 15:16:29.000000000","message":"Hello, Wu!\n\nI took a closer look at why this patch was originally created.\n\nCurrently, the `pip install` process works exactly as you described: the guest-agent service installs all required packages in the `ExecStartPre` directive. However, the problem is that if there are network issues in the development environment (for example, the issue addressed in [this](https://review.opendev.org/c/openstack/trove/+/992900) patch, a misconfigured or unavailable nameserver, or some future Neutron-related bug), **and** the current branch introduces new packages in `requirements.txt`, the instance will end up in the `ERROR` state.\n\nThis happens because the DIB image build process clones the `master` branch and installs its requirements, but it does not take into account the modified `requirements.txt` from the current branch (see the `integration/scripts/files/elements/guest-agent/source-repository-guest-agent` element definition).\n\nBecause of that, copying `requirements.txt` into the target image and using it during the `ExecStartPre` installation seems like the most logical solution. We could limit this behavior to the development environment only.\n\nAnother approach would be to copy the Trove source code from the current working directory into the target image instead of cloning the `master` branch during the image build. That would also ensure the image contains the exact version of the code under test. I think we can implement that approach as well if it seems preferable.\n\nDo you think either of these approaches would be more appropriate?","commit_id":"3e2c0d87bcb115a5f6259389c9d35d25ec34651a"}]}