)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"385187317c18087512e30b2dc952d19b8b66cb14","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - At slow environment (small flavors, etc.),"},{"line_number":11,"context_line":"   for certain reasons Cassandra instances are in SHUTDOWN state"},{"line_number":12,"context_line":"   for short period of time. This issue breaks assertion"},{"line_number":13,"context_line":"   in int-test that waits for guest to reach ACTIVE state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Changes:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_54d29200","line":12,"updated":"2014-07-11 17:19:47.000000000","message":"OK, so I\u0027ve been testing cassandra startup extensively as part of the other change that I\u0027m making for the rsync issue.\n\ncassandra startup code is very slow.\n\nThis fix does not address the real problem of why cassandra startup is slow and instead just attempts to bandage around it.\n\nI have a good idea why this is happening; it has to do with the fact that during startup we are in fact continuing to run the periodic poll of status which should instead turn off and set the status to merely BUILDING.\n\nThe underlying problem should be fixed, this is not a fix, merely a treatment of the symptoms.","commit_id":"5fa8d162a1c9465d52ac443addf69607fc1cff2c"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"93032cd0399de6210abd6b95f7a8af602fa273be","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - At slow environment (small flavors, etc.),"},{"line_number":11,"context_line":"   for certain reasons Cassandra instances are in SHUTDOWN state"},{"line_number":12,"context_line":"   for short period of time. This issue breaks assertion"},{"line_number":13,"context_line":"   in int-test that waits for guest to reach ACTIVE state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Changes:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_47373cff","line":12,"in_reply_to":"baada198_0452a234","updated":"2014-07-11 22:08:44.000000000","message":"Denis - comments like this are not constructive in any way - more importantly, they violate the code of conduct that we as a community strive to abide by.  Please spend some time reading this http://www.openstack.org/legal/community-code-of-conduct/ and help us improve the cohesiveness of the Trove community.","commit_id":"5fa8d162a1c9465d52ac443addf69607fc1cff2c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"14f4c7669caf2edb7e95f3c8d767b7b160d5733e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - At slow environment (small flavors, etc.),"},{"line_number":11,"context_line":"   for certain reasons Cassandra instances are in SHUTDOWN state"},{"line_number":12,"context_line":"   for short period of time. This issue breaks assertion"},{"line_number":13,"context_line":"   in int-test that waits for guest to reach ACTIVE state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Changes:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_caf51384","line":12,"in_reply_to":"baada198_47373cff","updated":"2014-07-11 22:42:24.000000000","message":"+1 Michael, and Vipul. \n\nDenis: Please be respectful and constructive with your comments and replies. Disrespectful comments on code reviews reflects poorly on us as a community, and are not acceptable.","commit_id":"5fa8d162a1c9465d52ac443addf69607fc1cff2c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"44028d602e3457962a25a970213235c57aef137e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - At slow environment (small flavors, etc.),"},{"line_number":11,"context_line":"   for certain reasons Cassandra instances are in SHUTDOWN state"},{"line_number":12,"context_line":"   for short period of time. This issue breaks assertion"},{"line_number":13,"context_line":"   in int-test that waits for guest to reach ACTIVE state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Changes:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_ab7e28ad","line":12,"in_reply_to":"baada198_54d29200","updated":"2014-07-11 20:33:38.000000000","message":"Amrith, you\u0027d better debug guest code before telling that something slows sothing. Have you even checked cassandra logs? i bet you\u0027re not.\nAnd even if you are - have you ever find any attempts to establish connections from local client?\n\nPlease, when you suggesting something provide real facts, without any science fiction.","commit_id":"5fa8d162a1c9465d52ac443addf69607fc1cff2c"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"4476d3fa963d944d526a7a431743ef14a5989749","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - At slow environment (small flavors, etc.),"},{"line_number":11,"context_line":"   for certain reasons Cassandra instances are in SHUTDOWN state"},{"line_number":12,"context_line":"   for short period of time. This issue breaks assertion"},{"line_number":13,"context_line":"   in int-test that waits for guest to reach ACTIVE state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Changes:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_0452a234","line":12,"in_reply_to":"baada198_ab7e28ad","updated":"2014-07-11 21:38:28.000000000","message":"This comment is distasteful denis. Provide facts to amriths points as counter points. Do not dismiss his thoughts as \"science fiction\". This is not how a senior member of the trove community should act or respond to comments from other members of the trove community.","commit_id":"5fa8d162a1c9465d52ac443addf69607fc1cff2c"}],"trove/guestagent/datastore/cassandra/service.py":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"b6cfe24009f6ccfc13936c3e8efa95bf7d664272","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class CassandraAppStatus(service.BaseDbStatus):"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    fail_msg \u003d \"Connection error. Could not connect to\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _get_actual_db_status(self):"},{"line_number":199,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_e805b4c2","line":196,"updated":"2014-07-10 20:42:15.000000000","message":"Based on the error message in the bug report, I believe this string is incorrect:\nStderr: \u0027Connection error: Could not connect to localhost:9160\\n\u0027\nNote the presence of the \u0027:\u0027 after \u0027Connection Error\u0027\n\nI believe this means that the code below will always return \"RUNNING\"","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"b6cfe24009f6ccfc13936c3e8efa95bf7d664272","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            # possible previous exec was finished with code 1,"},{"line_number":209,"context_line":"            # that\u0027s why guest should verify that cassandra"},{"line_number":210,"context_line":"            # actually starting in a background"},{"line_number":211,"context_line":"            result \u003d system._verify_cassandra_is_starting(utils)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            if self.fail_msg not in err:"},{"line_number":214,"context_line":"                return rd_instance.ServiceStatuses.RUNNING"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_6820c449","line":211,"updated":"2014-07-10 20:42:15.000000000","message":"This code will needlessly introduce a 5 second sleep every time this method is called. If we do believe have a hardcoded 5 second sleep in the code is the way to go, then this should be moved do to after line 214. (I believe you can change \u0027elif result:\u0027 to \u0027if result:\u0027 and put this call above it.","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"}],"trove/guestagent/datastore/cassandra/system.py":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"b6cfe24009f6ccfc13936c3e8efa95bf7d664272","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    Verifies that log was changed"},{"line_number":42,"context_line":"    after at least 5 seconds sleep"},{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":"    log_path \u003d \u0027/var/log/cassandra/system.log\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    if os.path.exists(log_path):"},{"line_number":47,"context_line":"        md5, _ \u003d utils_module.execute_with_timeout("}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_88e278ff","line":44,"updated":"2014-07-10 20:42:15.000000000","message":"Maybe this should be moved above with the other constants?","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"b6cfe24009f6ccfc13936c3e8efa95bf7d664272","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":"    log_path \u003d \u0027/var/log/cassandra/system.log\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    if os.path.exists(log_path):"},{"line_number":47,"context_line":"        md5, _ \u003d utils_module.execute_with_timeout("},{"line_number":48,"context_line":"            \u0027md5sum %s\u0027 % log_path, shell\u003dTrue)"},{"line_number":49,"context_line":"        md5before \u003d md5.split(\"\")[:1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_08a588b4","line":46,"updated":"2014-07-10 20:42:15.000000000","message":"This seems like a pretty heavy way to detect change. Can\u0027t you just check if the file\u0027s timestamp changed?","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d4017732887fd6cc12cdbc69255ffaefdd91dcfc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":"    log_path \u003d \u0027/var/log/cassandra/system.log\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    if os.path.exists(log_path):"},{"line_number":47,"context_line":"        md5, _ \u003d utils_module.execute_with_timeout("},{"line_number":48,"context_line":"            \u0027md5sum %s\u0027 % log_path, shell\u003dTrue)"},{"line_number":49,"context_line":"        md5before \u003d md5.split(\"\")[:1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2e5c15ed","line":46,"in_reply_to":"baada198_08a588b4","updated":"2014-07-10 21:01:54.000000000","message":"Absolutely no, since it requires to read/seek/reload file. By checking hash sum from backup makes status definition easier.","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"18f4a74c731322020326a98933423a91f832843b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\""},{"line_number":44,"context_line":"    log_path \u003d \u0027/var/log/cassandra/system.log\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    if os.path.exists(log_path):"},{"line_number":47,"context_line":"        md5, _ \u003d utils_module.execute_with_timeout("},{"line_number":48,"context_line":"            \u0027md5sum %s\u0027 % log_path, shell\u003dTrue)"},{"line_number":49,"context_line":"        md5before \u003d md5.split(\"\")[:1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_51264817","line":46,"in_reply_to":"baada198_2e5c15ed","updated":"2014-07-10 21:37:47.000000000","message":"This seems like a rather odd way to determine if a file has changed. Why not just check the file size or timestamp ;)\n\nIt is a log file, it gets appended.\n\nWhen it is appended, the timestamp changes and the file size grows. That should be better than hashing the whole file.","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"b6cfe24009f6ccfc13936c3e8efa95bf7d664272","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027md5sum %s\u0027 % log_path, shell\u003dTrue)"},{"line_number":49,"context_line":"        md5before \u003d md5.split(\"\")[:1]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        time.sleep(5)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        md5, _ \u003d utils_module.execute_with_timeout("},{"line_number":54,"context_line":"            \u0027md5sum %s\u0027 % log_path, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_088ca834","line":51,"updated":"2014-07-10 20:42:15.000000000","message":"It would be better if we could come up with a better way to determine if cassandra is running than doing a sleep with md5 checks.","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d4017732887fd6cc12cdbc69255ffaefdd91dcfc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027md5sum %s\u0027 % log_path, shell\u003dTrue)"},{"line_number":49,"context_line":"        md5before \u003d md5.split(\"\")[:1]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        time.sleep(5)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        md5, _ \u003d utils_module.execute_with_timeout("},{"line_number":54,"context_line":"            \u0027md5sum %s\u0027 % log_path, shell\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_aefe65ac","line":51,"in_reply_to":"baada198_088ca834","updated":"2014-07-10 21:01:54.000000000","message":"I\u0027m open for discussions, but suggestions about tailing/reading/seeking would be ignored.","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"}],"trove/tests/unittests/guestagent/test_cassandra_manager.py":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"b6cfe24009f6ccfc13936c3e8efa95bf7d664272","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        mock_app.restart.assert_any_call()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class TestCassandraServiceStatus(testtools.TestCase):"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def setUp(self):"},{"line_number":149,"context_line":"        super(TestCassandraServiceStatus, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_68ca8450","line":146,"updated":"2014-07-10 20:42:15.000000000","message":"I don\u0027t believe any of these tests actually test the code that is in the new _verify_cassandra_is_starting method. Given I believe that code will always return RUNNING....","commit_id":"7678e2037eccfdd4995b73cb75c8e56a9feefbb8"}]}