)]}'
{"run_tests.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"673409378736c26be5dbdd8685f9de87cb2e0b86","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Adds the datastore for mysql (needed to make most calls work)."},{"line_number":75,"context_line":"    from trove.datastore import models"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    models.DBDatastore.create(id\u003dconfig.dbaas_datastore_id,"},{"line_number":78,"context_line":"                              name\u003dconfig.dbaas_datastore,"},{"line_number":79,"context_line":"                              default_version_id\u003d"},{"line_number":80,"context_line":"                              config.dbaas_datastore_version_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_cff6445d","line":77,"updated":"2014-06-18 00:51:19.000000000","message":"config or config.CONFIG? same comment in many places","commit_id":"2e2a370182eae768692252a64fb260e3424e3255"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"12f511c691425f469f4d0e15fdcf9092182773a3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # Adds the datastore for mysql (needed to make most calls work)."},{"line_number":75,"context_line":"    from trove.datastore import models"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    models.DBDatastore.create(id\u003dconfig.dbaas_datastore_id,"},{"line_number":78,"context_line":"                              name\u003dconfig.dbaas_datastore,"},{"line_number":79,"context_line":"                              default_version_id\u003d"},{"line_number":80,"context_line":"                              config.dbaas_datastore_version_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_8f2ef7a3","line":77,"in_reply_to":"1ae5cdf2_cff6445d","updated":"2014-06-18 04:54:22.000000000","message":"If you take a look at config.py you would see that this parameters are global variables, not pinned to Config object at all.\nIf you read bug report you will see the main goal of this patch - avoid use of datastores/version from test config, instead use datastotes/versions API for retrieving them","commit_id":"2e2a370182eae768692252a64fb260e3424e3255"}],"trove/tests/api/root_on_create.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"f43778e160c6870bc6a93a17dca676b0301910dd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @before_class"},{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        self.orig_conf_value \u003d CONF.get("},{"line_number":73,"context_line":"            \"mysql\").root_on_create"},{"line_number":74,"context_line":"        CONF.get(\"mysql\").root_on_create \u003d True"},{"line_number":75,"context_line":"        self.dbaas \u003d util.create_dbaas_client(instance_info.user)"},{"line_number":76,"context_line":"        self.dbaas_admin \u003d util.create_dbaas_client(instance_info.admin_user)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_98f5d586","line":73,"updated":"2014-07-15 16:00:13.000000000","message":"I don\u0027t think we should be hard coding mysql here. \neither make it a global variable, or load default datastore config","commit_id":"02f76e7f5a3f41b1d983d9ceaa888711c136d471"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ccc60473e885d27f3425f9ed1ddd724bb4560054","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @before_class"},{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        self.orig_conf_value \u003d CONF.get("},{"line_number":73,"context_line":"            \"mysql\").root_on_create"},{"line_number":74,"context_line":"        CONF.get(\"mysql\").root_on_create \u003d True"},{"line_number":75,"context_line":"        self.dbaas \u003d util.create_dbaas_client(instance_info.user)"},{"line_number":76,"context_line":"        self.dbaas_admin \u003d util.create_dbaas_client(instance_info.admin_user)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_fb8a4b63","line":73,"in_reply_to":"baada198_98f5d586","updated":"2014-07-15 16:15:38.000000000","message":"i can do the same https://review.openstack.org/#/c/99682/10/trove/tests/api/datastores.py,cm\n\nbut it still very tricky","commit_id":"02f76e7f5a3f41b1d983d9ceaa888711c136d471"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"f43778e160c6870bc6a93a17dca676b0301910dd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        self.orig_conf_value \u003d CONF.get("},{"line_number":73,"context_line":"            \"mysql\").root_on_create"},{"line_number":74,"context_line":"        CONF.get(\"mysql\").root_on_create \u003d True"},{"line_number":75,"context_line":"        self.dbaas \u003d util.create_dbaas_client(instance_info.user)"},{"line_number":76,"context_line":"        self.dbaas_admin \u003d util.create_dbaas_client(instance_info.admin_user)"},{"line_number":77,"context_line":"        self.history \u003d self.dbaas_admin.management.root_enabled_history"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_788641dd","line":74,"updated":"2014-07-15 16:00:13.000000000","message":"also in the code like in task manager we use the datastore manager name, should we be using something similar to load config groups?","commit_id":"02f76e7f5a3f41b1d983d9ceaa888711c136d471"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ccc60473e885d27f3425f9ed1ddd724bb4560054","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        self.orig_conf_value \u003d CONF.get("},{"line_number":73,"context_line":"            \"mysql\").root_on_create"},{"line_number":74,"context_line":"        CONF.get(\"mysql\").root_on_create \u003d True"},{"line_number":75,"context_line":"        self.dbaas \u003d util.create_dbaas_client(instance_info.user)"},{"line_number":76,"context_line":"        self.dbaas_admin \u003d util.create_dbaas_client(instance_info.admin_user)"},{"line_number":77,"context_line":"        self.history \u003d self.dbaas_admin.management.root_enabled_history"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_7b71dba7","line":74,"in_reply_to":"baada198_788641dd","updated":"2014-07-15 16:15:38.000000000","message":"we can\u0027t query datastore manager from the API, in tests we\u0027re expecting that datastore name equals to datastore manager.","commit_id":"02f76e7f5a3f41b1d983d9ceaa888711c136d471"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"44b2f3d4f44766e7bd6cfcf5c7ea99f26bfe3b76","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @before_class"},{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        self.dbaas \u003d util.create_dbaas_client(instance_info.user)"},{"line_number":73,"context_line":"        datastores \u003d self.dbaas.datastores.list()"},{"line_number":74,"context_line":"        for dstore in datastores:"},{"line_number":75,"context_line":"            self.datastore_active \u003d self.dbaas.datastores.get("},{"line_number":76,"context_line":"                dstore.name)"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_88cb5849","line":73,"updated":"2014-07-17 20:11:38.000000000","message":"I\u0027ve seen this pattern come up several times.  Would it not be possible to have a self.dbaas.active_datastore() method.","commit_id":"d2f8b6d11b1ec1976a1ab56f487ac8f39d3fe41a"}],"trove/tests/config.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"f43778e160c6870bc6a93a17dca676b0301910dd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"dbaas_datastore_version \u003d \"5.5\""},{"line_number":34,"context_line":"dbaas_datastore_version_id \u003d (\"b00000b0-00b0-0b00-00b0-\""},{"line_number":35,"context_line":"                              \"000b000000bb\")"},{"line_number":36,"context_line":"dbaas_inactive_datastore_version \u003d \"inactive_version\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#TODO(tim.simpson): I feel like this class already exists somewhere in core"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_780f2189","line":36,"updated":"2014-07-15 16:00:13.000000000","message":"just out of curiosity where are these values loaded in the db?","commit_id":"02f76e7f5a3f41b1d983d9ceaa888711c136d471"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"fe04bd4f7102b02d1f7b7c4869127ed358f40157","unresolved":false,"context_lines":[{"line_number":33,"context_line":"dbaas_datastore_version \u003d \"5.5\""},{"line_number":34,"context_line":"dbaas_datastore_version_id \u003d (\"b00000b0-00b0-0b00-00b0-\""},{"line_number":35,"context_line":"                              \"000b000000bb\")"},{"line_number":36,"context_line":"dbaas_inactive_datastore_version \u003d \"inactive_version\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#TODO(tim.simpson): I feel like this class already exists somewhere in core"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_f8dfb1d4","line":36,"in_reply_to":"baada198_780f2189","updated":"2014-07-15 16:02:01.000000000","message":"I got it in run_tests.py","commit_id":"02f76e7f5a3f41b1d983d9ceaa888711c136d471"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"86840aee79741fcd2d9675b1058902281812985d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from collections import Mapping"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"dbaas_datastore \u003d \"mysql\""},{"line_number":30,"context_line":"dbaas_datastore_id \u003d \"a00000a0-00a0-0a00-00a0-000a000000aa\""},{"line_number":31,"context_line":"dbaas_datastore_id_no_versions \u003d (\"10000000-0000-0000\""},{"line_number":32,"context_line":"                                  \"-0000-000000000001\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_576f1893","line":29,"updated":"2014-07-31 14:25:03.000000000","message":"hard-coding this block of values is not a good idea.","commit_id":"ba84425c6e300ae9c75063230f13e8c2fed1f60f"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"8d7c12943e5951127c5d770f6e3a4cb35750f78d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"dbaas_datastore_version \u003d \"5.5\""},{"line_number":34,"context_line":"dbaas_datastore_version_id \u003d (\"b00000b0-00b0-0b00-00b0-\""},{"line_number":35,"context_line":"                              \"000b000000bb\")"},{"line_number":36,"context_line":"dbaas_inactive_datastore_version \u003d \"inactive_version\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#TODO(tim.simpson): I feel like this class already exists somewhere in core"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_e5dec8d9","line":36,"updated":"2014-07-23 21:08:25.000000000","message":"When these values where stored in the config, it was possible to change the config to test other datastores or other environments or deployments where the IDs didn\u0027t match these IDs. \n\nI don\u0027t understand why you\u0027ve moved them to be hard coded instead. What is the benefit? Now if the dbaas_datastore_id isn\u0027t \"a00000a0-00a0-0a00-00a0-000a000000aa\" in an environment we can\u0027t run the tests.","commit_id":"ba84425c6e300ae9c75063230f13e8c2fed1f60f"}],"trove/tests/unittests/instance/test_instance_status.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"86840aee79741fcd2d9675b1058902281812985d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from trove.instance.models import InstanceStatus"},{"line_number":19,"context_line":"from trove.instance.models import InstanceServiceStatus"},{"line_number":20,"context_line":"from trove.instance.models import SimpleInstance"},{"line_number":21,"context_line":"from trove.tests import config"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class FakeInstanceTask(object):"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_975290dc","line":21,"updated":"2014-07-31 14:25:03.000000000","message":"I\u0027m trying to understand why this change is required?","commit_id":"ba84425c6e300ae9c75063230f13e8c2fed1f60f"}],"trove/tests/unittests/mgmt/test_models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"86840aee79741fcd2d9675b1058902281812985d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"import trove.extensions.mgmt.instances.models as mgmtmodels"},{"line_number":33,"context_line":"from trove.openstack.common.notifier import api as notifier"},{"line_number":34,"context_line":"from trove.common import remote"},{"line_number":35,"context_line":"from trove.tests import config"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_77433c11","line":35,"updated":"2014-07-31 14:25:03.000000000","message":"I\u0027m trying to understand why this change is required?","commit_id":"ba84425c6e300ae9c75063230f13e8c2fed1f60f"}]}