)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"7f277a24b982c699882cfb9ff85d9ef4ff4cff2c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add datastore configuration parameters API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Trove supports loading datastore configuration parameters, including"},{"line_number":10,"context_line":"validation rules, through trove-manage. That workflow requires direct"},{"line_number":11,"context_line":"access to the Trove control plane, which is not practical for"},{"line_number":12,"context_line":"deployments where datastore version maintenance is automated through"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"f58df51f_850a52bc","line":9,"updated":"2026-08-04 17:45:56.000000000","message":"Probably the description may be much shorter, for example:\nAPI implementation for `db_load_datastore_config_parameters` and `db_remove_datastore_config_parameters` methods from trove-manage tool.\n\nProbably we don\u0027t need to describe why we need them 🙂\nThe presence of this patch itself shows that these methods were missing in the current API implementation.","commit_id":"98b88295bc3e792678f1d2a4d97ecbebb02f9cb5"},{"author":{"_account_id":39300,"name":"Olessya Khussainova","display_name":"Olessya Khussainova","email":"olessya.khussainova@ps.kz","username":"Cellofun"},"change_message_id":"27228f60176a519b4c0192df86e2c3252261027f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add datastore configuration parameters API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Trove supports loading datastore configuration parameters, including"},{"line_number":10,"context_line":"validation rules, through trove-manage. That workflow requires direct"},{"line_number":11,"context_line":"access to the Trove control plane, which is not practical for"},{"line_number":12,"context_line":"deployments where datastore version maintenance is automated through"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"0c5d0ec7_eafe20e6","line":9,"in_reply_to":"f58df51f_850a52bc","updated":"2026-08-07 04:44:12.000000000","message":"Done","commit_id":"98b88295bc3e792678f1d2a4d97ecbebb02f9cb5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"67438ecc4ee9ea06d74077046e386f88a49afec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"12981502_ba18ef64","updated":"2026-07-20 15:27:14.000000000","message":"We need here:\n- more precise commit description, why we need this in the upstream\n- release notes\n- support this API call in python-troveclient (e.g. `datastore configuration  set`/`datastore configuration delete`","commit_id":"7f271e994e59fc4d1381bd903ba7b4d56ba73a22"},{"author":{"_account_id":39300,"name":"Olessya Khussainova","display_name":"Olessya Khussainova","email":"olessya.khussainova@ps.kz","username":"Cellofun"},"change_message_id":"a0bf7c8a270229004cce5c5d02a6b4e0323a1aea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bb3aecad_cdf4e9c8","in_reply_to":"12981502_ba18ef64","updated":"2026-07-22 16:00:08.000000000","message":"Done! Here\u0027s the python-troveclient support - https://review.opendev.org/c/openstack/python-troveclient/+/998329","commit_id":"7f271e994e59fc4d1381bd903ba7b4d56ba73a22"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"7f277a24b982c699882cfb9ff85d9ef4ff4cff2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f0b26c0e_5e874a94","updated":"2026-08-04 17:45:56.000000000","message":"Two small notes. The rest LGTM!","commit_id":"98b88295bc3e792678f1d2a4d97ecbebb02f9cb5"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"09d3c9dff988cd350837863ea5fdf9447c0eb958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"63d23b17_3bac49e2","updated":"2026-09-17 06:40:05.000000000","message":"Since this MR doesn\u0027t add new functionality but rather fills a gap by adding missing API endpoints, I think it can be merged without additional approval from a core developer.","commit_id":"a624a6ba75d4c1c65024287519105babdaf5faaf"}],"api-ref/source/datastore-versions.inc":[{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"7f277a24b982c699882cfb9ff85d9ef4ff4cff2c","unresolved":true,"context_lines":[{"line_number":431,"context_line":"   - project_id: project_id"},{"line_number":432,"context_line":"   - datastore_version_id: datastore_version_id"},{"line_number":433,"context_line":"   - configuration-parameters: configuration-parameters"},{"line_number":434,"context_line":"   - name: configuration_parameter_name"},{"line_number":435,"context_line":"   - restart_required: configuration_parameter_restart_required"},{"line_number":436,"context_line":"   - type: configuration_parameter_type"},{"line_number":437,"context_line":"   - max: configuration_parameter_max"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"3aa1fc4a_59bd6ed3","line":434,"updated":"2026-08-04 17:45:56.000000000","message":"I\u0027m not sure, but I saw somewhere (maybe in other projects) the notation like `configuration-parameters.name` or more precise: `configuration-parameters[].name`. \n\nCan you please check whether it\u0027s legit? It will be much better, because right now it\u0027s not clear (without looking at the example request) that all these parameters belong to objects within the configuration-parameters array, and the `configuration-parameters[].name` notation shows exactly that.","commit_id":"98b88295bc3e792678f1d2a4d97ecbebb02f9cb5"},{"author":{"_account_id":39300,"name":"Olessya Khussainova","display_name":"Olessya Khussainova","email":"olessya.khussainova@ps.kz","username":"Cellofun"},"change_message_id":"955cf804a0683f07f3adec2e760bc4b170d61560","unresolved":true,"context_lines":[{"line_number":431,"context_line":"   - project_id: project_id"},{"line_number":432,"context_line":"   - datastore_version_id: datastore_version_id"},{"line_number":433,"context_line":"   - configuration-parameters: configuration-parameters"},{"line_number":434,"context_line":"   - name: configuration_parameter_name"},{"line_number":435,"context_line":"   - restart_required: configuration_parameter_restart_required"},{"line_number":436,"context_line":"   - type: configuration_parameter_type"},{"line_number":437,"context_line":"   - max: configuration_parameter_max"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"e0bd4aaf_9b5fef51","line":434,"in_reply_to":"3aa1fc4a_59bd6ed3","updated":"2026-08-06 04:46:00.000000000","message":"I searched through several OpenStack projects but, unfortunately, couldn\u0027t find any examples of ```configuration-parameters[].name``` usage. However, standard dotted notation is widely used, including in Trove, so I\u0027m fixing this block accordingly.","commit_id":"98b88295bc3e792678f1d2a4d97ecbebb02f9cb5"},{"author":{"_account_id":39300,"name":"Olessya Khussainova","display_name":"Olessya Khussainova","email":"olessya.khussainova@ps.kz","username":"Cellofun"},"change_message_id":"27228f60176a519b4c0192df86e2c3252261027f","unresolved":false,"context_lines":[{"line_number":431,"context_line":"   - project_id: project_id"},{"line_number":432,"context_line":"   - datastore_version_id: datastore_version_id"},{"line_number":433,"context_line":"   - configuration-parameters: configuration-parameters"},{"line_number":434,"context_line":"   - name: configuration_parameter_name"},{"line_number":435,"context_line":"   - restart_required: configuration_parameter_restart_required"},{"line_number":436,"context_line":"   - type: configuration_parameter_type"},{"line_number":437,"context_line":"   - max: configuration_parameter_max"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"ceb1066e_a5bf9c63","line":434,"in_reply_to":"e0bd4aaf_9b5fef51","updated":"2026-08-07 04:44:12.000000000","message":"Done","commit_id":"98b88295bc3e792678f1d2a4d97ecbebb02f9cb5"}],"trove/tests/unittests/configuration/test_configuration_controller.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"141bc8b92e300c04ba927ffcff848c67b0840555","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        self.assertEqual(3, mock_create_or_update_conf_param.call_count)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @mock.patch(\u0027trove.configuration.models.DatastoreConfigurationParameters.\u0027"},{"line_number":468,"context_line":"              \u0027load_parameters\u0027)"},{"line_number":469,"context_line":"    @mock.patch(\u0027trove.datastore.models.DatastoreVersion.load_by_uuid\u0027)"},{"line_number":470,"context_line":"    def test_delete_all_configuration_params("},{"line_number":471,"context_line":"            self, mock_load_datastore_version, mock_load_conf_params):"}],"source_content_type":"text/x-python","patch_set":9,"id":"6eae6cb3_e60c3799","line":468,"updated":"2026-07-24 18:37:17.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"cd6108e55556b35d2b6e0572c492a48ecdcd0d21"}]}