)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"69c2451639d5000ac0a7e11eb0aafc875bd0581d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    cfg.StrOpt(\u0027taskmanager_queue\u0027, default\u003d\u0027taskmanager\u0027),"},{"line_number":124,"context_line":"    cfg.StrOpt(\u0027conductor_queue\u0027, default\u003d\u0027trove-conductor\u0027),"},{"line_number":125,"context_line":"    cfg.IntOpt(\u0027trove_conductor_workers\u0027, default\u003d1),"},{"line_number":126,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_config_drive\u0027, default\u003dFalse,"},{"line_number":127,"context_line":"                help\u003d\"Use config drive for file injection when booting \""},{"line_number":128,"context_line":"                \"instance.\"),"},{"line_number":129,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_volume\u0027, default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_fe7362e4","line":126,"updated":"2014-06-19 16:31:40.000000000","message":"Shouldn\u0027t we use a StrOpt with default\u003dNone since the nova option is interpreted as:     :param config_drive: (optional extension) value for config drive either boolean, or volume-id","commit_id":"070d05cd74e322f4a61af5095d566bba2b324a6b"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"ac3c7a9eafdc5a2f00ab01f27bbb771dd5ec3772","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    cfg.StrOpt(\u0027taskmanager_queue\u0027, default\u003d\u0027taskmanager\u0027),"},{"line_number":124,"context_line":"    cfg.StrOpt(\u0027conductor_queue\u0027, default\u003d\u0027trove-conductor\u0027),"},{"line_number":125,"context_line":"    cfg.IntOpt(\u0027trove_conductor_workers\u0027, default\u003d1),"},{"line_number":126,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_config_drive\u0027, default\u003dFalse,"},{"line_number":127,"context_line":"                help\u003d\"Use config drive for file injection when booting \""},{"line_number":128,"context_line":"                \"instance.\"),"},{"line_number":129,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_volume\u0027, default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2887a5d8","line":126,"in_reply_to":"1ae5cdf2_96edec27","updated":"2014-07-10 23:55:26.000000000","message":"So I understand that Nova allows you to pass in the volume-id that you can attach and have cloud-init read from that prepared volume.  However, this means that Trove would be the one creating a volume with the necessary config, which i don\u0027t think is something we want to do.  This patch really just allows Nova to do that for us, as opposed to using nbd or having the hypervisor do the file injection.","commit_id":"070d05cd74e322f4a61af5095d566bba2b324a6b"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"6357de80775adaa37a1f27aa95c35527ea3d4016","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    cfg.StrOpt(\u0027taskmanager_queue\u0027, default\u003d\u0027taskmanager\u0027),"},{"line_number":124,"context_line":"    cfg.StrOpt(\u0027conductor_queue\u0027, default\u003d\u0027trove-conductor\u0027),"},{"line_number":125,"context_line":"    cfg.IntOpt(\u0027trove_conductor_workers\u0027, default\u003d1),"},{"line_number":126,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_config_drive\u0027, default\u003dFalse,"},{"line_number":127,"context_line":"                help\u003d\"Use config drive for file injection when booting \""},{"line_number":128,"context_line":"                \"instance.\"),"},{"line_number":129,"context_line":"    cfg.BoolOpt(\u0027use_nova_server_volume\u0027, default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_96edec27","line":126,"in_reply_to":"1ae5cdf2_fe7362e4","updated":"2014-06-27 06:10:55.000000000","message":"i agree.","commit_id":"070d05cd74e322f4a61af5095d566bba2b324a6b"}],"trove/tests/fakes/nova.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ef78648c30c274ae5749c7e70a1fb0b92b287627","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def create(self, name, image_id, flavor_ref, files\u003dNone, userdata\u003dNone,"},{"line_number":261,"context_line":"               block_device_mapping\u003dNone, volume\u003dNone, security_groups\u003dNone,"},{"line_number":262,"context_line":"               availability_zone\u003dNone, nics\u003dNone, config_drive\u003dFalse):"},{"line_number":263,"context_line":"        id \u003d \"FAKE_%s\" % uuid.uuid4()"},{"line_number":264,"context_line":"        if volume:"},{"line_number":265,"context_line":"            volume \u003d self.volumes.create(volume[\u0027size\u0027], volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_c1322df1","line":262,"updated":"2014-07-14 15:13:46.000000000","message":"config_drive is not being used anywhere in this function.","commit_id":"5018dae112e16d3aafe25612dfdaf6a490a07fad"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"91b167768b58291dd69f3acd8cabf9945ef81fba","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def create(self, name, image_id, flavor_ref, files\u003dNone, userdata\u003dNone,"},{"line_number":261,"context_line":"               block_device_mapping\u003dNone, volume\u003dNone, security_groups\u003dNone,"},{"line_number":262,"context_line":"               availability_zone\u003dNone, nics\u003dNone, config_drive\u003dFalse):"},{"line_number":263,"context_line":"        id \u003d \"FAKE_%s\" % uuid.uuid4()"},{"line_number":264,"context_line":"        if volume:"},{"line_number":265,"context_line":"            volume \u003d self.volumes.create(volume[\u0027size\u0027], volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_89fa1441","line":262,"in_reply_to":"baada198_090e04e5","updated":"2014-07-14 19:59:18.000000000","message":"Thank you for clarifying Denis. That sounds good to me.","commit_id":"5018dae112e16d3aafe25612dfdaf6a490a07fad"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"87a6d8f49798b1b547cfaa00f6569a9df5575014","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def create(self, name, image_id, flavor_ref, files\u003dNone, userdata\u003dNone,"},{"line_number":261,"context_line":"               block_device_mapping\u003dNone, volume\u003dNone, security_groups\u003dNone,"},{"line_number":262,"context_line":"               availability_zone\u003dNone, nics\u003dNone, config_drive\u003dFalse):"},{"line_number":263,"context_line":"        id \u003d \"FAKE_%s\" % uuid.uuid4()"},{"line_number":264,"context_line":"        if volume:"},{"line_number":265,"context_line":"            volume \u003d self.volumes.create(volume[\u0027size\u0027], volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_090e04e5","line":262,"in_reply_to":"baada198_c1322df1","updated":"2014-07-14 19:48:14.000000000","message":"Because it\u0027s Fake implementation, so, we should not care about that. This change is required to allow use of fake nova implementation inside integration tests that are being executed by jenkins (not reddwarf). So, please re-review this patchset","commit_id":"5018dae112e16d3aafe25612dfdaf6a490a07fad"}],"trove/tests/unittests/taskmanager/test_models.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ef78648c30c274ae5749c7e70a1fb0b92b287627","unresolved":false,"context_lines":[{"line_number":76,"context_line":"class fake_ServerManager:"},{"line_number":77,"context_line":"    def create(self, name, image_id, flavor_id, files, userdata,"},{"line_number":78,"context_line":"               security_groups, block_device_mapping, availability_zone\u003dNone,"},{"line_number":79,"context_line":"               nics\u003dNone, config_drive\u003dFalse):"},{"line_number":80,"context_line":"        server \u003d fake_Server()"},{"line_number":81,"context_line":"        server.id \u003d \"server_id\""},{"line_number":82,"context_line":"        server.name \u003d name"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2153e917","line":79,"updated":"2014-07-14 15:13:46.000000000","message":"Same concern here, config_drive is not being used anywhere here.","commit_id":"5018dae112e16d3aafe25612dfdaf6a490a07fad"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"87a6d8f49798b1b547cfaa00f6569a9df5575014","unresolved":false,"context_lines":[{"line_number":76,"context_line":"class fake_ServerManager:"},{"line_number":77,"context_line":"    def create(self, name, image_id, flavor_id, files, userdata,"},{"line_number":78,"context_line":"               security_groups, block_device_mapping, availability_zone\u003dNone,"},{"line_number":79,"context_line":"               nics\u003dNone, config_drive\u003dFalse):"},{"line_number":80,"context_line":"        server \u003d fake_Server()"},{"line_number":81,"context_line":"        server.id \u003d \"server_id\""},{"line_number":82,"context_line":"        server.name \u003d name"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_890134b1","line":79,"in_reply_to":"baada198_2153e917","updated":"2014-07-14 19:48:14.000000000","message":"same as comment at previous file","commit_id":"5018dae112e16d3aafe25612dfdaf6a490a07fad"}]}