)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"b7721143f637b1d461653f4fec9aad0d93d26961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e69125c5_518d7c7e","updated":"2026-08-04 16:37:07.000000000","message":"Hello! Thank you for the contribution. LGTM.\n\nHowever, I can see an additional issue, which we can also fix in this MR.\nPlease take a look at [build_log_file_name](https://opendev.org/openstack/trove/src/branch/master/trove/guestagent/datastore/manager.py#L664) and [validate_log_file](https://opendev.org/openstack/trove/src/branch/master/trove/guestagent/datastore/manager.py#L686) methods. They pass the `owner` into the `group` argument for `ensure_directory` and `chown` calls.\nUsually, the owner uid and group gid are equal, but in some future datastore managers and custom-built Docker images this may not be true.\n\nSo we can pass the correct group with the correct owner in advance. Imo it\u0027s not an extra task, and stays within the \"one patch - one logical change\" rule, as it also addresses the wrong ownership fix.\n\nWhat do you think?","commit_id":"58e8d16fd0774c94e7929d434ed00d283254cabd"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"ef624976ba79c8b06038b010d7b6811120016b17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"103306aa_828adfb1","in_reply_to":"0b446a4a_e0cda377","updated":"2026-08-06 02:21:21.000000000","message":"Hi Eric,\n\nI\u0027ve pushed a new change for the potential issue you highlighted, as you asked.\n\nI have to say though, as a new Trove contributor (and long-time OpenStack operator / contributor / reviewer), I am discouraged that you would hold back a change that fixes a bug in the default install that breaks all guest log functionality over an unrelated issue.\n\nFWIW, this bug was also breaking the guest-log dump in the tempest gate that\u0027s meant to help debug instance build failures:\nhttps://zuul.opendev.org/t/openstack/build/c0663d101a474216ab43c961cd197119/log/controller/logs/tempest_log.txt#2092\nhttps://zuul.opendev.org/t/openstack/build/9a7fa067f3044f539da203c19b36513b/log/controller/logs/tempest_log.txt#2818","commit_id":"58e8d16fd0774c94e7929d434ed00d283254cabd"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"e953bca60ab52fee80e6b3c02427bdb1ac333c5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b446a4a_e0cda377","in_reply_to":"3c3abd16_8d283049","updated":"2026-08-05 10:29:07.000000000","message":"Ok, that\u0027s a fair point.\n\nThen please provide the child patch as well, and we\u0027ll merge them both at once. This patch resolves the reported issue but leaves another potential issue unaddressed.","commit_id":"58e8d16fd0774c94e7929d434ed00d283254cabd"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"69f44125ad5683061764ce6049a397aee7d969a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c3abd16_8d283049","in_reply_to":"e69125c5_518d7c7e","updated":"2026-08-04 23:59:07.000000000","message":"Hi Eric, thanks for reviewing!\n\nThis current patch is effectively a two-line change, and the scope of your suggestion seems a bit broader that than? My rule of thumb is that if there is another case of the same behaviour described in the commit message, it should be fixed in the same change, but otherwise it probably belongs in a separate change.\n\nThey also have different backport potential, so I\u0027d prefer to keep this one separate.","commit_id":"58e8d16fd0774c94e7929d434ed00d283254cabd"},{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"fb4b6577c28d77e6550a98d8f6043c0f55f1747f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73533405_8b99d783","updated":"2026-08-10 09:23:13.000000000","message":"LGTM, thank you for the contribution!","commit_id":"748de442dfc525f2ceecadd5395bbb90f3b22e06"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"d2453c376e0d7090cfca665008bda89166038164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0974b259_1aa107ea","updated":"2026-08-07 07:48:40.000000000","message":"recheck","commit_id":"748de442dfc525f2ceecadd5395bbb90f3b22e06"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"b48e693828487609cebe45da4597b9fbd82ba38a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9ad0494_5de5b131","updated":"2026-08-06 05:44:04.000000000","message":"recheck","commit_id":"748de442dfc525f2ceecadd5395bbb90f3b22e06"}]}