)]}'
{"id":"openstack%2Fvalidations-common~758943","triplet_id":"openstack%2Fvalidations-common~master~I23a81c57774bb6259d071b0c3da3a309fc33986c","project":"openstack/validations-common","branch":"master","topic":"callback/json/gathering_facts_actions","hashtags":[],"change_id":"I23a81c57774bb6259d071b0c3da3a309fc33986c","subject":"Exclude non failing gathering facts action in simplified result","status":"MERGED","created":"2020-10-21 05:59:04.000000000","updated":"2020-10-23 11:29:55.000000000","submitted":"2020-10-23 11:29:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"758943-1603452595901-3ba9713c","meta_rev_id":"e7a1c5afdfeec85bfb1b9e25ae818afd42dd239d","_number":758943,"virtual_id_number":758943,"owner":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-23 11:29:55.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},{"value":0,"date":"2020-10-22 15:39:16.000000000","_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-10-23 06:56:01.000000000","_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":2,"date":"2020-10-21 09:53:33.000000000","_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},{"value":0,"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-10-23 06:56:01.000000000","_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},{"value":0,"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-21 09:53:33.000000000","updated_by":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"reviewer":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"state":"REVIEWER"},{"updated":"2020-10-23 06:56:01.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2020-10-23 11:29:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cbf0c005dbb55c7ef7c69785699520b7039f383b","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2020-10-21 05:59:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2fb5ed441578076fdb00dce31c31ab594c999f2d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-21 06:19:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/49983399d4c54d87a5a1b537084c4d25 : SUCCESS in 6m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6625ae6e40e644a9bd02c9be64b49c60 : SUCCESS in 6m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0fcfd47a5cb548f6b465ad4a31f45f6a : SUCCESS in 7m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a1eb1ffe151248acb61aab5f9a3f806c : SUCCESS in 8m 33s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/cc710cd9e4304f7e823b12f3ccacf8da : SUCCESS in 7m 57s\n- validations-common-functional https://zuul.opendev.org/t/openstack/build/770699f1a3784582a60b891710313f4d : SUCCESS in 14m 14s","accounts_in_message":[],"_revision_number":1},{"id":"240d6451e0c6e4669706eae83849848e274d7f1f","author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"date":"2020-10-21 09:53:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1d3a7533a492763c9ad28736b1a97dec7da6dbb1","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2020-10-22 05:35:04.000000000","message":"Patch Set 1: Code-Review+1\n\nDon\u0027t we need to do the same for the \"failed\" part?","accounts_in_message":[],"_revision_number":1},{"id":"acd385ddb7c715a8fdb954e7f5198af28e8c3e54","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2020-10-22 15:39:16.000000000","message":"Patch Set 1:\n\n\u003e Don\u0027t we need to do the same for the \"failed\" part?\n\nIn the simple_results (which is injected into validation_output dict), we want all the failed tasks and all the warning tasks coming from our custom warn modules. The issue here is that the gathering_facts action has a warnings key in its task results which is set to [] when this action went well. And we don\u0027t want to get a long long list of ansible facts in the simple output.\n\nIf the gathering_facts fails, it will be caught in the FAILED test.","accounts_in_message":[],"_revision_number":1},{"id":"d96119c3724a02f3c847c321af26f6bdd1ddfe4c","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2020-10-23 06:56:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"43420846829d7fde6ca220a3bc23f40f8cdcc80a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-23 06:56:14.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d15f206e4de26e1c3c94796279483d50bac1f5b9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-23 11:29:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/91aaa60dad9947faa25a0c3818238876 : SUCCESS in 9m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/efb1e25b537645f6922e421fe948ff50 : SUCCESS in 9m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3321e451babb403e803f345232d1e574 : SUCCESS in 8m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8b0bed2506fb439d986abb064f3a869b : SUCCESS in 8m 48s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/7449173dedda4e94b266ac6ba2f486cd : SUCCESS in 10m 14s\n- validations-common-functional https://zuul.opendev.org/t/openstack/build/4970be6685de44ddb43d2e3a20f46fd6 : SUCCESS in 14m 24s","accounts_in_message":[],"_revision_number":1},{"id":"dffd34ee7b443a283f982ba8bb1371957ecc7daa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-23 11:29:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"51f27383c8f63190658d758319ba5d7a7de203fe","revisions":{"51f27383c8f63190658d758319ba5d7a7de203fe":{"kind":"REWORK","_number":1,"created":"2020-10-21 05:59:04.000000000","uploader":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"ref":"refs/changes/43/758943/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/validations-common","ref":"refs/changes/43/758943/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/validations-common refs/changes/43/758943/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/validations-common refs/changes/43/758943/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/validations-common refs/changes/43/758943/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/validations-common refs/changes/43/758943/1"}}},"commit":{"parents":[{"commit":"844b877a686db15927d27b456892206758bea214","subject":"Install CI roles into share/ansible/roles","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/validations-common/commit/844b877a686db15927d27b456892206758bea214"}]}],"author":{"name":"Gael Chamoulaud (Strider)","email":"gchamoul@redhat.com","date":"2020-10-20 12:56:29.000000000","tz":120},"committer":{"name":"Gael Chamoulaud (Strider)","email":"gchamoul@redhat.com","date":"2020-10-20 12:56:29.000000000","tz":120},"subject":"Exclude non failing gathering facts action in simplified result","message":"Exclude non failing gathering facts action in simplified result\n\nThe warnings key while gathering facts is set to an empty list if this\naction pass successfully. This patch excludes successful gathering facts\naction and grab action logs when some real warnings are present.\n\nChange-Id: I23a81c57774bb6259d071b0c3da3a309fc33986c\nSigned-off-by: Gael Chamoulaud (Strider) \u003cgchamoul@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/validations-common/commit/51f27383c8f63190658d758319ba5d7a7de203fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/validations-common/commit/51f27383c8f63190658d758319ba5d7a7de203fe"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}