)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"0dd22cf8196541c845de6f17f9eaf895e20c73b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"95e0aab4_a30bb6b7","updated":"2021-10-13 08:22:32.000000000","message":"I\u0027m going to wait for a bit before starting recheck on this one. If it is an infra failure it might take time to resolve.","commit_id":"7d416acbe89a9ba23cabfd4e97c80affe57e06cb"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"6cf4ef8b223652cd9a9a7bdd619d40da646ac113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"079ffd77_a2ee27b7","updated":"2021-10-13 10:14:41.000000000","message":"recheck","commit_id":"7d416acbe89a9ba23cabfd4e97c80affe57e06cb"}],"validations_libs/validation_actions.py":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"8722c798386325c1187b9727fc5f9fb5d52f526f","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    def __init__(self, validation_path\u003dconstants.ANSIBLE_VALIDATION_DIR,"},{"line_number":44,"context_line":"                 group\u003dNone):"},{"line_number":45,"context_line":"        self.log \u003d logging.getLogger(__name__ + \".ValidationActions\")"},{"line_number":46,"context_line":"        self.validation_path \u003d validation_path"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def list_validations(self, group\u003dNone):"},{"line_number":49,"context_line":"        \"\"\"Get a list of the validations selected by group"}],"source_content_type":"text/x-python","patch_set":1,"id":"d3f14dee_ecf0d578","line":46,"updated":"2021-06-18 08:16:34.000000000","message":"What about the group which is not accessed at all here.\n\nWe should add the group in the self instance:\n\n      self.group \u003d group\n\nAnd use the per-instance attribute self.group everywhere like we do for self.validation_path.\n\nBUT, that will break the API. Then if we don\u0027t want to do that, it\u0027s better to remove the \u0027group\u0027 argument from the constructor method, because it is pretty useless.","commit_id":"6e54ac6fc193a5f566934c362c6aada9340bc202"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"ffcc9bb04ce160bbff9610ba542724f2f91bb157","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    def __init__(self, validation_path\u003dconstants.ANSIBLE_VALIDATION_DIR,"},{"line_number":44,"context_line":"                 group\u003dNone):"},{"line_number":45,"context_line":"        self.log \u003d logging.getLogger(__name__ + \".ValidationActions\")"},{"line_number":46,"context_line":"        self.validation_path \u003d validation_path"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def list_validations(self, group\u003dNone):"},{"line_number":49,"context_line":"        \"\"\"Get a list of the validations selected by group"}],"source_content_type":"text/x-python","patch_set":1,"id":"a297cedf_cf311f82","line":46,"in_reply_to":"d3f14dee_ecf0d578","updated":"2021-06-18 08:35:35.000000000","message":"Or we can make one small, self contained, change here. And resolve the issue of group parameter during the tech checkpoint.\n\nThere is no reason why we can\u0027t adjust the methods to accept the `group` param and defer to instance attribute value if it is `None`.","commit_id":"6e54ac6fc193a5f566934c362c6aada9340bc202"}]}