)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"f78418478e91be3e7a03aca0ed3143dde98bade8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jiri Podivin \u003cjpodivin@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-06-17 17:06:11 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Old \"groups show\" behavior restored"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resolves: rhbz#1972155"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"05a4d71e_8e956be0","line":7,"updated":"2021-06-17 17:39:45.000000000","message":"I would rather see as commit message the following one:\n\n    Fix a regression in the ShowGroup sub-command\n\n    The ShowGroup sub-command was not working anymore due \n    to a regression introduced by the new CLI next generation\n    commit[1].\n\n    This patch fixes the ShowGroup sub-command by addressing the\n    following points:\n    * The ValidationActions.group_information method should take \n      the absolute path of the groups.yaml file by default.\n    * Using cliff.lister.Lister base class instead of\n      cliff.show.ShowOne base class for the ShowGroup class.\n\n    Resolves: rhbz#1972155\n\n    [1] - https://opendev.org/openstack/validations-libs/commit/5fad1a4d18c655910ed72e23ad5fb6ac0e4e412c","commit_id":"007c8e04717069991b66f665d9d9779c1fc81bcc"}],"validations_libs/cli/show.py":[{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"fb7ffcbb7c06dad752e8d1dd446c677464b5cb1f","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def get_parser(self, parser):"},{"line_number":57,"context_line":"        \"\"\"Argument parser for validation show group\"\"\""},{"line_number":58,"context_line":"        parser \u003d super(ShowGroup, self).get_parser(parser)"},{"line_number":59,"context_line":"        parser.add_argument(\u0027--validation-dir\u0027, dest\u003d\u0027validation_dir\u0027,"},{"line_number":60,"context_line":"                            default\u003dconstants.ANSIBLE_VALIDATION_DIR,"},{"line_number":61,"context_line":"                            help\u003d(\"Path where the validation playbooks \""},{"line_number":62,"context_line":"                                  \"are located.\"))"},{"line_number":63,"context_line":"        parser.add_argument(\u0027--group\u0027, \u0027-g\u0027,"},{"line_number":64,"context_line":"                            metavar\u003d\u0027\u003cgroup_name\u003e\u0027,"},{"line_number":65,"context_line":"                            dest\u003d\"group\","},{"line_number":66,"context_line":"                            help\u003d(\"Show a specific group.\"))"},{"line_number":67,"context_line":"        return parser"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"d2da5f53_3dce3c8d","side":"PARENT","line":66,"range":{"start_line":59,"start_character":0,"end_line":66,"end_character":60},"updated":"2021-06-18 04:57:41.000000000","message":"I think we should keep those parameters but with the constants as default.\nThe user may wants to provide different paths.","commit_id":"4d1df7b0e75260c96164fd5a21347f5ce18c7a8b"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"bfbab894e0e1b57c527e813fd3eaeb9960400b72","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    def get_parser(self, parser):"},{"line_number":57,"context_line":"        \"\"\"Argument parser for validation show group\"\"\""},{"line_number":58,"context_line":"        parser \u003d super(ShowGroup, self).get_parser(parser)"},{"line_number":59,"context_line":"        parser.add_argument(\u0027--validation-dir\u0027, dest\u003d\u0027validation_dir\u0027,"},{"line_number":60,"context_line":"                            default\u003dconstants.ANSIBLE_VALIDATION_DIR,"},{"line_number":61,"context_line":"                            help\u003d(\"Path where the validation playbooks \""},{"line_number":62,"context_line":"                                  \"are located.\"))"},{"line_number":63,"context_line":"        parser.add_argument(\u0027--group\u0027, \u0027-g\u0027,"},{"line_number":64,"context_line":"                            metavar\u003d\u0027\u003cgroup_name\u003e\u0027,"},{"line_number":65,"context_line":"                            dest\u003d\"group\","},{"line_number":66,"context_line":"                            help\u003d(\"Show a specific group.\"))"},{"line_number":67,"context_line":"        return parser"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"597e4201_bbfc77dc","side":"PARENT","line":66,"range":{"start_line":59,"start_character":0,"end_line":66,"end_character":60},"in_reply_to":"d2da5f53_3dce3c8d","updated":"2021-06-18 07:34:29.000000000","message":"That was in my previous proposal along with move to lister.py and renaming of the class, and Gael explicitly requested them to be removed and for this to be as close to what was in python-tripleoclient as possible. \nhttps://review.opendev.org/c/openstack/validations-libs/+/796426","commit_id":"4d1df7b0e75260c96164fd5a21347f5ce18c7a8b"}]}