)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"9949af77d7eb9f13b3b80663ba7d072a71ebc36f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d46fd9ae_177c6c21","updated":"2022-05-16 06:43:39.000000000","message":"This is great. I\u0027ll have to give it a proper read however, as I know of some cases when side effects of six were used to control the flow.\n\nIn any case, it might be better to leave the setup.cfg out of the review, as we have one review open for it already[1].\n\n[1]https://review.opendev.org/c/openstack/validations-libs/+/840438","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"1d4d1dbae25150e0ab36a4222506bceb083f56ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b1dd3b6_059b341a","updated":"2022-06-03 07:31:07.000000000","message":"recheck","commit_id":"07d720211c7e2607bd5a814ab6f930e42cd8dc4e"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"a23362efcef257e63239e92924279927af27f12b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7fa7c92f_d47364eb","updated":"2022-06-01 13:59:30.000000000","message":"recheck","commit_id":"07d720211c7e2607bd5a814ab6f930e42cd8dc4e"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"8c90d4410cb89b2beb4a0d8618c2aff0231cf64b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ca5262c7_63255bf4","updated":"2022-06-03 12:47:40.000000000","message":"Tenatative +1, probably actually a +2 but I\u0027d like consensus from the rest of the VF DFG regarding if this idea is a go.\n\nCode looks good and its obviously passing zuul. :-)","commit_id":"c8fb5bfa2ec76eeb1e2c6dd3a87b275a3eac72fb"}],"setup.cfg":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"9949af77d7eb9f13b3b80663ba7d072a71ebc36f","unresolved":true,"context_lines":[{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author_email \u003d openstack-discuss@lists.openstack.org"},{"line_number":8,"context_line":"home_page \u003d https://docs.openstack.org/validations-libs/latest/"},{"line_number":9,"context_line":"python_requires \u003d \u003e\u003d3.6"},{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"2c847961_fda16de2","line":9,"updated":"2022-05-16 06:43:39.000000000","message":"I believe this key actually belongs in the `options` section.[0]\n\n[0]https://setuptools.pypa.io/en/latest/userguide/dependency_management.html?highlight\u003dpython_requires#python-requirement","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87e3156f293510372fb0b1ab4d58be63d0568ec5","unresolved":true,"context_lines":[{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author_email \u003d openstack-discuss@lists.openstack.org"},{"line_number":8,"context_line":"home_page \u003d https://docs.openstack.org/validations-libs/latest/"},{"line_number":9,"context_line":"python_requires \u003d \u003e\u003d3.6"},{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"44883128_588e1c3d","line":9,"in_reply_to":"050f1ac4_6a0b7707","updated":"2022-06-01 04:36:30.000000000","message":"Hmm. ok so you already selected [options] for validations-libs so I\u0027ll follow that then. But please be aware this is not what we globally do in the other projects atm.","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bd018862daa596a753b13a4503d882a1dfb1faf7","unresolved":true,"context_lines":[{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author_email \u003d openstack-discuss@lists.openstack.org"},{"line_number":8,"context_line":"home_page \u003d https://docs.openstack.org/validations-libs/latest/"},{"line_number":9,"context_line":"python_requires \u003d \u003e\u003d3.6"},{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"99edc6c0_5939ff21","line":9,"in_reply_to":"2c847961_fda16de2","updated":"2022-05-16 06:56:17.000000000","message":"The setting.cfg is not directly passed to setuptools but it is first parsed by pbr, which uses [metadata] parameters and generates options for setuptools.\n\nThe following line describes the mapping between [metadata] python_requires and [option] python_requires.\n https://github.com/openstack/pbr/blob/5ded0ee1ff7236aa6bdc94cf5f4426b3816c98ef/pbr/util.py#L117","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"09b7e3342f1e8814768690a1dfef32aae8c630ff","unresolved":false,"context_lines":[{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author_email \u003d openstack-discuss@lists.openstack.org"},{"line_number":8,"context_line":"home_page \u003d https://docs.openstack.org/validations-libs/latest/"},{"line_number":9,"context_line":"python_requires \u003d \u003e\u003d3.6"},{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"924267d2_a1ea35df","line":9,"in_reply_to":"44883128_588e1c3d","updated":"2022-06-03 08:11:23.000000000","message":"Done","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"3ebe1df75b1e08ab8f02a0415bbce32dc1976489","unresolved":true,"context_lines":[{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author_email \u003d openstack-discuss@lists.openstack.org"},{"line_number":8,"context_line":"home_page \u003d https://docs.openstack.org/validations-libs/latest/"},{"line_number":9,"context_line":"python_requires \u003d \u003e\u003d3.6"},{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ed8b8b9e_5dc2af5c","line":9,"in_reply_to":"99edc6c0_5939ff21","updated":"2022-05-16 07:11:17.000000000","message":"Interesting. Still according to the pbr docs, other sections, such as options, are handled in a same same way as in vanilla setuptools[2]\n\n[2]https://docs.openstack.org/pbr/latest/user/using.html#setup-cfg","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"043559f7fddedc4e67886e5971238b289d0bc2c1","unresolved":true,"context_lines":[{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author_email \u003d openstack-discuss@lists.openstack.org"},{"line_number":8,"context_line":"home_page \u003d https://docs.openstack.org/validations-libs/latest/"},{"line_number":9,"context_line":"python_requires \u003d \u003e\u003d3.6"},{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"050f1ac4_6a0b7707","line":9,"in_reply_to":"ed8b8b9e_5dc2af5c","updated":"2022-06-01 04:34:59.000000000","message":"My understanding is that you can use the native interface of setuptools while pbr provides more sophisticated structure. Using [options] would work but I\u0027ll keep usage of [metadata] since that is globally used in the other OpenStack projects.","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"9949af77d7eb9f13b3b80663ba7d072a71ebc36f","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    License :: OSI Approved :: Apache Software License"},{"line_number":15,"context_line":"    Operating System :: POSIX :: Linux"},{"line_number":16,"context_line":"    Programming Language :: Python"},{"line_number":17,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":18,"context_line":"    Programming Language :: Python :: 3"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3.6"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.7"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b9930871_50570d51","line":17,"updated":"2022-05-16 06:43:39.000000000","message":"Good point about the classifier. I\u0027ve completely forgotten about that.","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"09b7e3342f1e8814768690a1dfef32aae8c630ff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    License :: OSI Approved :: Apache Software License"},{"line_number":15,"context_line":"    Operating System :: POSIX :: Linux"},{"line_number":16,"context_line":"    Programming Language :: Python"},{"line_number":17,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":18,"context_line":"    Programming Language :: Python :: 3"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3.6"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.7"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"e7cdcb0c_a27e0449","line":17,"in_reply_to":"b9930871_50570d51","updated":"2022-06-03 08:11:23.000000000","message":"Done","commit_id":"67940818b4ae55593f6c8b1f4d48b6796eb80bbc"}]}