)]}'
{"virtualbmc/tests/unit/test_vbmc.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"f03737ba54b881ae6ed78f41bd06f63da3be93bb","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self._test_power_off(mock_libvirt_domain, mock_libvirt_open,"},{"line_number":128,"context_line":"                             power_on\u003dTrue)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test__power_off_is_off(self, mock_libvirt_domain, mock_libvirt_open):"},{"line_number":131,"context_line":"        self._test_power_off(mock_libvirt_domain, mock_libvirt_open,"},{"line_number":132,"context_line":"                             power_on\u003dFalse)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_52c9f7ab","line":130,"updated":"2016-05-12 15:29:39.000000000","message":"Why the double-underscore here and single-underscore elsewhere?","commit_id":"e24ba468acecd6eaa0cb0ec89b19cc7b3daa56e6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2dca1ac5a9e264241f9316bfdd76b6b6f5f7bbdd","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self._test_power_off(mock_libvirt_domain, mock_libvirt_open,"},{"line_number":128,"context_line":"                             power_on\u003dTrue)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def test__power_off_is_off(self, mock_libvirt_domain, mock_libvirt_open):"},{"line_number":131,"context_line":"        self._test_power_off(mock_libvirt_domain, mock_libvirt_open,"},{"line_number":132,"context_line":"                             power_on\u003dFalse)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_6dd9ba83","line":130,"in_reply_to":"dab17558_52c9f7ab","updated":"2016-05-12 15:43:50.000000000","message":"ops, will be fixed","commit_id":"e24ba468acecd6eaa0cb0ec89b19cc7b3daa56e6"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"f03737ba54b881ae6ed78f41bd06f63da3be93bb","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                             power_on\u003dFalse)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_power_off_error(self, mock_libvirt_domain, mock_libvirt_open,"},{"line_number":135,"context_line":"                             power_on\u003dTrue):"},{"line_number":136,"context_line":"        mock_libvirt_domain.side_effect \u003d libvirt.libvirtError(\u0027boom\u0027)"},{"line_number":137,"context_line":"        self.vbmc.power_off()"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_32f713f7","line":135,"updated":"2016-05-12 15:29:39.000000000","message":"You aren\u0027t using the power_on argument. Either eliminate it or test both cases - though AFAICT nothing should happen if it\u0027s False.","commit_id":"e24ba468acecd6eaa0cb0ec89b19cc7b3daa56e6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2dca1ac5a9e264241f9316bfdd76b6b6f5f7bbdd","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                             power_on\u003dFalse)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_power_off_error(self, mock_libvirt_domain, mock_libvirt_open,"},{"line_number":135,"context_line":"                             power_on\u003dTrue):"},{"line_number":136,"context_line":"        mock_libvirt_domain.side_effect \u003d libvirt.libvirtError(\u0027boom\u0027)"},{"line_number":137,"context_line":"        self.vbmc.power_off()"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_4dc956ac","line":135,"in_reply_to":"dab17558_32f713f7","updated":"2016-05-12 15:43:50.000000000","message":"Done","commit_id":"e24ba468acecd6eaa0cb0ec89b19cc7b3daa56e6"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"f03737ba54b881ae6ed78f41bd06f63da3be93bb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            sasl_username\u003dself.domain[\u0027libvirt_sasl_username\u0027],"},{"line_number":145,"context_line":"            uri\u003dself.domain[\u0027libvirt_uri\u0027])"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _test_power_on(self, mock_libvirt_domain, mock_libvirt_open,"},{"line_number":148,"context_line":"                       power_on\u003dTrue):"},{"line_number":149,"context_line":"        mock_libvirt_domain.return_value.isActive.return_value \u003d power_on"},{"line_number":150,"context_line":"        self.vbmc.power_on()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_f7345dfc","line":147,"updated":"2016-05-12 15:29:39.000000000","message":"I\u0027m wondering if it\u0027s worth unifying this with _test_power_off:\n\n    # common setup\n\n    domain \u003d mock_libvirt_domain.return_value\n    if source \u003d\u003d target:\n        domain.create.assert_not_called()\n        domain.destroy.assert_not_called()\n    elif target \u003d\u003d \"off\":\n        domain.create.assert_not_called()\n        domain.destroy.assert_called_once_with()\n    else:\n        domain.create.assert_called_once_with()\n        domain.destroy.assert_not_called()\n\n    # common assertions\n\nOr you could factor out the common assertions into an assertLibvirtCalls method, which you could then call from the test_power_*_error methods as well.","commit_id":"e24ba468acecd6eaa0cb0ec89b19cc7b3daa56e6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2dca1ac5a9e264241f9316bfdd76b6b6f5f7bbdd","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            sasl_username\u003dself.domain[\u0027libvirt_sasl_username\u0027],"},{"line_number":145,"context_line":"            uri\u003dself.domain[\u0027libvirt_uri\u0027])"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _test_power_on(self, mock_libvirt_domain, mock_libvirt_open,"},{"line_number":148,"context_line":"                       power_on\u003dTrue):"},{"line_number":149,"context_line":"        mock_libvirt_domain.return_value.isActive.return_value \u003d power_on"},{"line_number":150,"context_line":"        self.vbmc.power_on()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_6df53aca","line":147,"in_reply_to":"dab17558_f7345dfc","updated":"2016-05-12 15:43:50.000000000","message":"great suggestion! Will try that","commit_id":"e24ba468acecd6eaa0cb0ec89b19cc7b3daa56e6"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"f03737ba54b881ae6ed78f41bd06f63da3be93bb","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                            power_on\u003dFalse)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_power_on_error(self, mock_libvirt_domain, mock_libvirt_open,"},{"line_number":171,"context_line":"                            power_on\u003dTrue):"},{"line_number":172,"context_line":"        mock_libvirt_domain.side_effect \u003d libvirt.libvirtError(\u0027boom\u0027)"},{"line_number":173,"context_line":"        self.vbmc.power_on()"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_5225775a","line":171,"updated":"2016-05-12 15:29:39.000000000","message":"This argument is unused.","commit_id":"e24ba468acecd6eaa0cb0ec89b19cc7b3daa56e6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2dca1ac5a9e264241f9316bfdd76b6b6f5f7bbdd","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                            power_on\u003dFalse)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_power_on_error(self, mock_libvirt_domain, mock_libvirt_open,"},{"line_number":171,"context_line":"                            power_on\u003dTrue):"},{"line_number":172,"context_line":"        mock_libvirt_domain.side_effect \u003d libvirt.libvirtError(\u0027boom\u0027)"},{"line_number":173,"context_line":"        self.vbmc.power_on()"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_8d717e7a","line":171,"in_reply_to":"dab17558_5225775a","updated":"2016-05-12 15:43:50.000000000","message":"Done","commit_id":"e24ba468acecd6eaa0cb0ec89b19cc7b3daa56e6"}]}