)]}'
{"virtualbmc/manager.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b6230352c752ef2ab67dea77546c07169b5323ec","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            config.add_section(DEFAULT_SECTION)"},{"line_number":110,"context_line":"            config.set(DEFAULT_SECTION, \u0027username\u0027, username)"},{"line_number":111,"context_line":"            config.set(DEFAULT_SECTION, \u0027password\u0027, password)"},{"line_number":112,"context_line":"            config.set(DEFAULT_SECTION, \u0027port\u0027, \"{}\".format(port))"},{"line_number":113,"context_line":"            config.set(DEFAULT_SECTION, \u0027address\u0027, address)"},{"line_number":114,"context_line":"            config.set(DEFAULT_SECTION, \u0027domain_name\u0027, domain_name)"},{"line_number":115,"context_line":"            config.set(DEFAULT_SECTION, \u0027libvirt_uri\u0027, libvirt_uri)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_c22fc63c","line":112,"range":{"start_line":112,"start_character":48,"end_line":112,"end_character":65},"updated":"2017-03-06 17:57:44.000000000","message":"Looks a bit hacky to use string interpolation to convert stuff. Since we already rely on the \"six\" library for Py2/3 compat, what about:\n\n six.text_type(port)\n\n?","commit_id":"b19b3706942b5a9f932af522bc9bcd1a0df012a8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1c71b31ae2fdfd95f9b665b874ec583cae5f6e95","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            config.add_section(DEFAULT_SECTION)"},{"line_number":110,"context_line":"            config.set(DEFAULT_SECTION, \u0027username\u0027, username)"},{"line_number":111,"context_line":"            config.set(DEFAULT_SECTION, \u0027password\u0027, password)"},{"line_number":112,"context_line":"            config.set(DEFAULT_SECTION, \u0027port\u0027, \"{}\".format(port))"},{"line_number":113,"context_line":"            config.set(DEFAULT_SECTION, \u0027address\u0027, address)"},{"line_number":114,"context_line":"            config.set(DEFAULT_SECTION, \u0027domain_name\u0027, domain_name)"},{"line_number":115,"context_line":"            config.set(DEFAULT_SECTION, \u0027libvirt_uri\u0027, libvirt_uri)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_a202d270","line":112,"range":{"start_line":112,"start_character":48,"end_line":112,"end_character":65},"in_reply_to":"ba2be162_c22fc63c","updated":"2017-03-06 18:02:17.000000000","message":"Done","commit_id":"b19b3706942b5a9f932af522bc9bcd1a0df012a8"}],"virtualbmc/tests/unit/test_manager.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"692caa115d3ebd7804159804b2d8bc82c7ae2438","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.domain_path0 \u003d os.path.join(_CONFIG_PATH, self.domain_name0)"},{"line_number":45,"context_line":"        self.domain_path1 \u003d os.path.join(_CONFIG_PATH, self.domain_name1)"},{"line_number":46,"context_line":"        self.add_params \u003d {\u0027username\u0027: \u0027admin\u0027, \u0027password\u0027: \u0027pass\u0027,"},{"line_number":47,"context_line":"                           \u0027port\u0027: \u0027777\u0027, \u0027address\u0027: \u0027::\u0027,"},{"line_number":48,"context_line":"                           \u0027domain_name\u0027: \u0027Squidward Tentacles\u0027,"},{"line_number":49,"context_line":"                           \u0027libvirt_uri\u0027: \u0027foo://bar\u0027,"},{"line_number":50,"context_line":"                           \u0027libvirt_sasl_username\u0027: \u0027sasl_admin\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_bdbf535f","line":47,"updated":"2017-03-06 18:32:09.000000000","message":"So, I see why you changed this (because we use it for validation), but we should also test passing an int into add() (so we know this patch does what it says). Maybe a copy of test_add() with an int passed in.","commit_id":"8b3c660e92c2298cae38946afbcd123ac8dfa2cc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ff31070a927a07d4641eb37bb3e2d8c4a93cbdb7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.domain_path0 \u003d os.path.join(_CONFIG_PATH, self.domain_name0)"},{"line_number":45,"context_line":"        self.domain_path1 \u003d os.path.join(_CONFIG_PATH, self.domain_name1)"},{"line_number":46,"context_line":"        self.add_params \u003d {\u0027username\u0027: \u0027admin\u0027, \u0027password\u0027: \u0027pass\u0027,"},{"line_number":47,"context_line":"                           \u0027port\u0027: \u0027777\u0027, \u0027address\u0027: \u0027::\u0027,"},{"line_number":48,"context_line":"                           \u0027domain_name\u0027: \u0027Squidward Tentacles\u0027,"},{"line_number":49,"context_line":"                           \u0027libvirt_uri\u0027: \u0027foo://bar\u0027,"},{"line_number":50,"context_line":"                           \u0027libvirt_sasl_username\u0027: \u0027sasl_admin\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_bb582858","line":47,"in_reply_to":"ba2be162_4fc05e7d","updated":"2017-03-07 12:18:50.000000000","message":"Good point Jim","commit_id":"8b3c660e92c2298cae38946afbcd123ac8dfa2cc"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"14129e810c9397feb36cce22c9b66be7c5eec499","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.domain_path0 \u003d os.path.join(_CONFIG_PATH, self.domain_name0)"},{"line_number":45,"context_line":"        self.domain_path1 \u003d os.path.join(_CONFIG_PATH, self.domain_name1)"},{"line_number":46,"context_line":"        self.add_params \u003d {\u0027username\u0027: \u0027admin\u0027, \u0027password\u0027: \u0027pass\u0027,"},{"line_number":47,"context_line":"                           \u0027port\u0027: \u0027777\u0027, \u0027address\u0027: \u0027::\u0027,"},{"line_number":48,"context_line":"                           \u0027domain_name\u0027: \u0027Squidward Tentacles\u0027,"},{"line_number":49,"context_line":"                           \u0027libvirt_uri\u0027: \u0027foo://bar\u0027,"},{"line_number":50,"context_line":"                           \u0027libvirt_sasl_username\u0027: \u0027sasl_admin\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_4fc05e7d","line":47,"in_reply_to":"ba2be162_bdbf535f","updated":"2017-03-06 18:40:59.000000000","message":"Done","commit_id":"8b3c660e92c2298cae38946afbcd123ac8dfa2cc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ef57dd1b095cfa85122843a8e35c07641a91b466","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def test_add_with_port_as_int(self, mock_check_conn, mock_makedirs,"},{"line_number":144,"context_line":"                                  mock_configparser, mock_open):"},{"line_number":145,"context_line":"        config \u003d mock_configparser.return_value"},{"line_number":146,"context_line":"        params \u003d copy.copy(self.add_params)"},{"line_number":147,"context_line":"        params[\u0027port\u0027] \u003d int(params[\u0027port\u0027])"},{"line_number":148,"context_line":"        self.manager.add(**params)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_1b1db473","line":146,"range":{"start_line":146,"start_character":17,"end_line":146,"end_character":43},"updated":"2017-03-07 12:19:58.000000000","message":"nit: self.add_params.copy()","commit_id":"ef2c8818e6139904027830435171aff14c6b2407"}]}