)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7f75715ebfe3f67d74e3d462215c650e0ea9b053","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note: current pyghmi supports only port 623 and 28418 for SoL."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"It requires pyghmi \u003e\u003d 1.0.22."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I7f9dfbd2b3eb1320be755bade2f97b9f0621d409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f91af0f_8400a336","line":17,"updated":"2018-01-02 13:55:11.000000000","message":"nit: Not required to state, it is already the minimum in global requirements.","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"7673f216b9009d3a69e2ec7755a0107e3ac5cdce","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note: current pyghmi supports only port 623 and 28418 for SoL."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"It requires pyghmi \u003e\u003d 1.0.22."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I7f9dfbd2b3eb1320be755bade2f97b9f0621d409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f91af0f_01b6b8fb","line":17,"in_reply_to":"9f91af0f_8400a336","updated":"2018-01-03 04:22:24.000000000","message":"Done","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ea807959bd390fd204b874c298d69636643390e7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\"ipmitool sol activate\" command."},{"line_number":12,"context_line":"SOL capability requires a persistent libvirt connection, so this"},{"line_number":13,"context_line":"patchset adds libvirt_open.get_conn() method and use it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7f9dfbd2b3eb1320be755bade2f97b9f0621d409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bf659307_c3996a6e","line":14,"updated":"2018-03-28 13:57:08.000000000","message":"Is there a story or task id associated with this?","commit_id":"9f7bfb9f6bc3d561c9a669e9bed3364d610a9642"}],"doc/source/user/index.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edceb13669246a662034a19a95a8811ae5d37a65","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 chassis bootparam get 5"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* To Connect the serial console (type \"~.\" to quit)::"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 sol activate"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_58ed98ed","line":104,"updated":"2018-01-02 16:46:52.000000000","message":"nit: \"connect\"","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"7673f216b9009d3a69e2ec7755a0107e3ac5cdce","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 chassis bootparam get 5"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* To Connect the serial console (type \"~.\" to quit)::"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 sol activate"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_21bbbce2","line":104,"in_reply_to":"9f91af0f_58ed98ed","updated":"2018-01-03 04:22:24.000000000","message":"Done","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edceb13669246a662034a19a95a8811ae5d37a65","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 sol activate"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  Note: pyghmi supports only port 623 and 28418 for serial console."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_f8bb4ce2","line":108,"updated":"2018-01-02 16:46:52.000000000","message":"I suggest we merge this, and then follow up when a new version of pyghmi is released. Thanks Jarrod!\n\nunrelated: I\u0027d prefer we use .. warning:: syntax for this","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7f75715ebfe3f67d74e3d462215c650e0ea9b053","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 sol activate"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  Note: pyghmi supports only port 623 and 28418 for serial console."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_e4940feb","line":108,"updated":"2018-01-02 13:55:11.000000000","message":"This could be problematic in terms of CI testing :(","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":7902,"name":"Jarrod Johnson","email":"jjohnson2@lenovo.com","username":"jbjohnso"},"change_message_id":"3636b27bba2bed339ba28c1f156f017ff5ed63d3","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 sol activate"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  Note: pyghmi supports only port 623 and 28418 for serial console."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_7df64e92","line":108,"in_reply_to":"9f91af0f_1dace28a","updated":"2018-01-02 16:24:45.000000000","message":"On the server side:\n756ebdbf (Akira Yoshiyama     2017-07-09 01:14:20 +0900  69)                 data\u003d[0, 0, 0, 0, 1, 0, 1, 0, 2, 0x6f, 0xff, 0xff])\n\nI have added a change to that section, now both server and client should be able to have custom ports.","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":7902,"name":"Jarrod Johnson","email":"jjohnson2@lenovo.com","username":"jbjohnso"},"change_message_id":"5986dcccaa26210c2adf3658e40d32fe1eb760b9","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 sol activate"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  Note: pyghmi supports only port 623 and 28418 for serial console."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_1dace28a","line":108,"in_reply_to":"9f91af0f_ba87fcd7","updated":"2018-01-02 16:12:52.000000000","message":"Ok, at least on the client side I did:\nhttps://review.openstack.org/530763\nWill seek comments on whatever you need to support custom ports.","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"693e8e99624bb52321dfc18797a027490fb67143","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 sol activate"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  Note: pyghmi supports only port 623 and 28418 for serial console."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_ba87fcd7","line":108,"in_reply_to":"9f91af0f_e4940feb","updated":"2018-01-02 15:23:05.000000000","message":"Yes... Jarrod, do you have any plan to improve pyghmi?","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"7673f216b9009d3a69e2ec7755a0107e3ac5cdce","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    $ ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 sol activate"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  Note: pyghmi supports only port 623 and 28418 for serial console."}],"source_content_type":"text/x-rst","patch_set":6,"id":"9f91af0f_a19b4c70","line":108,"in_reply_to":"9f91af0f_f8bb4ce2","updated":"2018-01-03 04:22:24.000000000","message":"I\u0027ll update the line like below:\n\n\"..warning:: old versions of phghmi only support port 623 and 28418 for serial console. Use newer ones.\"","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"63a0c6147529de40325b01386e4b908de71c8a31","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  .. warning::"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"     Old versions of pyghmi support only port 623 and 28418 for serial"},{"line_number":111,"context_line":"     console. Use newer ones."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f91af0f_1991b1f1","line":111,"updated":"2018-01-10 11:38:29.000000000","message":"I\u0027d prefer to be specific on which versions we\u0027re referring to","commit_id":"5d09a222439391c284292ba149584c839938737f"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"9cda501d90bee3314bc7eee1e274c2b9eb3ca60f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"  .. warning::"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"     Old versions of pyghmi support only port 623 and 28418 for serial"},{"line_number":111,"context_line":"     console. Use newer ones."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7f96bb07_c236a9b5","line":111,"in_reply_to":"9f91af0f_1991b1f1","updated":"2018-01-11 15:02:22.000000000","message":"Done","commit_id":"5d09a222439391c284292ba149584c839938737f"}],"virtualbmc/vbmc.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"983a29d2a07baf077fd1c8e0c82c44b699e181e5","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            libvirt.virEventRunDefaultImpl()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def check_console(self):"},{"line_number":216,"context_line":"        if (self.state[0] \u003d\u003d libvirt.VIR_DOMAIN_RUNNING or"},{"line_number":217,"context_line":"                self.state[0] \u003d\u003d libvirt.VIR_DOMAIN_PAUSED):"},{"line_number":218,"context_line":"            if self.stream is None:"},{"line_number":219,"context_line":"                self.stream \u003d self.conn.newStream(libvirt.VIR_STREAM_NONBLOCK)"},{"line_number":220,"context_line":"                self.domain.openConsole(None, self.stream, 0)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_ee27ed11","line":217,"range":{"start_line":216,"start_character":8,"end_line":217,"end_character":60},"updated":"2017-08-10 15:42:30.000000000","message":"fails with a TypeError if self.state is None:\n\n\n\n  In [15]: v.check_console?\n  Signature: v.check_console()\n  Docstring: \u003cno docstring\u003e\n  File:      /usr/lib/python2.7/site-packages/virtualbmc/vbmc.py\n  Type:      instancemethod\n\n  In [16]: v.check_console()\n  ---------------------------------------------------------------------------\n  TypeError                                 Traceback (most recent call last)\n  \u003cipython-input-16-44af012fa54f\u003e in \u003cmodule\u003e()\n  ----\u003e 1 v.check_console()\n\n  /usr/lib/python2.7/site-packages/virtualbmc/vbmc.pyc in check_console(self)\n      214\n      215     def check_console(self):\n  --\u003e 216         if (self.state[0] \u003d\u003d libvirt.VIR_DOMAIN_RUNNING or\n      217                 self.state[0] \u003d\u003d libvirt.VIR_DOMAIN_PAUSED):\n      218             if self.stream is None:\n\n  TypeError: \u0027NoneType\u0027 object has no attribute \u0027__getitem__\u0027","commit_id":"dad2b5f2530791b4b0f3141182b36e53e653ea50"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"4d73403aff197a5f6659ff6bc43d978d793f5e29","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            libvirt.virEventRunDefaultImpl()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def check_console(self):"},{"line_number":216,"context_line":"        if (self.state[0] \u003d\u003d libvirt.VIR_DOMAIN_RUNNING or"},{"line_number":217,"context_line":"                self.state[0] \u003d\u003d libvirt.VIR_DOMAIN_PAUSED):"},{"line_number":218,"context_line":"            if self.stream is None:"},{"line_number":219,"context_line":"                self.stream \u003d self.conn.newStream(libvirt.VIR_STREAM_NONBLOCK)"},{"line_number":220,"context_line":"                self.domain.openConsole(None, self.stream, 0)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_0dc3c958","line":217,"range":{"start_line":216,"start_character":8,"end_line":217,"end_character":60},"in_reply_to":"9f436f4f_ee27ed11","updated":"2017-08-16 15:06:36.000000000","message":"Done","commit_id":"dad2b5f2530791b4b0f3141182b36e53e653ea50"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"983a29d2a07baf077fd1c8e0c82c44b699e181e5","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        return self.run_console"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def activate_payload(self, request, session):"},{"line_number":231,"context_line":"        LOG.debug(\u0027Activate payload called for domain %s\u0027, self.domain_name)"},{"line_number":232,"context_line":"        if self.activated:"},{"line_number":233,"context_line":"            LOG.error(\u0027Error activating payload the domain %(domain)s. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_a22b39e9","line":230,"range":{"start_line":230,"start_character":31,"end_line":230,"end_character":49},"updated":"2017-08-10 15:42:30.000000000","message":"no docstring describing the args","commit_id":"dad2b5f2530791b4b0f3141182b36e53e653ea50"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"4d73403aff197a5f6659ff6bc43d978d793f5e29","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        return self.run_console"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def activate_payload(self, request, session):"},{"line_number":231,"context_line":"        LOG.debug(\u0027Activate payload called for domain %s\u0027, self.domain_name)"},{"line_number":232,"context_line":"        if self.activated:"},{"line_number":233,"context_line":"            LOG.error(\u0027Error activating payload the domain %(domain)s. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_2dc8cd71","line":230,"range":{"start_line":230,"start_character":31,"end_line":230,"end_character":49},"in_reply_to":"9f436f4f_a22b39e9","updated":"2017-08-16 15:06:36.000000000","message":"Done","commit_id":"dad2b5f2530791b4b0f3141182b36e53e653ea50"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edceb13669246a662034a19a95a8811ae5d37a65","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.state \u003d None"},{"line_number":79,"context_line":"        self.stream \u003d None"},{"line_number":80,"context_line":"        self.run_console \u003d False"},{"line_number":81,"context_line":"        self.sol_thread \u003d None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        libvirt.virEventRegisterDefaultImpl()"},{"line_number":84,"context_line":"        libvirt.registerErrorHandler(error_handler, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_18c15055","line":81,"updated":"2018-01-02 16:46:52.000000000","message":"nit: these seem private, maybe prefix with _ ?","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"7673f216b9009d3a69e2ec7755a0107e3ac5cdce","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.state \u003d None"},{"line_number":79,"context_line":"        self.stream \u003d None"},{"line_number":80,"context_line":"        self.run_console \u003d False"},{"line_number":81,"context_line":"        self.sol_thread \u003d None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        libvirt.virEventRegisterDefaultImpl()"},{"line_number":84,"context_line":"        libvirt.registerErrorHandler(error_handler, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_618f842a","line":81,"in_reply_to":"9f91af0f_18c15055","updated":"2018-01-03 04:22:24.000000000","message":"Done","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edceb13669246a662034a19a95a8811ae5d37a65","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                      \u0027Error: %(error)s\u0027 % {\u0027domain\u0027: self.domain_name,"},{"line_number":207,"context_line":"                                            \u0027error\u0027: e})"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def iohandler(self, data):"},{"line_number":210,"context_line":"        if self.stream:"},{"line_number":211,"context_line":"            self.stream.send(data)"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_b8b5c4f0","line":209,"updated":"2018-01-02 16:46:52.000000000","message":"is this method used? I don\u0027t see where, but maybe I\u0027m missing it","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"7673f216b9009d3a69e2ec7755a0107e3ac5cdce","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                      \u0027Error: %(error)s\u0027 % {\u0027domain\u0027: self.domain_name,"},{"line_number":207,"context_line":"                                            \u0027error\u0027: e})"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def iohandler(self, data):"},{"line_number":210,"context_line":"        if self.stream:"},{"line_number":211,"context_line":"            self.stream.send(data)"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_9c2b0b93","line":209,"in_reply_to":"9f91af0f_b8b5c4f0","updated":"2018-01-03 04:22:24.000000000","message":"self.iohandler() is passed to pyghmi.ipmi.console.Console in pyghmi.ipmi.bmc.Bmc.activate_payload().","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edceb13669246a662034a19a95a8811ae5d37a65","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            LOG.error(\u0027Error activating payload the domain %(domain)s. \u0027"},{"line_number":257,"context_line":"                      \u0027Error: %(error)s\u0027 % {\u0027domain\u0027: self.domain_name,"},{"line_number":258,"context_line":"                                            \u0027error\u0027: e})"},{"line_number":259,"context_line":"            super(VirtualBMC, self).deactivate_payload(request, session)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def deactivate_payload(self, request, session):"},{"line_number":262,"context_line":"        \"\"\"Disonnect VM serial console from the IPMI session"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_d8ba08dd","line":259,"updated":"2018-01-02 16:46:52.000000000","message":"should we return something here? how will it look for a user if we hit this error? will it just return nothing, crash, hang..?","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"7673f216b9009d3a69e2ec7755a0107e3ac5cdce","unresolved":false,"context_lines":[{"line_number":256,"context_line":"            LOG.error(\u0027Error activating payload the domain %(domain)s. \u0027"},{"line_number":257,"context_line":"                      \u0027Error: %(error)s\u0027 % {\u0027domain\u0027: self.domain_name,"},{"line_number":258,"context_line":"                                            \u0027error\u0027: e})"},{"line_number":259,"context_line":"            super(VirtualBMC, self).deactivate_payload(request, session)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def deactivate_payload(self, request, session):"},{"line_number":262,"context_line":"        \"\"\"Disonnect VM serial console from the IPMI session"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_a7191c7a","line":259,"in_reply_to":"9f91af0f_d8ba08dd","updated":"2018-01-03 04:22:24.000000000","message":"Other IPMI requests like power-on should be accepted after exceptions here. So nothing looks good.","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edceb13669246a662034a19a95a8811ae5d37a65","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        except libvirt.libvirtError as e:"},{"line_number":281,"context_line":"            LOG.error(\u0027Error deactivating payload the domain %(domain)s. \u0027"},{"line_number":282,"context_line":"                      \u0027Error: %(error)s\u0027 % {\u0027domain\u0027: self.domain_name,"},{"line_number":283,"context_line":"                                            \u0027error\u0027: e})"},{"line_number":284,"context_line":"        finally:"},{"line_number":285,"context_line":"            self.conn.close()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_78cf3c7f","line":283,"updated":"2018-01-02 16:46:52.000000000","message":"ditto","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"7673f216b9009d3a69e2ec7755a0107e3ac5cdce","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        except libvirt.libvirtError as e:"},{"line_number":281,"context_line":"            LOG.error(\u0027Error deactivating payload the domain %(domain)s. \u0027"},{"line_number":282,"context_line":"                      \u0027Error: %(error)s\u0027 % {\u0027domain\u0027: self.domain_name,"},{"line_number":283,"context_line":"                                            \u0027error\u0027: e})"},{"line_number":284,"context_line":"        finally:"},{"line_number":285,"context_line":"            self.conn.close()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f91af0f_c73b00cf","line":283,"in_reply_to":"9f91af0f_78cf3c7f","updated":"2018-01-03 04:22:24.000000000","message":"ditto","commit_id":"3ac5352d3261159edb60c0076bf2911ea1966884"}]}