)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a83c291aca78f14680a3fedc5115c4a05f0d622","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     HyunsikYang \u003cyangun@dcn.ssu.ac.kr\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-28 21:06:31 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vBMC for openstack instance"},{"line_number":8,"context_line":"vBMC currently works well when it is used to control virtual machine which is made by KVM."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"With this, user uses a virtual machine as like as a baremetal."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_702b5b94","line":7,"updated":"2018-05-28 13:12:41.000000000","message":"Greetings! You should add a line break in between line 7 and 8 since otherwise gerrit related tools don\u0027t process the commit message properly.","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"af7530e237ab055144b6ec6439c6be6caf463ebc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     HyunsikYang \u003cyangun@dcn.ssu.ac.kr\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-28 21:06:31 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vBMC for openstack instance"},{"line_number":8,"context_line":"vBMC currently works well when it is used to control virtual machine which is made by KVM."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"With this, user uses a virtual machine as like as a baremetal."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_6c37ffb1","line":7,"in_reply_to":"5f7c97a3_702b5b94","updated":"2018-05-29 01:29:33.000000000","message":"Thank you for your kind reply. \n\nI will check it and update it soon","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a83c291aca78f14680a3fedc5115c4a05f0d622","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-05-28 21:06:31 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vBMC for openstack instance"},{"line_number":8,"context_line":"vBMC currently works well when it is used to control virtual machine which is made by KVM."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"With this, user uses a virtual machine as like as a baremetal."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_301ba381","line":8,"range":{"start_line":8,"start_character":69,"end_line":8,"end_character":72},"updated":"2018-05-28 13:12:41.000000000","message":"Please wrap the line.","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"af7530e237ab055144b6ec6439c6be6caf463ebc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-05-28 21:06:31 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vBMC for openstack instance"},{"line_number":8,"context_line":"vBMC currently works well when it is used to control virtual machine which is made by KVM."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"With this, user uses a virtual machine as like as a baremetal."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_8c3cdb93","line":8,"range":{"start_line":8,"start_character":69,"end_line":8,"end_character":72},"in_reply_to":"5f7c97a3_301ba381","updated":"2018-05-29 01:29:33.000000000","message":"fixed. Thanks","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a83c291aca78f14680a3fedc5115c4a05f0d622","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"With this, user uses a virtual machine as like as a baremetal."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In addition, each KVM node should have vBMC to control the virtual machine."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, current vBMC doesn\u0027t support instance which is made by openstack."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_50209fac","line":12,"range":{"start_line":12,"start_character":66,"end_line":12,"end_character":72},"updated":"2018-05-28 13:12:41.000000000","message":"Please wrap the line","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"af7530e237ab055144b6ec6439c6be6caf463ebc","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"With this, user uses a virtual machine as like as a baremetal."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In addition, each KVM node should have vBMC to control the virtual machine."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, current vBMC doesn\u0027t support instance which is made by openstack."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_2c3d878d","line":12,"range":{"start_line":12,"start_character":66,"end_line":12,"end_character":72},"in_reply_to":"5f7c97a3_50209fac","updated":"2018-05-29 01:29:33.000000000","message":"fixed. Thanks","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a83c291aca78f14680a3fedc5115c4a05f0d622","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In addition, each KVM node should have vBMC to control the virtual machine."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, current vBMC doesn\u0027t support instance which is made by openstack."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Therefore, I uploaded this patch for supporting vBMC for openstack instance."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_f010cb5b","line":14,"range":{"start_line":14,"start_character":71,"end_line":14,"end_character":73},"updated":"2018-05-28 13:12:41.000000000","message":"Please wrap the line","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"af7530e237ab055144b6ec6439c6be6caf463ebc","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In addition, each KVM node should have vBMC to control the virtual machine."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, current vBMC doesn\u0027t support instance which is made by openstack."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Therefore, I uploaded this patch for supporting vBMC for openstack instance."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_4c424311","line":14,"range":{"start_line":14,"start_character":71,"end_line":14,"end_character":73},"in_reply_to":"5f7c97a3_f010cb5b","updated":"2018-05-29 01:29:33.000000000","message":"fixed. Thanks","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a83c291aca78f14680a3fedc5115c4a05f0d622","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, current vBMC doesn\u0027t support instance which is made by openstack."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Therefore, I uploaded this patch for supporting vBMC for openstack instance."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I4da0b011250451cff5fbf209e2fae80c391a5df5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_d00b4f27","line":16,"range":{"start_line":16,"start_character":57,"end_line":16,"end_character":76},"updated":"2018-05-28 13:12:41.000000000","message":"Please wrap this line to 79 characters and elaborate a little more as to what your patch does.","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"af7530e237ab055144b6ec6439c6be6caf463ebc","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"However, current vBMC doesn\u0027t support instance which is made by openstack."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Therefore, I uploaded this patch for supporting vBMC for openstack instance."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I4da0b011250451cff5fbf209e2fae80c391a5df5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_ec4a2f25","line":16,"range":{"start_line":16,"start_character":57,"end_line":16,"end_character":76},"in_reply_to":"5f7c97a3_d00b4f27","updated":"2018-05-29 01:29:33.000000000","message":"fixed. Thanks","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"360ecd5b28462ef7ecc9970613bb48a30df6e0af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     HyunsikYang \u003cyangun@dcn.ssu.ac.kr\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-30 10:11:08 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vBMC for openstack instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vBMC currently works well when it is used to control virtual machine"},{"line_number":10,"context_line":"which is made by KVM."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_29cc9932","line":7,"updated":"2018-06-11 10:17:02.000000000","message":"The title is a bit confusing to me, may be rephrase to better explain the feature being introduced?","commit_id":"ca0146cb04834b77fe51b83e4492c2568456cadf"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"360ecd5b28462ef7ecc9970613bb48a30df6e0af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vBMC for openstack instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vBMC currently works well when it is used to control virtual machine"},{"line_number":10,"context_line":"which is made by KVM."},{"line_number":11,"context_line":"With this, user uses a virtual machine as like as a baremetal."},{"line_number":12,"context_line":"In addition, each KVM node should have vBMC to control the virtual"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_e9d9c1f3","line":9,"updated":"2018-06-11 10:17:02.000000000","message":"Could you please wrap lines shorter?","commit_id":"ca0146cb04834b77fe51b83e4492c2568456cadf"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"360ecd5b28462ef7ecc9970613bb48a30df6e0af","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Therefore, this patch can be used for supporting vBMC for"},{"line_number":17,"context_line":"openstack instance."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I4da0b011250451cff5fbf209e2fae80c391a5df5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f7c97a3_e9546156","line":19,"updated":"2018-06-11 10:17:02.000000000","message":"Please, add Story: and Task: tags\n\nhttps://storyboard.openstack.org/#!/story/1754724","commit_id":"ca0146cb04834b77fe51b83e4492c2568456cadf"}],"virtualbmc/openstack_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a83c291aca78f14680a3fedc5115c4a05f0d622","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# nova list"},{"line_number":15,"context_line":"# vbmc delete 61bd6c79-7f78-4576-86fc-d0884fced014"},{"line_number":16,"context_line":"# vbmc add 61bd6c79-7f78-4576-86fc-d0884fced014"},{"line_number":17,"context_line":"# vbmc start 61bd6c79-7f78-4576-86fc-d0884fced014"},{"line_number":18,"context_line":"# ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 chassis \\"},{"line_number":19,"context_line":"#   bootdev pxe"},{"line_number":20,"context_line":"# ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 power reset"},{"line_number":21,"context_line":"# pip install ws4py"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# ykpark (novaclient service)"},{"line_number":24,"context_line":"import imp"},{"line_number":25,"context_line":"from virtualbmc import config as vbmc_config"},{"line_number":26,"context_line":"from virtualbmc import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_eb053a11","line":23,"range":{"start_line":14,"start_character":0,"end_line":23,"end_character":29},"updated":"2018-05-28 13:12:41.000000000","message":"This seems like it is left over from development?","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"af7530e237ab055144b6ec6439c6be6caf463ebc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# nova list"},{"line_number":15,"context_line":"# vbmc delete 61bd6c79-7f78-4576-86fc-d0884fced014"},{"line_number":16,"context_line":"# vbmc add 61bd6c79-7f78-4576-86fc-d0884fced014"},{"line_number":17,"context_line":"# vbmc start 61bd6c79-7f78-4576-86fc-d0884fced014"},{"line_number":18,"context_line":"# ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 chassis \\"},{"line_number":19,"context_line":"#   bootdev pxe"},{"line_number":20,"context_line":"# ipmitool -I lanplus -U admin -P password -H 127.0.0.1 -p 623 power reset"},{"line_number":21,"context_line":"# pip install ws4py"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# ykpark (novaclient service)"},{"line_number":24,"context_line":"import imp"},{"line_number":25,"context_line":"from virtualbmc import config as vbmc_config"},{"line_number":26,"context_line":"from virtualbmc import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ac50b7d6","line":23,"range":{"start_line":14,"start_character":0,"end_line":23,"end_character":29},"in_reply_to":"5f7c97a3_eb053a11","updated":"2018-05-29 01:29:33.000000000","message":"i will remove it. thanks","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a83c291aca78f14680a3fedc5115c4a05f0d622","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from virtualbmc import log"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"try:"},{"line_number":30,"context_line":"    imp.find_module(\u0027keystoneauth1\u0027)"},{"line_number":31,"context_line":"    imp.find_module(\u0027novaclient\u0027)"},{"line_number":32,"context_line":"    from keystoneauth1 import loading"},{"line_number":33,"context_line":"    from keystoneauth1 import session"},{"line_number":34,"context_line":"    from novaclient import client"},{"line_number":35,"context_line":"    found \u003d True"},{"line_number":36,"context_line":"except ImportError:"},{"line_number":37,"context_line":"    found \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_cb107e51","line":34,"range":{"start_line":30,"start_character":0,"end_line":34,"end_character":33},"updated":"2018-05-28 13:12:41.000000000","message":"nit: We should ideally make use of openstacksdk instead of novaclient.","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":22290,"name":"hyunsik Yang","email":"yangun@dcn.ssu.ac.kr","username":"hyunsikYang"},"change_message_id":"b953c61db51ea3b82fdd14f22c0570f3d9cd74e7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from virtualbmc import log"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"try:"},{"line_number":30,"context_line":"    imp.find_module(\u0027keystoneauth1\u0027)"},{"line_number":31,"context_line":"    imp.find_module(\u0027novaclient\u0027)"},{"line_number":32,"context_line":"    from keystoneauth1 import loading"},{"line_number":33,"context_line":"    from keystoneauth1 import session"},{"line_number":34,"context_line":"    from novaclient import client"},{"line_number":35,"context_line":"    found \u003d True"},{"line_number":36,"context_line":"except ImportError:"},{"line_number":37,"context_line":"    found \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4ca00343","line":34,"range":{"start_line":30,"start_character":0,"end_line":34,"end_character":33},"in_reply_to":"5f7c97a3_cb107e51","updated":"2018-05-29 04:21:32.000000000","message":"what is the mean of the openstackSDK? \ncould you let me know the detail? Thanks alot","commit_id":"97af017154a8920ba740ac50815f652148e3f434"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"360ecd5b28462ef7ecc9970613bb48a30df6e0af","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def create_connection_from_config():"},{"line_number":40,"context_line":"    \"\"\"From existing CloudRegion.\"\"\""},{"line_number":41,"context_line":"    cloud_name \u003d \\"},{"line_number":42,"context_line":"        CONF[\u0027cloud_config\u0027][\u0027cloud_name\u0027] or \u0027vbmc-cloud\u0027"},{"line_number":43,"context_line":"    region_name \u003d \\"},{"line_number":44,"context_line":"        CONF[\u0027cloud_config\u0027][\u0027region_name\u0027] or \u0027RegionOne\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_6994d1e8","line":41,"updated":"2018-06-11 10:17:02.000000000","message":"Shall we use curly braces instead of backslash?\n\n    cloud_name \u003d (\n        ... or\n        ...\n    )","commit_id":"ca0146cb04834b77fe51b83e4492c2568456cadf"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"360ecd5b28462ef7ecc9970613bb48a30df6e0af","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_openstack_conn(conn\u003dNone):"},{"line_number":78,"context_line":"    \"\"\"Get a openstack connect.\"\"\""},{"line_number":79,"context_line":"    if conn is None:"},{"line_number":80,"context_line":"        conn \u003d create_connection_from_config()"},{"line_number":81,"context_line":"    return conn"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_a98d09d5","line":78,"range":{"start_line":78,"start_character":11,"end_line":78,"end_character":30},"updated":"2018-06-11 10:17:02.000000000","message":"nit: an OpenStack connection","commit_id":"ca0146cb04834b77fe51b83e4492c2568456cadf"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"360ecd5b28462ef7ecc9970613bb48a30df6e0af","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    return conn"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def is_enable(domain_name\u003dNone):"},{"line_number":85,"context_line":"    if KEYSTONE_TAG in CONF._conf_dict \\"},{"line_number":86,"context_line":"       and found and domain_name is not None \\"},{"line_number":87,"context_line":"       and len(domain_name) \u003e 35 \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_c98ac5ba","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":13},"updated":"2018-06-11 10:17:02.000000000","message":"nit: is_enabled","commit_id":"ca0146cb04834b77fe51b83e4492c2568456cadf"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"360ecd5b28462ef7ecc9970613bb48a30df6e0af","unresolved":false,"context_lines":[{"line_number":84,"context_line":"def is_enable(domain_name\u003dNone):"},{"line_number":85,"context_line":"    if KEYSTONE_TAG in CONF._conf_dict \\"},{"line_number":86,"context_line":"       and found and domain_name is not None \\"},{"line_number":87,"context_line":"       and len(domain_name) \u003e 35 \\"},{"line_number":88,"context_line":"       and not domain_name.lower().startswith(\u0027instance\u0027):"},{"line_number":89,"context_line":"        return True"},{"line_number":90,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_69bdb166","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":32},"updated":"2018-06-11 10:17:02.000000000","message":"What exactly this condition is for?\n\nMay be a comment would help?","commit_id":"ca0146cb04834b77fe51b83e4492c2568456cadf"}],"virtualbmc/vbmc.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"360ecd5b28462ef7ecc9970613bb48a30df6e0af","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            return IPMI_INVALID_DATA"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            if openstack_utils.is_enable(self.domain_name):"},{"line_number":88,"context_line":"                openstack_utils.set_meta_item(self.domain_name, str(device))"},{"line_number":89,"context_line":"            else:"},{"line_number":90,"context_line":"                with utils.libvirt_open(**self._conn_args) as conn:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_a9a66953","line":87,"updated":"2018-06-11 10:17:02.000000000","message":"Could we branch based on explicit command-line option rather than on OpenStack availability? Explicit is better than implicit, huh? ;-)","commit_id":"ca0146cb04834b77fe51b83e4492c2568456cadf"}]}