)]}'
{"id":"openstack%2Fvirtualbmc~700407","triplet_id":"openstack%2Fvirtualbmc~master~I190733137eb37183e517d1194a91bf534164c3fd","project":"openstack/virtualbmc","branch":"master","topic":"tox-enforce-correct-pyver","hashtags":[],"change_id":"I190733137eb37183e517d1194a91bf534164c3fd","subject":"Enforce running tox with correct python version based on env","status":"MERGED","created":"2019-12-23 10:18:06.000000000","updated":"2020-01-10 02:40:24.000000000","submitted":"2020-01-10 02:39:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"700407-1578623945171-f3637170","meta_rev_id":"57abe1f8d6212366d570e9a45ad44f01a67a78ed","_number":700407,"virtual_id_number":700407,"owner":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-01-09 09:14:14.000000000","_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-10 02:39:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":2,"date":"2020-01-10 02:32:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-26 11:41:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":1,"date":"2020-01-10 02:32:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-26 11:41:16.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-01-10 02:32:04.000000000","updated_by":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"reviewer":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"state":"REVIEWER"},{"updated":"2020-01-10 02:39:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f0f5ddeedcd3b61fd0013e4d1571271c6cf35c49","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2019-12-23 10:18:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b1087b4fbe5ad283f43757a3713b2873bda407a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-23 10:27:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/11912201a5f749c9b485a89a3b489ede : SUCCESS in 3m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/98a47da2403740638fe64c8c0e7fc687 : SUCCESS in 5m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cce27c6c00ce494ea237d1e1c464ec53 : SUCCESS in 3m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9a752161ad94450284c8b1598e1b3b9d : SUCCESS in 3m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/843857493e274be1bc1e0875bcb858bf : SUCCESS in 3m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/20d39abb40e342a5b9bed0ce5125ebd0 : SUCCESS in 6m 12s","accounts_in_message":[],"_revision_number":1},{"id":"b3c9337d6c45cc8def22e1733802d498ec420df7","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-12-26 11:41:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"154b8f5be838c46854cb53e063975386a2b40f21","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2020-01-09 03:56:22.000000000","message":"Patch Set 1:\n\nHi Riccardo, I am not quite understand the description. Without this fix, I can still run py38 tests with tox -epy38, so what\u0027s the issue here?","accounts_in_message":[],"_revision_number":1},{"id":"793a0b3dee34f5877bbc732c509f2c755d594ec4","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-01-09 09:14:14.000000000","message":"Patch Set 1:\n\n\u003e Hi Riccardo, I am not quite understand the description. Without\n \u003e this fix, I can still run py38 tests with tox -epy38, so what\u0027s the\n \u003e issue here?\n\nHi Kaifeng, since we use basepython3 for all the jobs, without this option tox will run the test but not forcing the use of the correct Python interpreter selected, but using the default one available in the system, it will just spawn a warning saying that the interpreter is not the one selected, for example:\n2020-01-03 18:06:56.077887 | ubuntu-bionic | /usr/local/lib/python3.6/dist-packages/tox/config/__init__.py:582: UserWarning: conflicting basepython version (set 3.6, should be 3.7) for env \u0027py37\u0027;resolve conflict or set ignore_basepython_conflict\n\nSo unning tox -epy37 on ubuntu 18.04, with Python 3.6 as default system python3 interpreter, it will use python3.6.\nYou can find an example in this job:\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b37/700990/3/check/openstack-tox-py37/b379a05/job-output.txt","accounts_in_message":[],"_revision_number":1},{"id":"9d20034a858af27c2902a0373f8ad3b839c2897c","author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"date":"2020-01-10 02:32:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThank you Riccardo, got it now, I am testing on ironic by changing tox version to 2.0 but forget to remove the ignore_basepython_conflict, so it works like the patch has no effect :)","accounts_in_message":[],"_revision_number":1},{"id":"c81ebea7ab9c62a93e76338a158d997dd7473542","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-10 02:32:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"188f1833771ae016d022ee7e2884c8deba16008c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-10 02:39:04.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1ee12ee5cf614f8ab1ea906b8ce64699 : SUCCESS in 3m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/973c49d2c3f14996a8527364c1bd2b54 : SUCCESS in 5m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bc74d5ea7f394dffb48aa41fa95ec33c : SUCCESS in 3m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b4b72f60cd164f05b487edfdbd89aa12 : SUCCESS in 3m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f2e7f33e965d4b06a4a850a239c47a3c : SUCCESS in 3m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4b0551f8ac284abbb0061e8a42d2d1ae : SUCCESS in 6m 09s","accounts_in_message":[],"_revision_number":1},{"id":"aba1487090eb7c1f30ae5ad9da107485941300b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-10 02:39:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"205363ffd6a5ed12d0160ce5ac47e76bc61f4747","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-10 02:40:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ba7736fe980343cd95c065aa161a1405 : SUCCESS in 56s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bd16e716ca3149fe9dfd6c00e53b4c74 : SUCCESS in 1m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"695c41ede99dab7708a2b603e11034f6b4bf9bd8","revisions":{"695c41ede99dab7708a2b603e11034f6b4bf9bd8":{"kind":"REWORK","_number":1,"created":"2019-12-23 10:18:06.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/07/700407/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/virtualbmc","ref":"refs/changes/07/700407/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/07/700407/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/07/700407/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/07/700407/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/virtualbmc refs/changes/07/700407/1"}}},"commit":{"parents":[{"commit":"26b7ff606372ef35279d8dc4926d5a4001e367f7","subject":"Stop using six library","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/26b7ff606372ef35279d8dc4926d5a4001e367f7"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2019-12-23 10:17:52.000000000","tz":60},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2019-12-23 10:17:52.000000000","tz":60},"subject":"Enforce running tox with correct python version based on env","message":"Enforce running tox with correct python version based on env\n\nSince removing support for Python 2, we changed the basepython\nvalue to 3.\nThis means that all the tox tests run with the default python\nversion available in the system.\nThis is not quite correct when running on environment such as\npy36, py37 or py38, since they imply running with different\nPython versions based on the environment.\nTo enforce the correct version we need to add the option\nignore_basepython_conflict available since tox 3.1.0 [0].\n\n[0] https://tox.readthedocs.io/en/latest/config.html#conf-ignore_basepython_conflict\n\nChange-Id: I190733137eb37183e517d1194a91bf534164c3fd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/695c41ede99dab7708a2b603e11034f6b4bf9bd8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/695c41ede99dab7708a2b603e11034f6b4bf9bd8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}