)]}'
{"id":"openstack%2Fvirtualbmc~708763","triplet_id":"openstack%2Fvirtualbmc~master~I3ad307f97442c6b30c3e60bd8186bfb30903c0b0","project":"openstack/virtualbmc","branch":"master","topic":"show-failing-state","hashtags":[],"change_id":"I3ad307f97442c6b30c3e60bd8186bfb30903c0b0","subject":"Add `error` instance status to `vbmc` reporing","status":"MERGED","created":"2020-02-19 22:30:13.000000000","updated":"2020-03-06 08:48:25.000000000","submitted":"2020-03-06 08:47:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"708763-1583484423260-3bf77f9f","meta_rev_id":"0994b1a6541dc180dc6aa245104baeb4993b6905","_number":708763,"virtual_id_number":708763,"owner":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-06 08:47:03.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":2,"date":"2020-03-06 07:55:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-03-05 16:26:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":1,"date":"2020-03-06 07:55:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-05 16:26:38.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-03-06 07:55:55.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-03-06 08:47:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3220c1a5f8496f0ccdad3dcd7f0416ae23e22e7d","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-02-19 22:30:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"212d77e59b8b0e48388a0b54cbfe89ce61b2d054","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-19 23:19:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6c5f72bad9394ea6b68f24abe6549df6 : SUCCESS in 5m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/28749732608749bc98bdcecfe1097e54 : SUCCESS in 6m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f315bd056fd74454bd31af9346904f85 : SUCCESS in 5m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/edee3e2cb91e428aab84e9288eeaaa49 : SUCCESS in 5m 15s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/06afeb274b10495da418401ce86e83cd : SUCCESS in 5m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f37ee59fb16d4172a2082b00c2d7deeb : SUCCESS in 5m 32s (non-voting)\n- virtualbmc-tempest-ironic-ipmi-iscsi https://zuul.opendev.org/t/openstack/build/e0a09e53b11448ed8389c50bc83b61ab : SUCCESS in 47m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dcc4a990ee424d4886751d54aa3beb2b : SUCCESS in 8m 33s","accounts_in_message":[],"_revision_number":1},{"id":"ae676821a6ffee0c8004552da8cb47b64d44278c","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-03 14:36:45.000000000","message":"Patch Set 1:\n\nA bit of bikeshedding: maybe call the new state \"error\"? Seems consistent with openstack world, including ironic.","accounts_in_message":[],"_revision_number":1},{"id":"4f3b78e0bce1f207f165a5c76fab0ff2eba93ef1","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-05 10:46:56.000000000","message":"Patch Set 1: Code-Review-1\n\n-1 to highlight my question. also, can we somehow report the exact error?","accounts_in_message":[],"_revision_number":1},{"id":"fef3111872ac8192f82090e18f46374b2b2ab49b","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-03-05 15:46:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6b293dd5299898036ce7b596e769b4983d1816ab","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-03-05 15:50:38.000000000","message":"Patch Set 1:\n\n\u003e -1 to highlight my question. also, can we somehow report the exact error?\n\nChanged to \"error\".\n\nConveying error from a dead child to the client seems difficult... For that we need to establish some kind of child-\u003eparent communication to transfer the error message, then let the master vbmcd process either cache it in memory or write into instance .ini file.\n\nConsidering that the child will report all the details in log, I thought not to complicate things....","accounts_in_message":[],"_revision_number":1},{"id":"4ddeb22a0dcf4b3caafec2a6c332151f872f4b48","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-05 16:26:38.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"60991e2df3f048330127338b8dc09a42477d0c05","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-05 16:33:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/113873f6ee4a48f282ace93bf50f2a9f : SUCCESS in 3m 54s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c37d67c03b8b4b3ea6cbe6762409ac42 : SUCCESS in 5m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b68b145acad34ec68821157defb82a0b : SUCCESS in 4m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b30fa65de7e844ac9da7e6d9be7bf614 : SUCCESS in 4m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fcbfec4ef04348b09a5d594f9fc031f7 : SUCCESS in 4m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0f0249a7438e4f77a7c62a6bf8c7b38f : SUCCESS in 4m 20s (non-voting)\n- virtualbmc-tempest-ironic-ipmi-iscsi https://zuul.opendev.org/t/openstack/build/be5b756dfff84741b495a5174d07e4de : SUCCESS in 44m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/168891ecd53b4163a0c1e0adb835c754 : SUCCESS in 6m 16s","accounts_in_message":[],"_revision_number":2},{"id":"c2e9484a7809d5d1a03cab4bb4e49222898c917a","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-03-06 07:55:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"957815fb227359813c4ebed6a96cdc808984ba82","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-06 07:56:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b6f0da25bc8de6bb2507f8c6f75f7a64ac850051","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-06 08:47:03.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0cd2dd618d0f49c3bfcf62ac21def796 : SUCCESS in 3m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/913749b6437945bdacbdc48f55316e28 : SUCCESS in 7m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f924ed6802ad4f8bb02ca814fbbc27b5 : SUCCESS in 4m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/50e1abd88663449b8ebf73230805eac9 : SUCCESS in 4m 22s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/252b36633ed44aec9fb5555d4a1d7ed1 : SUCCESS in 4m 18s\n- virtualbmc-tempest-ironic-ipmi-iscsi https://zuul.opendev.org/t/openstack/build/a82374aa8e6044bb89870ecd44baa8dd : SUCCESS in 44m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/445d1c179b904434a25211ef3a238588 : SUCCESS in 6m 20s","accounts_in_message":[],"_revision_number":2},{"id":"b88be1bfa06359c0dbe9f7a474c8ad42605184a5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-06 08:47:03.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"6b12d4fa4a4377d8a3943b1f24a163468eb8f8dd","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-06 08:48:25.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/210c2b17981e45aebd7a7a23c4dfecc3 : SUCCESS in 1m 05s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/36122918da1a48df8dd4a797bdbefe67 : SUCCESS in 1m 01s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f79c9ee89a6929a5c6f7d154f59a8443b244bb4d","revisions":{"621b41e63d26fbcc744b42a69a379cc3960da615":{"kind":"REWORK","_number":1,"created":"2020-02-19 22:30:13.000000000","uploader":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"ref":"refs/changes/63/708763/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/virtualbmc","ref":"refs/changes/63/708763/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/63/708763/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/63/708763/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/63/708763/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/virtualbmc refs/changes/63/708763/1"}}},"commit":{"parents":[{"commit":"834d02e6161ef64836395bb00e44870b495143af","subject":"Merge \"Enforce running tox with correct python version based on env\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/834d02e6161ef64836395bb00e44870b495143af"}]}],"author":{"name":"Ilya Etingof","email":"etingof@gmail.com","date":"2020-02-19 22:29:14.000000000","tz":60},"committer":{"name":"Ilya Etingof","email":"etingof@gmail.com","date":"2020-02-19 22:29:46.000000000","tz":60},"subject":"Add `failing` instance status to `vbmc` reporing","message":"Add `failing` instance status to `vbmc` reporing\n\nAdded `failing` status to `vbmc list` and `vbmc start`\ncommands output. If the instance is failing to start, such\ninstance will be shown as `failing` rather than being\n`down`.\n\nChange-Id: I3ad307f97442c6b30c3e60bd8186bfb30903c0b0\nStory: 2006457\nTask: 36378\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/621b41e63d26fbcc744b42a69a379cc3960da615"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/621b41e63d26fbcc744b42a69a379cc3960da615"}]},"branch":"refs/heads/master"},"f79c9ee89a6929a5c6f7d154f59a8443b244bb4d":{"kind":"REWORK","_number":2,"created":"2020-03-05 15:46:19.000000000","uploader":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"ref":"refs/changes/63/708763/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/virtualbmc","ref":"refs/changes/63/708763/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/63/708763/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/63/708763/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/63/708763/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/virtualbmc refs/changes/63/708763/2"}}},"commit":{"parents":[{"commit":"834d02e6161ef64836395bb00e44870b495143af","subject":"Merge \"Enforce running tox with correct python version based on env\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/834d02e6161ef64836395bb00e44870b495143af"}]}],"author":{"name":"Ilya Etingof","email":"etingof@gmail.com","date":"2020-02-19 22:29:14.000000000","tz":60},"committer":{"name":"Ilya Etingof","email":"etingof@gmail.com","date":"2020-03-05 15:46:04.000000000","tz":60},"subject":"Add `error` instance status to `vbmc` reporing","message":"Add `error` instance status to `vbmc` reporing\n\nAdded `error` status to `vbmc list` and `vbmc start`\ncommands output. If the instance is failing to start, such\ninstance will be shown as being in `error` satte rather\nthan being `down`.\n\nChange-Id: I3ad307f97442c6b30c3e60bd8186bfb30903c0b0\nStory: 2006457\nTask: 36378\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/f79c9ee89a6929a5c6f7d154f59a8443b244bb4d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/f79c9ee89a6929a5c6f7d154f59a8443b244bb4d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}