)]}'
{"id":"openstack%2Fvirtualbmc~713038","triplet_id":"openstack%2Fvirtualbmc~master~I784e7cd9e0545a591150dc21a8232bd85672c21c","project":"openstack/virtualbmc","branch":"master","hashtags":[],"change_id":"I784e7cd9e0545a591150dc21a8232bd85672c21c","subject":"Fix stop command by using default SIGTERM handler in children","status":"MERGED","created":"2020-03-13 17:28:39.000000000","updated":"2020-03-23 15:05:50.000000000","submitted":"2020-03-23 15:03:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"713038-1584975832063-354c625b","meta_rev_id":"982dc38dd1019f65e87b212a327e3748678f96c5","_number":713038,"virtual_id_number":713038,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-23 15:03:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"all":[{"value":2,"date":"2020-03-20 11:37:45.000000000","_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":2,"date":"2020-03-23 14:05:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":1,"date":"2020-03-23 14:05:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-20 11:37:45.000000000","updated_by":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"reviewer":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"state":"REVIEWER"},{"updated":"2020-03-23 14:05:00.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-03-23 15:03:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c690a1262dc25e82d8d421e5ac0839326d4cb774","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-03-13 17:28:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"273c98cb72445aff267a736e9697297e550a59af","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-13 18:13:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d0faf7e5103c4a1b854efc8cda4c4d50 : SUCCESS in 7m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/134d806865244f2795897e78cbac8fb1 : SUCCESS in 5m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/093b8d34ee9c4964991cdccc082cddab : SUCCESS in 4m 53s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9336eda22b6e42f3b6fbeccd4db307ce : SUCCESS in 4m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/daa113eb674a467d9738f55cf9354e6f : SUCCESS in 4m 02s (non-voting)\n- virtualbmc-tempest-ironic-ipmi-iscsi https://zuul.opendev.org/t/openstack/build/78e32493e38c4988b69f5a19e91c6fac : SUCCESS in 43m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2113b218106e4b59a44f071022595c65 : SUCCESS in 6m 48s","accounts_in_message":[],"_revision_number":1},{"id":"75dd5598dcfe8a3ef18f0e4f4d7f1943f58f267c","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-03-13 18:20:16.000000000","message":"Patch Set 1:\n\nHitting this issue in Tenks.","accounts_in_message":[],"_revision_number":1},{"id":"86bb32c574b76154360fcb4c4d58171fb0079074","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-03-19 17:34:46.000000000","message":"Patch Set 1:\n\nThere seems to be something relevant already in the code [1]. I wonder if SIGTERM reaches that `kill_children` callback at all? If it does, may be the problem is in that `kill_children` contents?\n\n1. https://github.com/openstack/virtualbmc/blob/master/virtualbmc/control.py#L213","accounts_in_message":[],"_revision_number":1},{"id":"8cdf208caa5df1058bae2f201ed577fce898a6c4","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-03-19 17:51:52.000000000","message":"Patch Set 1:\n\n\u003e There seems to be something relevant already in the code [1]. I\n \u003e wonder if SIGTERM reaches that `kill_children` callback at all? If\n \u003e it does, may be the problem is in that `kill_children` contents?\n \u003e \n \u003e 1. https://github.com/openstack/virtualbmc/blob/master/virtualbmc/control.py#L213\n\nI think that is for a shutdown of the manager process. This issue is that children do not stop when a vbmc stop is executed.","accounts_in_message":[],"_revision_number":1},{"id":"cce52d93c1607330eed48ece682933381b20aded","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-03-19 18:04:47.000000000","message":"Patch Set 1:\n\nCould it be that children inherit that SIGTERM signal handler and somehow get stuck there? In that case may be resetting SIGTERM to default prior to forking [1] would be a cleaner solution?\n\nSorry for nitpicking, I am just trying to find an easy explanation why SIGTERM does not work. ;-)\n\n1. https://github.com/openstack/virtualbmc/blob/master/virtualbmc/manager.py#L171","accounts_in_message":[],"_revision_number":1},{"id":"a256154296f6f5724f2cd1531e0f88a74df1c372","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-03-19 18:08:55.000000000","message":"Patch Set 1:\n\n\u003e Could it be that children inherit that SIGTERM signal handler and\n \u003e somehow get stuck there? In that case may be resetting SIGTERM to\n \u003e default prior to forking [1] would be a cleaner solution?\n \u003e \n \u003e Sorry for nitpicking, I am just trying to find an easy explanation\n \u003e why SIGTERM does not work. ;-)\n \u003e \n \u003e 1. https://github.com/openstack/virtualbmc/blob/master/virtualbmc/manager.py#L171\n\nIt\u0027s fine - if there is a more elegant solution I\u0027d be glad to use it. Signal handler sounds like a good lead. Will investigate when I get time.","accounts_in_message":[],"_revision_number":1},{"id":"b9a1c0d4bf09ff1b733c228370758e29820b9ad7","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-03-20 11:15:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5194a6dc3e6a2a8fa47d53c4b2113b2405ca341e","author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"date":"2020-03-20 11:37:45.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2cb0a7cf11a5bede08bf0a5062b7e9cd338a8e37","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-20 12:11:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b5d8c461dbc74fedaeb77904aeca7bda : SUCCESS in 8m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/937d49fe86ff49af9ad7f62460f16a04 : SUCCESS in 4m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/95b45701093b4b38ba847518c2992a14 : SUCCESS in 4m 32s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ed0859c0947e4aa8adbc975c7a3fb48c : SUCCESS in 5m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/81adb3318e7e4131acfbd31d06f9b352 : SUCCESS in 5m 44s (non-voting)\n- virtualbmc-tempest-ironic-ipmi-iscsi https://zuul.opendev.org/t/openstack/build/4c0fd478261849aeaacd853c36c4116a : SUCCESS in 55m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/64b55910fec44a409555987e8f9db166 : SUCCESS in 7m 34s","accounts_in_message":[],"_revision_number":2},{"id":"aba6775aa6659f1d40bcc891687139571fdf811c","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-03-23 14:05:00.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"61e854ab8bb3d80bee992bee4f84bb66cb42f3ea","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 14:07:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"00c11b6dbe4801c173f1d763a3de26989e703329","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 15:03:51.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/436ee881e3b34b7a8b535808d4569fda : SUCCESS in 4m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c9f9d5d0fff2439a889fac74efa5792c : SUCCESS in 5m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fc0873567c444c6a8ac36b1e260d0342 : SUCCESS in 6m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e687398e80bd440b9f4f30fbb71bda8c : SUCCESS in 5m 43s\n- virtualbmc-tempest-ironic-ipmi-iscsi https://zuul.opendev.org/t/openstack/build/0a4684d822624368bdadf6e828760079 : SUCCESS in 50m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/70973e5952a04b9a9433a9ba9ba085ad : SUCCESS in 7m 30s","accounts_in_message":[],"_revision_number":2},{"id":"03e179186e5de54febe5bc2999a87b92b47e0765","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 15:03:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"982dc38dd1019f65e87b212a327e3748678f96c5","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 15:05:50.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/61046ea296c74a2796a783717a332a7f : SUCCESS in 1m 34s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3449d74b4eb13019246ab507029fee3bc78a2ff9","revisions":{"2846dda3268d5635a8b305fbddd950752471805d":{"kind":"REWORK","_number":1,"created":"2020-03-13 17:28:39.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/38/713038/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/virtualbmc","ref":"refs/changes/38/713038/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/38/713038/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/38/713038/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/38/713038/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/virtualbmc refs/changes/38/713038/1"}}},"commit":{"parents":[{"commit":"4f2aa4540b5e185eabb93834f231aaf59a1b5b03","subject":"[trivial] change vbmc error message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/4f2aa4540b5e185eabb93834f231aaf59a1b5b03"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-03-13 17:28:08.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-03-13 17:28:36.000000000","tz":0},"subject":"Fix stop command by killing children","message":"Fix stop command by killing children\n\nThe daemon child processes do not respond to a SIGTERM. This means that\nthey stay running indefinitely. Switch to a SIGKILL to ensure the child\nis killed.\n\nChange-Id: I784e7cd9e0545a591150dc21a8232bd85672c21c\nStory: 2003534\nTask: 24819\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/2846dda3268d5635a8b305fbddd950752471805d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/2846dda3268d5635a8b305fbddd950752471805d"}]},"branch":"refs/heads/master"},"3449d74b4eb13019246ab507029fee3bc78a2ff9":{"kind":"REWORK","_number":2,"created":"2020-03-20 11:15:00.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/38/713038/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/virtualbmc","ref":"refs/changes/38/713038/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/38/713038/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/38/713038/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/virtualbmc refs/changes/38/713038/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/virtualbmc refs/changes/38/713038/2"}}},"commit":{"parents":[{"commit":"4f2aa4540b5e185eabb93834f231aaf59a1b5b03","subject":"[trivial] change vbmc error message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/4f2aa4540b5e185eabb93834f231aaf59a1b5b03"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-03-13 17:28:08.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-03-20 11:14:27.000000000","tz":0},"subject":"Fix stop command by using default SIGTERM handler in children","message":"Fix stop command by using default SIGTERM handler in children\n\nThe daemon child processes do not respond to a SIGTERM. This means that\nthey stay running indefinitely. This is because the manager process\ninstalls a SIGTERM handler to propagate the signal to children, and this\nhandler is inherited by the children.\n\nReturn children to the default handler for SIGTERM.\n\nChange-Id: I784e7cd9e0545a591150dc21a8232bd85672c21c\nStory: 2003534\nTask: 24819\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/3449d74b4eb13019246ab507029fee3bc78a2ff9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/virtualbmc/commit/3449d74b4eb13019246ab507029fee3bc78a2ff9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}