)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5d61d29301c56e5c151897899d44ed86e8cba466","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4402833c_2a986995","updated":"2024-06-17 23:23:51.000000000","message":"adding cid to review since he expressed interest in the problem in irc","commit_id":"64ee70f95aa3d1a7273cde110e98466fd9bce909"}],"virtualpdu/tests/snmp_client.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7f93fec560418e46c9fc27f05f7ea5eaebc8f617","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from virtualpdu.tests import snmp_error_indications"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import nest_asyncio"},{"line_number":22,"context_line":"nest_asyncio.apply()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SnmpClient(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"a74144df_46322c83","line":22,"updated":"2024-06-17 23:23:34.000000000","message":"First of all: I\u0027d suggest putting this in the base __init__ of the module.\n\nI was honestly tempted today just to factor out the threads altogether and instead set it all up as coroutines. Might be easier than getting asyncio+threads to play well together.","commit_id":"64ee70f95aa3d1a7273cde110e98466fd9bce909"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"65eb97378ff2e85dc731d87b3f1c8f75db66e71e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from virtualpdu.tests import snmp_error_indications"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import nest_asyncio"},{"line_number":22,"context_line":"nest_asyncio.apply()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SnmpClient(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"70f3872a_437e1d53","line":22,"in_reply_to":"a74144df_46322c83","updated":"2024-06-18 07:09:54.000000000","message":"yeah, I agree, I think that\u0027s probably the correct way.\n\ntests are actually passing now, but it\u0027s going in time out as it never close ends the process, still not sure why","commit_id":"64ee70f95aa3d1a7273cde110e98466fd9bce909"}]}