)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Weyl \u003calexey.weyl@nokia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-28 09:41:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"template not operator support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifbeb468eb7eb79fbf950690b69d78095ed7051e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_22b0a28b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":29},"updated":"2017-02-28 15:27:44.000000000","message":"Please add a blueprint in launchpad and write here:\n\nImplements: blueprint xyz","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"}],"specs/ocata/template-not-operator-support.rst":[{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"1e4b74cc6698626edd9def11902883516c2ba88d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Today the templates language support the \"and\" and \"or\" operators, but this is not enough."},{"line_number":17,"context_line":"Many scenarios can\u0027t be described by those 2 operators, and thus we would like to add a support for the \"not\" operator."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Proposed change"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_0ea1e8a9","line":17,"updated":"2017-03-01 09:31:40.000000000","message":"replace \"2\" with \"two\" (this is true for all numbers \u003c\u003d20 within a sentence)","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Today the templates language support the \"and\" and \"or\" operators, but this is not enough."},{"line_number":17,"context_line":"Many scenarios can\u0027t be described by those 2 operators, and thus we would like to add a support for the \"not\" operator."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Proposed change"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Remark: positive vertex \u003d vertex that has an edge with \"is_deleted\"\u003dFalse property."},{"line_number":23,"context_line":"        negative vertex \u003d the opposite of positive vertex. Meaning that the vertex has only edges with \"is_deleted\"\u003dTrue property."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_6277fa02","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":15},"updated":"2017-02-28 15:27:44.000000000","message":"I think you should add an example of how the template will look like","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"1e4b74cc6698626edd9def11902883516c2ba88d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Today the templates language support the \"and\" and \"or\" operators, but this is not enough."},{"line_number":17,"context_line":"Many scenarios can\u0027t be described by those 2 operators, and thus we would like to add a support for the \"not\" operator."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Proposed change"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Remark: positive vertex \u003d vertex that has an edge with \"is_deleted\"\u003dFalse property."},{"line_number":23,"context_line":"        negative vertex \u003d the opposite of positive vertex. Meaning that the vertex has only edges with \"is_deleted\"\u003dTrue property."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_81c4c992","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":15},"in_reply_to":"ba2be162_6277fa02","updated":"2017-03-01 09:31:40.000000000","message":"I think this is a must as well. we need the examples to also cover all the valid/invalid usages here. What we support and what we don\u0027t has to be very clear.","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"1. In the template validation. Check that the \"Not\" operator can appear only in the following way:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   \"Not\" operator can appear before edges."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"2. Scenario Evaluator:"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_82b6ae3b","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":42},"updated":"2017-02-28 15:27:44.000000000","message":"Will we want to support not for vertices in the future?\nFor example: host_contains_instance and not host_with_property_x","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19233,"name":"Elisha Rosensweig","email":"elisha@chorus.ai","username":"elisha.rosensweig"},"change_message_id":"1e4b74cc6698626edd9def11902883516c2ba88d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"1. In the template validation. Check that the \"Not\" operator can appear only in the following way:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   \"Not\" operator can appear before edges."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"2. Scenario Evaluator:"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_612515aa","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":42},"in_reply_to":"ba2be162_82b6ae3b","updated":"2017-03-01 09:31:40.000000000","message":"I don\u0027t think so, since you will not be able (at least in the current approach) to determine how the \"host_with_property_x\" relates to the host_contains_instance relationship","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. Networkx Algorithm:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"   In the subgraph_matching method. If the match is not a \"negative condition\" then perform regular subgraph_matching."},{"line_number":38,"context_line":"   Otherwise, perform subgraph_matching is performer on a negative edges, and thus perform subgraph_matching on the positive vertices of the edge and unite the results."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"4. sub_graph_matching:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_e2576ac8","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":168},"updated":"2017-02-28 15:27:44.000000000","message":"This sentence is too complex, I didn\u0027t understand it... can you give an example, or a more detailed explanation?","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   In the subgraph_matching method. If the match is not a \"negative condition\" then perform regular subgraph_matching."},{"line_number":38,"context_line":"   Otherwise, perform subgraph_matching is performer on a negative edges, and thus perform subgraph_matching on the positive vertices of the edge and unite the results."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"4. sub_graph_matching:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"   a. In step 3, prefer to choose vertex that has is a positive vertex. Otherwise choose some vertex."},{"line_number":43,"context_line":"   b. In step 5, find the positive and the negative edges of the subgraph_vertex_to_map."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_02b9dee9","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":22},"updated":"2017-02-28 15:27:44.000000000","message":"I\u0027m not sure all the details below are needed. It\u0027s hard to understand if you don\u0027t look at the code, and will most likely become un-updated in the future","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"4. sub_graph_matching:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"   a. In step 3, prefer to choose vertex that has is a positive vertex. Otherwise choose some vertex."},{"line_number":43,"context_line":"   b. In step 5, find the positive and the negative edges of the subgraph_vertex_to_map."},{"line_number":44,"context_line":"      If that vertex has no candidates and it has only negative vertices thus it means that it"},{"line_number":45,"context_line":"      is ok that we can\u0027t find candidates for it, and thus it will be marked and pushed back to the queue."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_c230a6a1","line":42,"range":{"start_line":42,"start_character":46,"end_line":42,"end_character":52},"updated":"2017-02-28 15:27:44.000000000","message":"is","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"None"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Data model impact"},{"line_number":55,"context_line":"-----------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"REST API impact"},{"line_number":60,"context_line":"---------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"None"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Security impact"},{"line_number":65,"context_line":"---------------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"None"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Pipeline impact"},{"line_number":70,"context_line":"---------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Other end user impact"},{"line_number":75,"context_line":"---------------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Performance/Scalability Impacts"},{"line_number":80,"context_line":"-------------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_a28e5225","line":77,"range":{"start_line":54,"start_character":0,"end_line":77,"end_character":4},"updated":"2017-02-28 15:27:44.000000000","message":"You can remove the sections that are not interesting","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Performance/Scalability Impacts"},{"line_number":80,"context_line":"-------------------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_4292f658","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":4},"updated":"2017-02-28 15:27:44.000000000","message":"Is there a performance impact?","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":120,"context_line":"Testing"},{"line_number":121,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"None"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Documentation Impact"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_a2b572d1","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":4},"updated":"2017-02-28 15:27:44.000000000","message":"Unit tests and/or tempest tests?","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"33e18fc5eb6ad19a36481747cde12858e5805255","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Documentation Impact"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"None"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"References"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba2be162_a2dc9219","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":4},"updated":"2017-02-28 15:27:44.000000000","message":"You should update the template documentation","commit_id":"ce0f8eb8638f7919039e742f157dc1011396b8bf"}],"specs/pike/template-not-operator-support.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"49ad53da9b8483036f182f8ceaf07e6eb5714ba7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"-----------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Primary assignee:"},{"line_number":65,"context_line":"\talexey_weyl \u003calexey.weyl@nokia.com\u003e"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Work Items"},{"line_number":68,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_167284e4","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":1},"updated":"2017-06-07 07:23:51.000000000","message":"Delete the \"","commit_id":"cb9ec0e33e63690af32dc9662f329f183603c29f"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"49ad53da9b8483036f182f8ceaf07e6eb5714ba7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Testing"},{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"None"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Documentation Impact"},{"line_number":88,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_b6619814","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":4},"updated":"2017-06-07 07:23:51.000000000","message":"Please specify whether you need unit tests and/or tempest tests","commit_id":"cb9ec0e33e63690af32dc9662f329f183603c29f"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"49ad53da9b8483036f182f8ceaf07e6eb5714ba7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Documentation Impact"},{"line_number":88,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"None"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"References"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"df140735_5670fcdc","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":4},"updated":"2017-06-07 07:23:51.000000000","message":"Please put a link to the templates documentation: \nhttps://docs.openstack.org/developer/vitrage/vitrage-template-format.html","commit_id":"cb9ec0e33e63690af32dc9662f329f183603c29f"}]}
