)]}'
{"specs/pike/entity-equivalence.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"35e1f0d9d057b6202cba880e312060d0feb6f9ff","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Introducing entity equivalence will enhance the extensibility of Vitrage,"},{"line_number":23,"context_line":"making it suitable for more use cases, such as"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- `deduction`_ of monitored (but unreported) alarm"},{"line_number":26,"context_line":"- `aggregation`_ of identical alarm from multiple monitor"},{"line_number":27,"context_line":"- aggregation of resource information from multiple data sources."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_74ea2dd8","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":50},"updated":"2017-03-29 07:29:34.000000000","message":"I would rename this use case. The deduction part is easy and already supported. The problem is uniting the deduced alarm with the real alarm that arrives later on. \nHow about:\n- Early deduction\n- A real alarm that follows a deduced alarm\n- ?","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"55174097cc9bed32d284ddfac643d44e3ba1b830","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Introducing entity equivalence will enhance the extensibility of Vitrage,"},{"line_number":23,"context_line":"making it suitable for more use cases, such as"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- `deduction`_ of monitored (but unreported) alarm"},{"line_number":26,"context_line":"- `aggregation`_ of identical alarm from multiple monitor"},{"line_number":27,"context_line":"- aggregation of resource information from multiple data sources."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_c7582989","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":50},"in_reply_to":"ffe62b97_74ea2dd8","updated":"2017-03-29 08:05:46.000000000","message":"Done","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"35e1f0d9d057b6202cba880e312060d0feb6f9ff","unresolved":false,"context_lines":[{"line_number":23,"context_line":"making it suitable for more use cases, such as"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- `deduction`_ of monitored (but unreported) alarm"},{"line_number":26,"context_line":"- `aggregation`_ of identical alarm from multiple monitor"},{"line_number":27,"context_line":"- aggregation of resource information from multiple data sources."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_94c81174","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":29},"updated":"2017-03-29 07:29:34.000000000","message":"Equivalent. The alarms are not necessarily identical. For example, we could have \u0027cpu load\u0027 in one monitor and \u0027CPU load\u0027 in another.","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"35e1f0d9d057b6202cba880e312060d0feb6f9ff","unresolved":false,"context_lines":[{"line_number":23,"context_line":"making it suitable for more use cases, such as"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- `deduction`_ of monitored (but unreported) alarm"},{"line_number":26,"context_line":"- `aggregation`_ of identical alarm from multiple monitor"},{"line_number":27,"context_line":"- aggregation of resource information from multiple data sources."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_f4b75df4","line":26,"range":{"start_line":26,"start_character":50,"end_line":26,"end_character":57},"updated":"2017-03-29 07:29:34.000000000","message":"monitors","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"55174097cc9bed32d284ddfac643d44e3ba1b830","unresolved":false,"context_lines":[{"line_number":23,"context_line":"making it suitable for more use cases, such as"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- `deduction`_ of monitored (but unreported) alarm"},{"line_number":26,"context_line":"- `aggregation`_ of identical alarm from multiple monitor"},{"line_number":27,"context_line":"- aggregation of resource information from multiple data sources."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_a753e56a","line":26,"range":{"start_line":26,"start_character":20,"end_line":26,"end_character":29},"in_reply_to":"ffe62b97_94c81174","updated":"2017-03-29 08:05:46.000000000","message":"Done","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"55174097cc9bed32d284ddfac643d44e3ba1b830","unresolved":false,"context_lines":[{"line_number":23,"context_line":"making it suitable for more use cases, such as"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- `deduction`_ of monitored (but unreported) alarm"},{"line_number":26,"context_line":"- `aggregation`_ of identical alarm from multiple monitor"},{"line_number":27,"context_line":"- aggregation of resource information from multiple data sources."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_27cd9530","line":26,"range":{"start_line":26,"start_character":50,"end_line":26,"end_character":57},"in_reply_to":"ffe62b97_f4b75df4","updated":"2017-03-29 08:05:46.000000000","message":"Done","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"35e1f0d9d057b6202cba880e312060d0feb6f9ff","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"- equivalence definition in Vitrage templates"},{"line_number":90,"context_line":"- handling alarm equivalence in scenario evaluator"},{"line_number":91,"context_line":"- back-compatibility for UI which does not handle alarm equivalence"},{"line_number":92,"context_line":"- validate alarm equivalence in alarm deduction design"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The following items are not in scope"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_14aac183","line":91,"range":{"start_line":91,"start_character":2,"end_line":91,"end_character":67},"updated":"2017-03-29 07:29:34.000000000","message":"What do you mean? Are you trying to support a use case of old vitrage-dashboard with new vitrage core?","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"55174097cc9bed32d284ddfac643d44e3ba1b830","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"- equivalence definition in Vitrage templates"},{"line_number":90,"context_line":"- handling alarm equivalence in scenario evaluator"},{"line_number":91,"context_line":"- back-compatibility for UI which does not handle alarm equivalence"},{"line_number":92,"context_line":"- validate alarm equivalence in alarm deduction design"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"The following items are not in scope"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_e7d20dd1","line":91,"range":{"start_line":91,"start_character":2,"end_line":91,"end_character":67},"in_reply_to":"ffe62b97_14aac183","updated":"2017-03-29 08:05:46.000000000","message":"Done","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"35e1f0d9d057b6202cba880e312060d0feb6f9ff","unresolved":false,"context_lines":[{"line_number":94,"context_line":"The following items are not in scope"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"- support alarm equivalence in UI"},{"line_number":97,"context_line":"- implement alarm deduction based on equivalence"},{"line_number":98,"context_line":"- resource equivalence"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_b492f555","line":97,"range":{"start_line":97,"start_character":2,"end_line":97,"end_character":48},"updated":"2017-03-29 07:29:34.000000000","message":"What does it mean?","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"55174097cc9bed32d284ddfac643d44e3ba1b830","unresolved":false,"context_lines":[{"line_number":94,"context_line":"The following items are not in scope"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"- support alarm equivalence in UI"},{"line_number":97,"context_line":"- implement alarm deduction based on equivalence"},{"line_number":98,"context_line":"- resource equivalence"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_a7d885ee","line":97,"range":{"start_line":97,"start_character":2,"end_line":97,"end_character":48},"in_reply_to":"ffe62b97_b492f555","updated":"2017-03-29 08:05:46.000000000","message":"Done","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"35e1f0d9d057b6202cba880e312060d0feb6f9ff","unresolved":false,"context_lines":[{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. _ZTE use case of alarm deduction: https://goo.gl/FfDLi8"},{"line_number":119,"context_line":".. _deduction: https://review.openstack.org/#/c/423000/"},{"line_number":120,"context_line":".. _aggregation: https://blueprints.launchpad.net/vitrage/+spec/alarm-aggregation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_d4ce9961","line":119,"range":{"start_line":119,"start_character":15,"end_line":119,"end_character":55},"updated":"2017-03-29 07:29:34.000000000","message":"Does the current blueprint replace the _deduction blueprint? or is there additional effort left to implement the _deduction blueprint?","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"55174097cc9bed32d284ddfac643d44e3ba1b830","unresolved":false,"context_lines":[{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. _ZTE use case of alarm deduction: https://goo.gl/FfDLi8"},{"line_number":119,"context_line":".. _deduction: https://review.openstack.org/#/c/423000/"},{"line_number":120,"context_line":".. _aggregation: https://blueprints.launchpad.net/vitrage/+spec/alarm-aggregation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe62b97_07b73188","line":119,"range":{"start_line":119,"start_character":15,"end_line":119,"end_character":55},"in_reply_to":"ffe62b97_d4ce9961","updated":"2017-03-29 08:05:46.000000000","message":"Yes, there will be additional effort for alarm-deduction enhancement, which is related to the causal tree model we discussed in the design session. There are actually something not mentioned in it yet, such as automatic upstream/downstream deduction and suspicious/reported/confirmed status.","commit_id":"f6ee534f24b7f727f5b88a93d8c5e2af97dd0d5a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"00d32bc32c1f5b105d96acde7563da8c4aced105","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"- equivalence definition in Vitrage templates"},{"line_number":91,"context_line":"- handling alarm equivalence in scenario evaluator"},{"line_number":92,"context_line":"- configure option for enable/disable equivalent feature"},{"line_number":93,"context_line":"- validate alarm equivalence in alarm deduction design"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"The following items are not in scope"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ffe62b97_e058b388","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":56},"updated":"2017-03-29 09:11:52.000000000","message":"Why is it needed? as far as I understand, if no equivalent alarms are defined, then this feature will not be used.\nIs there a use case where you would like to ignore equivalent alarms although they are defined?","commit_id":"4d8349de3832077227ea9375edfc329790d5318a"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"4f6f569189fc7f765145525247f04922f691402c","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"- equivalence definition in Vitrage templates"},{"line_number":91,"context_line":"- handling alarm equivalence in scenario evaluator"},{"line_number":92,"context_line":"- configure option for enable/disable equivalent feature"},{"line_number":93,"context_line":"- validate alarm equivalence in alarm deduction design"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"The following items are not in scope"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ffe62b97_5b3ab498","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":56},"in_reply_to":"ffe62b97_e058b388","updated":"2017-03-29 09:23:16.000000000","message":"Done","commit_id":"4d8349de3832077227ea9375edfc329790d5318a"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"08fbe3743ff75fa90a2e77feca9c46ac5dbca9d9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add a new section ``equivalences`` under ``definitions`` in template. Entities"},{"line_number":33,"context_line":"that are equivalent to each other are grouped in arrays of their ``template_id``"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffe62b97_a1362a50","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":68},"updated":"2017-03-29 11:12:49.000000000","message":"It\u0027s a question whether we want to define the equivalences section inside a template, or globally. There are pros and cons to each option.\n\nI think that once you add an \"equivalent\" edge between two alarms, then it *logically* means that they are equivalent in *all* other templates as well. Even if they are not specified this way in the other templates. This is why I think we should have a separate, dedicated, file(s) for defining the equivalence, and these definitions should be applied to all templates.\n\n(BTW, the \"cons\" for my suggestion is that the template will be less clear without the equivalence information embedded in it).","commit_id":"9da2c12d49467a8d2cebe38f37fc3a00f1dc3eaf"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9a108a478c6e83468bbab882aa11faa8faab384f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add a new section ``equivalences`` under ``definitions`` in template. Entities"},{"line_number":33,"context_line":"that are equivalent to each other are grouped in arrays of their ``template_id``"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffe62b97_03581a85","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":68},"in_reply_to":"ffe62b97_a1362a50","updated":"2017-03-30 01:03:13.000000000","message":"Done","commit_id":"9da2c12d49467a8d2cebe38f37fc3a00f1dc3eaf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"08fbe3743ff75fa90a2e77feca9c46ac5dbca9d9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    relationships:"},{"line_number":58,"context_line":"     ..."},{"line_number":59,"context_line":"    equivalences:"},{"line_number":60,"context_line":"     - [nagios_host_problem, zabbix_host_problem]"},{"line_number":61,"context_line":"   scenarios:"},{"line_number":62,"context_line":"     ..."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffe62b97_61e4a20d","line":60,"range":{"start_line":60,"start_character":7,"end_line":60,"end_character":49},"updated":"2017-03-29 11:12:49.000000000","message":"I assume you want to also add here vitrage_host_problem?","commit_id":"9da2c12d49467a8d2cebe38f37fc3a00f1dc3eaf"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9a108a478c6e83468bbab882aa11faa8faab384f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    relationships:"},{"line_number":58,"context_line":"     ..."},{"line_number":59,"context_line":"    equivalences:"},{"line_number":60,"context_line":"     - [nagios_host_problem, zabbix_host_problem]"},{"line_number":61,"context_line":"   scenarios:"},{"line_number":62,"context_line":"     ..."},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffe62b97_c34d92c4","line":60,"range":{"start_line":60,"start_character":7,"end_line":60,"end_character":49},"in_reply_to":"ffe62b97_61e4a20d","updated":"2017-03-30 01:03:13.000000000","message":"Done","commit_id":"9da2c12d49467a8d2cebe38f37fc3a00f1dc3eaf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"08fbe3743ff75fa90a2e77feca9c46ac5dbca9d9","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. TODO:: (yujunz) include example graph"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"The UI won’t look nice, we will need to implement alarm aggregation. But it is"},{"line_number":133,"context_line":"not urgent if the ``vitrage-dashboard`` is not used or ``equivalence`` section"},{"line_number":134,"context_line":"is left empty."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Implementation"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffe62b97_6153826c","line":134,"range":{"start_line":132,"start_character":69,"end_line":134,"end_character":14},"updated":"2017-03-29 11:12:49.000000000","message":"What you said is ok. But I would consider changing it \"we will handle it in the future/ another blueprint\". Maybe \"This will only be relevant to cases where both equivalence and vitrage-dashboard are used\" .\nPeople that will read it might not understand why we think it is not urgent...","commit_id":"9da2c12d49467a8d2cebe38f37fc3a00f1dc3eaf"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9a108a478c6e83468bbab882aa11faa8faab384f","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. TODO:: (yujunz) include example graph"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"The UI won’t look nice, we will need to implement alarm aggregation. But it is"},{"line_number":133,"context_line":"not urgent if the ``vitrage-dashboard`` is not used or ``equivalence`` section"},{"line_number":134,"context_line":"is left empty."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Implementation"},{"line_number":137,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffe62b97_83c9ca26","line":134,"range":{"start_line":132,"start_character":69,"end_line":134,"end_character":14},"in_reply_to":"ffe62b97_6153826c","updated":"2017-03-30 01:03:13.000000000","message":"Done","commit_id":"9da2c12d49467a8d2cebe38f37fc3a00f1dc3eaf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"08fbe3743ff75fa90a2e77feca9c46ac5dbca9d9","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"- documentation on how to define equivalence and when to use it"},{"line_number":177,"context_line":"- limitation on resource equivalence"},{"line_number":178,"context_line":"- know issues on UI in release note"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"References"},{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffe62b97_81dd66e1","line":178,"range":{"start_line":178,"start_character":2,"end_line":178,"end_character":6},"updated":"2017-03-29 11:12:49.000000000","message":"known","commit_id":"9da2c12d49467a8d2cebe38f37fc3a00f1dc3eaf"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"9a108a478c6e83468bbab882aa11faa8faab384f","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"- documentation on how to define equivalence and when to use it"},{"line_number":177,"context_line":"- limitation on resource equivalence"},{"line_number":178,"context_line":"- know issues on UI in release note"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"References"},{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffe62b97_e3d776be","line":178,"range":{"start_line":178,"start_character":2,"end_line":178,"end_character":6},"in_reply_to":"ffe62b97_81dd66e1","updated":"2017-03-30 01:03:13.000000000","message":"Done","commit_id":"9da2c12d49467a8d2cebe38f37fc3a00f1dc3eaf"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"ed3b309e7979a3f54eaf51b0d6f4bf3c854ed6c6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"``equivalent`` edges will be created between every two equivalent alarms. Again,"},{"line_number":79,"context_line":"without the need for the user to write it specifically."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"User may define the equivalences section inside a template, or globally. In"},{"line_number":82,"context_line":"either way, once an ``equivalent`` edge is added between two alarms, then it"},{"line_number":83,"context_line":"*logically* means that they are equivalent in *all* other templates as well."},{"line_number":84,"context_line":"Even if they are not specified this way in the other templates."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"If the project includes many templates, it is recommended to create a separate,"},{"line_number":87,"context_line":"dedicated, file(s) for defining the equivalence"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ffe62b97_e5cd3366","line":84,"range":{"start_line":81,"start_character":0,"end_line":84,"end_character":63},"updated":"2017-03-30 07:35:19.000000000","message":"I think that allowing both options is even more confusing... \nAnd what if the user defines one equivalence in one file (e.g. [A,B,C] and another equivalence in anther file (e.g. [A,X,Y])? the result might not be quite strange.","commit_id":"8a70450b5699faeefa0c91167542d11223432e32"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"eb9978f7c2f885647cd51226c992998cf237df1a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"``equivalent`` edges will be created between every two equivalent alarms. Again,"},{"line_number":79,"context_line":"without the need for the user to write it specifically."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"User may define the equivalences section inside a template, or globally. In"},{"line_number":82,"context_line":"either way, once an ``equivalent`` edge is added between two alarms, then it"},{"line_number":83,"context_line":"*logically* means that they are equivalent in *all* other templates as well."},{"line_number":84,"context_line":"Even if they are not specified this way in the other templates."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"If the project includes many templates, it is recommended to create a separate,"},{"line_number":87,"context_line":"dedicated, file(s) for defining the equivalence"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ffe62b97_65f36075","line":84,"range":{"start_line":81,"start_character":0,"end_line":84,"end_character":63},"in_reply_to":"ffe62b97_e5cd3366","updated":"2017-03-30 08:58:10.000000000","message":"Sounds reasonable. Moved to alternatives.","commit_id":"8a70450b5699faeefa0c91167542d11223432e32"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"ed3b309e7979a3f54eaf51b0d6f4bf3c854ed6c6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    equivalences:"},{"line_number":95,"context_line":"     - [nagios_host_problem, zabbix_host_problem, vitrage_host_problem]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. TODO:: check if ``template_id`` is global in current implementation, if not,"},{"line_number":98,"context_line":"it needs to be extended to allow global equivalence definition."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Alternatives"},{"line_number":101,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ffe62b97_450bbf8c","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":63},"updated":"2017-03-30 07:35:19.000000000","message":"I don\u0027t think that template_id should be global. Instead, I think that we should define the alarms in the same file where the equivalence is defined. \nAlternatively, we can implement an \u0027import\u0027 feature for templates (we discussed it for other use cases as well, because we realized that sometimes we define the same alarms in several templates, or end up with one big template file).","commit_id":"8a70450b5699faeefa0c91167542d11223432e32"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"eb9978f7c2f885647cd51226c992998cf237df1a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    equivalences:"},{"line_number":95,"context_line":"     - [nagios_host_problem, zabbix_host_problem, vitrage_host_problem]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. TODO:: check if ``template_id`` is global in current implementation, if not,"},{"line_number":98,"context_line":"it needs to be extended to allow global equivalence definition."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Alternatives"},{"line_number":101,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ffe62b97_e5d530b9","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":63},"in_reply_to":"ffe62b97_450bbf8c","updated":"2017-03-30 08:58:10.000000000","message":"Understood now.","commit_id":"8a70450b5699faeefa0c91167542d11223432e32"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"858d5982e34684c997dd1b2765cc1c0bd0560615","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add a new Add a new file (or a set of files) that define equivalence between"},{"line_number":33,"context_line":"entities"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ffe62b97_6598001b","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":19},"updated":"2017-03-30 10:45:13.000000000","message":"Only once...","commit_id":"a4d0b3ea438e429109c8d35f2b9b89d6b1523d44"}]}