)]}'
{"specs/pike/alarm-counts-api.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"5362145bff428406ad981702d36727d778320933","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Vitrage Alarm Counts API"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Extend the Vitrage REST API to support a GET of the Active Alarm Counts, for "},{"line_number":12,"context_line":"each alarm severity level, in Vitrage."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_19c50e3d","line":11,"range":{"start_line":11,"start_character":76,"end_line":11,"end_character":77},"updated":"2017-05-18 05:56:33.000000000","message":"Something is wrong with the formatting, I\u0027m not sure what. Could it be an extra space? try to check if you can eliminate this.","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"d550335b3f32fcd3dbc62b62007c2fe5d4c3d00d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Vitrage Alarm Counts API"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Extend the Vitrage REST API to support a GET of the Active Alarm Counts, for "},{"line_number":12,"context_line":"each alarm severity level, in Vitrage."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_ac13700d","line":11,"range":{"start_line":11,"start_character":76,"end_line":11,"end_character":77},"in_reply_to":"ff0f0b1f_19c50e3d","updated":"2017-05-18 14:05:37.000000000","message":"Yeah it is the space at the end of line ... have that in a couple of places below as well.\n\nTried to just edit it with inline editor but don\u0027t think it worked.\nI will remove these in follow up commit.","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"5362145bff428406ad981702d36727d778320933","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"Modify Vitrage Entity Graph to maintain Active Alarm Counts for each alarm "},{"line_number":24,"context_line":"severity level."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Add the following REST API to Vitrage API::"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_b91862d3","line":24,"range":{"start_line":23,"start_character":31,"end_line":24,"end_character":15},"updated":"2017-05-18 05:56:33.000000000","message":"I rather calculate the alarm count when requested, instead of keeping a counter. My reasons are:\n- keeping a counter, in addition to the graph, might be buggy (multi threading issues etc.)\n- calculating the counter means traversing once all of the vertices in the graph, get all alarms, and count. It shouldn\u0027t be too expensive, it\u0027s just like \u0027get alarms\u0027 api\n- since the result of this api is used for ui query (and not for notification or corrective actions for example), I don\u0027t think that the performance is that critical","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"d550335b3f32fcd3dbc62b62007c2fe5d4c3d00d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"Modify Vitrage Entity Graph to maintain Active Alarm Counts for each alarm "},{"line_number":24,"context_line":"severity level."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Add the following REST API to Vitrage API::"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_cc27c464","line":24,"range":{"start_line":23,"start_character":31,"end_line":24,"end_character":15},"in_reply_to":"ff0f0b1f_b91862d3","updated":"2017-05-18 14:05:37.000000000","message":"I agree.\nI will change this in follow up commit.","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"5362145bff428406ad981702d36727d778320933","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Add the following REST API to Vitrage API::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"\tGET /v1/alarm_counts/"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"\tHeaders"},{"line_number":31,"context_line":"\t\tX-Auth-Token (string, required) - Keystone auth token"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_7912cab3","line":28,"range":{"start_line":28,"start_character":5,"end_line":28,"end_character":22},"updated":"2017-05-18 05:56:33.000000000","message":"Maybe use instead:\n/v1/alarm/count","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"d550335b3f32fcd3dbc62b62007c2fe5d4c3d00d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Add the following REST API to Vitrage API::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"\tGET /v1/alarm_counts/"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"\tHeaders"},{"line_number":31,"context_line":"\t\tX-Auth-Token (string, required) - Keystone auth token"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_4c1bb41a","line":28,"range":{"start_line":28,"start_character":5,"end_line":28,"end_character":22},"in_reply_to":"ff0f0b1f_7912cab3","updated":"2017-05-18 14:05:37.000000000","message":"Sounds good.","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"b4a9ac2b40b13add300ec7803bbd97f2d7cb611c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"\t\t  \"warning_alarm_count\": 3"},{"line_number":61,"context_line":"\t\t}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"NOTE: was not planning on adding CLI for alarm counts."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_940d6392","line":63,"range":{"start_line":63,"start_character":25,"end_line":63,"end_character":26},"updated":"2017-05-18 06:30:58.000000000","message":"cli should also support this client cli and client are implemented python-vitrageclient","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"d550335b3f32fcd3dbc62b62007c2fe5d4c3d00d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"\t\t  \"warning_alarm_count\": 3"},{"line_number":61,"context_line":"\t\t}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"NOTE: was not planning on adding CLI for alarm counts."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_0cddbc13","line":63,"range":{"start_line":63,"start_character":25,"end_line":63,"end_character":26},"in_reply_to":"ff0f0b1f_940d6392","updated":"2017-05-18 14:05:37.000000000","message":"Ok ... i will indicate that i will add a CLI command for this.\ne.g.\n% vitrage alarm count","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"5362145bff428406ad981702d36727d778320933","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":"None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"REST API impact"},{"line_number":77,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_d961d63b","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":4},"updated":"2017-05-18 05:56:33.000000000","message":"If you want to keep the counter, then there is a data model impact. In fact, I\u0027m not sure where we should keep it (doesn\u0027t fit in the graph; maybe just hold it in memory?)","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"d550335b3f32fcd3dbc62b62007c2fe5d4c3d00d","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Data model impact"},{"line_number":73,"context_line":"-----------------"},{"line_number":74,"context_line":"None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"REST API impact"},{"line_number":77,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_6ccd585c","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":4},"in_reply_to":"ff0f0b1f_d961d63b","updated":"2017-05-18 14:05:37.000000000","message":"No ... i\u0027m good with changing to not have counter and just count when the REST API is processed.","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"5362145bff428406ad981702d36727d778320933","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":134,"context_line":"Update to Vitrage API Documentation"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_d9bd5669","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":35},"updated":"2017-05-18 05:56:33.000000000","message":"You can specify that the new API should be added under https://github.com/openstack/vitrage/blob/master/doc/source/vitrage-api.rst","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"d550335b3f32fcd3dbc62b62007c2fe5d4c3d00d","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Documentation Impact"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":134,"context_line":"Update to Vitrage API Documentation"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_ac04907c","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":35},"in_reply_to":"ff0f0b1f_d9bd5669","updated":"2017-05-18 14:05:37.000000000","message":"Will add this in follow up commit.","commit_id":"4cd85c4cb48932df793667c30af0d68a0c898da2"}]}