)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"cb0712273ab4e5f3948ebf92411ac11b9cb0f71d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Offek \u003cdan.offek@nokia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-20 08:32:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rest API Registration and Filtering"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If9d807a627dbd26ae824d0e5cc518df2c56cd69d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f231b9d_53a2504d","line":7,"updated":"2017-06-20 09:03:15.000000000","message":"Please add:\n\nImplements: blueprint configurable-notifications","commit_id":"7c3eb012f33bf5f79fb00d4480b8980a95f0f437"}],"specs/pike/httppost-registration.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"httppost Registrations"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"launchpad blueprint:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_27b32beb","line":8,"range":{"start_line":8,"start_character":21,"end_line":8,"end_character":22},"updated":"2017-06-19 14:35:31.000000000","message":"without the s","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Vitrage will get the alarm / entity events from the message bus and the"},{"line_number":35,"context_line":"httppost notifier will send notifications on any changes / alarms."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The notifications will be sent to all destinations specified in the DB."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_e73bf334","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":63},"updated":"2017-06-19 14:35:31.000000000","message":"I think that you should replace this with:\nVitrage evaluator may perform raise alarm or set state actions, and the httpost...","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  - name : \"%kinori%\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Each registration will be saved in a different \"line\" in the DB."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"There can be multiple registrations with the same address and different regex(es)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_677ec3e4","line":57,"range":{"start_line":57,"start_character":47,"end_line":57,"end_character":53},"updated":"2017-06-19 14:35:31.000000000","message":"row?","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Data model impact"},{"line_number":74,"context_line":"-----------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"REST API impact"},{"line_number":79,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_475aa782","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":4},"updated":"2017-06-19 14:35:31.000000000","message":"New table in the DB","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"REST API impact"},{"line_number":79,"context_line":"---------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Versioning impact"},{"line_number":84,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_27d20bd2","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":4},"updated":"2017-06-19 14:35:31.000000000","message":"You can put a link to the API spec","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- Create filtering in httppost notifications"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"- Create UI"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- Create unit test for registration"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_c7a91724","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":11},"updated":"2017-06-19 14:35:31.000000000","message":"I think that the UI shouldn\u0027t be part of this blueprint. You can complete this blueprint without UI, and add it later on","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- Create unit test for registration"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  - test registration works"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  - test filter works properly by creating alarms"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_276e8bff","line":144,"range":{"start_line":144,"start_character":4,"end_line":144,"end_character":21},"updated":"2017-06-19 14:35:31.000000000","message":"test that the registration works","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  - test registration success: url matches, properties match, filter matches"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  - test additional same and different registration"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  - test delete registration success"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_4744e773","line":152,"range":{"start_line":152,"start_character":9,"end_line":152,"end_character":19},"updated":"2017-06-19 14:35:31.000000000","message":"additional,","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  - test delete registration success"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  - UI tests"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Dependencies"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_a7529b33","line":156,"range":{"start_line":156,"start_character":2,"end_line":156,"end_character":12},"updated":"2017-06-19 14:35:31.000000000","message":"Not here. And I don\u0027t think we have automatic UI tests today...","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"167d0e02b8cc037f936012510418e1b7bf695eb0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"This blueprint requires both unit tests and tempest tests."},{"line_number":167,"context_line":"Test Add, Remove registrations, and test that they have the same address,"},{"line_number":168,"context_line":"properties, and filters,"},{"line_number":169,"context_line":"Test UI"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Documentation Impact"},{"line_number":172,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_6736c305","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":7},"updated":"2017-06-19 14:35:31.000000000","message":"Not here","commit_id":"ace73674ea041deff2f3e3ad1ee715262b93c328"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"cace8ecf0bd5a7aa2de825da9189d7ae2bd17215","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Developer impact"},{"line_number":112,"context_line":"----------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Horizon impact"},{"line_number":117,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_8d9d670c","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":4},"updated":"2017-06-20 08:16:27.000000000","message":"We need to write infrastructure for working with databases\nsqlalchemy can be used for that\n\nmaybe we need a blueprint for database usage that will include the use sqlalchemy some database migration tools and maybe also some testing framework","commit_id":"c3a85755de14cbedb52a7d267d86b805ef726978"}]}
