)]}'
{"specs/pike/snmp-parsing-service.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c5f38ad96dd977a421ba914a3ad8532b615f50ce","unresolved":false,"context_lines":[{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Support External Actions in Vitrage Templates"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"launchpad blueprint:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_3f6ad3b2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":45},"updated":"2017-07-25 06:17:20.000000000","message":"Wrong title...","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c5f38ad96dd977a421ba914a3ad8532b615f50ce","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/vitrage/+spec/snmp-support"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint describes the implementation of SNMP parsing service for transforming SNMP alarm"},{"line_number":14,"context_line":"messages to alarm details and distributing them to corresponding DATASOURCE."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_df5e2711","line":14,"range":{"start_line":14,"start_character":65,"end_line":14,"end_character":75},"updated":"2017-07-25 06:17:20.000000000","message":"why in capital letters?","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c5f38ad96dd977a421ba914a3ad8532b615f50ce","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The following use cases should be supported:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Vitrage datasources module provides the ability to handle alarms from part of monitored systems,"},{"line_number":22,"context_line":"but not systems that report alarms by SNMP communication way currently. A SNMP service module is"},{"line_number":23,"context_line":"presented here, which provides service to parse alarms reported from SNMP managed system and"},{"line_number":24,"context_line":"distributes them to the specified data source for further processing."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_9f9e5fb6","line":24,"range":{"start_line":22,"start_character":72,"end_line":24,"end_character":69},"updated":"2017-07-25 06:17:20.000000000","message":"This belongs in the \"proposed change\" section","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c5f38ad96dd977a421ba914a3ad8532b615f50ce","unresolved":false,"context_lines":[{"line_number":56,"context_line":"REST API impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Versioning impact"},{"line_number":62,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_dfe1872c","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":4},"updated":"2017-07-25 06:17:20.000000000","message":"If I understand correctly, you wanted to turn this feature on using an API call?","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"d1ec7ee76b09f2f8e5ca3149cff1e93e2e48f016","unresolved":false,"context_lines":[{"line_number":56,"context_line":"REST API impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"None"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Versioning impact"},{"line_number":62,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_543c59c7","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":4},"in_reply_to":"ff346bd7_dfe1872c","updated":"2017-07-25 07:32:16.000000000","message":"This service doesn\u0027t use API call.After it parses origin alarm message, the service sends message to rabbitMq, then listener service distributes it to corresponding datasource.","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c5f38ad96dd977a421ba914a3ad8532b615f50ce","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Assignee(s)"},{"line_number":91,"context_line":"-----------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Primary assignee:"},{"line_number":94,"context_line":"  ifat-afek"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Work Items"},{"line_number":97,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_df686788","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":11},"updated":"2017-07-25 06:17:20.000000000","message":"Not me :-)","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c5f38ad96dd977a421ba914a3ad8532b615f50ce","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Dependencies"},{"line_number":103,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Dependent lib: pysnmp"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_7f0f3be1","line":105,"range":{"start_line":105,"start_character":15,"end_line":105,"end_character":21},"updated":"2017-07-25 06:17:20.000000000","message":"I think we are already using it for the SNMP notifier","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c5f38ad96dd977a421ba914a3ad8532b615f50ce","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The implementation will be covered by unit tests and tempest tests."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Documentation Impact"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_1ff4afce","line":110,"range":{"start_line":110,"start_character":53,"end_line":110,"end_character":66},"updated":"2017-07-25 06:17:20.000000000","message":"If you find a way to cover it with tempest tests, it would be great. Writing a tempest test for datasources that involve external systems is not trivial, since you need to have it working in the jenkins job","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"d1ec7ee76b09f2f8e5ca3149cff1e93e2e48f016","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The implementation will be covered by unit tests and tempest tests."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Documentation Impact"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_d42ba9e8","line":110,"range":{"start_line":110,"start_character":53,"end_line":110,"end_character":66},"in_reply_to":"ff346bd7_1ff4afce","updated":"2017-07-25 07:32:16.000000000","message":"I have make a mistake here. We only have unit tests for now. Tempest test means having interation with external alarms? We just construct origin alarm code stream and test whether message is correct after snmp parsing, since there are no external alarms in CI.","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"3264133667b4706d278a2072faa4618172d3549f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The implementation will be covered by unit tests and tempest tests."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Documentation Impact"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_bbbfedf9","line":110,"range":{"start_line":110,"start_character":53,"end_line":110,"end_character":66},"in_reply_to":"ff346bd7_d42ba9e8","updated":"2017-07-25 11:17:58.000000000","message":"Unit tests check a specific function with mock data. \nTempest tests are supposed to work on a real devstack (that is created by Jenkins when the change is pushed) and can include other components, like Nova/Neutron/Heat resources etc.\nI said that for SNMP writing tempest tests might be problematic, since the standard Vitrage devstack does not contain an SNMP service.","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c5f38ad96dd977a421ba914a3ad8532b615f50ce","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Documentation Impact"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The new action should be documented"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"References"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff346bd7_dffd07b2","line":115,"range":{"start_line":115,"start_character":8,"end_line":115,"end_character":14},"updated":"2017-07-25 06:17:20.000000000","message":"SNMP configuration","commit_id":"1577585b1514049f260bd3c6b059f58c1ca13e61"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a385d0505b2be79dfbb0a362fab7e831af05a221","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Snmp Parsing Service"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff346bd7_3bf3fd0c","line":6,"range":{"start_line":6,"start_character":20,"end_line":6,"end_character":45},"updated":"2017-07-25 11:17:34.000000000","message":"Please remove the extra \u003d","commit_id":"80e383029355e46bcc34a4e1b4b4a8268f0c49ce"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a385d0505b2be79dfbb0a362fab7e831af05a221","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Snmp Parsing Service"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"launchpad blueprint:"},{"line_number":11,"context_line":"https://blueprints.launchpad.net/vitrage/+spec/snmp-support"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff346bd7_5b9ec1b8","line":8,"range":{"start_line":8,"start_character":20,"end_line":8,"end_character":45},"updated":"2017-07-25 11:17:34.000000000","message":"Please remove the extra \u003d","commit_id":"80e383029355e46bcc34a4e1b4b4a8268f0c49ce"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"a385d0505b2be79dfbb0a362fab7e831af05a221","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Assignee(s)"},{"line_number":91,"context_line":"-----------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Work Items"},{"line_number":96,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff346bd7_9b8c2980","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":4},"updated":"2017-07-25 11:17:34.000000000","message":"You better write someone, or at least write TBD","commit_id":"80e383029355e46bcc34a4e1b4b4a8268f0c49ce"},{"author":{"_account_id":24635,"name":"Anna Reznikov","email":"annarez82@gmail.com","username":"annarez"},"change_message_id":"dc9eb56ee16f7bed2c19e6d209083a69fbb1921e","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Snmp Parsing Service"},{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff346bd7_7d6f1992","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":19},"updated":"2017-07-26 06:36:19.000000000","message":"one more \u0027\u003d\u0027 is neaded","commit_id":"79b1c12494b28d4f85e1246bf541b753ea064583"}],"specs/queens/approved/snmp-parsing-service.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"e42ccda7262cef16fbb7b934295d4c6e1310f8fb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"information by decoded alarm details."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The configuration for snmp service:"},{"line_number":39,"context_line":"[snmp_service]"},{"line_number":40,"context_line":"port \u003dxxx"},{"line_number":41,"context_line":"default_coding \u003d iso-8859-1"},{"line_number":42,"context_line":"event_type_mapping \u003d 1.3.6.1.4.1.3902.4101.1.3.1.1:nova.host.alarm"},{"line_number":43,"context_line":"Event_type_mapping defines the map of datasource name and OID, here takes nova.host.alarm as an"},{"line_number":44,"context_line":"example."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"df3967d1_59ee0589","line":44,"range":{"start_line":39,"start_character":0,"end_line":44,"end_character":8},"updated":"2017-07-30 09:45:38.000000000","message":"A few questions regarding the configuration:\na. Will it reside in vitrage.conf file?\nb. Will there be one section for all SNMP sources (IaaS, PaaS, etc.)? I think that having separate sections would be much better\nc. Will there be one line per mapping? so there will be many event_type_mapping lines?","commit_id":"bb016df97379ecb60dde095626a68af21f6ff2ab"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"41f72a0f44d6aa4ea66b9b7333005e13e4e33760","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The configuration for snmp service:"},{"line_number":39,"context_line":"[snmp_parsing]"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# From vitrage"},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# snmp listening port (integer value)"},{"line_number":45,"context_line":"#snmp_listening_port \u003d xxx"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_b79b1516","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":1},"updated":"2017-08-31 08:47:11.000000000","message":"Why add this comment? the [snmp_parsing] is part of the vitrage.conf, right?","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c799483024d1fded5efbb32dac13c601204d1dcd","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The configuration for snmp service:"},{"line_number":39,"context_line":"[snmp_parsing]"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# From vitrage"},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# snmp listening port (integer value)"},{"line_number":45,"context_line":"#snmp_listening_port \u003d xxx"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_7efeef38","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":1},"in_reply_to":"7f287b81_9b888dc6","updated":"2017-09-06 09:32:16.000000000","message":"I don\u0027t see a reason to add these lines","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"51e6b3c78f50f417b5393ed17788bf3804ccf60e","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The configuration for snmp service:"},{"line_number":39,"context_line":"[snmp_parsing]"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# From vitrage"},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# snmp listening port (integer value)"},{"line_number":45,"context_line":"#snmp_listening_port \u003d xxx"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_9b888dc6","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":1},"in_reply_to":"7f287b81_b79b1516","updated":"2017-09-06 09:21:26.000000000","message":"Yes, it is part of vitrage.conf. I add it after other rsts, should it not be here?","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"41f72a0f44d6aa4ea66b9b7333005e13e4e33760","unresolved":false,"context_lines":[{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# snmp listening port (integer value)"},{"line_number":45,"context_line":"#snmp_listening_port \u003d xxx"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# default decode protocol(string value)"},{"line_number":48,"context_line":"#default_coding \u003d xxxx"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_377fe866","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":1},"updated":"2017-08-31 08:47:11.000000000","message":"Please remove the # from the SNMP settings. If I understand correctly, someone who wants to enable the SNMP service will need to have all of these settings (uncommented)","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"41f72a0f44d6aa4ea66b9b7333005e13e4e33760","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#snmp_listening_port \u003d xxx"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# default decode protocol(string value)"},{"line_number":48,"context_line":"#default_coding \u003d xxxx"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# traps oid mapping yaml file path(string value)"},{"line_number":51,"context_line":"#oid_mapping \u003d /etc/vitrage/snmp_parsing_conf.yaml"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_77a0d0f4","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":22},"updated":"2017-08-31 08:47:11.000000000","message":"Can you give an example?","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c799483024d1fded5efbb32dac13c601204d1dcd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#snmp_listening_port \u003d xxx"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# default decode protocol(string value)"},{"line_number":48,"context_line":"#default_coding \u003d xxxx"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# traps oid mapping yaml file path(string value)"},{"line_number":51,"context_line":"#oid_mapping \u003d /etc/vitrage/snmp_parsing_conf.yaml"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_beba176b","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":22},"in_reply_to":"7f287b81_77a0d0f4","updated":"2017-09-06 09:32:16.000000000","message":"The example is good. Is it always the same coding? if not, please explain that it\u0027s just an example. Also, why is it named \u0027default\u0027? why not name it \u0027snmp_coding\u0027?","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"2e9819faf76a6993679c8a1e1c174fa033460c1d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#snmp_listening_port \u003d xxx"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# default decode protocol(string value)"},{"line_number":48,"context_line":"#default_coding \u003d xxxx"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# traps oid mapping yaml file path(string value)"},{"line_number":51,"context_line":"#oid_mapping \u003d /etc/vitrage/snmp_parsing_conf.yaml"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_219ba6c9","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":22},"in_reply_to":"7f287b81_beba176b","updated":"2017-09-06 09:48:23.000000000","message":"Generally, it is always the same code for snmp traps.I have rename the field.","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"41f72a0f44d6aa4ea66b9b7333005e13e4e33760","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# traps oid mapping yaml file path(string value)"},{"line_number":51,"context_line":"#oid_mapping \u003d /etc/vitrage/snmp_parsing_conf.yaml"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"An example of config for snmp_parsing_conf.yaml:"},{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_d78f8472","line":53,"range":{"start_line":53,"start_character":47,"end_line":53,"end_character":48},"updated":"2017-08-31 08:47:11.000000000","message":"Please add a blank line after the :","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"41f72a0f44d6aa4ea66b9b7333005e13e4e33760","unresolved":false,"context_lines":[{"line_number":51,"context_line":"#oid_mapping \u003d /etc/vitrage/snmp_parsing_conf.yaml"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"An example of config for snmp_parsing_conf.yaml:"},{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_97eb3c11","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":21},"updated":"2017-08-31 08:47:11.000000000","message":"Can there be different files, with different service names? what is the purpose of the \u0027service\u0027?","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"41f72a0f44d6aa4ea66b9b7333005e13e4e33760","unresolved":false,"context_lines":[{"line_number":53,"context_line":"An example of config for snmp_parsing_conf.yaml:"},{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_77d7b04c","line":56,"range":{"start_line":56,"start_character":2,"end_line":56,"end_character":18},"updated":"2017-08-31 08:47:11.000000000","message":"Is it a list? can you have multiple config values entries?","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"51e6b3c78f50f417b5393ed17788bf3804ccf60e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"An example of config for snmp_parsing_conf.yaml:"},{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_7ecb8f49","line":56,"range":{"start_line":56,"start_character":2,"end_line":56,"end_character":18},"in_reply_to":"7f287b81_77d7b04c","updated":"2017-09-06 09:21:26.000000000","message":"The construction of yaml file has been simplified because the origin yaml file has too many fileds not needed.","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"41f72a0f44d6aa4ea66b9b7333005e13e4e33760","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"},{"line_number":60,"context_line":"          datasource: nova"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_b7b87810","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"updated":"2017-08-31 08:47:11.000000000","message":"Please give a concrete example for this.\n\n1. What info exists under the OID key? \n2. What is the OID value? an alarm name? something else?\n3. What is the datasource? an identifier of a real datasource? if so, then please change it to \u0027nova.instance\u0027 or \u0027nova.host\u0027 (we don\u0027t have a datasource named \u0027nova\u0027)","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"2e9819faf76a6993679c8a1e1c174fa033460c1d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"},{"line_number":60,"context_line":"          datasource: nova"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_c1ad029c","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"in_reply_to":"7f287b81_1e4c8b9c","updated":"2017-09-06 09:48:23.000000000","message":"2. The oid_key and oid_value is defined by system that trigger alarms, datasource name is defined inside vitrage. Will it be clearer by renaming \u0027oid_value\u0027 to \u0027system\u0027?\n3.Yes, snmp service can distribute traps to all the specified datasources.","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c799483024d1fded5efbb32dac13c601204d1dcd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"},{"line_number":60,"context_line":"          datasource: nova"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_1e4c8b9c","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"in_reply_to":"7f287b81_7e226f03","updated":"2017-09-06 09:32:16.000000000","message":"1. Ok\n2. What is this value used for? is it needed by the datasource? I think the name oid_value might be confusing (key-value pair usually means something else)\n3. Ok. BTW, can the same OID be passed to more than one datasource? (it\u0027s not critical at the moment, I\u0027m just trying to understand).","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"51e6b3c78f50f417b5393ed17788bf3804ccf60e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"},{"line_number":60,"context_line":"          datasource: nova"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_7e226f03","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"in_reply_to":"7f287b81_b7b87810","updated":"2017-09-06 09:21:26.000000000","message":"1. OID key: a serial of numbers and dots to uniquely define which sysytem the alarm comes from(iaas or paas, for exapmle).\n2. The name of system where alarms come from.(iaas_platform, paas_platform, for example).\n3.Yes, it is the name of a real datasource.","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"49d0f5c9ce46ee6a6ee9bc253065d5a817e78707","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"},{"line_number":60,"context_line":"          datasource: nova"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_ccb1b9e3","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"in_reply_to":"7f287b81_c1ad029c","updated":"2017-09-06 10:31:18.000000000","message":"2. But who is going to use the oid_value field? why add it in the first place?\n3. So datasource can hold a list of datasources?","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"0844677cf208f699581d2d74b04796aca04ad86b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"},{"line_number":60,"context_line":"          datasource: nova"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_6738779f","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"in_reply_to":"7f287b81_ccb1b9e3","updated":"2017-09-07 12:29:49.000000000","message":"2. The reported traps contain the mapping of oid key and platform(oid_value, iaas, for example),and the mapping of  oid_value and datasource must be defined, so that snmp\ncan get which datasource this trap should be distributed to.\n3.Generally, there is one datasource since it has been diff platforms.","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"852511049d9bc4ed311148cd7403bd23a1c63fc3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service: snmp_parsing"},{"line_number":55,"context_line":"values:"},{"line_number":56,"context_line":"  - config values:"},{"line_number":57,"context_line":"      oid mappings:"},{"line_number":58,"context_line":"        - oid_key: 1.3.6.1.4.1.3902.4101.1.3.1.12(for example)"},{"line_number":59,"context_line":"          oid_value: Nova(defined by different systems)"},{"line_number":60,"context_line":"          datasource: nova"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7f287b81_d447e976","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"in_reply_to":"7f287b81_ccb1b9e3","updated":"2017-09-07 01:29:02.000000000","message":"3. In my understanding, one datasource per list item. The whole list may include different datasources.","commit_id":"9265fc8c9e57360b76254fafe3ec38e8ac56de91"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bfcc79b5cadb84461e9adfe075226830b91a0f59","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The following use cases should be supported:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Vitrage datasources module provides the ability to handle alarms from part of monitored systems,"},{"line_number":23,"context_line":"but not systems that report alarms by SNMP communication way currently."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_2b72c112","line":20,"range":{"start_line":20,"start_character":18,"end_line":20,"end_character":23},"updated":"2017-10-30 08:54:49.000000000","message":"case","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bfcc79b5cadb84461e9adfe075226830b91a0f59","unresolved":false,"context_lines":[{"line_number":20,"context_line":"The following use cases should be supported:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Vitrage datasources module provides the ability to handle alarms from part of monitored systems,"},{"line_number":23,"context_line":"but not systems that report alarms by SNMP communication way currently."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_abd471be","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":15},"updated":"2017-10-30 08:54:49.000000000","message":"Please change it to \"currently there is no system\"","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bfcc79b5cadb84461e9adfe075226830b91a0f59","unresolved":false,"context_lines":[{"line_number":20,"context_line":"The following use cases should be supported:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Vitrage datasources module provides the ability to handle alarms from part of monitored systems,"},{"line_number":23,"context_line":"but not systems that report alarms by SNMP communication way currently."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_6bd679c6","line":23,"range":{"start_line":23,"start_character":56,"end_line":23,"end_character":70},"updated":"2017-10-30 08:54:49.000000000","message":"This can be deleted","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bfcc79b5cadb84461e9adfe075226830b91a0f59","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"A SNMP service module is presented here, which provides service to parse alarms reported from SNMP"},{"line_number":28,"context_line":"managed system and distributes them to the specified datasource for further processing."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Since snmp service is a common service for alarm datasource, the service powers on just after api,"},{"line_number":31,"context_line":"graph and notifier service. After successfully powered on, SNMP parsing service can receive and"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_2b03e111","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":86},"updated":"2017-10-30 08:54:49.000000000","message":"The SNMP service does not distribute the alarms to the datasources. Instead, it sends events to the RabbitMQ, and the datasources *may* process these events based on their parameters. This part is the responsibility of the datasource, not the SNMP service. \n\nI would rephrase this sentence to:\nand send them to the OpenStack message bus, for further processing by the datasources.","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"4052911c678ba1276f7dbd9475e5aa3d6aefc63d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"A SNMP service module is presented here, which provides service to parse alarms reported from SNMP"},{"line_number":28,"context_line":"managed system and distributes them to the specified datasource for further processing."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Since snmp service is a common service for alarm datasource, the service powers on just after api,"},{"line_number":31,"context_line":"graph and notifier service. After successfully powered on, SNMP parsing service can receive and"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_35243ac6","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":86},"in_reply_to":"3f4b6375_2b03e111","updated":"2017-10-31 08:27:05.000000000","message":"Ok, this will be better.","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bfcc79b5cadb84461e9adfe075226830b91a0f59","unresolved":false,"context_lines":[{"line_number":31,"context_line":"graph and notifier service. After successfully powered on, SNMP parsing service can receive and"},{"line_number":32,"context_line":"decode alarm message. Decoded alarm details are made up of alarm/object info and corresponding value,"},{"line_number":33,"context_line":"e.g. alarm_code. The SNMP parsing service parses alarm datasource info according to corresponding"},{"line_number":34,"context_line":"OID, then constructs message after marking datasource information and distributes messages to each"},{"line_number":35,"context_line":"datasource through the RabbitMQ queue. According to the values of OID, alarm data source can extract"},{"line_number":36,"context_line":"information by decoded alarm details."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The configuration for snmp service:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_ce20db9e","line":35,"range":{"start_line":34,"start_character":94,"end_line":35,"end_character":18},"updated":"2017-10-30 08:54:49.000000000","message":"Please delete this part","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"4052911c678ba1276f7dbd9475e5aa3d6aefc63d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# snmp listening port (integer value)"},{"line_number":42,"context_line":"snmp_listening_port \u003d xxx"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# default decode protocol(string value)"},{"line_number":45,"context_line":"default_coding \u003d iso-8859-1"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# traps oid mapping yaml file path(string value)"},{"line_number":48,"context_line":"#oid_mapping \u003d /etc/vitrage/snmp_parsing_conf.yaml"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_b5302a09","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":27},"updated":"2017-10-31 08:27:05.000000000","message":"This part will be deleted because coding way is always the same and won\u0027t be changed.","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"bfcc79b5cadb84461e9adfe075226830b91a0f59","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":53,"context_line":"  system: iaas_platform (just for example)"},{"line_number":54,"context_line":"  datasource: nova.host   (for example)"},{"line_number":55,"context_line":"- oid: xxxx"},{"line_number":56,"context_line":"  system: xxx"},{"line_number":57,"context_line":"  datasource: xxx"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_ae735fb1","line":54,"range":{"start_line":54,"start_character":14,"end_line":54,"end_character":23},"updated":"2017-10-30 08:54:49.000000000","message":"Please give a different example. As far as I understood, you are going to use the SNMP alarms in another datasource, not in nova.host. I think that this specific example is confusing.","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"4ccc1b98c2e45cbcfb83a0a0b4e9c9f300b7c7d7","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":53,"context_line":"  system: iaas_platform (just for example)"},{"line_number":54,"context_line":"  datasource: nova.host   (for example)"},{"line_number":55,"context_line":"- oid: xxxx"},{"line_number":56,"context_line":"  system: xxx"},{"line_number":57,"context_line":"  datasource: xxx"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_ec4938b7","line":54,"range":{"start_line":54,"start_character":14,"end_line":54,"end_character":23},"in_reply_to":"3f4b6375_200d1a35","updated":"2017-10-31 13:17:54.000000000","message":"How about my_datasource? or new_datasource?","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"4052911c678ba1276f7dbd9475e5aa3d6aefc63d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":53,"context_line":"  system: iaas_platform (just for example)"},{"line_number":54,"context_line":"  datasource: nova.host   (for example)"},{"line_number":55,"context_line":"- oid: xxxx"},{"line_number":56,"context_line":"  system: xxx"},{"line_number":57,"context_line":"  datasource: xxx"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_200d1a35","line":54,"range":{"start_line":54,"start_character":14,"end_line":54,"end_character":23},"in_reply_to":"3f4b6375_318eaed0","updated":"2017-10-31 08:27:05.000000000","message":"Ok. This should be a new alarm datasource. I change this to [new_alarm], will it be clearer?","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"6ae93d55ccf4f6f4d093ece6a96d5d4867d64124","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":53,"context_line":"  system: iaas_platform (just for example)"},{"line_number":54,"context_line":"  datasource: nova.host   (for example)"},{"line_number":55,"context_line":"- oid: xxxx"},{"line_number":56,"context_line":"  system: xxx"},{"line_number":57,"context_line":"  datasource: xxx"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_318eaed0","line":54,"range":{"start_line":54,"start_character":14,"end_line":54,"end_character":23},"in_reply_to":"3f4b6375_ae735fb1","updated":"2017-10-30 09:59:31.000000000","message":"I agree. It\u0027s not related to nova.host / nova.instance / any other existing datasource. SNMP should have it\u0027s own datasource(s).","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19194,"name":"Dan Offek","email":"dany.offek@gmail.com","username":"danoffek"},"change_message_id":"6ae93d55ccf4f6f4d093ece6a96d5d4867d64124","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Work Items"},{"line_number":112,"context_line":"----------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Add a new service SNMP parsing service"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_91b0c28d","line":114,"updated":"2017-10-30 09:59:31.000000000","message":"Add a new SNMP parsing service","commit_id":"46bb52bf6ddafcdd7e92a92ad328bab54f4508a3"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"62280877ef0aa2962c53e7b4619b64768390821b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"The following use case should be supported:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Vitrage datasources module provides the ability to handle alarms from part of monitored systems,"},{"line_number":23,"context_line":"but currently there is no system that reports alarms by SNMP communication.."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_2cd510b8","line":23,"range":{"start_line":23,"start_character":75,"end_line":23,"end_character":76},"updated":"2017-10-31 13:22:42.000000000","message":"Extra point","commit_id":"4e79fda4b189bc76a973fa94a268300d116508f8"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"62280877ef0aa2962c53e7b4619b64768390821b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"graph and notifier service. After successfully powered on, SNMP parsing service can receive and"},{"line_number":32,"context_line":"decode alarm message. Decoded alarm details are made up of alarm/object info and corresponding value,"},{"line_number":33,"context_line":"e.g. alarm_code. The SNMP parsing service parses alarm datasource info according to corresponding"},{"line_number":34,"context_line":"OID, then constructs message after marking datasource information and distributes messages to the "},{"line_number":35,"context_line":"RabbitMQ queue. According to the values of OID, alarm data source can extract"},{"line_number":36,"context_line":"information by decoded alarm details."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_2cfe3038","line":34,"range":{"start_line":34,"start_character":97,"end_line":34,"end_character":98},"updated":"2017-10-31 13:22:42.000000000","message":"There is a red sign here. Maybe you have an extra space?","commit_id":"4e79fda4b189bc76a973fa94a268300d116508f8"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"5edb2114038312161c454104250859b05fc1b98d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"graph and notifier service. After successfully powered on, SNMP parsing service can receive and"},{"line_number":32,"context_line":"decode alarm message. Decoded alarm details are made up of alarm/object info and corresponding value,"},{"line_number":33,"context_line":"e.g. alarm_code. The SNMP parsing service parses alarm datasource info according to corresponding"},{"line_number":34,"context_line":"OID, then constructs message after marking datasource information and distributes messages to the "},{"line_number":35,"context_line":"RabbitMQ queue. According to the values of OID, alarm data source can extract"},{"line_number":36,"context_line":"information by decoded alarm details."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_fb919753","line":34,"range":{"start_line":34,"start_character":97,"end_line":34,"end_character":98},"in_reply_to":"3f4b6375_2cfe3038","updated":"2017-11-02 23:50:03.000000000","message":"The red mark at the end of the line still exists. Can you please check why?","commit_id":"4e79fda4b189bc76a973fa94a268300d116508f8"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"62280877ef0aa2962c53e7b4619b64768390821b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"decode alarm message. Decoded alarm details are made up of alarm/object info and corresponding value,"},{"line_number":33,"context_line":"e.g. alarm_code. The SNMP parsing service parses alarm datasource info according to corresponding"},{"line_number":34,"context_line":"OID, then constructs message after marking datasource information and distributes messages to the "},{"line_number":35,"context_line":"RabbitMQ queue. According to the values of OID, alarm data source can extract"},{"line_number":36,"context_line":"information by decoded alarm details."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The configuration for snmp service:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_4c884cc5","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":53},"updated":"2017-10-31 13:22:42.000000000","message":"Missing \u0027the\u0027 before \u0027alarm\u0027","commit_id":"4e79fda4b189bc76a973fa94a268300d116508f8"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"62280877ef0aa2962c53e7b4619b64768390821b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"decode alarm message. Decoded alarm details are made up of alarm/object info and corresponding value,"},{"line_number":33,"context_line":"e.g. alarm_code. The SNMP parsing service parses alarm datasource info according to corresponding"},{"line_number":34,"context_line":"OID, then constructs message after marking datasource information and distributes messages to the "},{"line_number":35,"context_line":"RabbitMQ queue. According to the values of OID, alarm data source can extract"},{"line_number":36,"context_line":"information by decoded alarm details."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The configuration for snmp service:"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_8ce9a481","line":35,"range":{"start_line":35,"start_character":54,"end_line":35,"end_character":65},"updated":"2017-10-31 13:22:42.000000000","message":"datasource","commit_id":"4e79fda4b189bc76a973fa94a268300d116508f8"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"62280877ef0aa2962c53e7b4619b64768390821b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"e.g. alarm_code. The SNMP parsing service parses alarm datasource info according to corresponding"},{"line_number":34,"context_line":"OID, then constructs message after marking datasource information and distributes messages to the "},{"line_number":35,"context_line":"RabbitMQ queue. According to the values of OID, alarm data source can extract"},{"line_number":36,"context_line":"information by decoded alarm details."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The configuration for snmp service:"},{"line_number":39,"context_line":"[snmp_parsing]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f4b6375_eca5b848","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":37},"updated":"2017-10-31 13:22:42.000000000","message":"Please continue the previous line","commit_id":"4e79fda4b189bc76a973fa94a268300d116508f8"},{"author":{"_account_id":27135,"name":"LiJing","email":"li.jing10@zte.com.cn","username":"LiJing"},"change_message_id":"f9e0b4ae6f1a0f3c27da5a13ddb2d96476b2cba3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"graph and notifier service. After successfully powered on, SNMP parsing service can receive and"},{"line_number":32,"context_line":"decode alarm messages. Decoded alarm details are made up of alarm/object info and corresponding value,"},{"line_number":33,"context_line":"e.g. alarm_code. The SNMP parsing service parses alarm datasource info according to corresponding"},{"line_number":34,"context_line":"OID, then constructs message after marking datasource information and distributes messages to the "},{"line_number":35,"context_line":"RabbitMQ queue. According to the values of OID, the alarm datasource can extract information by decoded"},{"line_number":36,"context_line":"alarm details."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f4b6375_5b69cbf5","line":34,"updated":"2017-11-03 00:27:03.000000000","message":"line34 end with a space, delete it?","commit_id":"1083f3618da52f8224328633c8eaed1755d36909"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"1acbb122deb7dbcc39e7ee52a6b6fbc81f1ac518","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"An example of config for snmp_parsing_conf.yaml:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":50,"context_line":"  system: iaas_platform (for example)"},{"line_number":51,"context_line":"  datasource: [new_datasource]"},{"line_number":52,"context_line":"- oid: xxxx"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_0d5d5546","line":49,"range":{"start_line":49,"start_character":38,"end_line":49,"end_character":51},"updated":"2017-11-03 06:37:36.000000000","message":"Although it is not actual code, I would prefer to put comments in comment format, i.e. # for example","commit_id":"1f53e9bb07864684e143e0b912e8ae11f9d35e0e"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"5d4c65731cfb1d5075640400821a929910940f67","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"An example of config for snmp_parsing_conf.yaml:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":50,"context_line":"  system: iaas_platform (for example)"},{"line_number":51,"context_line":"  datasource: [new_datasource]"},{"line_number":52,"context_line":"- oid: xxxx"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_f8e63216","line":49,"range":{"start_line":49,"start_character":38,"end_line":49,"end_character":51},"in_reply_to":"3f4b6375_0d5d5546","updated":"2017-11-03 09:33:36.000000000","message":"You mean change it to (i.e.) ?","commit_id":"1f53e9bb07864684e143e0b912e8ae11f9d35e0e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"56e41f58cd1688d93c31616eec08a71b37d21f91","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"An example of config for snmp_parsing_conf.yaml:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":50,"context_line":"  system: iaas_platform (for example)"},{"line_number":51,"context_line":"  datasource: [new_datasource]"},{"line_number":52,"context_line":"- oid: xxxx"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_5bebee76","line":49,"range":{"start_line":49,"start_character":38,"end_line":49,"end_character":51},"in_reply_to":"3f4b6375_f8e63216","updated":"2017-11-04 03:52:55.000000000","message":"Change it to\n\n- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 # for example","commit_id":"1f53e9bb07864684e143e0b912e8ae11f9d35e0e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"1acbb122deb7dbcc39e7ee52a6b6fbc81f1ac518","unresolved":false,"context_lines":[{"line_number":47,"context_line":"An example of config for snmp_parsing_conf.yaml:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":50,"context_line":"  system: iaas_platform (for example)"},{"line_number":51,"context_line":"  datasource: [new_datasource]"},{"line_number":52,"context_line":"- oid: xxxx"},{"line_number":53,"context_line":"  system: xxx"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_ed55591f","line":50,"range":{"start_line":50,"start_character":24,"end_line":50,"end_character":37},"updated":"2017-11-03 06:37:36.000000000","message":"The same as L49","commit_id":"1f53e9bb07864684e143e0b912e8ae11f9d35e0e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"1acbb122deb7dbcc39e7ee52a6b6fbc81f1ac518","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":50,"context_line":"  system: iaas_platform (for example)"},{"line_number":51,"context_line":"  datasource: [new_datasource]"},{"line_number":52,"context_line":"- oid: xxxx"},{"line_number":53,"context_line":"  system: xxx"},{"line_number":54,"context_line":"  datasource: xxx"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_8d36e502","line":51,"range":{"start_line":51,"start_character":14,"end_line":51,"end_character":30},"updated":"2017-11-03 06:37:36.000000000","message":"[...] represents array in yaml. Do you mean it is an array here?","commit_id":"1f53e9bb07864684e143e0b912e8ae11f9d35e0e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"56e41f58cd1688d93c31616eec08a71b37d21f91","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":50,"context_line":"  system: iaas_platform (for example)"},{"line_number":51,"context_line":"  datasource: [new_datasource]"},{"line_number":52,"context_line":"- oid: xxxx"},{"line_number":53,"context_line":"  system: xxx"},{"line_number":54,"context_line":"  datasource: xxx"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_3b04b249","line":51,"range":{"start_line":51,"start_character":14,"end_line":51,"end_character":30},"in_reply_to":"3f4b6375_58d8a651","updated":"2017-11-04 03:52:55.000000000","message":"Yes.","commit_id":"1f53e9bb07864684e143e0b912e8ae11f9d35e0e"},{"author":{"_account_id":25301,"name":"xupeipei","email":"xu.peipei1@zte.com.cn","username":"xupeipei"},"change_message_id":"5d4c65731cfb1d5075640400821a929910940f67","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- oid: 1.3.6.1.4.1.3902.4101.1.3.1.12 (for example)"},{"line_number":50,"context_line":"  system: iaas_platform (for example)"},{"line_number":51,"context_line":"  datasource: [new_datasource]"},{"line_number":52,"context_line":"- oid: xxxx"},{"line_number":53,"context_line":"  system: xxx"},{"line_number":54,"context_line":"  datasource: xxx"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_58d8a651","line":51,"range":{"start_line":51,"start_character":14,"end_line":51,"end_character":30},"in_reply_to":"3f4b6375_8d36e502","updated":"2017-11-03 09:33:36.000000000","message":"Here I mean new_datasource is a variable. Should I remove []?","commit_id":"1f53e9bb07864684e143e0b912e8ae11f9d35e0e"}]}