)]}'
{"specs/queens/approved/template-include.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c51c68cd1a1cca0ecc846c5eb55a75bd321b7ac9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      template_id : alarm_on_host"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Add an \"include\" section within templates, which states the name that should be"},{"line_number":55,"context_line":"included at it appears in the metadata of the definition template:"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. code-block:: yaml"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf3e73b7_81351dfa","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":66},"updated":"2017-08-06 10:31:10.000000000","message":"Can there be more than one include?","commit_id":"464f39fa45fb60634aa8773a30797c59fea57516"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c51c68cd1a1cca0ecc846c5eb55a75bd321b7ac9","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Other contributors:"},{"line_number":155,"context_line":"  None"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Work Items"},{"line_number":158,"context_line":"----------"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"The following items are not in scope"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf3e73b7_413f35d6","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":10},"updated":"2017-08-06 10:31:10.000000000","message":"Please add the work items that are in scope, e.g.:\n- load the new definition files\n- validate the new definition files\n- documentation\n- tests","commit_id":"464f39fa45fb60634aa8773a30797c59fea57516"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"c51c68cd1a1cca0ecc846c5eb55a75bd321b7ac9","unresolved":false,"context_lines":[{"line_number":176,"context_line":"Documentation Impact"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"- Documentation on how to define definition template files and when to use them"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"References"},{"line_number":182,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf3e73b7_e12d09a9","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":2},"updated":"2017-08-06 10:31:10.000000000","message":"Not needed","commit_id":"464f39fa45fb60634aa8773a30797c59fea57516"}],"specs/queens/template-include.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"59927640f553be27976a4cf66abaf078176d3380","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Define includable templates to include within other templates"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/vitrage/+spec/includables"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_5d17baee","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":27},"updated":"2017-08-02 08:57:35.000000000","message":"I don\u0027t like the word includables... it explains what you are going to do with the file, but not what it actually contains.\n\nA template is currently made of \u0027definitions\u0027 and \u0027scenarios\u0027. So I think that you are suggesting to separate the definitions and allow including it. \n\nHow about: \nInclude common template definitions\n\nOr:\nInclude template definition from an external file\n\nOr something similar?","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"59927640f553be27976a4cf66abaf078176d3380","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Introducing includables will avoid code repetition, as a lot of templates"},{"line_number":21,"context_line":"were redefining the same entities and relationships for use in their scenarios."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_bd958642","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":55},"updated":"2017-08-02 08:57:35.000000000","message":"You can remove the beginning of this sentence. The problem is that \"A lot of templates ..\". Then there is the suggested solution.","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"59927640f553be27976a4cf66abaf078176d3380","unresolved":false,"context_lines":[{"line_number":29,"context_line":".. code-block:: yaml"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":" metadata:"},{"line_number":32,"context_line":"  name: includable_example"},{"line_number":33,"context_line":"  description: basic includable example"},{"line_number":34,"context_line":" definitions:"},{"line_number":35,"context_line":"  entities:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_ddb5eace","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":26},"updated":"2017-08-02 08:57:35.000000000","message":"Please give it a meaningful name, even if it\u0027s an example. Something like: alarm_on_host_definitions","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"59927640f553be27976a4cf66abaf078176d3380","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Data model impact"},{"line_number":86,"context_line":"-----------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"None"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"REST API impact"},{"line_number":91,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_fd00ae69","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":4},"updated":"2017-08-02 08:57:35.000000000","message":"There is an impact on the scenario repository, right?\nI don\u0027t think that you need to write a lot of details here, but please mention it in one line.","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"59927640f553be27976a4cf66abaf078176d3380","unresolved":false,"context_lines":[{"line_number":90,"context_line":"REST API impact"},{"line_number":91,"context_line":"---------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Versioning impact"},{"line_number":96,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_3d2cf600","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":4},"updated":"2017-08-02 08:57:35.000000000","message":"Currently None, but please mention that it should be addressed in a future template CRUD implementation","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"59927640f553be27976a4cf66abaf078176d3380","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Versioning impact"},{"line_number":96,"context_line":"-----------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"None"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Other end user impact"},{"line_number":101,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_fd0e6e8b","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":4},"updated":"2017-08-02 08:57:35.000000000","message":"\u0027None\u0027 is correct, but please add an explanation: \nThe old template format will still be supported, and you are just adding another alternative.","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"59927640f553be27976a4cf66abaf078176d3380","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Horizon impact"},{"line_number":116,"context_line":"--------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"None"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Topology view"},{"line_number":121,"context_line":"^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_9d688221","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":4},"updated":"2017-08-02 08:57:35.000000000","message":"There actually is an impact. We will have to change the current template UI and show the new definitions","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"0b9765809067dbbf58dcd74cd4b596ff1b6116f8","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Work Items"},{"line_number":154,"context_line":"----------"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"The following items are not in scope"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"- Adding scenarios in the includables"},{"line_number":159,"context_line":"- Recursive includes (an includable can not include other includables)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_200ce639","line":156,"updated":"2017-08-01 15:11:03.000000000","message":"What about validation of the includables and templates with include section?","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"59927640f553be27976a4cf66abaf078176d3380","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Testing"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"The implementation will be covered by additional unit test"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Documentation Impact"},{"line_number":172,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df3967d1_5de0da96","line":169,"range":{"start_line":169,"start_character":49,"end_line":169,"end_character":58},"updated":"2017-08-02 08:57:35.000000000","message":"and tempest tests. We must have the existing deduced and rca tempest tests work, and then you should add tests for your feature","commit_id":"3e2e75f95f6a1cd8b579ddb6790051e5fd74a9f9"}]}
