)]}'
{"specs/queens/approved/add_nova_reset_state_notifier.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"df2b2fb82890d45cded0acb327bf02138dbfaad5","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In addition, the host_down_scenario template will be modified:"},{"line_number":40,"context_line":" - Modify the states of the VMs which are launched at the down host to ERROR"},{"line_number":41,"context_line":" - Call Nova reset-state API to set the servers as error states"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_afe892e1","line":41,"range":{"start_line":41,"start_character":3,"end_line":41,"end_character":63},"updated":"2017-10-24 06:08:59.000000000","message":"Can you please add details on that? are you going to add a new syntax to the templates?\n\nAs part of the Vitrage integration with Mistral, I added an infrastructure for adding \"external actions\" to the templates. The first (and for now the only) external action is execute_mistral. I think we can add a similar execute_nova action, with parameters about the kind of action that should be executed.\n\nNote also that there is an open blueprint for refactoring the implementation of Nova mark-down. I don\u0027t think that you need to do it as part of the current blueprint, just keep it in mind and try to implement your blueprint in a way that will make the mark-down refactoring easier later on.\n\nRelevant links:\n\nhttps://specs.openstack.org/openstack/vitrage-specs/specs/pike/external-actions.html\n\nhttps://specs.openstack.org/openstack/vitrage-specs/specs/pike/approved/integration-with-mistral.html\n\nhttps://blueprints.launchpad.net/vitrage/+spec/support-external-actions\n\nhttps://blueprints.launchpad.net/vitrage/+spec/refactor-mark-down","commit_id":"af2649dad5b50aed7c1442830d260a4708ef1d83"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"bd1605e959035b9d5d028743951dc29bc0936229","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In addition, the host_down_scenario template will be modified:"},{"line_number":40,"context_line":" - Modify the states of the VMs which are launched at the down host to ERROR"},{"line_number":41,"context_line":" - Call Nova reset-state API to set the servers as error states"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_b3a57b49","line":41,"range":{"start_line":41,"start_character":3,"end_line":41,"end_character":63},"in_reply_to":"3f4b6375_95538739","updated":"2017-10-25 03:24:57.000000000","message":"Done","commit_id":"af2649dad5b50aed7c1442830d260a4708ef1d83"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"63475e4d05d580089d4a5210ff9a5d2c492355a4","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In addition, the host_down_scenario template will be modified:"},{"line_number":40,"context_line":" - Modify the states of the VMs which are launched at the down host to ERROR"},{"line_number":41,"context_line":" - Call Nova reset-state API to set the servers as error states"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_95538739","line":41,"range":{"start_line":41,"start_character":3,"end_line":41,"end_character":63},"in_reply_to":"3f4b6375_afcd3267","updated":"2017-10-25 01:46:13.000000000","message":"-1 to clear unread and remind myself this documents is unfinished.","commit_id":"af2649dad5b50aed7c1442830d260a4708ef1d83"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"35c18fbd7db2444aae2565c111fbc30adb4ecb97","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In addition, the host_down_scenario template will be modified:"},{"line_number":40,"context_line":" - Modify the states of the VMs which are launched at the down host to ERROR"},{"line_number":41,"context_line":" - Call Nova reset-state API to set the servers as error states"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_afcd3267","line":41,"range":{"start_line":41,"start_character":3,"end_line":41,"end_character":63},"in_reply_to":"3f4b6375_afe892e1","updated":"2017-10-24 06:23:52.000000000","message":"Thanks for letting me know. I\u0027ll update this BP after I read the relevant links.","commit_id":"af2649dad5b50aed7c1442830d260a4708ef1d83"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"df2b2fb82890d45cded0acb327bf02138dbfaad5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"What other ways could we do this thing? Why aren\u0027t we using those? This doesn\u0027t"},{"line_number":47,"context_line":"have to be a full literature review, but it should demonstrate that thought has"},{"line_number":48,"context_line":"been put into why the proposed solution is an appropriate one."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"},{"line_number":51,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_cf806e49","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":62},"updated":"2017-10-24 06:08:59.000000000","message":"Remove this :-)","commit_id":"af2649dad5b50aed7c1442830d260a4708ef1d83"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"35c18fbd7db2444aae2565c111fbc30adb4ecb97","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"What other ways could we do this thing? Why aren\u0027t we using those? This doesn\u0027t"},{"line_number":47,"context_line":"have to be a full literature review, but it should demonstrate that thought has"},{"line_number":48,"context_line":"been put into why the proposed solution is an appropriate one."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"},{"line_number":51,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_cf862e14","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":62},"in_reply_to":"3f4b6375_cf806e49","updated":"2017-10-24 06:23:52.000000000","message":"Done","commit_id":"af2649dad5b50aed7c1442830d260a4708ef1d83"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"904b694450468653918aa5663892b83bd105ab58","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Add a \u0027execute_nova\u0027 action that under host down conditions in Vitrage"},{"line_number":34,"context_line":"template. This action will call Nova api: \u0027reset-state\u0027 to set instance state."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Examples"},{"line_number":37,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_4a3d6929","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":21},"updated":"2017-10-25 07:02:44.000000000","message":"You can delete these two words. Instead: \n\nAdd a \u0027execute-nova\u0027 action that under host down conditions in Vitrage template will call ...","commit_id":"2f3089e13f4e035925e1a56b7c2e135ae8b5c2a5"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"5e3a09bd0005d2f7717e6844f71ff548c3a17d2f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Add a \u0027execute_nova\u0027 action that under host down conditions in Vitrage"},{"line_number":34,"context_line":"template. This action will call Nova api: \u0027reset-state\u0027 to set instance state."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Examples"},{"line_number":37,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_eda2efad","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":21},"in_reply_to":"3f4b6375_4a3d6929","updated":"2017-10-25 08:19:34.000000000","message":"Ok.","commit_id":"2f3089e13f4e035925e1a56b7c2e135ae8b5c2a5"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"333735e84df5b03d2309d06adcab180a2608524d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    condition: host_down_alarm_on_host and host_contains_instance and alarm_on_instance"},{"line_number":43,"context_line":"    actions:"},{"line_number":44,"context_line":"     - action:"},{"line_number":45,"context_line":"        action_type: execute_nova"},{"line_number":46,"context_line":"        properties:"},{"line_number":47,"context_line":"          api_call: reset-state"},{"line_number":48,"context_line":"          instance: instance1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_caf6f963","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":33},"updated":"2017-10-25 06:56:16.000000000","message":"Shall we refactor `mark-down` action to keep consistency? It may not be in scope of this blueprint, but better to mention it. \n\nOr you can refactor mark-down before implementing this blueprint.","commit_id":"2f3089e13f4e035925e1a56b7c2e135ae8b5c2a5"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"67f03ae07d04df541c71c9d9b4eea00f47b2ef6d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    condition: host_down_alarm_on_host and host_contains_instance and alarm_on_instance"},{"line_number":43,"context_line":"    actions:"},{"line_number":44,"context_line":"     - action:"},{"line_number":45,"context_line":"        action_type: execute_nova"},{"line_number":46,"context_line":"        properties:"},{"line_number":47,"context_line":"          api_call: reset-state"},{"line_number":48,"context_line":"          instance: instance1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_34b94e14","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":33},"in_reply_to":"3f4b6375_7357fc59","updated":"2017-10-26 06:01:07.000000000","message":"I\u0027m OK with it as long as we finish both in Queens release.","commit_id":"2f3089e13f4e035925e1a56b7c2e135ae8b5c2a5"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"5e3a09bd0005d2f7717e6844f71ff548c3a17d2f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    condition: host_down_alarm_on_host and host_contains_instance and alarm_on_instance"},{"line_number":43,"context_line":"    actions:"},{"line_number":44,"context_line":"     - action:"},{"line_number":45,"context_line":"        action_type: execute_nova"},{"line_number":46,"context_line":"        properties:"},{"line_number":47,"context_line":"          api_call: reset-state"},{"line_number":48,"context_line":"          instance: instance1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_cd6613c2","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":33},"in_reply_to":"3f4b6375_caf6f963","updated":"2017-10-25 08:19:34.000000000","message":"\u0027mark-down\u0027 should be refactored, but may not included in this BP.\nThere already has a BP to refactor it. https://blueprints.launchpad.net/vitrage/+spec/refactor-mark-down","commit_id":"2f3089e13f4e035925e1a56b7c2e135ae8b5c2a5"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"cda779e3a4c57978ba4e4c3e8c36bc5a8a8e85c5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    condition: host_down_alarm_on_host and host_contains_instance and alarm_on_instance"},{"line_number":43,"context_line":"    actions:"},{"line_number":44,"context_line":"     - action:"},{"line_number":45,"context_line":"        action_type: execute_nova"},{"line_number":46,"context_line":"        properties:"},{"line_number":47,"context_line":"          api_call: reset-state"},{"line_number":48,"context_line":"          instance: instance1"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_7357fc59","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":33},"in_reply_to":"3f4b6375_cd6613c2","updated":"2017-10-25 09:04:16.000000000","message":"Note that there are two ways to refactor mark-down:\n\n1. Change the syntax to use execute_nova. IMO This is more correct, but will require us to support the old format as well (or do an automatic conversion).\n\n2. Change only the internal implementation to use the new external actions, and keep the mark-down syntax.\n\nPersonally I think that it\u0027s ok to implement reset-server-state now and mark-down later.","commit_id":"2f3089e13f4e035925e1a56b7c2e135ae8b5c2a5"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"904b694450468653918aa5663892b83bd105ab58","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    condition: host_down_alarm_on_host and host_contains_instance and alarm_on_instance"},{"line_number":43,"context_line":"    actions:"},{"line_number":44,"context_line":"     - action:"},{"line_number":45,"context_line":"        action_type: execute_nova"},{"line_number":46,"context_line":"        properties:"},{"line_number":47,"context_line":"          api_call: reset-state"},{"line_number":48,"context_line":"          instance: instance1"},{"line_number":49,"context_line":"          state: error"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_8a6fe1fa","line":49,"range":{"start_line":45,"start_character":0,"end_line":49,"end_character":22},"updated":"2017-10-25 07:02:44.000000000","message":"This is similar to the Mistral structure, but I got a feedback from Renat Akhmerov (Mistral PTL) that it should be changed. \n\nIf I apply his comment to your case, then api_call is a mandatory property that should be part of the execute_nova syntax, while instance and state are specific to reset-state.\n\n\nHow about this structure instead:\n\n        action_type: execute_nova\n\n        properties:\n\n          api_call: reset-state\n\n          parameters:\n\n            instance: instance1\n\n            state: error\n\n\nI\u0027m not sure if the difference between \u0027properties\u0027 and \u0027parameters\u0027 is clear enough. Maybe \u0027metadata\u0027 is better?","commit_id":"2f3089e13f4e035925e1a56b7c2e135ae8b5c2a5"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"5e3a09bd0005d2f7717e6844f71ff548c3a17d2f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    condition: host_down_alarm_on_host and host_contains_instance and alarm_on_instance"},{"line_number":43,"context_line":"    actions:"},{"line_number":44,"context_line":"     - action:"},{"line_number":45,"context_line":"        action_type: execute_nova"},{"line_number":46,"context_line":"        properties:"},{"line_number":47,"context_line":"          api_call: reset-state"},{"line_number":48,"context_line":"          instance: instance1"},{"line_number":49,"context_line":"          state: error"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_edb9cfcb","line":49,"range":{"start_line":45,"start_character":0,"end_line":49,"end_character":22},"in_reply_to":"3f4b6375_8a6fe1fa","updated":"2017-10-25 08:19:34.000000000","message":"\u0027metadata\u0027 seems better.","commit_id":"2f3089e13f4e035925e1a56b7c2e135ae8b5c2a5"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b39949903b111307387af82244b44c1b2c2f6677","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Add the \u0027nova\u0027 notifier in vitrage config file::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"::"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_7305bc45","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":48},"updated":"2017-10-25 09:08:36.000000000","message":"This already exists, but we need to document the fact that this configuration is required for the feature to work","commit_id":"e4783ebe61d6a395010fb949f58348300a7f84d0"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"f58070a87a862c3b732edb2a6001c76145e92426","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Add the \u0027nova\u0027 notifier in vitrage config file::"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"::"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_5ed2c701","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":48},"in_reply_to":"3f4b6375_7305bc45","updated":"2017-10-25 09:32:17.000000000","message":"OK,I\u0027ll delete it.","commit_id":"e4783ebe61d6a395010fb949f58348300a7f84d0"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"b39949903b111307387af82244b44c1b2c2f6677","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    actions:"},{"line_number":51,"context_line":"     - action:"},{"line_number":52,"context_line":"        action_type: execute_nova"},{"line_number":53,"context_line":"　　　　　metadata:"},{"line_number":54,"context_line":"          api_call: reset-state"},{"line_number":55,"context_line":"          parameters:"},{"line_number":56,"context_line":"            instance: instance1"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_f3640c24","line":53,"range":{"start_line":53,"start_character":5,"end_line":53,"end_character":13},"updated":"2017-10-25 09:08:36.000000000","message":"I think that we should keep \u0027properties\u0027 here. It is used for all action types. You can say that \u0027metadata\u0027 is better than \u0027properties\u0027, but changing it for all actions will break the existing template format so I don\u0027t think it\u0027s worth it.\n\nMaybe \u0027parameters\u0027 should be replaced with \u0027metadata\u0027?","commit_id":"e4783ebe61d6a395010fb949f58348300a7f84d0"},{"author":{"_account_id":18783,"name":"dongwenjuan","email":"dong.wenjuan@zte.com.cn","username":"dongwenjuan"},"change_message_id":"f58070a87a862c3b732edb2a6001c76145e92426","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    actions:"},{"line_number":51,"context_line":"     - action:"},{"line_number":52,"context_line":"        action_type: execute_nova"},{"line_number":53,"context_line":"　　　　　metadata:"},{"line_number":54,"context_line":"          api_call: reset-state"},{"line_number":55,"context_line":"          parameters:"},{"line_number":56,"context_line":"            instance: instance1"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_7eb8e3e3","line":53,"range":{"start_line":53,"start_character":5,"end_line":53,"end_character":13},"in_reply_to":"3f4b6375_f3640c24","updated":"2017-10-25 09:32:17.000000000","message":"OK.","commit_id":"e4783ebe61d6a395010fb949f58348300a7f84d0"}]}
