)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     idan kinory \u003cidan.kinory@nokia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-05 07:00:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"template CRUD-specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0ff5112ca3abc2d6235dbde750836cbad4faf834"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f485f77_473273f3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"updated":"2017-11-13 13:53:30.000000000","message":"Please add a blank line, and then:\n\nImplements: blueprint crud-templates\n\nThis will (hopefully) link the gerrit topic to the launchpad blueprint","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"4b85cdbd5d62dfd80221edd7d0c23a22fb3bf5ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"template CRUD-specs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0ff5112ca3abc2d6235dbde750836cbad4faf834"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f91af0f_3d73bdb3","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"updated":"2018-01-04 09:50:59.000000000","message":"Please add:\n\nImplements: blueprint crud-templates","commit_id":"cea54855f17bd9a0e445c2dca0fd69932610fa77"}],"specs/queens/approved/template-CRUD.rst":[{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add CRUD support for template addition"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_47195377","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":51},"updated":"2017-11-13 13:53:30.000000000","message":"Please remove the extra \u003d\u003d\u003d","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Adding CRUD support means that templates can be added/removed in real time when Vitrage is up."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Templates will be add via API and will be stored persistently in DB so they can survive Vitrage restart."},{"line_number":17,"context_line":"sqlalchemy will be used for DB management."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_cd0f162c","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":41},"updated":"2017-11-06 07:19:13.000000000","message":"What about \"Templates added/removed via API will be ...\"","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently, Vitrage templates are loaded from a specific folder during Vitrage startup."},{"line_number":23,"context_line":"adding/removing templates during Vitrage services are running is impossible."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_8d159e3f","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":6},"updated":"2017-11-06 07:19:13.000000000","message":"\u003d\u003e Adding","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently, Vitrage templates are loaded from a specific folder during Vitrage startup."},{"line_number":23,"context_line":"adding/removing templates during Vitrage services are running is impossible."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_674a0f56","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":75},"updated":"2017-11-13 13:53:30.000000000","message":"I would replace it with \"requires restart of the vitrage-graph service\"","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":23,"context_line":"adding/removing templates during Vitrage services are running is impossible."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"Templates should be stored in DB instead of specific folder in file system, In that way they can be modified (add/delete) during vitrage is up. evaluator restart will load new templates actions and change the graph accordingly."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_676d6f97","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":15},"updated":"2017-11-13 13:53:30.000000000","message":"Please mention somewhere that \u0027update\u0027 will not be supported at this stage","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"Templates should be stored in DB instead of specific folder in file system, In that way they can be modified (add/delete) during vitrage is up. evaluator restart will load new templates actions and change the graph accordingly."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"workflow:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_cd3836d4","line":28,"range":{"start_line":28,"start_character":144,"end_line":28,"end_character":153},"updated":"2017-11-06 07:19:13.000000000","message":"\u003d\u003e Evaluator","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"Templates should be stored in DB instead of specific folder in file system, In that way they can be modified (add/delete) during vitrage is up. evaluator restart will load new templates actions and change the graph accordingly."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"workflow:"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_0d23eea8","line":28,"range":{"start_line":28,"start_character":100,"end_line":28,"end_character":108},"updated":"2017-11-06 07:19:13.000000000","message":"Wrap this line for reviewer?","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   :alt: Problem description"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Add :"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- Validate template."},{"line_number":41,"context_line":"- store in DB."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_4d520615","line":38,"range":{"start_line":38,"start_character":3,"end_line":38,"end_character":4},"updated":"2017-11-06 07:19:13.000000000","message":"Remove whitespace","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- Validate template."},{"line_number":41,"context_line":"- store in DB."},{"line_number":42,"context_line":"- Restart evaluator."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Delete:"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_87d98b84","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":20},"updated":"2017-11-13 13:53:30.000000000","message":"Please specify that the evaluator will run sub-graph matching of the new template on *all* vertices in the graph, and will execute the actions on every match that is found","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Delete:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- Delete from DB."},{"line_number":47,"context_line":"- Restart evaluator."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_67e68f47","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":20},"updated":"2017-11-13 13:53:30.000000000","message":"Similar, but will execute undo actions","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"few changes should be made in order to implement CRUD support"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- Support Add/Remove commands in vitrageclient (Vitrage API)"},{"line_number":54,"context_line":"- Adjust POST method  to support validate and add."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_ad33baf5","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":3},"updated":"2017-11-06 07:19:13.000000000","message":"\u003d\u003e A few","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"few changes should be made in order to implement CRUD support"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- Support Add/Remove commands in vitrageclient (Vitrage API)"},{"line_number":54,"context_line":"- Adjust POST method  to support validate and add."},{"line_number":55,"context_line":"- add DELETE method."},{"line_number":56,"context_line":"- API handler: Store/Delete Template from the Database ."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_8d435e3f","line":53,"range":{"start_line":53,"start_character":10,"end_line":53,"end_character":20},"updated":"2017-11-06 07:19:13.000000000","message":"\u003d\u003e template add/remove\n\nsince there could be other resources.","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":51,"context_line":"few changes should be made in order to implement CRUD support"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- Support Add/Remove commands in vitrageclient (Vitrage API)"},{"line_number":54,"context_line":"- Adjust POST method  to support validate and add."},{"line_number":55,"context_line":"- add DELETE method."},{"line_number":56,"context_line":"- API handler: Store/Delete Template from the Database ."},{"line_number":57,"context_line":"- Add query option evaluator repo. (evaluator can fetch new templates)."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_6d78228f","line":54,"range":{"start_line":54,"start_character":20,"end_line":54,"end_character":21},"updated":"2017-11-06 07:19:13.000000000","message":"Extra space","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":53,"context_line":"- Support Add/Remove commands in vitrageclient (Vitrage API)"},{"line_number":54,"context_line":"- Adjust POST method  to support validate and add."},{"line_number":55,"context_line":"- add DELETE method."},{"line_number":56,"context_line":"- API handler: Store/Delete Template from the Database ."},{"line_number":57,"context_line":"- Add query option evaluator repo. (evaluator can fetch new templates)."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_4d7b268b","line":56,"range":{"start_line":56,"start_character":15,"end_line":56,"end_character":20},"updated":"2017-11-06 07:19:13.000000000","message":"\"Insert\" could be better when talking about database.","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":54,"context_line":"- Adjust POST method  to support validate and add."},{"line_number":55,"context_line":"- add DELETE method."},{"line_number":56,"context_line":"- API handler: Store/Delete Template from the Database ."},{"line_number":57,"context_line":"- Add query option evaluator repo. (evaluator can fetch new templates)."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Template DB Table:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_adb61a3d","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":71},"updated":"2017-11-06 07:19:13.000000000","message":"Are you talking about **scenario** repo? I think the data flow is like:\n\ntemplates \u003d\u003e scenario repository \u003d\u003e evaluator\n\nSo you are talking about evaluator fetches new templates and update the scenario repository, am I right?","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":21414,"name":"Yujun Zhang","email":"zhang.yujunz@zte.com.cn","username":"yujunz"},"change_message_id":"595a75a171893393fadd9312c8ef792815a83d83","unresolved":false,"context_lines":[{"line_number":66,"context_line":"|               |              |      |     |         |       |"},{"line_number":67,"context_line":"| template_name | varchar(128) | NO   | PRI | NULL    |       |"},{"line_number":68,"context_line":"|               |              |      |     |         |       |"},{"line_number":69,"context_line":"| template_file | json         | YES  |     | NULL    |       |"},{"line_number":70,"context_line":"+---------------+--------------+------+-----+---------+-------+"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f4b6375_0d7f6e66","line":69,"range":{"start_line":69,"start_character":2,"end_line":69,"end_character":15},"updated":"2017-11-06 07:19:13.000000000","message":"File sounds ambiguous to regular file stored in file system. What about \"content\" ?\n\nSince it is a table for templates, I think the prefix \"template_\" may not be necessary.","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Data model impact"},{"line_number":80,"context_line":"-----------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"REST API impact"},{"line_number":85,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_87c2ab84","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":4},"updated":"2017-11-13 13:53:30.000000000","message":"There is an impact, new DB table :-)","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Horizon impact"},{"line_number":116,"context_line":"--------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"None"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Topology view"},{"line_number":121,"context_line":"^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_073c7b91","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":4},"updated":"2017-11-13 13:53:30.000000000","message":"This functionality should eventually be added to Horizon, but this can be defined in a future blueprint","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"None"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Topology view"},{"line_number":121,"context_line":"^^^^^^^^^^^^^"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"No impact"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"RCA view"},{"line_number":126,"context_line":"^^^^^^^^"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"No impact"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Entity graph"},{"line_number":132,"context_line":"^^^^^^^^^^^^"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"No impact"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Summary"},{"line_number":137,"context_line":"^^^^^^^"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"No impacts"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Implementation"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_87474b1e","line":139,"range":{"start_line":120,"start_character":0,"end_line":139,"end_character":10},"updated":"2017-11-13 13:53:30.000000000","message":"I think these can be deleted","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"2c9a50744ff9aa028f0cc1343625cc33cddf1f35","unresolved":false,"context_lines":[{"line_number":155,"context_line":" - API support for add/remove template"},{"line_number":156,"context_line":" - implement database table via SQLAlchemy."},{"line_number":157,"context_line":" - implement queries to database."},{"line_number":158,"context_line":" - Tests as explained in \"Testing\"."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f485f77_e7595ffe","line":158,"range":{"start_line":158,"start_character":1,"end_line":158,"end_character":35},"updated":"2017-11-13 13:53:30.000000000","message":"Also: evaluate the added/deleted templates on the entire graph","commit_id":"49bf93891213b22a1cc699ba2edb80829fcc861e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"eb515c6a4c48e83651feec6a550fa76a41f9f6e8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Currently, Vitrage templates are loaded from a specific folder during Vitrage startup."},{"line_number":23,"context_line":"Adding/removing templates during Vitrage services are running requires restart of the vitrage-graph service."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f96bb07_dd1aa77b","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":32},"updated":"2018-01-24 11:55:58.000000000","message":"while","commit_id":"eb2c9cfdca61de6423d8f70c686df03e0e94ae3e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"eb515c6a4c48e83651feec6a550fa76a41f9f6e8","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"Templates should be stored in DB instead of specific folder in file system,"},{"line_number":29,"context_line":"In that way they can be modified (add/delete) during vitrage is up."},{"line_number":30,"context_line":"The evaluator will preform a live update to the entity graph according to actions specified in the added/removed templates."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f96bb07_1d048f17","line":28,"range":{"start_line":28,"start_character":74,"end_line":28,"end_character":75},"updated":"2018-01-24 11:55:58.000000000","message":".","commit_id":"eb2c9cfdca61de6423d8f70c686df03e0e94ae3e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"eb515c6a4c48e83651feec6a550fa76a41f9f6e8","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"Templates should be stored in DB instead of specific folder in file system,"},{"line_number":29,"context_line":"In that way they can be modified (add/delete) during vitrage is up."},{"line_number":30,"context_line":"The evaluator will preform a live update to the entity graph according to actions specified in the added/removed templates."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f96bb07_bd155b4b","line":28,"range":{"start_line":28,"start_character":30,"end_line":28,"end_character":32},"updated":"2018-01-24 11:55:58.000000000","message":"the database","commit_id":"eb2c9cfdca61de6423d8f70c686df03e0e94ae3e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"eb515c6a4c48e83651feec6a550fa76a41f9f6e8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"Templates should be stored in DB instead of specific folder in file system,"},{"line_number":29,"context_line":"In that way they can be modified (add/delete) during vitrage is up."},{"line_number":30,"context_line":"The evaluator will preform a live update to the entity graph according to actions specified in the added/removed templates."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f96bb07_7d0b5329","line":29,"range":{"start_line":29,"start_character":46,"end_line":29,"end_character":52},"updated":"2018-01-24 11:55:58.000000000","message":"while","commit_id":"eb2c9cfdca61de6423d8f70c686df03e0e94ae3e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"eb515c6a4c48e83651feec6a550fa76a41f9f6e8","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Template add:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- Validate template."},{"line_number":36,"context_line":"- store template in database."},{"line_number":37,"context_line":"- notify evaluator."},{"line_number":38,"context_line":"- entity graph evaluation with new actions."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f96bb07_e8ff9ffe","line":35,"range":{"start_line":35,"start_character":2,"end_line":35,"end_character":3},"updated":"2018-01-24 11:55:58.000000000","message":"Please use either capital letters or small letters in all the lists","commit_id":"eb2c9cfdca61de6423d8f70c686df03e0e94ae3e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"eb515c6a4c48e83651feec6a550fa76a41f9f6e8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"A few changes should be made in order to implement CRUD support"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- Support template Add/Remove commands in vitrageclient (Vitrage API)"},{"line_number":54,"context_line":"- API handler: Store/Delete Templates to and from the Database ."},{"line_number":55,"context_line":"- Graph cloning logic should be extracted to base class."},{"line_number":56,"context_line":"- Add new DB table called templates"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f96bb07_a86c37d0","line":54,"range":{"start_line":54,"start_character":62,"end_line":54,"end_character":63},"updated":"2018-01-24 11:55:58.000000000","message":"Extra space","commit_id":"eb2c9cfdca61de6423d8f70c686df03e0e94ae3e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"eb515c6a4c48e83651feec6a550fa76a41f9f6e8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Data model impact"},{"line_number":83,"context_line":"-----------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"A new DB table."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"REST API impact"},{"line_number":88,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f96bb07_286027cf","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":8},"updated":"2018-01-24 11:55:58.000000000","message":"database","commit_id":"eb2c9cfdca61de6423d8f70c686df03e0e94ae3e"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"eb515c6a4c48e83651feec6a550fa76a41f9f6e8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"REST API impact"},{"line_number":88,"context_line":"---------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"PUT and DELETE methods were added."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Versioning impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f96bb07_485d7313","line":90,"range":{"start_line":90,"start_character":23,"end_line":90,"end_character":27},"updated":"2018-01-24 11:55:58.000000000","message":"will be ;-)","commit_id":"eb2c9cfdca61de6423d8f70c686df03e0e94ae3e"}]}
